From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C3DFEB64D8 for ; Tue, 20 Jun 2023 12:20:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABE128D0005; Tue, 20 Jun 2023 08:20:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A6E5B8D0001; Tue, 20 Jun 2023 08:20:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 935BF8D0005; Tue, 20 Jun 2023 08:20:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 84DAB8D0001 for ; Tue, 20 Jun 2023 08:20:25 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4920C40CDD for ; Tue, 20 Jun 2023 12:20:25 +0000 (UTC) X-FDA: 80923034010.04.B288929 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf23.hostedemail.com (Postfix) with ESMTP id 80FB914001F for ; Tue, 20 Jun 2023 12:20:21 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LmOLGFbf; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf23.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687263622; a=rsa-sha256; cv=none; b=odCZaSgRQ7nX7I79/2Idn1zK8mMgCw1OPXK03vGuj0P6cJ6DyWSghWdjzr2icWlFUEynP8 QDkNbTlaWyj5ama0Nrc0VrQVJT8wVitP/HWOtkxsEIx5pYfRcsJO0+TGUt3GF+Z7T78BA4 pMYn/ZRdCmXFiH5Y7rbGsg2hdJhGaxw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LmOLGFbf; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf23.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687263622; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q7YvuNLEDjdiwrqjyA5uzkgX0dxf9qrdY7Fa7LDYC3w=; b=bUZz8xDFc6SfcfIKtOkfcPCEjosTn8nynIyEQQbs30ZKrQN7HqLUcoH7nTrh30fAcxgwF+ MxCFcvbz0nu2ZttdJkS8xj2Kimcwg4zyE000/11DjVEZ0+YE9AEygXEaKYVVmHVFZA/Cnw k0l05ZC4CvBXUXy3MkW0mKBQ+qt4MTI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687263621; x=1718799621; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=F+HeITyySyj3YXzLM/AtaRIIghZxjYADeQkaNZHPles=; b=LmOLGFbfZGyEfKMHqhdAJv19An9/whYIxoJySOm4yscTHQMOiv+Vx05y FUBqqp8fjOm73M1UYBRD1GXNcsqhgFw8nfewAl/arhtJv1mguB0eG6dEz 2aDX2YUgl1d1Pzr2S/w4eNutFi3IyGkLsEtW2F0cZvx7kXrQWKgvaT6O7 vZlwOGZG9kmbV7KvfbkmPOKlrWcx+iSDXYLzYjD41MBV4sDN9I0LHmcou fZ9f3YqpV++PEWI30bu67NcZTDnFwKzZZZposSiP1SGJkDbHyKTPR8gGY /rehDGmbFz5rAEbq72ae1rwtHwIpG3zS4lNrQwQ3Lq6Fya9s1EcD1I/fH Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="357332166" X-IronPort-AV: E=Sophos;i="6.00,257,1681196400"; d="scan'208";a="357332166" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2023 05:20:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="858560189" X-IronPort-AV: E=Sophos;i="6.00,257,1681196400"; d="scan'208";a="858560189" Received: from dkravtso-mobl1.ccr.corp.intel.com (HELO box.shutemov.name) ([10.252.62.180]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2023 05:20:14 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id 30F8E10F89F; Tue, 20 Jun 2023 15:20:12 +0300 (+03) Date: Tue, 20 Jun 2023 15:20:12 +0300 From: "kirill.shutemov@linux.intel.com" To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "david@redhat.com" , "Hansen, Dave" , "Luck, Tony" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "Christopherson,, Sean" , "Chatre, Reinette" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" Subject: Re: [PATCH v11 05/20] x86/virt/tdx: Add SEAMCALL infrastructure Message-ID: <20230620122012.mnlgko443qrpfrzg@box.shutemov.name> References: <759e3af5-6aec-7e50-c432-c5e0a0c3cf36@redhat.com> <8e7d6b83347688bb013d7ebb660d0a74a1949d52.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8e7d6b83347688bb013d7ebb660d0a74a1949d52.camel@intel.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 80FB914001F X-Stat-Signature: q86nxj8gfd1xjqsx15kd4cbzqbrsj6oy X-HE-Tag: 1687263621-70906 X-HE-Meta: U2FsdGVkX1/7OpFWGdzFXX77usZtshxHFbv7+QmuwehJPKEsbx7MR8OKWdGvvmtJkxoS1WeEjh7s1DoFg+tMz5Sqh13pcSSRK0jEgyDTdhEzctbKOTnLxiCMfkRSWwRSPflJzLnv/bsMpRDjs2TIRGIy3dv1bjnSLA0KVVWWiIzGZ9SfgolyfVPAPICpCBTvkhjFFQZ9XphQpMBdxf44f8KXYeC/dtUEh+gfaWT27QscXnVmbzIEyJcBNmYbsvQTdDOJXunR/35cLolofauVjCNMTw8ADQ9OVWhTAa6h2N8maNm2eQONUXszne4Er4GznVAJhoDRXI9Ff7BNa+x0Uq0pN2a/O6m7bLCJOUt/+Q+QrMSasLb4Ky06DGERngnTp7/WrwIsBtyxhjUbw/SvIlE+zkqUiP+1XkUv70DtYAazCZ1oqjTWKyDTI6uu5cCGXgrPRpnMO31wBzREGwTylEVoP9K60PFDhxMc37dPR+5fbqfnXZ32LttVKYypjWRSwpowC5PHaMtCZ/k4J9fc98YvFRZcvUxOij0uBKEPmdIwxCd2w896ve+Mg0nZ5SsMHzSrK75aab4LepbdIzOQD9oeHNG7fHIWt4CKuLrFS5hhol/xUWlS3kODy+4XCD4hxw4taiqqmMNjWqEsyO125iFgGqpvndC7RhtlC/ecrY26Wcyvv3dxubnBa3rIXKMmFFNCjNrJyHYjC/b0GfIEXqMd6bSbc3yBbqqcINAgdo6q7P6pYGBKyLSZGHSEc3HgYnv1kSWDwSAjLXqjckUXO0jw6LCedDlJNnLnzk1fsWye5Uq0rBHWT2/ynmN/jhGLMvINrr0dU0+Ghqi/slqrod/PKUEDtUwa1F1OudWLYGx2wVEnTwnSk1oMUFpdZNOh1sX7d87blw6tcbrlY2Kk9weoWeII+fNiBujrGmsWrxkz11ARnO/ch78GGzd3dPin7oXnguJz9ZE7U9oZWlz fJ5pCur0 IqF+UJX9CFGjGsIovMkWSJw+Dbf4XaRwHmhJwvAx/SbFfEkXcBV6QiDnYwzMOePaQ3WiJ9KfKoodxBh0yDfHpwpv4iJx1+v30rvhoLaPNH0lakJgRg1VoMLP4u4xSYFhlykpoG4e9Ob0OlBE3AZav/3SRtHBv2xrkgida X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 20, 2023 at 10:37:16AM +0000, Huang, Kai wrote: > > > + /* > > > + * SEAMCALL caused #GP or #UD. By reaching here %eax contains > > > + * the trap number. Convert the trap number to the TDX error > > > + * code by setting TDX_SW_ERROR to the high 32-bits of %rax. > > > + * > > > + * Note cannot OR TDX_SW_ERROR directly to %rax as OR instruction > > > + * only accepts 32-bit immediate at most. > > > > Not sure if that comment is really helpful here. It's a common pattern > > for large immediates, no? > > I am not sure. I guess I am not expert of x86 assembly but only casual writer. > > Hi Dave, Kirill, > > Are you OK to remove it? I would rather keep it. I wanted to ask why separate MOV is needed here, before I read the comment. Also size of $TDX_SW_ERROR is not visible here, so it contributes to possible confusion without the comment. -- Kiryl Shutsemau / Kirill A. Shutemov