From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A21EB64D8 for ; Tue, 20 Jun 2023 12:10:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A74548D0002; Tue, 20 Jun 2023 08:10:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A23908D0001; Tue, 20 Jun 2023 08:10:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EBB08D0002; Tue, 20 Jun 2023 08:10:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8035F8D0001 for ; Tue, 20 Jun 2023 08:10:14 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 485031A0B68 for ; Tue, 20 Jun 2023 12:10:14 +0000 (UTC) X-FDA: 80923008348.12.CC8810B Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf21.hostedemail.com (Postfix) with ESMTP id B2DD61C0009 for ; Tue, 20 Jun 2023 12:10:11 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=WjEsimMg; dkim=pass header.d=alien8.de header.s=alien8 header.b=hfOUBxtB; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf21.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687263012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ql+U7fdRXmA/T5FzVBClcEAj8T+8ofxD8UdRBhS4onc=; b=C332818voilNYXwjUgK6P/dIhicaCDEbyujimeq2HXB7oEpRWbrSRKRkKJmoLSEknW0jRQ ClbnnbHG33Ptga+QT+WrTehw/ju1W2BqJwFIO1cXUUhghoBY6S43NACyy/qLCei0w0mUXe OPtBJjYTGOh3I2UHCbx/zJP3dLzLUR0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=WjEsimMg; dkim=pass header.d=alien8.de header.s=alien8 header.b=hfOUBxtB; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf21.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687263012; a=rsa-sha256; cv=none; b=MWvbpdj2xlJGFzHB7wZh9saDGZr9+IpzVedw1oBLxk/QgA8H8/fj00YABMIjN2grJdkFpU ExPpurZJUd2p+nmthZU82wpAPYq6AmrsifsHvTpLLzKjJPjQMSZkl7AIGnXB2c/EWNcXVN dyCRnpq0wqFY6m3l0+NEolIDpx6Bj6g= Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 52D6D1EC0589; Tue, 20 Jun 2023 14:10:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1687263009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Ql+U7fdRXmA/T5FzVBClcEAj8T+8ofxD8UdRBhS4onc=; b=WjEsimMgK0SDv+cwlHliRtOENHTrsh91vMlUj76a3SY0Rc6H+E1QML4j0hkmoDQidVH8Jo iXeveYuyVhZCavOAbekzryJbODT1+1WzsAlpLWeLbvTXnmWdxcNWhwVhZgfkinI/0jEWz6 GPtY+3bfzVSiL0QsI9sT/GtaoNxGfp0= X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 18CQLNStf_-r; Tue, 20 Jun 2023 12:10:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1687263006; bh=Ql+U7fdRXmA/T5FzVBClcEAj8T+8ofxD8UdRBhS4onc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hfOUBxtBtBjPXF39oOF3ZUvN61XjQe3LmVhjKtWxJsHC/101LS7/ZwEAyCLXrtDos 6rV65BENcyyyWRLr06AnSLHuPXyYBP8k8Xku12SM1wyuoQ3Kt7xKdjkycFp66hKDeI tFuA9sZRcDfWPUaFLFmL9M3d8fJU46JD2A9HhsxeXeaEyPL1MYk7jgUgshZnl0oZAw OgRuwWp1I1HEPoirhwvgfY/c1X5by8s5P5gOw3pP8I8emQDdyYknlRJuLQgo31u10O Jk+ojyM8mG0G6b2kJ5L0JpD5WSMAWgQ0sytpzO/R9X8XJt4S4PLWWkg6QpaXqhaO6+ X+XI3G+Wq8YDfZEGURuoru8FEWkLjNEwD6KAFabpurzjQPQbNuZOAMar3QqiqdycQ4 uDOihd2sUnMyBYqaLil+kQxq+50zc+tis817YK1HglsVOg/HvJeyupBjjO2cT+gHMM dOR61duo+TRp5kxEpjcmIJQXulRbaURS/xFMoH7MoED/2Ky/h5xU7sUczEOG44CZFz 1bjOrgBSvWNgYLNzPwUoG+11pqfR/yFvht+38G03bd5wsnae6D/9ccuMfHQ64U5wZ4 tsmJXHXJbtLyApTEr6gMiQS/0RNFXcGdJzXW8hqDoM72Z/gUH4o1a2wvYS9PjVWPxB DtXgq+0bY4yEUrlbXMaWY9ug= Received: from zn.tnic (p200300eA971dC592329C23ffFEa6A903.dip0.t-ipconnect.de [IPv6:2003:ea:971d:c592:329c:23ff:fea6:a903]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 1E74440E01DE; Tue, 20 Jun 2023 12:09:26 +0000 (UTC) Date: Tue, 20 Jun 2023 14:09:20 +0200 From: Borislav Petkov To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, "Kirill A . Shutemov" Subject: Re: [PATCH RFC v9 05/51] x86/coco: move CONFIG_HAS_CC_PLATFORM check down into coco/Makefile Message-ID: <20230620120920.GAZJGW8B6XHrsoLGCJ@fat_crate.local> References: <20230612042559.375660-1-michael.roth@amd.com> <20230612042559.375660-6-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230612042559.375660-6-michael.roth@amd.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B2DD61C0009 X-Stat-Signature: oku3hamckfb6e9myt1zwf4bhp8w6wihb X-HE-Tag: 1687263011-736777 X-HE-Meta: U2FsdGVkX1/GEaToCxENCHbGGCktNSzUsoC3QFN1dahkvEZqV3x2K2iG4DQBKVx1VgiSCm949/buILVR+QIxMKcJ3cbafbCybTy+Iwfp3lk6/WyiYyv6U/qr43/NVhTAUQEafrhofhr2OK5JXUEfBuH2KQkEzE2TyORShWt598ibIMsYpBio07sQ2grgxG1OCq/CL0QpTLCacS1HemK2tBsp7FTcUqHY6g6kl3A2P/9I7z9FF/RV7V+L7IoSDH320k/vq4g4Kwi82HrkrjKwEvEM7e2T6GhgyJ2eb9d3GsbhhsjpEwxXUyzZWxkHwcv1VjuHGInq2TxJVAPO5vKdco4+h97WOwUlGcxcP6kS+i9H6ne5HXtT+TjMEAxSWml3VBEG0fKIKilFQsNtHbEJvO3WNlLdZeGDpCXz/SOc3whegIZbz7OKLJUZdKccTL74rQz5Ddl+JZgdzDJd4ix0hJL5P/qRcFMpXgsNIufSr2J2/zOJ6vO+OnV2tMJKu5K7QaBE9psbct5PXHiWxl4Ssq6vRAWA0cGY5bWg6aEekU/JZpCO8uRyDW/uK+NpV2PuPQ4Ki2ZpzALEMSBU1CpalLf1wpdJ4cmotAGXr5EK+uoHo06sOJGKgGiw7egI3rbxfoqVp1I4AcxX7ZhHD0gsLXhWuQrp5h7WWgVlJgK9vlKwfEnhRxT/KXDsSiRtpCEzC7Uxo7cXPKbHbfb2uWs61NDfczqti6Z+lw5z8bmR/2py6ZaS3hT6fxVnEVMrk7kEgHAIVHdEWVY/CbjhMsfuftTxSjqeCRFWKXNUxaUE0KAGYDRktD6aZoxz0QTBL3CHadUEP9xFlK7egH4ONlOQ2cso0E00Yqz7hrxaA5jfI+SBHWqdS4Q2MbPILWF/AU2rHFxYw9Vv9kgM6u9colk3YmTtuuLczutdSupgA283cd1xrK0rEq2Vjyj0StR4z/0NE+rEsdO2/G2rqhGrgdp vwwa7mUY OlSqdbEIdrVYh7Fbq6WRaTH/UDVxPmB/3WWnID/0Rj5jyacu1e5/EG8CJm27KeN/24ptdK+wGLkod4JVOsolwNs4lBW9fz2+oT12mSQZqQxnLIJlh3M3zA1PhYrCZ8vInWdF8sLke7xP/yRcKDohlt82DvKRcu9Z9T/xT3BaEiWEablnCkQrHRrCWyWi1dAPF0HXbTex/OK1Hyvoh3+tC7btaKYPTfk7tmrNmZALdcABPVzoqQDYmK7MPXhskLPz949lfi6oaAZWu3NSYQstet9qxlOwpBs6dGjY2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 11, 2023 at 11:25:13PM -0500, Michael Roth wrote: > Currently CONFIG_HAS_CC_PLATFORM is a prereq for building anything in ^^^^^^ Use proper english words pls. > arch/x86/coco, but that is generally only applicable for guest support. > > For SEV-SNP, helpers related purely to host support will also live in > arch/x86/coco. To allow for CoCo-related host support code in > arch/x86/coco, move that check down into the Makefile and check for it > specifically when needed. I have no clue what that means. Example? The last time we talked about paths, we ended up agreeing on: https://lore.kernel.org/all/Yg5nh1RknPRwIrb8@zn.tnic/ So your "helpers related purely to host support" should go to arch/x86/virt/svm/sev*.c And just to keep it simple, that should be arch/x86/virt/svm/sev.c and if there's real need to split that, we can do that later. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette