From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0A28EB64D8 for ; Tue, 20 Jun 2023 10:56:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5133C8D0007; Tue, 20 Jun 2023 06:56:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49BEE8D0001; Tue, 20 Jun 2023 06:56:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 315BD8D0007; Tue, 20 Jun 2023 06:56:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 20FAE8D0001 for ; Tue, 20 Jun 2023 06:56:24 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E09198085A for ; Tue, 20 Jun 2023 10:56:23 +0000 (UTC) X-FDA: 80922822246.04.A833D39 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id 5EC5714000C for ; Tue, 20 Jun 2023 10:56:21 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=F+a8aeJk; dmarc=none; spf=none (imf23.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687258581; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8BRZB7IQy1y+6aXuOJBtxvQaRvGQfzc7ssU6i3h0tfQ=; b=dYGcPcPzdT/+zu3xvc39A6wL1Xdkczzd3i4fxoFYHvi5TarGCGEX7lP02VebkfbXydOrZs odfkUVPoMwfebpAdeBNTYrnBVUy3uw7BPSQl+BXyi2Uuyy4qwjA4Q+Ug43n6b9Vs9thG25 u5kPbKd6knJ+lczFPQKHn1zMWk/KjMs= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=F+a8aeJk; dmarc=none; spf=none (imf23.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687258581; a=rsa-sha256; cv=none; b=lRMnDeNMOTiS2AyueKrwcrk+O7s97A9Bv9PRfP6WfkBstTHldI8MrMAQP/CyiPEpoAI882 noEhEgyVeCB7BVyPyvCmSqguPoX+6ZFQzwWn401IxxjofdEAp8X0WhLY5YptBqsRRab9/V jcmnkJUf6VDNo4CBGXdMMINi9D7tNQs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8BRZB7IQy1y+6aXuOJBtxvQaRvGQfzc7ssU6i3h0tfQ=; b=F+a8aeJkj2DZTF42cL8azBfLYt erGY4rRQmeUkWJhjdvWrYqMFArNmSzit4S1telmnI+DG/MLkdEkIpx0WCkgtCdWkLIVVsZJDDVL/J rT7iB3pirq/HkBtEkkDWooJcSUQZfht7mhxqJvXkE6BJc1u3IOJcMwHczLFPXarWLkkg4U9r+N+ZN OJItdcEbddviKcqFD1mlAwC8zBjAm2LuanwOwQwX+djT5lCxKvMifY1jxfj9R35QPD3xwtDsbYBrb VaVTc8acLP0GaGvScsX17ZlqUIqRII1M1Fstnv22CHT+q1sh8m/1XkR0IDDSZ1ml3nq9fRwTcGa0Y V+/hFh6Q==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qBZ1y-00Czjm-DY; Tue, 20 Jun 2023 10:56:14 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 3A3ED300274; Tue, 20 Jun 2023 12:56:13 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 13DA223BE1E49; Tue, 20 Jun 2023 12:56:13 +0200 (CEST) Date: Tue, 20 Jun 2023 12:56:12 +0200 From: Peter Zijlstra To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "Yamahata, Isaku" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "Luck, Tony" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" Subject: Re: [PATCH v11 18/20] x86: Handle TDX erratum to reset TDX private memory during kexec() and reboot Message-ID: <20230620105612.GA4253@hirez.programming.kicks-ass.net> References: <5aa7506d4fedbf625e3fe8ceeb88af3be1ce97ea.1685887183.git.kai.huang@intel.com> <20230609132301.uvvp27yr5kpenl6f@box.shutemov.name> <58f34b4b81b6d6b37d3386dec0f073e6eb7a97ff.camel@intel.com> <20230620081131.GV4253@hirez.programming.kicks-ass.net> <93b49134cdf5c7f0658ba0aeb2b1a49778b2aece.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <93b49134cdf5c7f0658ba0aeb2b1a49778b2aece.camel@intel.com> X-Rspamd-Queue-Id: 5EC5714000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 39s1u4t17bd59arptw7ae1qztwe89kci X-HE-Tag: 1687258581-835245 X-HE-Meta: U2FsdGVkX1/qp3t+WSJRq/7NpKo/29oETGeo+SvNdghSR5KNhpnBSTr5qB4JYxaQGE5I/eaC0bZ9KNMQ06Z0Drv0Tp20+KnDLbOHxr63MrCNDbF0xKhwJ2W/yurjpbMxgzsNx44K8cKQBF/VYuv72TaC9tOPqG/K2Q8F4cCbBgKn2NXK++VrdPZtW4xYAINVnVAMbsZEGzefwlmC52g3uLMxIOOm0hehcQHwl9hgMbLRYqgPJkfESHpnzeJmEXN0yc9iRRlC+bpzFxlItdUq5QrTuEhNQKUHDjHkszDRqLluDMAVdnER18cyvrs4ANeD2Hg2Q87PuY70uY2nw46JzIfwv4Xffx0PnU7h+udixZlTyFjkZUpv7ddLyEULy1HCzo1l6LCo65DQItjs1JnvHYxtmHfkQxNIsmqZMTEsoK1zQUWykFy5kussagyHxLUHt8Q1/IrkwxvHcn3P+0cMsowWeqUW+brTguUGtEzA3l2vIAWXa4DkIbHR8BAnX5Gh2H2LxdDpMOCMkK+HWdFAMpZiiRcKx1MrPKU19Z/jzvIq474dsJRSjLKGxOHwGQ5GeYu0oEFAfYfgzadPdL8qdQCgeOz20LffpUOCWwMm472MY+4BKVmID0S9jvManOtKHPikBEBJZ0Lmsi85mkA51Ro4k8Fw54P2mqrtcuDVW7WPqa/J4ISI3CzmDFqrfEHdkIGli7hr4K56A8kLDDU2kLb4SGWP8ochwVPCDbtvWdhal1vA43qJT89ka0ZNbLRYzliuChdXBQkRvwIsDQ5joa+KGI3yU2z8d+c+Dboo+wBQ9DQasM8w5s5GV7Og8Iao9xMRLRxI7a2YvDX4Yde+BxQHtOKdJZX3RK5c/orHIZZhVV/cLongCf+BGvhGr9HwxofBMtoin3qKJDgaIgTqUb1fLmhj7T6MWZd1MQU2rggfyI8PAWUnuaRxNiN3sbLX2saPYCvJd/WeupHIQCr O5kc0aKu 1UTC2oEoiZmDOuxMGGCPjyaEqjD/bQvVg2mN3bLGI0No0aDXnq3bmzoCiMPPE+5hBAj8YXurG4ljnrMOL/UfrpTqpBYAjZP0XPDmc8p+eR06+ZGL4cRwgvVKCWoCLSQD7uu/KkDHA3HwgaeTpUz690XH9gjSOHim9+v+8L0vufvC9pfQWS81RrXTzCg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 20, 2023 at 10:42:32AM +0000, Huang, Kai wrote: > On Tue, 2023-06-20 at 10:11 +0200, Peter Zijlstra wrote: > > On Mon, Jun 12, 2023 at 03:06:48AM +0000, Huang, Kai wrote: > > > > > + __mb(); > > > > __mb() is not a valid interface to use. > > Thanks for feedback! > > May I ask why, for education purpose? :) it's the raw MFENCE wrapper, not one of the *many* documented barriers. Also, typicaly you do *not* want MFENCE, MFENCE bad.