From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DED0EB64DB for ; Mon, 19 Jun 2023 06:20:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B75E8D0002; Mon, 19 Jun 2023 02:20:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 965BA8D0001; Mon, 19 Jun 2023 02:20:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 854F28D0002; Mon, 19 Jun 2023 02:20:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 764FF8D0001 for ; Mon, 19 Jun 2023 02:20:51 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 31CF6A03DE for ; Mon, 19 Jun 2023 06:20:51 +0000 (UTC) X-FDA: 80918499102.11.B843C07 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 5D15640007 for ; Mon, 19 Jun 2023 06:20:49 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=RIz+gKiu; spf=pass (imf04.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687155649; a=rsa-sha256; cv=none; b=adR+FrcdTZo0gNL+wXtMtg2jCh5A1+t1K1GtOyLpqWGqCCdjHaE4LiK48IkaQbVGgZ5EUk 0szqZbxb0+CzZ7Sv9/BKhr9+rao/bcG44p+LDoCmY2mfuxt9lt5HkdqLnHLJU0gh0ytx6z PdgGnQdO03W0dgvID6DLK3MPE7c12pg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=RIz+gKiu; spf=pass (imf04.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687155649; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M4BXOoNsAsc6KRQrpkNGw6iZ0r5Emzfhu1vt0RgT0Cg=; b=aYcz9KXxV3B0P6oB8PHDt9Aywuya3l3cSijx+3tKD75fEX01hWnyzsEMFNfwoodlbpVAOo EEVamJcxw+DZYC2eEIekc/K6l5yAj3v6G7o9onQQmsFGFBP9SaPxJA9VNUBIYuz3bVAL4l hUe6lBiPFhWM30sg/ozVXVap/oJMS5g= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5A6D260F00; Mon, 19 Jun 2023 06:20:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1099BC433C8; Mon, 19 Jun 2023 06:20:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687155647; bh=RyhHvsArpvvLmzXBr8ZG4BEMJyn2f/6MIZNEdgiReLQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RIz+gKiuBkUDhFOF+rHvjkUuRJWcTLFL6hb/qWGm3P1WcGcZo2lsKb31qMXSo8UHX XLlj2jIyynRfN/AMByM1FbRumqhWRnHLGC+GAHGkBDhYNeTS4mOm8M0oD5K7ygWzSi BcxZ68M2FSXO7oW6n/V+aqGkOQFU0W4UzNKTm89A= Date: Mon, 19 Jun 2023 08:20:43 +0200 From: Greg KH To: mawupeng Cc: akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, richard.weiyang@linux.alibaba.com, mst@redhat.com, jasowang@redhat.com, pankaj.gupta.linux@gmail.com, mhocko@kernel.org, osalvador@suse.de Subject: Re: [PATCH stable 5.10 1/1] mm/memory_hotplug: extend offline_and_remove_memory() to handle more than one memory block Message-ID: <2023061927-parsnip-gauging-86e9@gregkh> References: <20230614061900.3296725-1-mawupeng1@huawei.com> <20230614061900.3296725-2-mawupeng1@huawei.com> <2023061440-showing-happiest-937e@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5D15640007 X-Stat-Signature: x58m7998pnatxg37d553jw75toofgig4 X-Rspam-User: X-HE-Tag: 1687155649-901648 X-HE-Meta: U2FsdGVkX18we6TiZ/EpM7CQg9bYaODUZMw0smu0lfJhXWxAjODpfI4mm93qIft/DiKpSW+gCinthTQTZgx2+S4LV1vcZTczc3q1RT71DRyYtbi48SgTMN+INLtSZ/AlQZAxt8F3rjNnTexYnF8x3RlSjLKKzjfNL1UCDBaIKDVceD2EufrOPiObAn+ZDap3FXDUMQugNrEQu6GTYqlTKqKkftK3Jgpk76er37xktDQzNguxVn3mjAetv/Ja8/Hi75Ea+MhTRVy2QBLBku5G77Y/Ov4ZF2mQ149unUgZlUd47gdKMV5vZWahAJHExitsgGmQVutF3tdSHnPraVRT3okVauX7GdLZ0Ti9X4jbm9aoggukXpZaoXGOHwIEf6wmhAztKeJPvLnQSzyqLVWNlQmNEoOWtYtlO/nrHvg7NpiJd810RCNxj+hK/A2mxi4EKrU2363uqRurdHLB2UVHlN2qW3qDrJMJ7CdxPy00ez2gKL5fBV7Q5HlJ8XR57WokGZU9M2qzwcACRuGrltAhdxmg6xpOTWhcu0+2FsRA+bEq3XsqKAoHhVR026RcRnrVZqWpxJbJswdFr2a38efejybfFL6xI/eQDq10MTh1tN5X5ZfBXNinBDbckj48DSxDJ/tRLtnf4sYy4waU1ZPAa1M8VHoJWwyRLPN5pCmfoHiOJFIG6hUGERV53F/LhaQOnqWd2ZBRE90JP+YO985jSsluYxyshdcnDjsb0Gm4Rtrt/WDNLZLBPLOuvBl4mUOLC/DKUWIXT419D2OTfCI56pYbw23AhIxebcAoaXOtDnzmSXT27urHVBc93KCjhnNlXkI/VCEuuaApxgWTZVcg6otf0TwLcUi6Gvbyn4zPR0xvp3yEmLllY+ykXmxxq/LlOju//i4e5dm3fVL3F+MNwdggWl7GB1fPTGRbZ2F5nhbIKgJABtPKKYB2ssgsxKfXe+Obyls1oDtsZ2aAoil Qkjhyc7S 7s3m+Fu4gW2a9Y5321qNsfpNc0NjNWbVFge8ctgsat37XeVKN1obYsbsZ1Z8eQl+csxe68EZmjlhC3pwyC2pwZCKcU41Vk4hwqMaonALtPD4KVE5ED9u8AyonBYsBd2bsn9fCdeaMsBLhKxQca3rhp1E5K6/7VvI0F/mU2npkuy/U7mjiCKVSzuyInrfRXKHfrBx3pOaxnUhDkNNpXl/8srxJs4EzSGL4v4a/S6Bf8+AXNfmCFEb9tW/S3LcxUeICrXUIlLmCEVBO3M1fWEK+GJJ8Jq3eOTdgZ67mcsoZ27MHlgp3HO9XFRcuSs+/7mXjd7nmaNDUr4M5Expjp8JhIRx2QCIpFSeduTMi7BrkTnQ4SJbgxC/TwP1xo981smtJJA7lS5QueMjTnQFVA/D3Hbu0YIv570zM8GlMSuHuy2O+mUb0faL66zfuJCf+g6juurFEBdaHRLT+/Xj01BWn/sQarDbd3XecSj5/2XGTIAJ0iSZL8EgkNt98TzO82yM23SVcXiaEXGzSZtBuBbwVIIS+Prs8FDnORBFEXLXsuaNYCbGc3aqV+hG7erXaOq6sUlY/8t1YnejY4JBoILY9BopXgsuW1IJs9Eshaegv29CnJhclszXDsIC53T7rx+rjVXh0C6AyTbiovJ4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 14, 2023 at 02:45:58PM +0800, mawupeng wrote: > > > On 2023/6/14 14:35, Greg KH wrote: > > On Wed, Jun 14, 2023 at 02:19:00PM +0800, Wupeng Ma wrote: > >> From: David Hildenbrand > >> > >> virtio-mem soon wants to use offline_and_remove_memory() memory that > >> exceeds a single Linux memory block (memory_block_size_bytes()). Let's > >> remove that restriction. > >> > >> Let's remember the old state and try to restore that if anything goes > >> wrong. While re-onlining can, in general, fail, it's highly unlikely to > >> happen (usually only when a notifier fails to allocate memory, and these > >> are rather rare). > >> > >> This will be used by virtio-mem to offline+remove memory ranges that are > >> bigger than a single memory block - for example, with a device block > >> size of 1 GiB (e.g., gigantic pages in the hypervisor) and a Linux memory > >> block size of 128MB. > >> > >> While we could compress the state into 2 bit, using 8 bit is much > >> easier. > >> > >> This handling is similar, but different to acpi_scan_try_to_offline(): > >> > >> a) We don't try to offline twice. I am not sure if this CONFIG_MEMCG > >> optimization is still relevant - it should only apply to ZONE_NORMAL > >> (where we have no guarantees). If relevant, we can always add it. > >> > >> b) acpi_scan_try_to_offline() simply onlines all memory in case > >> something goes wrong. It doesn't restore previous online type. Let's do > >> that, so we won't overwrite what e.g., user space configured. > >> > >> Reviewed-by: Wei Yang > >> Cc: "Michael S. Tsirkin" > >> Cc: Jason Wang > >> Cc: Pankaj Gupta > >> Cc: Michal Hocko > >> Cc: Oscar Salvador > >> Cc: Wei Yang > >> Cc: Andrew Morton > >> Signed-off-by: David Hildenbrand > >> Link: https://lore.kernel.org/r/20201112133815.13332-28-david@redhat.com > >> Signed-off-by: Michael S. Tsirkin > >> Acked-by: Andrew Morton > >> --- > >> mm/memory_hotplug.c | 105 +++++++++++++++++++++++++++++++++++++------- > >> 1 file changed, 89 insertions(+), 16 deletions(-) > > > > As you forwarded this patch on, you too need to sign-off on it. > > Thanks for reminding me. > > Signed-off-by: Ma Wupeng > > > > > Also, what is the git id of the commit in Linus's tree? > > Sorry, here is the commit in Linus's tree. > > commit 8dc4bb58a146655eb057247d7c9d19e73928715b upstream. Please resend the change with both of these things fixed up, so I don't have to manually do it :) thanks, greg k-h