From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A457CEB64DB for ; Mon, 19 Jun 2023 16:40:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 091168D0002; Mon, 19 Jun 2023 12:40:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 040FE8D0001; Mon, 19 Jun 2023 12:40:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4C778D0002; Mon, 19 Jun 2023 12:40:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D6D7E8D0001 for ; Mon, 19 Jun 2023 12:40:44 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A06B2C0E18 for ; Mon, 19 Jun 2023 16:40:44 +0000 (UTC) X-FDA: 80920061208.09.2A63B2F Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf17.hostedemail.com (Postfix) with ESMTP id 9D15D40008 for ; Mon, 19 Jun 2023 16:40:41 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=DDMC6mwf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of sumitraartsy@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=sumitraartsy@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687192841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=chD1v7hFslt/id3ngHvaiW89I/a0twqHaudkcV+NNl0=; b=PXxP4Yzl03hzICYDsioH3UdX+cza0nFN2HB2h2VHu2QPvbYbsNyUTWMy0c8HBkLZA/c9G2 e3XKUKJY7HsqY+/p//6vD/Tpdj9rfGKjxjwfZDNT14AxNloARjZU6GcG6eI+fNEscoOMoG D24yPNsfNv1XWJsK4fc7YYQ3/fpmojg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=DDMC6mwf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of sumitraartsy@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=sumitraartsy@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687192841; a=rsa-sha256; cv=none; b=JsIzOufGfXWjl/pNKXOGF9Y7qc11BZ4mmBmo32OwTaG5Pe1iFLQPu4cTh7A7V6LSD0p8da 23c2lTIXnu+/DnuhfLdgg207R2IL/p/e5+uK2CjmgUKlTmnYuhb8VJMbh9/XHttKAsKcb1 pmrRgKEF1Jrfn54KeUHiHoZuVvRfE68= Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1b55fc3a71cso7195755ad.2 for ; Mon, 19 Jun 2023 09:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687192840; x=1689784840; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=chD1v7hFslt/id3ngHvaiW89I/a0twqHaudkcV+NNl0=; b=DDMC6mwfK+wLLbzDINuw3Qm8uRFn1bXYbhxD1tEo7YEuRpzE/LrP8G2djpsmwfBtjr Hb+13bWZOVR3JNbJD41xN02pdHcroY19ZukwcRdOv82GmRXUipwcsWtdOqkorS2KRrwC u3ZvZcIk1gmEc0vD4fY8rRkzBaOVUPY/B4KAVs6i3p0dNbfJ3TOhQPBE5bcsikT5niqI NfjBgJZ3q7g3l77Xpe5qd5iNgH1mvrz3pij3sd0qDDDNvZH+UlMrlIfoRso7VuuovTRs rbO11QOyuMy8mIHd66Ncj2ZWdFVS+lRjI/Hf2aRRs+Dwt9rqK1irD433101XQj9Q3BjQ w+qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687192840; x=1689784840; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=chD1v7hFslt/id3ngHvaiW89I/a0twqHaudkcV+NNl0=; b=kT/SSTgDqL9b9GgFaMg5fyvqAyuVzrZvznc6EXVI1odl/GWx/xRVz8HcsTBPqyFVG+ tu1OPhEXr//Ui4WCGfGsU1J0ATqpsg9VPTYLcjgWKzpWoR/v+8EhxX2ujHu4vtZtpIFH kyy4hkT2C6uzUEVtGBq2277xkdOaflLWoy3lwScGYXb942R6UHSTJHqGSENR6JH/wNbH BDJ/ShZBivtGNqHQOaNwcTr6yp5hLo0/5GOrvmJrsf0DyqgOtD9umqR77gwAMsWOyhhh 6btialQZLL74zLDD7RN1nyyaV22/K1Y3zNCG0KVoOLfCkz1fAih7J1dYHQsT2pqifqPS 5HUg== X-Gm-Message-State: AC+VfDzjSlOj9Yc8Kx11TstIRZT6+Oovu2YXkgdTXCwTfABEaCf7jjV4 k7JS5I9QYCZGLI6RzeHCJtw= X-Google-Smtp-Source: ACHHUZ6hU84TO6j4I3f1kv8nkLZCBWPfnIc6bo7wEYsl0blvq6R/+XTXrOKB7tbVh+NDhHGokWI9jA== X-Received: by 2002:a17:902:c403:b0:1b3:fafd:11c5 with SMTP id k3-20020a170902c40300b001b3fafd11c5mr10027947plk.44.1687192840151; Mon, 19 Jun 2023 09:40:40 -0700 (PDT) Received: from sumitra.com ([59.95.144.189]) by smtp.gmail.com with ESMTPSA id l12-20020a170902f68c00b001ab061e352bsm65896plg.195.2023.06.19.09.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 09:40:39 -0700 (PDT) Date: Mon, 19 Jun 2023 09:40:35 -0700 From: Sumitra Sharma To: "Fabio M. De Francesco" Cc: =?iso-8859-1?B?Suly9G1l?= Glisse , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ira Weiny , Deepak R Varma , Sumitra Sharma Subject: Re: [PATCH v2] lib: Replace kmap() with kmap_local_page() Message-ID: <20230619164035.GC412243@sumitra.com> References: <20230610175712.GA348514@sumitra.com> <8275009.NyiUUSuA9g@suse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8275009.NyiUUSuA9g@suse> X-Rspam-User: X-Stat-Signature: fuk88xxnmdyhtnsefdqh6acep6soe71i X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9D15D40008 X-HE-Tag: 1687192841-937444 X-HE-Meta: U2FsdGVkX18Mcj1+gQ502hJVi/miMyizGuY56YD1HqMVgL8QkuGEUiLqfyw+uysgfUSOMdVRD1IwFAIgqFArpU33YP93uIUE5x7fGu0kOQwchOWy1z7lFXXiawLJ6wTUr0rfyWBlQoOWfqKHIgIvkKGTAyUlWP1jvmI4IomWJWSJazKORtY+DVqltmUjt4eGH/OQgtdtpp23K+z/V1plZkHtBcLm6OjBHLCGI/KuvRYQuU4CVhLpShbj77obAYB5XzPWZZtp5NrDByBK7A5sbsBBaBHcqrE2I7BXXKQIrf1DrYe+ZP7vASHKNsZvehKup3Lx28s0L4kRqjgmM5EgD3tJuBimpvryB0Oq4q4Gu8U9sHIEgMsqLaPuOkF4NfmONGf9sMLVqJ5QY+cp9t6xe0vACgIog/fuFb9WgiX8l1fhToqP3JjaNgIuOnjMLqQJxWOt0FXlXVXZztt6f7b9t1mZ8nlc9cJjG1xZGKKo04yBpoS0Rns2C6isQX4o9uC8TDAMj8fBZEIvsYghylvwyG9X1HfyKkDNnenRJr1XiUBptSjyy0G6ahctFQ2IuyC+jnYK5nEfrpp+Yux8J4ciK+JAsJ0lf+Wr0yuoOW9OGow41puxqCUxqhDr52ZRs/1Wn74rk1ID9sBfdm3kyV3o67qAV8mXK0GrxgACuwcGBV2kwJ7RzdvPK08qfw9a9IZdmVHY3hJNYJqJDSvddNbXtT6oG7NH9ZafTNzNw/xUDeb/CuNDqUCZH5LXC0tP3YNNYlbnJi1EC8RD3mmCjal1gfwKgPQiJkgJj1PDmMCzEDXPb0RcC7rCCwDr2QTqCOlyC50rudnV+v1cxHaeGq1TH7L2RYAk3xcnjI6t0fXeRdRT5hOMB3+9WNlJ3qCKpg/pf45NLIK02Q+JbPV4A+SZb0Ku9Y0VZwgGnzhcT5W8tFs4t68SR0QSjEQjauY9gt5EkYN08lcyxQwcTwFIcxG FSu09jUy QKO9Nqip7QIL8L1fZeglgFQp1Jyz30+xt7dqrEVj/9xwuGg1ZM2q7kddvjcYfbIiIaw1oWQf33iLmBHCFfQe3TARFzP0LxSH5Ua8FJxUbM8SUwgOdTI+UnVj0qTJlrzG8IIKlMoQsJ6eZWqBFFbmkJTli63B46fDXx9NxEcCAaeObtwtUxNsuL59XAxHxrbsXVL1xMOjV4fH06S1jm9inFht8sad6SmpM6kXs3LxtSSwR0l7c+kWteNO+D/AQ7sxbyFu5HpYae/5Ol+MCfVhJYm0nxxhodDOAyGXql2y1yqtfFwgTvc8se/9IgvP3tvStbCSBgWb+lM3tc/YYIHlCsxPlKXlup2QgjP+MHQwFj5aJzK1T5CSvddx2jM2dEg32dz+HvmirnhVj6HMp5YgTzYeFg/F7bZZ2lSl18EstTUR4X8v3gA7sRCUUh+hegI/4XzsZ1fvXGLyMfEL5fIoyKyS1SfX4CBY4FJ3Ox0+u/tkF5vXqa9VTQP+Y0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 18, 2023 at 06:50:04AM +0200, Fabio M. De Francesco wrote: > On sabato 10 giugno 2023 19:57:12 CEST Sumitra Sharma wrote: > > kmap() has been deprecated in favor of the kmap_local_page() > > due to high cost, restricted mapping space, the overhead of > > a global lock for synchronization, and making the process > > sleep in the absence of free slots. > > > > kmap_local_page() is faster than kmap() and offers thread-local > > and CPU-local mappings, take pagefaults in a local kmap region > > and preserves preemption by saving the mappings of outgoing > > tasks and restoring those of the incoming one during a context > > switch. > > > > The mappings are kept thread local in the functions > > “dmirror_do_read” and “dmirror_do_write” in test_hmm.c > > > > Therefore, replace kmap() with kmap_local_page() and use > > mempcy_from/to_page() to avoid open coding kmap_local_page() > > + memcpy() + kunmap_local(). > > > > Remove the unused variable “tmp”. > > > > > > Suggested-by: Fabio M. De Francesco > > LGTM, so... > > Reviewed-by: Fabio M. De Francesco > > Thanks, > > Fabio > > P.S.: The answer to an old question from you is that "LGTM" stands for "[It] > Looks Good To Me". > > It's just a way to introduce the "Reviewed-by" tag itself. However, "LGTM" is > not required, whereas the tag is required for a valid review and only the tag > line will be added by maintainers in the log when your patch gets applied. > > While here... Please don't put unnecessary blank lines between the tags.They > are not required and instead may worsen readability (obviously, I'm not > requiring a new version for this). > Hi Fabio, Thank you for your explanation and clarification regarding the meaning of "LGTM." I will take care of the blank lines. Thanks & regards Sumitra > > > > Signed-off-by: Sumitra Sharma > > --- > > > > Changes in v2: > > - Change commit subject and description. > > - Remove unnecessary type casting (char *). > > > > > > lib/test_hmm.c | 10 ++-------- > > 1 file changed, 2 insertions(+), 8 deletions(-) > > > > diff --git a/lib/test_hmm.c b/lib/test_hmm.c > > index 67e6f83fe0f8..717dcb830127 100644 > > --- a/lib/test_hmm.c > > +++ b/lib/test_hmm.c > > @@ -368,16 +368,13 @@ static int dmirror_do_read(struct dmirror *dmirror, > > unsigned long start, for (pfn = start >> PAGE_SHIFT; pfn < (end >> > > PAGE_SHIFT); pfn++) { void *entry; > > struct page *page; > > - void *tmp; > > > > entry = xa_load(&dmirror->pt, pfn); > > page = xa_untag_pointer(entry); > > if (!page) > > return -ENOENT; > > > > - tmp = kmap(page); > > - memcpy(ptr, tmp, PAGE_SIZE); > > - kunmap(page); > > + memcpy_from_page(ptr, page, 0, PAGE_SIZE); > > > > ptr += PAGE_SIZE; > > bounce->cpages++; > > @@ -437,16 +434,13 @@ static int dmirror_do_write(struct dmirror *dmirror, > > unsigned long start, for (pfn = start >> PAGE_SHIFT; pfn < (end >> > > PAGE_SHIFT); pfn++) { void *entry; > > struct page *page; > > - void *tmp; > > > > entry = xa_load(&dmirror->pt, pfn); > > page = xa_untag_pointer(entry); > > if (!page || xa_pointer_tag(entry) != DPT_XA_TAG_WRITE) > > return -ENOENT; > > > > - tmp = kmap(page); > > - memcpy(tmp, ptr, PAGE_SIZE); > > - kunmap(page); > > + memcpy_to_page(page, 0, ptr, PAGE_SIZE); > > > > ptr += PAGE_SIZE; > > bounce->cpages++; > > -- > > 2.25.1 > > > >