From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C9BEB64DA for ; Mon, 19 Jun 2023 14:56:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7974F8D0002; Mon, 19 Jun 2023 10:56:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7200B8D0001; Mon, 19 Jun 2023 10:56:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59A198D0002; Mon, 19 Jun 2023 10:56:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4581F8D0001 for ; Mon, 19 Jun 2023 10:56:37 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CFFBE1C901E for ; Mon, 19 Jun 2023 14:56:36 +0000 (UTC) X-FDA: 80919798792.25.ABDC06E Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf27.hostedemail.com (Postfix) with ESMTP id B1AA54001E for ; Mon, 19 Jun 2023 14:56:33 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Tkg7Gx7k; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf27.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687186593; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I48lyfS0GmZOpSPq6hUqoQ8Jww6eDc24FRgdhdcvuCo=; b=A6PKLv6Y8KF1PM9gAFp0onKyghXXrow5F8GnuaS9tHV1BwrvYhhd1Qnb/yu/gSN958veZ+ oYCd3d2uGpr2+121VM7pH7S2GAJZdioOz02oOAz+iJFsuvdY3uHLHPOaZh4n5FRc6Eb4vZ GOMidfttXwQ/ngd+aFa+CeNq/U66L60= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Tkg7Gx7k; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf27.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687186593; a=rsa-sha256; cv=none; b=FTgXYElpW/lGP3MOC02y3WzOvC5QN9bE7qH3DNz32SQRWrPMQyiYM2+ySVevObSvVLqAWa ERsI6ZiW+U5B9f1TXx+ktnrQbNJyjbjuSLVMFOMv6APxijUb6FYRPHcLmGpO1BZBJba/bZ HGrDK/USwwktfnsKTPXc1vPACg9G1go= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687186593; x=1718722593; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HukD5kUMPNH473OwrZ3/aKlQsAS1ptDXh1LdoJoOMcg=; b=Tkg7Gx7kqugG1X8O+deQIFrwyzuOUtpaP2DIlkJBWqzU74q/SlKiCVEY Kfq20BXQS9WJT7PVGm92vEF11/dOD4tfVKw7YlesH19OVzq7fAgTr1FgG 7nTP7jFyvR4FBYA9VGHlnQ9H1baJ3zS7p4O+KeJV1UPc+q/Kg/tGO0s8k XAk1fFcHnfigK0N3w/s7VtbtrmoN7FTt8ArUN8LLmBtgmjVevTFzjiRpW BJ0edsXZBiquSem1CxYKvGuQUkTAnTzBA7tWrdcJhszaxaXz4tMRdJ4yX AsMgLPMdHRheq6T80/txIkOyN4mF2rkayEjpPPOAooBwfasvgMYGoj2KD A==; X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="363073177" X-IronPort-AV: E=Sophos;i="6.00,254,1681196400"; d="scan'208";a="363073177" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2023 07:56:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="858245407" X-IronPort-AV: E=Sophos;i="6.00,254,1681196400"; d="scan'208";a="858245407" Received: from leitchrx-mobl1.ger.corp.intel.com (HELO box.shutemov.name) ([10.249.45.32]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2023 07:56:25 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id 01FD210DD6D; Mon, 19 Jun 2023 17:56:22 +0300 (+03) Date: Mon, 19 Jun 2023 17:56:22 +0300 From: "kirill.shutemov@linux.intel.com" To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "nik.borisov@suse.com" , "linux-kernel@vger.kernel.org" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "tglx@linutronix.de" , "Luck, Tony" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" Subject: Re: [PATCH v11 15/20] x86/virt/tdx: Configure global KeyID on all packages Message-ID: <20230619145622.cjyis472geajrmnk@box.shutemov.name> References: <30358db4eff961c69783bbd4d9f3e50932a9a759.1685887183.git.kai.huang@intel.com> <49bd9f7f-9a2b-8b8c-f408-49b9b5982eb7@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B1AA54001E X-Stat-Signature: pq47u65iymh4rp9grcu65j8zkuyyxjj9 X-Rspam-User: X-HE-Tag: 1687186593-777563 X-HE-Meta: U2FsdGVkX190ts1Xp39dU74lGnsRmHKekiKv91hc8uGs1dKmq6+YnP9qoo2JL0LbcRQKRJGRCR2aiCHMFmRWnfpvxqnLLt9PFy7X/sLvyvu9whd+az3MpV7DeXsyPMsPS/URyUXzcRdoNW1ypmSVzT3QHl2+nt3znm5oLIDweKAUgF7feDpQVS49+viBkNk24/NpMWiDIyiHiKsbULg+ngZ8ZkRSKTX4KjO/9fZBpUb0o5qb9RcJVHV0L4hsmYS1j3082OQXqI2ljotg42Ed31ylGhKJQAvr/yMefnpaDe3oj3AtOmwUEocZG6nU8fzu8NfK3qcif7QwKlscQaa/R3DQjaZQckiAkrJGiSLooHMW7dseAginwNF7D8ssVCbpxD4hK4qVXnFvVljgXT2++r/NBq9tDftHHCGfN3mwluaW1DDDnDnKOBPzAdfjMPO9tit4ASbwg/jhRIaGILju4fYj3osflUee9PG7nYY2R3rgp0rkn3X2jixNZsLW/lOAJDQlSSMT8V3jpHJKOFboO+nGWwFIiePMzPv7bEKHJeQ1dG4nIFTk+NH8QYbwQoEGbXQKvgen86LRp4TyBbbpMsV2GK2xdQgxLOizqpoHfYgAzAG3yYGdyWT+xayq41sdPhMz33+X40Xp7SnR4qmNdj/MSKxsEjeztkC1ZiQUZH3N/9LwahvgLOW3zxXMGiAAjEdFAPqJvC4JA6CerJeeyFp2fl80bBgHC1aQhh+z3CmopVmueVbVRZZXW93ElFmLkABKELpqbkiB2dJvbbJOOSh05F2jAysVokx4sFsC+/EL/4DAr2PuyWmzdshBwysMi98XngqqbQtDM774cVpMfr3uqcgnx/KlLpZdwXpAepQZ5Wuvzjn8N7YNOpCAguFw/SMeUwbwMCussXpqNs9YuCVwxLRWpsKyxrKju+Kp+Szn5b5T+rSbWN374dURnoQCZ+Xe8C50xgRdRFZQiF/ gV9GYaPP KgdD0DGhUOW7dH3lTEUEoavNIHiQAE7mH+d6DB/c7LsBehC0NrECRzqb7zCHqw5ArWLDbhlnJ4TOZPlNLJWahKqtNTpZH+1usfoMo5C99QiImP/TKiS4xxv+lg5RwEiT1piC7TAmDO2X/PkLI8mF4F7klOmt9VlVzIkQP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 15, 2023 at 10:24:17PM +0000, Huang, Kai wrote: > Hi Kirill/Dave, > > Since I have received couple of tags from you, may I know which way do you > prefer? I agree with Nikolay, removing these "if (ret)" helps readability. -- Kiryl Shutsemau / Kirill A. Shutemov