From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F176EB64DB for ; Mon, 19 Jun 2023 04:44:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FFD08D0002; Mon, 19 Jun 2023 00:44:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B0258D0001; Mon, 19 Jun 2023 00:44:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89EDB8D0002; Mon, 19 Jun 2023 00:44:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7AAF88D0001 for ; Mon, 19 Jun 2023 00:44:18 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 405431C7E30 for ; Mon, 19 Jun 2023 04:44:18 +0000 (UTC) X-FDA: 80918255796.28.582635C Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf14.hostedemail.com (Postfix) with ESMTP id 81445100007 for ; Mon, 19 Jun 2023 04:44:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=mnc3P2Qj; spf=pass (imf14.hostedemail.com: domain of zhiguangni01@gmail.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=zhiguangni01@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687149856; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=DRiCzck3okYf2yD4tBPHZkTboxRNgYiqksP+cRAkLVk=; b=iNMY9UQrK1X4Bzba8J1sB6t3xrzICCbXauRSkH9H37cbg19waDWkNdI4Gd1jVUeeY7w1pN 9z68k9psK7kxtbR1zne+mkOCH/504c7Evx+S3jnjLjqh3UcsQXPCXkI4mTyl8qAyz6cseu Jo8oL64+J4oG4xi0YYsVz1My0cF6s6g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687149856; a=rsa-sha256; cv=none; b=JpLJW3BdiU84VAuz+r+gTRhN27QfTD+mLq6FtxEUE+VaLl1UB+YJ7SsiWU3++nvJtXA57U qxHhi+2YRDqMFHunDB7RFh5vL7oxgMZIxdK0hFXPb0ZkNwGZ7bQe/tTxbWcZw0wuAsRtGl riX5d8djw2HZChQZm4UbIyTs2fjBRmc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=mnc3P2Qj; spf=pass (imf14.hostedemail.com: domain of zhiguangni01@gmail.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=zhiguangni01@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-51b4ef5378bso2490619a12.1 for ; Sun, 18 Jun 2023 21:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687149855; x=1689741855; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DRiCzck3okYf2yD4tBPHZkTboxRNgYiqksP+cRAkLVk=; b=mnc3P2Qj80BPwmWZJ0SVhjnbMIysbydBl46s6xqRQvO6P7LLdvLW35FqowO6QuOymq cvUNzzIUItOymNe+uuS961cxI0bUV/Y5E0fc8gpnPHl7BZ7oHEM83CO+zed//5qiNaEM HmNOizLx4YH5oO/OYTuPPhKyqgqpz7rNuYB/gOPhwDdjPsY1l3mWx060dmu6C02y0rz2 9yTbSORX0vuGoyvtsMUQYYZ6uIhCAxuy1Lu0KFULktlwbwO0m4PcYmCc/QpUf38NYnRc EtFOcyItjxj9CzqdfJG0gqvpBiDsfDOaznXs9fso72eZ/vxGbe96VP3xBriKH83rs79Z vWSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687149855; x=1689741855; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DRiCzck3okYf2yD4tBPHZkTboxRNgYiqksP+cRAkLVk=; b=FkIEg5nAdeoGmmyVcAjtk2+TTQLNawlqWOj6SrY2GaAahDOKUhY3JNtQzr/V4Ib7ap bvaPjfzJfbViHjMLKf0NzHTVrDiWKBS3ANqBN8MtkSVU+0zb6AyPr1CyQMewWmoUi33h umCu09PyqhUoTHSDNXHWQmBkF7FUYBfjqGLu+tbZYCUGqGLAlTX2yRFfmfh0SuHzDNX5 ZWVPFxmoJDvkimGiehQNCsVpssCVddbbjtq7+RH98JYzuOz0gPGzthrmet/X/khgY4AV kNMIgtwPlCnjW5OhlsaKzI2r8QVFuNx7vR7LASuT+dwJS0Wb4vm7YMpvhaKnaTg8wKNb yZSw== X-Gm-Message-State: AC+VfDw323d6GWu1oUh4S93VvnSMrTlM/yk01M1ADwLzHttYI7fBHk6r Xl6hm+oxuCGvFAs0vFKbDWA= X-Google-Smtp-Source: ACHHUZ6lV6WX6WtLXua+DDOER+macE3jWFt0K/xpjSbRgR8zXbpQqOMO/D+579fT0bGGeW9WjBl82A== X-Received: by 2002:a05:6a20:8f15:b0:121:4ae4:ee2e with SMTP id b21-20020a056a208f1500b001214ae4ee2emr4976747pzk.34.1687149854925; Sun, 18 Jun 2023 21:44:14 -0700 (PDT) Received: from aa-PC.zhaoxin.com ([180.169.121.82]) by smtp.gmail.com with ESMTPSA id w22-20020a1709027b9600b001ac95be5081sm19379400pll.307.2023.06.18.21.44.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jun 2023 21:44:14 -0700 (PDT) From: Liam Ni To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, rppt@kernel.org, Liam Ni Subject: [PATCH] mm/sparse: Check the return value of first_present_section_nr() Date: Mon, 19 Jun 2023 12:44:03 +0800 Message-Id: <20230619044403.1519685-1-zhiguangni01@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: mb83nttpkz6adj91mt6qmahhpony1wwx X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 81445100007 X-Rspam-User: X-HE-Tag: 1687149856-212317 X-HE-Meta: U2FsdGVkX1+7YHeWnz8oJuMnzxCDIsWtGLxE/iVPGetV8d57I7FW6BvzJ3doPjFlqizeLEJ2sgQHWuU/hjAHhjR+z4PNJcxi4UZ2fev4zs2ytRrSEf0lxZ5pH73BJXQfWqlDHQV97WHKt7vrw2ABIeKUfWosfz83wIckaGz1S9modIh8Nh62Rc3LZYddw8LIdltPHLhDjSFO9ZbVoN2zfncSMNEqp4yJ5S4eDOCpkxJAnuCAaIxeYrGMJeZZggfK9tuOIe6HIHCfRwO3IDZnc8cav+aqb6Tim2JJK9gEGcQY+8PA6gx1AjCFeZTkNxBxT6T9Mx43z2FkhMVu1TRrtKOG0x9nC/fQmpdBgqw1PdHlZbf9ssywwkUTiaBMfyMzsDoKvlmAe/qBZ34PrWLU20BkD34qF6e6alYD2Ui3XuQcFOcffG2szZ1rkIv3CzMc9Z727VUThoWFOshPvOTV0aJyux2CfaVo0i9hk5kAi1SOm9pXLI2Za+E6fudnq73P0WF6AIvyTAmdQosr5tlAScSTudfDICCldIxzrBPOvXdFM2WawgObfVk3zvM4LUf8/XTxMsXt0tltyETZgmphpIeG8INvDpemo0V0EzNWsMHBUOJg0YhqMohUSvcG37Uj/BQZXmQkmDuoJPUdxIkpzymB6me2H4FIeXCGNXbNTxN3ri/0Itj2QXCeAaYqkAgs6TcsTl2OSTxr0ZDBtiz8ww5ilewSmUontauLrkfDWLl1mMErM73IiYSoXGdDCr+h4KTfj6mUGH5mu+EdZx9cNQCMhXSbBBeLmp6sGXBVozvErp3oAg3H6YT0mrK8vGPnvE8bTP9ch4hLo6r4W+ZTpzJdEyqIs5Q49u8ogm0+VONiIKpWl6l0aN9ZWc3uJ1gxKNTdGeTipa1U1NS/vt/lrnZIbnRZYxmD5FpIgpPI+cDXAVK5q1gFjtOvLJuglBhx2fYRuAz3qvsQsz5CEC+ tzIJ77uh QnZUjhtikIAjIi2k+2T9r63Gt5nAA752X6ra6j9lr9dsW2YukrJ/oo3HnCQF+2dGyMjzl3Aq3ylWaN3oHTCjsE+edNM0g65YR+S5Nm7GKtNjcNdK0zk35o8y+jYE6ztIVDdVYuwCrz7Hb+DfTtihv2jlmOdT65YU833kRt68gQUJdDNFjSiajIKvBtwogHcVHSNlvoEAacOn07PYYDdeUGjY6PG07i+jCbPMVWkXYVsLZcpttdXhRGIz/aDuxbf00ti6CGlp8VWS6oIBbjPq/6eSBTqmDs/R06zNSQg5brLgxzVSxnbNOTG5AdFRNnW4NqX0fDt1XFgaI82x1NiZIvXDZK6TFpEesWTwkKRSzFOIN1jWNyz/SbnfBI+ZiyJoulnSOO0oIIG6K/zCVUkHFDV3jzF0nxlpQYZPgkkDf5WckVCCq/nSDblxVvhoUQu8RVDtCr8X4RmGvbddYWhJOdjztk7bKT5HGjZxO9+4dCTTKXDM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000262, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: first_present_section_nr() may return -1, which means there is no present section in system,or other errors, so we cause panic here. Signed-off-by: Liam Ni --- mm/sparse.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/sparse.c b/mm/sparse.c index b8d5d58fe240..175727e10deb 100644 --- a/mm/sparse.c +++ b/mm/sparse.c @@ -564,6 +564,8 @@ void __init sparse_init(void) memblocks_present(); pnum_begin = first_present_section_nr(); + if (pnum_begin == -1) + panic("There is no present section in system\n"); nid_begin = sparse_early_nid(__nr_to_section(pnum_begin)); /* Setup pageblock_order for HUGETLB_PAGE_SIZE_VARIABLE */ -- 2.25.1