From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2B3FEB64D7 for ; Mon, 19 Jun 2023 02:12:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4BA708D0002; Sun, 18 Jun 2023 22:12:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46AF88D0001; Sun, 18 Jun 2023 22:12:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 332DC8D0002; Sun, 18 Jun 2023 22:12:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 255D98D0001 for ; Sun, 18 Jun 2023 22:12:19 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E7F94160399 for ; Mon, 19 Jun 2023 02:12:18 +0000 (UTC) X-FDA: 80917872756.22.260FFC1 Received: from out-9.mta1.migadu.com (out-9.mta1.migadu.com [95.215.58.9]) by imf07.hostedemail.com (Postfix) with ESMTP id 0211B40003 for ; Mon, 19 Jun 2023 02:12:16 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TBWCnt8z; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.9 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687140737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r76UCXNSYK7hKAPox1fty7/njlbL/lomotiDbXrHJ0c=; b=RGmWtfa60xGO9OVKfniLtcBrqTaDNSBI7+0hJhxzhrutRRxbaw6BrENW5GR45npiTNJWcs SL2Da3hhHIx/1szTdBFc29eXHhJ0+jEvXeQd0R13YhjMpIaD9M3n0//s9HPdXLGnrwxp4Q goBrpcw6DJyP+pxouV5oKfM75hhTHiI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TBWCnt8z; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.9 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687140737; a=rsa-sha256; cv=none; b=PbrlUi8TjaGEAdmDdMhhpSHHhQVnX/CC0f+GNpML4TjtXXxLbmNrJ/CFwt5E4YzFixMxs1 C/JFxTfPaKFMerUkPd9plkj9ptarwfgS+esTp1SFgzI1usG1eOVBOh5ScKjTwYPFrGJ/oW ZgBk1XPezCdKyJkzy3v5HY5RMjRV+tk= Date: Sun, 18 Jun 2023 22:12:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1687140734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r76UCXNSYK7hKAPox1fty7/njlbL/lomotiDbXrHJ0c=; b=TBWCnt8zcFJ5nKRG4NITLMc0ih7Ljc1nAilqoS2S6VpJEHCfC/iKrXm4DqvCBteAIE0x7N KKt8TEEvrj/SIu68Wj5oBDWU01USU5SRaXmsywsmSDitWFep2jlqsfvvNpzkBQyjcAlBQy vbP17KRUSXvKHyjAh6Si2ussqbVjvZw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Thomas Gleixner Cc: Mike Rapoport , linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 06/12] mm/execmem: introduce execmem_data_alloc() Message-ID: <20230619021205.vfbolcklckdpbm4k@moria.home.lan> References: <20230616085038.4121892-1-rppt@kernel.org> <20230616085038.4121892-7-rppt@kernel.org> <87jzw0qu3s.ffs@tglx> <20230618231431.4aj3k5ujye22sqai@moria.home.lan> <87h6r4qo1d.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h6r4qo1d.ffs@tglx> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0211B40003 X-Stat-Signature: ew4c4s5i8w4betc5m3cgaupaax9xhifp X-Rspam-User: X-HE-Tag: 1687140736-675235 X-HE-Meta: U2FsdGVkX1+O0SkexzGp6GGgw5ZZ7ICBQ8mJAN0QUxor/onNtfZg8wEDj73jJZr7JVNnlXmPKDQ9LX/FnzXMA7qnQlGyJi3qXjtxSkSAKdjnKqs0D1H2bHYmZtVNiIF/FDwwnFtBRkI8TSmMQjjX3cWbWuivtFg+DTjcuaBqT6zkJJKjw9HSUgQwWV8IulX/CKvYXbH9VCGeXRLVm6MQafU9TthhBjrt8ht94aN8yuefDS+xSceyzW7Mn5+4onASNUEjUL7m7N/6s06htw08tQ3eC617lNR3pdIgpw2bGqN+rMKw3A2oKhkEHMz03VccsBJfHQRgS48r/qaVBod6iGeZPWyu0r/6QUgYKYNukokWTWdgWLFdrEZxPcG+z5apjUCzMDKtCouwdmSuProGuRVvh6y3SaLZpyUSKIKWUlhx6piwaUfTNAZh6Ir7g1f23SLLSc0w/TNoxA7s1uJBCwSOZkIm+ikZO2qcvzyoEJ0V69V09ntKOlvWbiBtTiBycYO0p9dFSmhm8Tx0a+Xz3Ei8TcoCSPLeYBdQ4G6qubv6Cq0BWXI4nbT9krL8XMfX/WD5TXuSNTf7tS7NJudTTutSm/Artjr9CvBfyxzEAD2xw+9k/XfgNjxLSbbpGiY90QTI0q+R4DHXviBol/w9SucGevSR/pySOmxWM3i+VmbWTqNxM6f/v0mcj9sI/8AvSbsPO6g7DPa00vjSiCjF8yvGOiKGNP18ZNZIl22htAFNHBxKGE5xWd/HkeqWYXtRnO2WKrvLmDwhxh8KgBkr/FASdfpBDgfFTjxLGwy0w972XxmDu7i4S7T7OHOvPRXkk6/eFXIaXK3Ij5RkTMrtCjQhLhETC+vUPO7/aC/he6mhG82vLVs7YoBgYw3X4FBWQADu/vXnQY5ruN6dSWEYXB87SI/YPLKqtp4qxx0NCW0YgxyQV11A4xBkINTld5ICAHWxuhMJJuBqyA+hb2N 59neI6QU hqwUU9R9pNguvFrqzd/ofTkuvww90OXT5WpE1bk7XuiT0KSsSA7YEIkYvNH8kJf9b1eIPQxJLEP008GbfrcUSkEzyyRf5tsOrZb0Rdt3PSAWaLas7y1VlqfwAyEY9ZpFSW8cqp5tGdsNZxIbgRQ2z464zD3WKhB7wHj+X X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 19, 2023 at 02:43:58AM +0200, Thomas Gleixner wrote: > Kent! Hi Thomas :) > No. I am not. Ok. > Whether that's an internal function or not does not make any difference > at all. Well, at the risk of this discussion going completely off the rails, I have to disagree with you there. External interfaces and high level semantics are more important to get right from the outset, internal implementation details can be cleaned up later, within reason. And the discussion on this patchset has been more focused on those external interfaces, which seems like the right approach to me. > > ... I made the same mistake reviewing Song's patchset... > > Songs series had rough edges, but was way more data structure driven > and palatable than this hackery. I liked that aspect of Song's patchset too, and I'm actually inclined to agree with you that this patchset might get a bit cleaner with more of that, but really, this semes like just quibbling over calling convention for an internal helper function.