From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B698EB64D7 for ; Sun, 18 Jun 2023 04:39:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6531C6B0071; Sun, 18 Jun 2023 00:39:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 603A16B0072; Sun, 18 Jun 2023 00:39:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F1DA6B0075; Sun, 18 Jun 2023 00:39:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3C0C36B0071 for ; Sun, 18 Jun 2023 00:39:07 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0DF63B01E1 for ; Sun, 18 Jun 2023 04:39:07 +0000 (UTC) X-FDA: 80914613934.03.872A61E Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf17.hostedemail.com (Postfix) with ESMTP id 1F40D40008 for ; Sun, 18 Jun 2023 04:39:03 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=kUubKdG8; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf17.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.178 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687063144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aAJOlDCu6yVx1t8MZ/ubuxcuyCm4Ril/WvnJhr6PqTc=; b=2gjel6UK0nSrZstg6P55yAzrac4ZuOq8ZhrmbpDblg0063/M5+9+lsvLGRXsMbooV7N/pT 6bxudLK63TZHMq4hWIRKgqDEmSTM47FVwzqXBtB+TAdR12APblpdavCliY6st5D4hn6ULB Zg3gJhtrQOcumK9JeXyJ1XVaIIkF3BM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=kUubKdG8; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf17.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.178 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687063144; a=rsa-sha256; cv=none; b=S2A/74ocDMbqrUmvojqnBphrFFzJ3/HM2SlXAnv6N7I5ldabmlS+ndmyqlK3K7tOJBKOj1 pFsaROLHH5YS4K+X/KW7VRNxiV5XpprDOi1Z/EQCM6PxGimogJwvbskwOdf8RwjbjTVenx rv7cqlSGl9qj2lrDXvXRK4Zjd9Ss4BQ= Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-66869feb7d1so343995b3a.3 for ; Sat, 17 Jun 2023 21:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687063143; x=1689655143; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aAJOlDCu6yVx1t8MZ/ubuxcuyCm4Ril/WvnJhr6PqTc=; b=kUubKdG83EbdbN9yvr/6QfOUKym5q05Ed1r/8j/3R/szNoGQPrh/JO3KLW6tJyuqhz +D+39zb+ZYEPMuLA4KzVBA/TWgLwnRkTUmMmpMpIzvWMJZ83yHkNA+VKjnuhO9ClnIXd 9LB7UB28EWN39Y3xD6YA0dSmpgaGyxThOELjs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687063143; x=1689655143; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aAJOlDCu6yVx1t8MZ/ubuxcuyCm4Ril/WvnJhr6PqTc=; b=k47tkOF2RblIcmzlKv3QKcBEkAAjSt9Xsy6wOQiC4yxN3ChTk0DX2KFS4RMuaDkADv f44WRyWaRyHJ1fT42nmmXMmk7yy+N7cu7TvwJZEj9u/w+n9yrPFn2n+CfLSASJ39ZpWX f2aRVdkSwYv2MZ1FsiQpbCFtjpSLq/NS3kM7y81bUHG8bsS5AzyMrhFLjL0WCyXIACHs LJpZrL2Hf83T98QoXmsp46ZT1AqCsMpHHWqfiIx5mDqS9s+aSLomJJqjdagoH40sl8zO JFf1CD76IvVHwrAKnoODf5+orY2Kv+u6oS4q9I9cgphOqaiAxXgnnj+bNZqIEoRKvBIk HNeg== X-Gm-Message-State: AC+VfDyF87UdjetZYrpmhs5sP79/qkJdZqYKH/wyuTqGjKAzqcLFel3p PuK+uqtdX5W9vIPLe1Uco5DdmQ== X-Google-Smtp-Source: ACHHUZ4+TFCi4phLyTt7JUqdskJA2bGLOMWWIuJlsRlZUP2ul+hVjrGXXC+lEX1FtSBBiz7VyAaNvg== X-Received: by 2002:a05:6a00:1789:b0:657:2f01:6078 with SMTP id s9-20020a056a00178900b006572f016078mr7030095pfg.28.1687063142869; Sat, 17 Jun 2023 21:39:02 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id e20-20020a62ee14000000b00640f51801e6sm13578671pfi.159.2023.06.17.21.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Jun 2023 21:39:02 -0700 (PDT) Date: Sun, 18 Jun 2023 13:38:57 +0900 From: Sergey Senozhatsky To: Domenico Cerasuolo Cc: vitaly.wool@konsulko.com, minchan@kernel.org, senozhatsky@chromium.org, yosryahmed@google.com, linux-mm@kvack.org, ddstreet@ieee.org, sjenning@redhat.com, nphamcs@gmail.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v3 1/7] mm: zswap: add pool shrinking mechanism Message-ID: <20230618043857.GA2417524@google.com> References: <20230612093815.133504-1-cerasuolodomenico@gmail.com> <20230612093815.133504-2-cerasuolodomenico@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612093815.133504-2-cerasuolodomenico@gmail.com> X-Rspam-User: X-Stat-Signature: 8nd11pieytjinu8anzis1a8moreqctr7 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1F40D40008 X-HE-Tag: 1687063143-219193 X-HE-Meta: U2FsdGVkX188aT/LRFncLPZQv7PSSnH9k1ggiYtqn5z78BNYexPnwtiitrjtUzAG/EKOgUe1GybQb0VRXIBQHEwbnmnnUIFmPAiGh51+Ucj/Q/QdXQjmvrLbbcrT1UzPEEJ1H81f2hwMcW3omApxPJmOR6agWLdld251NkwAA+el27/SA8Za4e2cbQwZ/DaG+HIqbMLafb9FvadzEC7QXxb6wIWZfS2VW7Eabb4yCEWU17YmGXiioER97krJDw635SNs5ZR590mwPEeRbvTraZNbwc0ezHGBpsX+PFd6r4nwcurM595FnU+laVTbORBIKJGusqWAWjPuLI8Qr0eHfROZWtwXiqSCXMwyhYrvdctc1qijw1PdEDY8KSCh9svpthCXKrHlx/sNgniQoD6+1dtOUwsqJMuz/cpWqmLL9xgbGscvL2o0e/eVnd3JzaageIA1pwCY6fz5JT7Rg4k6Tc7stSaJctpPX2Hg/ANpm3SSRMowJfUndtN1HIh5RSKbe5aiwNKLHFeC45chvgpALreKdBCzLCjRzcohOrUHwrEmkdU7Uw0rMXejrZ28nUoF1zEw9vo8zqmesF43QFVVPRqHmFjaWllqe+DM14D2wz93z6zKx5QTKQjLUpPWG6UT3CEkAYxJbWBM8zia4TC6nwnG+thM7p+uaMc4Zwgl49iPByjSwOIPrE/q5PIBZYteyOwyrrvcC3uU8KaxfNslUfsfuE4+vrtFnIXc/raQYtlKcN05pGKAWESYRejbcV/0+zByhV+m7x2/BHpfSeoXa608xj6jWzmDo1yxz/bQplRDs/lcw7307FW9Pw+nhdtagYkP1k4URVr/Y3/AiRp8HMM/fewNfcSV390jEj9XQMJa/VJkyp7QgGhtRHNgrD6niDDujnUJaku825/Qk+hUgIn3f7CBdKz81kXc5kKMMWOxXW4Hd/DaagbXaBpLP13Pqoq6sX6Yg2uKMuwAiwX EzI/M4AN 1BNAbsy0qor1a9Ivwckiz2YwZaanvcqwMDcmu1JBN1KjLngGAKAF9Ffu+/bZA7zolbsDZcn+P4nnb1ur4Mcr7q0/0uNZsdItk0JxZ/XqfVjYUq1ncbKXiRKbg0MD8TlA4FBq2dnccTor3v6wZ2wO+GG/koGz4E8tvBE6vTt2IjblbPP9QDCpfnkhmMOZlZdZ9yrwAJIsENgNktqKvG5pLLEbHeJaWDXVqLF60wA0ZCOWusSj+zGhKGMrFyxoJv4NzYr7Eh+gA4Bye0OJVVkkxDIRyqV3EFhNcsVx81PjNIMunKuDYnhM5DgBZMAdsGE2VjxAR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/06/12 11:38), Domenico Cerasuolo wrote: > +static int zswap_reclaim_entry(struct zswap_pool *pool) > +{ > + struct zswap_header *zhdr; > + struct zswap_entry *entry; > + struct zswap_tree *tree; > + pgoff_t swpoffset; > + int ret; > + > + /* Get an entry off the LRU */ > + spin_lock(&pool->lru_lock); > + if (list_empty(&pool->lru)) { > + spin_unlock(&pool->lru_lock); > + return -EINVAL; > + } > + entry = list_last_entry(&pool->lru, struct zswap_entry, lru); > + list_del_init(&entry->lru); A quick question: should we zswap_entry_get() here?