From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Domenico Cerasuolo <cerasuolodomenico@gmail.com>
Cc: vitaly.wool@konsulko.com, minchan@kernel.org,
senozhatsky@chromium.org, yosryahmed@google.com,
linux-mm@kvack.org, ddstreet@ieee.org, sjenning@redhat.com,
nphamcs@gmail.com, hannes@cmpxchg.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH v3 1/7] mm: zswap: add pool shrinking mechanism
Date: Sun, 18 Jun 2023 13:38:57 +0900 [thread overview]
Message-ID: <20230618043857.GA2417524@google.com> (raw)
In-Reply-To: <20230612093815.133504-2-cerasuolodomenico@gmail.com>
On (23/06/12 11:38), Domenico Cerasuolo wrote:
> +static int zswap_reclaim_entry(struct zswap_pool *pool)
> +{
> + struct zswap_header *zhdr;
> + struct zswap_entry *entry;
> + struct zswap_tree *tree;
> + pgoff_t swpoffset;
> + int ret;
> +
> + /* Get an entry off the LRU */
> + spin_lock(&pool->lru_lock);
> + if (list_empty(&pool->lru)) {
> + spin_unlock(&pool->lru_lock);
> + return -EINVAL;
> + }
> + entry = list_last_entry(&pool->lru, struct zswap_entry, lru);
> + list_del_init(&entry->lru);
A quick question: should we zswap_entry_get() here?
next prev parent reply other threads:[~2023-06-18 4:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 9:38 [PATCH v3 0/7] mm: zswap: move writeback LRU from zpool to zswap Domenico Cerasuolo
2023-06-12 9:38 ` [PATCH v3 1/7] mm: zswap: add pool shrinking mechanism Domenico Cerasuolo
2023-06-12 13:34 ` Johannes Weiner
2023-06-12 18:18 ` Yosry Ahmed
2023-06-18 4:38 ` Sergey Senozhatsky [this message]
2023-06-18 4:48 ` Yosry Ahmed
2023-06-18 5:25 ` Sergey Senozhatsky
2023-06-18 5:28 ` Yosry Ahmed
2023-06-18 5:30 ` Sergey Senozhatsky
2023-06-18 5:31 ` Yosry Ahmed
2023-06-12 9:38 ` [PATCH v3 2/7] mm: zswap: remove page reclaim logic from zbud Domenico Cerasuolo
2023-06-12 9:38 ` [PATCH v3 3/7] mm: zswap: remove page reclaim logic from z3fold Domenico Cerasuolo
2023-06-12 9:38 ` [PATCH v3 4/7] mm: zswap: remove page reclaim logic from zsmalloc Domenico Cerasuolo
2023-06-12 9:38 ` [PATCH v3 5/7] mm: zswap: remove shrink from zpool interface Domenico Cerasuolo
2023-06-12 9:38 ` [PATCH v3 6/7] mm: zswap: simplify writeback function Domenico Cerasuolo
2023-06-12 13:38 ` Johannes Weiner
2023-06-12 9:38 ` [PATCH v3 7/7] mm: zswap: remove zswap_header Domenico Cerasuolo
2023-06-12 18:47 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230618043857.GA2417524@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=cerasuolodomenico@gmail.com \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox