From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62233EB64D9 for ; Sat, 17 Jun 2023 15:01:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7121D6B0072; Sat, 17 Jun 2023 11:01:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C27A6B0075; Sat, 17 Jun 2023 11:01:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 563C16B0078; Sat, 17 Jun 2023 11:01:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 445276B0072 for ; Sat, 17 Jun 2023 11:01:45 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BCAEB401D0 for ; Sat, 17 Jun 2023 15:01:44 +0000 (UTC) X-FDA: 80912554128.10.73D0057 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf04.hostedemail.com (Postfix) with ESMTP id E78BD40025 for ; Sat, 17 Jun 2023 15:01:40 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=n2L4qTuX; spf=pass (imf04.hostedemail.com: domain of lkp@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687014101; a=rsa-sha256; cv=none; b=Ka/cN0tlDJC2kOY/i79YwrjevC8frwhZd6wLQEfl+028w4R1V0dc/IvD8ExF0pr4NVBbb6 XWVODCYEf3IVRo6GcFef39viiH9vfJO3/x5bYn4wMxqGqaNHPSvhyK6d/bBMH+1PX0N/lz z4/jXXl1KhvIrFogVBQIuN/rnCG1SJ0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=n2L4qTuX; spf=pass (imf04.hostedemail.com: domain of lkp@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687014101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=5IcfjZeMwmOGQp4+MK/eQTj31ueHzrQBjULGYIcCOoM=; b=uYhdwl71ghN5RwQDX+7Rv8pQroXnBya+spZBZrxgJ0tnKdzffRDV7W+Zeg7lt0xAZr8Y15 2SKA1Vg8DyUT5Tk00hnnyUE9Q/FPg0S6w0sXyWlX5lLGi+zv2NcgulhSG571GuWWrP0LVQ arLA9+Zk2h+szTx1Cz0gm6nfTYBAjd8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687014101; x=1718550101; h=date:from:to:cc:subject:message-id:mime-version; bh=nYxlNhys+EMsmxikqxXtY8HrsL/KmkhiJny/EYHTT9E=; b=n2L4qTuX02eonEiyjcbmdkRH/duZzEw8rPVLfk/JaIfS4Ohvvd7O+0cP r4Ug3B59Wm5SEK8S/BHmISBP7BGla8kZDlQ/vSj7ijWHci7oGwteSzhf6 5KCBTuLc5tvq4QlHnELtp6Phgk57eD+UVmZNNyUYL2EDl/ae6Eu8LZSuE 3sWM9TN6vAvxTlsgPjK4qsb3FEES+MDNC1kZypkx2NaAv38Ud4+4/WjhE Qif5fSvJNLZSDBYpllwingUGG3F3dvESHqn0KmVBvjH+dA4q50hSM4iaR ylAFv/EgXsTts1s4zwQ2NoLAs905BYQ/iFvQom6kFfhSVfHgF1jCtGeH/ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10744"; a="388277390" X-IronPort-AV: E=Sophos;i="6.00,250,1681196400"; d="scan'208";a="388277390" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2023 08:01:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10744"; a="713196624" X-IronPort-AV: E=Sophos;i="6.00,250,1681196400"; d="scan'208";a="713196624" Received: from lkp-server01.sh.intel.com (HELO 783282924a45) ([10.239.97.150]) by orsmga002.jf.intel.com with ESMTP; 17 Jun 2023 08:01:36 -0700 Received: from kbuild by 783282924a45 with local (Exim 4.96) (envelope-from ) id 1qAXQl-0002pU-2A; Sat, 17 Jun 2023 15:01:35 +0000 Date: Sat, 17 Jun 2023 23:00:43 +0800 From: kernel test robot To: Kashyap Desai Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Leon Romanovsky , Selvin Xavier Subject: [linux-next:master 8257/10546] drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:325:18: warning: variable 'opcode' is uninitialized when used here Message-ID: <202306172212.EDVOdASm-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E78BD40025 X-Stat-Signature: iyctd3r658zg446h7t8ht8tknbntjyrr X-Rspam-User: X-HE-Tag: 1687014100-728924 X-HE-Meta: U2FsdGVkX18mtgEQpo8ADhyEuRvKzJOjKbs1qCyHfnPqmVJBZyUXFtPri4lR1NiUwUPq8YdhHAjYwjyzt4bFiBvLN+vK03/LWd8xr6wdZZc47frqygMSJJaagH7yeXxCRY95yr10IA5MLhA4tmm9GW1RVuTTgqJdcIoG0xV8683aH1K9ZzefQMBwC/ddAvDQMxAbT231vtqqmjxQIedO8GUqbHi+APoOxdHYlD7lT/F9gZhHXka/CPZOceQHhLpK3cquWwtGvXr6qCuyMZknrJGx70f/YaiN5RUL1MRo7AHIlglV8AtiUFy0uzYQgEhOGIGvs/ZzwMkgw5WZXp/TSpxDTEp9GB+ekr3HgZXW7u+SUkb+3ZkyIWkX6h8MguLSm7dLSRUVWShkza5H8ff9hdgpElMo3KnYAASq+F5dOo/XeliXbtcG+BAwQphlV0FcuVmiJZ5JcgEtuc5rP4/YKv1ErvJYExu+yREKKErTqgmMTyDCn+QAa7dlp5bdpZVRMGqzkrg68XKVOh1C4Sl5YxCv5AwEMJ2Y51WXgkhN+9dFdlQqQvIy+NNzlnnzU8Mju2hZMkmiCHh3PD4F3DN468/qjET5xd9FBowakb+kctBlh3q+TGD66XyZiaDUmG8HSVEYOLrkvyYiYH1vvdspM57t7Jb0SYFvqR71Dj/29cD0zsy/kDq4T+7NckurJ6jw75kQ2tKX83FyNAMCW3QjWKh9EmOeauUsSB0QEIOEYymeM2RqHIdxeBSDO3Vz8MM1CmNzPjy38ZLBEvFyMnsnqQYuce//bVkYfUYpB73IUp5S773qcOW7DqDgEiQLNk9RXAeNJknEb6YWUFrUepK1Qg4BbDyPhy48DtSiP1kGnF2NF263IKTjpun71B06gzxZD5P86LOIYjdVvBnezX2QQN6+jMHVSOL8pkdtDXelJatPkZxa2tOeQ7eBQwREI0zNIG5FjDa+hPa3TIK/qbE y9m5LMUM lW4b4mp0lx+aSSf+U2nn1mAInYwBUBEM1dGQap8yaYZB+OsRQ/k4gRIY/FAlTDufvipa4yDtp5j5b6G1cAuj5mTXzLADS01YNbAc6tD8huPfCYDxDxVQjWlQYu85J7MfQj6f+qcY0d3Gi6/SY1WIv76GDbPKS7GouqK8sLZ+2NzPC1OOwim48DrX0TibTh8xQ057AWT6IDSBgfQbuS+bfyJNHaB5AbZ9opYMwjQyEzZquhRV9aE8+pVjotUCZuMqXWYu6p3bLynRwq2r/hEQU5yXg1hkWXT/UT2BukuJnd1Za88NpxPjYruc1KKWaptUmxAFQRmjg7eG3LUhGO8ZGCCa/BZb8lFQ1Uy29 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: f7efed9f38f886edb450041b82a6f15d663c98f8 commit: bcfee4ce3e0139ffa9c564e4ed3682e8b87f0a1d [8257/10546] RDMA/bnxt_re: remove redundant cmdq_bitmap config: x86_64-allmodconfig (https://download.01.org/0day-ci/archive/20230617/202306172212.EDVOdASm-lkp@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce: (https://download.01.org/0day-ci/archive/20230617/202306172212.EDVOdASm-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202306172212.EDVOdASm-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:325:18: warning: variable 'opcode' is uninitialized when used here [-Wuninitialized] crsqe->opcode = opcode; ^~~~~~ drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:291:11: note: initialize the variable 'opcode' to silence this warning u8 opcode; ^ = '\0' 1 warning generated. vim +/opcode +325 drivers/infiniband/hw/bnxt_re/qplib_rcfw.c 278 279 static int __send_message(struct bnxt_qplib_rcfw *rcfw, 280 struct bnxt_qplib_cmdqmsg *msg) 281 { 282 u32 bsize, free_slots, required_slots; 283 struct bnxt_qplib_cmdq_ctx *cmdq; 284 struct bnxt_qplib_crsqe *crsqe; 285 struct bnxt_qplib_cmdqe *cmdqe; 286 struct bnxt_qplib_hwq *hwq; 287 u32 sw_prod, cmdq_prod; 288 struct pci_dev *pdev; 289 unsigned long flags; 290 u16 cookie; 291 u8 opcode; 292 u8 *preq; 293 294 cmdq = &rcfw->cmdq; 295 hwq = &cmdq->hwq; 296 pdev = rcfw->pdev; 297 298 /* Cmdq are in 16-byte units, each request can consume 1 or more 299 * cmdqe 300 */ 301 spin_lock_irqsave(&hwq->lock, flags); 302 required_slots = bnxt_qplib_get_cmd_slots(msg->req); 303 free_slots = HWQ_FREE_SLOTS(hwq); 304 cookie = cmdq->seq_num & RCFW_MAX_COOKIE_VALUE; 305 crsqe = &rcfw->crsqe_tbl[cookie]; 306 307 if (required_slots >= free_slots) { 308 dev_info_ratelimited(&pdev->dev, 309 "CMDQ is full req/free %d/%d!", 310 required_slots, free_slots); 311 spin_unlock_irqrestore(&hwq->lock, flags); 312 return -EAGAIN; 313 } 314 if (msg->block) 315 cookie |= RCFW_CMD_IS_BLOCKING; 316 __set_cmdq_base_cookie(msg->req, msg->req_sz, cpu_to_le16(cookie)); 317 318 bsize = bnxt_qplib_set_cmd_slots(msg->req); 319 crsqe->free_slots = free_slots; 320 crsqe->resp = (struct creq_qp_event *)msg->resp; 321 crsqe->resp->cookie = cpu_to_le16(cookie); 322 crsqe->is_internal_cmd = false; 323 crsqe->is_waiter_alive = true; 324 crsqe->is_in_used = true; > 325 crsqe->opcode = opcode; 326 327 crsqe->req_size = __get_cmdq_base_cmd_size(msg->req, msg->req_sz); 328 if (__get_cmdq_base_resp_size(msg->req, msg->req_sz) && msg->sb) { 329 struct bnxt_qplib_rcfw_sbuf *sbuf = msg->sb; 330 331 __set_cmdq_base_resp_addr(msg->req, msg->req_sz, 332 cpu_to_le64(sbuf->dma_addr)); 333 __set_cmdq_base_resp_size(msg->req, msg->req_sz, 334 ALIGN(sbuf->size, 335 BNXT_QPLIB_CMDQE_UNITS)); 336 } 337 338 preq = (u8 *)msg->req; 339 do { 340 /* Locate the next cmdq slot */ 341 sw_prod = HWQ_CMP(hwq->prod, hwq); 342 cmdqe = bnxt_qplib_get_qe(hwq, sw_prod, NULL); 343 /* Copy a segment of the req cmd to the cmdq */ 344 memset(cmdqe, 0, sizeof(*cmdqe)); 345 memcpy(cmdqe, preq, min_t(u32, bsize, sizeof(*cmdqe))); 346 preq += min_t(u32, bsize, sizeof(*cmdqe)); 347 bsize -= min_t(u32, bsize, sizeof(*cmdqe)); 348 hwq->prod++; 349 } while (bsize > 0); 350 cmdq->seq_num++; 351 352 cmdq_prod = hwq->prod & 0xFFFF; 353 if (test_bit(FIRMWARE_FIRST_FLAG, &cmdq->flags)) { 354 /* The very first doorbell write 355 * is required to set this flag 356 * which prompts the FW to reset 357 * its internal pointers 358 */ 359 cmdq_prod |= BIT(FIRMWARE_FIRST_FLAG); 360 clear_bit(FIRMWARE_FIRST_FLAG, &cmdq->flags); 361 } 362 /* ring CMDQ DB */ 363 wmb(); 364 writel(cmdq_prod, cmdq->cmdq_mbox.prod); 365 writel(RCFW_CMDQ_TRIG_VAL, cmdq->cmdq_mbox.db); 366 spin_unlock_irqrestore(&hwq->lock, flags); 367 /* Return the CREQ response pointer */ 368 return 0; 369 } 370 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki