From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3559C0015E for ; Sat, 17 Jun 2023 05:53:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B0E86B0072; Sat, 17 Jun 2023 01:53:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 260F26B0075; Sat, 17 Jun 2023 01:53:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1295D6B0078; Sat, 17 Jun 2023 01:53:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 00E726B0072 for ; Sat, 17 Jun 2023 01:53:46 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B5CEFB019A for ; Sat, 17 Jun 2023 05:53:46 +0000 (UTC) X-FDA: 80911173252.25.39BD854 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id EA4A8C0002 for ; Sat, 17 Jun 2023 05:53:43 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lpj2dpfi; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686981224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6UBPYWqYKa19qS7/amCR8aFKWn98VrHZbuXsmbrcg7Y=; b=R1GY3l/bPhDWjP+NkjU1J6Zn6gY/147znSjP0tDQdLz2yt1Clik+GO5pvGOv3xfjE4v6s1 /or24vpJrqBLD6MUg5iw6z4HUs7PkoL2glaf5A3NATMf3TnNMzGnSPHI9PO/oC0DnpfjBr PfiAf+OISiUqngVuVGZbz6k9vaRK2/A= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lpj2dpfi; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686981224; a=rsa-sha256; cv=none; b=Qq4xfRcNXlkPichFDg79fCk/1JilIaSJIxvpTWv7nlVHKlEZu/BBRGHGHhBzckYvZQFqmj 9RewqSRVfeyziS77hnw8isJeAvCwMYqyy7VM/iMT4B00mqC+xR1dzAmpJcQtu0L++M6sfY BZYYvS09jk7d2Uq1NEwjr2gecjvju4s= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C3DF360F9B; Sat, 17 Jun 2023 05:53:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24536C433C8; Sat, 17 Jun 2023 05:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686981222; bh=TluszqxdgR0a0IwbMuuhT/6JAXY40kPgAznuGjSXri0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lpj2dpfi9Ji3xzZ2kbgOQVYp/ZmysDx8WqNHlHmdTvMZEZsbjfL4hE6m7SXkjz4Zo Mkq0iog3xkwtSwK3WOjB9XwUu05VRpcB0eogiPxG2WXCBK0aumyezzFkPPpZnGtjc7 5x++BGdF8JI0RHFvISKKMXQLn7exxg6GH1B4T2YCX3C0Zr0t9A89VOCr3b7IhrP+qG ZzJIZ0zukBYcwghAr54w2jBQdBKljd+YnNYrk8GHhTFw3utqrXxsX2NC3voAWygO8q svafETOLy9nPtmeHj06Y/0ZWzWAt+idrvmT6go/EJzAEpVusozQOwG5k1TndPIMv23 z+o01h8acz8Lg== Date: Sat, 17 Jun 2023 08:52:56 +0300 From: Mike Rapoport To: "Edgecombe, Rick P" Cc: "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "mcgrof@kernel.org" , "deller@gmx.de" , "davem@davemloft.net" , "nadav.amit@gmail.com" , "linux@armlinux.org.uk" , "netdev@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "hca@linux.ibm.com" , "catalin.marinas@arm.com" , "kent.overstreet@linux.dev" , "puranjay12@gmail.com" , "linux-s390@vger.kernel.org" , "palmer@dabbelt.com" , "chenhuacai@kernel.org" , "tsbogend@alpha.franken.de" , "linux-trace-kernel@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "christophe.leroy@csgroup.eu" , "x86@kernel.org" , "mpe@ellerman.id.au" , "mark.rutland@arm.com" , "rostedt@goodmis.org" , "linuxppc-dev@lists.ozlabs.org" , "will@kernel.org" , "dinguyen@kernel.org" , "naveen.n.rao@linux.ibm.com" , "sparclinux@vger.kernel.org" , "linux-modules@vger.kernel.org" , "bpf@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "song@kernel.org" , "linux-mm@kvack.org" , "loongarch@lists.linux.dev" , "akpm@linux-foundation.org" Subject: Re: [PATCH v2 01/12] nios2: define virtual address space for modules Message-ID: <20230617055256.GM52412@kernel.org> References: <20230616085038.4121892-1-rppt@kernel.org> <20230616085038.4121892-2-rppt@kernel.org> <6f9e9c385096bd965e53c49065848953398f5b8e.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6f9e9c385096bd965e53c49065848953398f5b8e.camel@intel.com> X-Rspamd-Queue-Id: EA4A8C0002 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: xm5zsztx5azbnipwn8awjti7pnde9jgw X-HE-Tag: 1686981223-593012 X-HE-Meta: U2FsdGVkX18cEE05mwgGaM71De8CuvuXXKYULcDsIPxqPkWgdCgzeGUQ3UCHD+tDrH6Jm08EYf+Y/qmDJLnsieAuPVpr1jiNP/+eVxzG+buVCe3LTQCTDTpy95CjoNSo433W2q638ZkHpjI9rtGo6TuiMtrk6yu67IlJmCXsOOo2xzYaBQ9MVem8FYqmxkxfOULP1scCsNzyAA/+jZCLWzhLT1HBrBFzvwB4qjpW0h+uGNodXZsmwGo99ciySrw7Cp/wTx5dEqgj6w+JxIWwqYVOym4FDAnXfdhnj07JESFz8JtSu/gBO0XBfRl0EBXcJ8G5OKEPRZOyHx5UlYlDlmuXF85ridH0Zs2e7kb3nK4cWzIWk37fhU4fZqLq9kYa+Fo1ptr9nGsJdaWTCcax/REYGMIGCEZTtOD1PRQqBE+54xiw5gTBYz5+pQBIABV9KZrWgpuDsiGrcPDUQ1Yvd6iawPtmrsjiRam5RuGPqjw6bT0clXAiWhjdJvnMfXckD3Lw65bvODhQ8zT3xLJG+iMzJVeOX+GbL7YquAMz7vsGYd7k7NJNsAsW0SK6jD32NUF1gpyATVILRpi9NxtIp4UbngZd5fS5LZQprAc13HOwb4PM1L5X+U6KsnumwPXH6HFqZAT7JXDHlOf2omR6fZEnsr+CEXbHRv/p9VLuuO5cM7I050kUGYgyrkaCKKJQjOZGp0HJ1nd5YENUjE2X68ltBYNfM3XEV6XGLwBvbv5pl7zPSqLE3PS9S2cnsJwspLl94vg4Vzb7xPvKd4ReFEN6ZnTDPJaAWyNjOybxrnSeAGdc+r2aJokCG0iZR7qvU3hHxGLe6DDwYy7weN+MFpbvGM1CYaYTIw6WdrZ0Gi6GXcL/np/FjQj42PO30gQvOb/hBUaK7u+Et1Vrw9h1MBG03fkGjXfdvAhoLsKqTB7TrGkl3RF4YPfdX7hlJtcQnM6X8DyXWR1PjuYcegh 5weT9m9v zJRUKg4RUDDqcPhyUW9CXzvOC6EJZ3XkeueGUgfFym4WhfeohwCuN56a+3BeHRY7iOIARNODvaciWdM9lTbk6ebrwjeHBNSqIXj/Loxj5+XvAJvydgY1Tp1M3hXOAPKGJO1ya1WGdzZZGEqm6MdZQli1t/sMdsqnjS3imov0Pp6VsOIxeZo2d0glwXiiiWkHCsm/+j2Yf2jGRhMJ/NLx7GakaieUYXtWFol+0WLRc+dmSSrVEqYnnfY/P4mUtJGIXUnYxfI7+auhNzp1Jz0gewuWeMKr/D/3RnXVZQj/CcvjAUsfoXUOWZ/y0EQqpLoRXgjCNumTCJZUzqLmXguVuho9RygWALe/vQ9mVtmHvtkyTB5CwoTCQvKjkDsfoDbfwConSlPbQm2MJpw4BH30pdph03A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 16, 2023 at 04:00:19PM +0000, Edgecombe, Rick P wrote: > On Fri, 2023-06-16 at 11:50 +0300, Mike Rapoport wrote: > >  void *module_alloc(unsigned long size) > >  { > > -       if (size == 0) > > -               return NULL; > > -       return kmalloc(size, GFP_KERNEL); > > -} > > - > > -/* Free memory returned from module_alloc */ > > -void module_memfree(void *module_region) > > -{ > > -       kfree(module_region); > > +       return __vmalloc_node_range(size, 1, MODULES_VADDR, > > MODULES_END, > > +                                   GFP_KERNEL, PAGE_KERNEL_EXEC, > > +                                   VM_FLUSH_RESET_PERMS, > > NUMA_NO_NODE, > > +                                   __builtin_return_address(0)); > >  } > >   > >  int apply_relocate_add(Elf32_Shdr *sechdrs, const char *s > > I wonder if the (size == 0) check is really needed, but > __vmalloc_node_range() will WARN on this case where the old code won't. module_alloc() should not be called with zero size, so a warning there would be appropriate. Besides, no other module_alloc() had this check. -- Sincerely yours, Mike.