From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEFD2EB64DA for ; Fri, 16 Jun 2023 19:52:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4531F8E0003; Fri, 16 Jun 2023 15:52:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 403A68E0001; Fri, 16 Jun 2023 15:52:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F1AC8E0003; Fri, 16 Jun 2023 15:52:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1E0688E0001 for ; Fri, 16 Jun 2023 15:52:25 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DD20240A70 for ; Fri, 16 Jun 2023 19:52:24 +0000 (UTC) X-FDA: 80909657808.30.6B65BDB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 2AA30180009 for ; Fri, 16 Jun 2023 19:52:21 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=T5Z5qDMt; dmarc=none; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686945142; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NI1WOJM+IdC+EuV9SRRv49AsdHjuQEXzoZav+2PpiZ0=; b=P4cFWUziEXOTUSXgSGqLDCNcRnObrBIBgxwVAzBe2NlLrU3MZUA/IEw6A9ADSg+ZftNQHT 7I8chK5NQiYTQNPRD8SgUuQm7EFSfjrlcHHqNmsrXo8a1dKsc9s1wCj2+7zoH/4AQoBVAM CxX/c0FxYgvbAISUT+cW414cIZLCpV0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=T5Z5qDMt; dmarc=none; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686945142; a=rsa-sha256; cv=none; b=0WQkKqCFkxdwdHDMrxx13T0zAeYtSWpFY7vQ/XM3mUsEvdJo2Ka5NPDvMMfgZf35A/SEjM mGO+A9bDDEGWNsdBegFzUqke9ShXVK00SJ70u5r1hKYBsMzu1C1AB6j4olMJxkC3Q4kCSh ONY0XAaMIQbrQfHPz+BKQgFqJ/hsThM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3D19D615F9; Fri, 16 Jun 2023 19:52:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74C88C433C0; Fri, 16 Jun 2023 19:52:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1686945140; bh=38PQ8mXTKmNOH9eVGrBGTZ0yea343MVgHP6RoGwZi3E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T5Z5qDMt0Hu62+5cHC0iEgIYOW90YxmvaXyL+RPf6gtCSt5bHm//L0HliL/X1pd3k DKe7Gmu31KV6DeR/Ux8wGinhKaSDidZ7pWA/Evc3hXPYytZaBYI4K054oWmcuklJGg WKbzBxLGaOKRePS9i5n/Bu08VzCoXYXgZm1lrh5I= Date: Fri, 16 Jun 2023 12:52:19 -0700 From: Andrew Morton To: Wang Ming Cc: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH v1] mm:Using div64_ul replaces do_div() function Message-Id: <20230616125219.dc2346534d6f279a7527c0b0@linux-foundation.org> In-Reply-To: <20230615075127.6832-1-machel@vivo.com> References: <20230615075127.6832-1-machel@vivo.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2AA30180009 X-Stat-Signature: wket5fbqe8foscemnttrt5qhqp9pujj4 X-Rspam-User: X-HE-Tag: 1686945141-249992 X-HE-Meta: U2FsdGVkX18NxcsmsAT87UNQla79RA0cCWSL8o5uMs+JunArDv0DxiHmBnOEJx7cw0htQEqDs6pThEhKO1ZyYicyyf+Yr1fg8CvTIlUvuGjHJ/bIRPjLSw9wQMp1DQCflTaNHj3F3yb4ksiIewPVqMVOev+JMagxECC+fWkwjymxWJVsHBUsFgGz7K9sTwMmx6nBz2/yDXoR7aokPzfmHF2fWIhDnAnLpS4Fb7sx6jd8L4NtKMtRaXqQ7YYvnUkvzUSLaSTiLbyUxGjORLE96DeJsKd0HJy4aa+a7cxUmsODWFlacw4oUkF85GgzetfMPy0Uc2mu9EO6Hrd7TeWmItLqaNH20Gpx/GxUnYDjJln496yTbV0NIcZrqjWxUJ7AXf70+rMO+R3lk3ObRJZcL0e87spQAIL/vfqmWcewRiMRceQLIphS4ZEHzvUImv/SgsQd9UfM7hMhSTWy9yieo48HSCuEK/RpJzSwOd+pWWxMlL4QV0AX92+RPr/0T0F5ilUaIcDaP5Yu1d2+WvY6qk3d0WotcItlYOFbpLtNM8TX7KPbeFSRviThdrlGmvtSmo23taJpWB7e44Hzq/t/wlgNIvbPpS6iD0JZX4/x8kniSA8HhZrXFkN5811ZAT3kZR18QrCwuhPc/SE8QVsi3+0G88b4cnyFFEvOK0kf6ylUbsPV8ATpqBBduCEWgzuSeBr1spq7LWhxkiCIi99hWstDtOAbxk9hzFPymFUYnR7p9HB0VIX9A0Hw/znFjZYrt7hOThn0yETw9gqGm5IG3GS6vxKbgSvdBH4b+k1hPVCdco25Y0+9lUkXQkVFq0pmPODJ4tdaQNJh/xzHPud6R76XhcOq8M1LxFjFLY/UnsKtTboOCsdNRG+c/Mh6K+vj21bN7wmWcMxGY6PXPYhP3+XUg0GhKdNufAMg7tUJ0wMXuSYbt9mxIN8R4yqsasRtmMgh376ruvbQZOg9roa yMGjP7jS 4Vk+732ANbcXSjjOyeQ5WpOCkKJVNnwtjIKNldLszNg5f5aPN/WyqdAYubl6h4bK7o6JNsbzRehEK2lIvH8VwvRdUhnmuLO2gUkhY//TUXAkE7NkSGEl999d9OTix511KjusUEij/zFoghuY89HkhFgjy1erR3WlrhnHFNQuTbEDAWAqTnGYlkPa62+E2oCqSuhnR/Ohr0BBukZmqFC1ra4eFehe1rT6owoAMytbvDaEGjJhpVLZymPNkBTMldelTzkq6W5eTP+opfP9vsel7DoMlYZto9xWRKwBCdy+xIA+Dlyl09bIf/o3fZwQvt/sFDyxQMpjaJ2DfqJnEPDi2aD1GsnvGWZr0vz4XlgNYlrF1w3jGLuIzN14phRSntiE9dJ1vDjwm1U286VhshmgwohrhbqFdN/NMRMz/SXvWKbYcFDrqeWlZIVF3/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 15 Jun 2023 15:51:14 +0800 Wang Ming wrote: > Fix the following coccicheck warning: > > mm/mm_init.c:2492:2-8: WARNING: do_div() does a > 64-by-32 division, please consider using div64_ul instead. I guess coccicheck was fooled by the incorrect comment over do_div(). do_div() returns an unsigned long. alloc_large_system_hash() should be using a u64 for `max'. Nobody uses unsigned long long any more. > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -2508,7 +2508,7 @@ void *__init alloc_large_system_hash(const char *tablename, > /* limit allocation size to 1/16 total memory by default */ > if (max == 0) { > max = ((unsigned long long)nr_all_pages << PAGE_SHIFT) >> 4; > - do_div(max, bucketsize); > + div64_ul(max, bucketsize); > } > max = min(max, 0x80000000ULL);