From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81F1FEB64DB for ; Thu, 15 Jun 2023 07:32:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDC436B0072; Thu, 15 Jun 2023 03:32:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C8DC78E0002; Thu, 15 Jun 2023 03:32:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B54B38E0001; Thu, 15 Jun 2023 03:32:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A38E06B0072 for ; Thu, 15 Jun 2023 03:32:42 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6ECAC120AB8 for ; Thu, 15 Jun 2023 07:32:42 +0000 (UTC) X-FDA: 80904164964.10.646CE1E Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf25.hostedemail.com (Postfix) with ESMTP id A5014A000C for ; Thu, 15 Jun 2023 07:32:39 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=iU852+gD; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf25.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686814359; a=rsa-sha256; cv=none; b=Cr6IPTUlNdRJMOMJVeU1AkZV4ALYvvEMQL3LFPOAEsAaOaSoTMi1+4DKc/mRhV8k53C05d xzBKue+VuNWWAHkhsfDXrsIwJdf3sKJCwONRuI+KgGKzXsPnyFd6Of972szb+uVWgVi5Cs QLCgta/e+64BQ8q/gzQaYRrBcvwyGDs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=iU852+gD; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf25.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686814359; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=CdSuqedJEIbRKqsNMW9S5G/OsjR68rCgzUTpBoDLnEM=; b=D8GCf1zftH/Vi27QtGyGLHpvmS1EJu+Utt0noo65luJj85N/6QHeuMEaa9bI/ED+dYw75G PpFNzBDphZaCz0oY5RMUIJOMYpm7Dk3gE6E8ESaKhj7qWKN4l0EvPmj+1cztR3DTgdzjH8 Nd9k3xbWERDKFDd0+MiPrDlU1DrNCcs= Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-666785456adso966178b3a.3 for ; Thu, 15 Jun 2023 00:32:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1686814358; x=1689406358; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CdSuqedJEIbRKqsNMW9S5G/OsjR68rCgzUTpBoDLnEM=; b=iU852+gDGJfi782GaPH9x2wg+XeTiQfHnMpKe82njSX7LmSgor6PAYAv0eEFGaz83T V469KupOqNbHHXNJ4Jefz2GB3bC4LZjS2faO6A6T5HWzH2FFEcITh2Zsgk5/t3sKWY44 NkzEhL0j/+VTAue8L4PvlYkIgx+veA8rgIpczK6FpJUpuYTWFAXj5VvB6se0797A+t3J mgGiwwWbHp4YJ3r4k0RWOusTLSUkzwa+q0OoRPly9mGKor87OeO/SXxdU8wAQ+Wd053g AJyBa0S3RjgNzLNNkJdtpb63/NRDm0Z0H1NOH05Zft4GUThQFhik4A5One3CXwpQ3lUh nI7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686814358; x=1689406358; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CdSuqedJEIbRKqsNMW9S5G/OsjR68rCgzUTpBoDLnEM=; b=Tg4cA1IXRjwkQDHAj2p81cjfYz6teduelHIbaEnq+whayuXac7P+oD0jowYb5Scibx 70PTYBGM5uyUIzoJ/vusOG3mfsrYdknqD0mceLHxAtYRE/8PJo3q4+CugT3CG4iGLy61 hQDZov2lh2eOl2BaLksli0GwlK0KglNiIK5W+TNUSV9sVjNpkrhJUepwfym5Zb6lS5M5 IZb3LrIye7T20FaZG5VvHDTDdrgnuzbzRrXtLIeC1uqLNuBKj/Enu6Op3sm2mEVIRMPr eUxztGdTrxXFgK2VXoL5qF+94zLwh8PT65bvCPjcN+erizSpfAODfEqBymIR04hBZXPA 6b1Q== X-Gm-Message-State: AC+VfDzj3ZQLJr7nFlmYp7L+ZRtDdQRSA5MpjKTiVrFrnvtqnxYfG+bB 5/Bc7L7UCU5S6FGOObuUS0kvXw== X-Google-Smtp-Source: ACHHUZ4ZYicTCAv+YpqReGd9GPg56Oefou00qAt0MRGEPlWBC1x7p3+Wj+Oqo6p7TyYjCIjfGMiy2A== X-Received: by 2002:a05:6a20:42a6:b0:10f:f8e2:183c with SMTP id o38-20020a056a2042a600b0010ff8e2183cmr4686446pzj.51.1686814358308; Thu, 15 Jun 2023 00:32:38 -0700 (PDT) Received: from ubuntu-hf2.default.svc.cluster.local ([101.127.248.173]) by smtp.gmail.com with ESMTPSA id z18-20020a170903019200b001acad86ebc5sm13352570plg.33.2023.06.15.00.32.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jun 2023 00:32:37 -0700 (PDT) From: Haifeng Xu To: mhocko@suse.com Cc: roman.gushchin@linux.dev, hannes@cmpxchg.org, shakeelb@google.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Haifeng Xu Subject: [PATCH 1/2] mm/memcontrol: do not tweak node in mem_cgroup_init() Date: Thu, 15 Jun 2023 07:32:25 +0000 Message-Id: <20230615073226.1343-1-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A5014A000C X-Stat-Signature: ccmkm9ayom64ae3jx5asnxggiaiwug78 X-HE-Tag: 1686814359-593518 X-HE-Meta: U2FsdGVkX19i93wee4ad4JXXxuvAHWOs4lJ2/KDFJxVBw4sXr6hpScKtz+MCBKnKCpnE94fZj3SwJPTQ47eErbZmj+jJiBYff50GdQwSXRxT/U561NhsEjhmzEMlEH0xuhgRlnBCZu1TLXVZ7CtsYT8KENuQYZYFmQUUnc3KQi1IRlABZPKve1QldC9jp0BOEQ8bydB0PzDRAqZg0vrKr1fb10vxsIh8ypswJDbx9+FuY2/AU6lk5GmgjlR2SMDznem0PXHw6tcOybs2sxkqR0M+ixM37KnhUUjHu3yCIGnX1J3DsmiYIKOrffd94hdpHzEEwljyxB3QddMk7v16MvEvpxZBa02jb4gPu1OH8Xdw4V7tMWGYojf7iU1ToYMzAS1D3fHSQU+wE2cNdKM16zq3OBhoYfv8ClUMvOnq2dMllHEhyW39GiWhY6iIw2fHwfJch39HojNr+47j047hnVJxY5frpY/L/YtsuoKL0hO9wjN2QkAywuOomPzvCQGmRWeazn3P3jtHoKyKWxmVYFtRqJTs69pXk4OQuxNqfWF8S0Ey9LJUvVCefozYcKMe5LTimNcDP76IRjIly6klSsASR6x025YNx0P0ii5FjCUHUbnVqwsLbGUBxWIdDdPvLW8oDTd18n3NOZn97+2jeUSTvCFSpvUOLfSGvXTwizcTZ2/hLQOXpq/IpPKTRTMx1+Stv3Pf7k3IktMW0dePRm4tEM+zf4wFEe+9mC6tFysONMC23h/YsaR+3oiQ5VdPlSXMdU1dIwAxhOs+ApnOXBUjFr4zZWzNy3oA9iYQswo/nmFnqcPRWzUpCmJCpBpEQK/fLRgh2+gGXQUQDdAS9nY9luaRUqhBe0uWnBdwFdb/44gC7PP0N+gBix5qd3gbeJYKqYNqguDg36azFvD52JssuKYes3abYLGaezSS8dLZbMv0jfBosrJb3fdEw4Va6Z1PGLICpYx1P3khtWY ns2/u9id TIBCvfiuermlaZAtRF2UxRsRgsbPm2Z/lfjfK1wu6+VDCmb8ruKosEgfC+DxEhYsBtJB0CVloPTJdhg4dkRFyDFZ/h9YVe+mwACHaavD12z6dMcvYJw/P2DF2XInFFzgeBNt3X+/SsRv5Ro2kQJ4KfU4smp6tv8Zd6Vc4/XbnAaPAXt01/TQLhwIakwweLwY7ae+Wau/xZfpKD4i3Fsql+qgJDeIcJmDXCz0fZPCp8m6cafP1Gyb8RyBPoiZPuOe0cBtlWEqecl/CJw3cY4fJ/EcJEm4THSRZVPMo+2AT8NcZAXwQArjl/PzAPLR8UMLsz8rTeJ4g90tgSXMJZTKggLWN1d1F2xsEF5Nh0/q79IqtLN5lnPo8VLvu8Ktgwehazdh7vesBF/2j6Kfrb/BLiCyBaCkYLzh2FUN3MYUBGX0mG3eRQOi9qwOSBI+1rraIHZls X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: mem_cgroup_init() request for allocations from each possible node, and it's used to be a problem because NODE_DATA is not allocated for offline node. Things have already changed since commit 09f49dca570a9 ("mm: handle uninitialized numa nodes gracefully"), so it's unnecessary to check for !node_online nodes here. Signed-off-by: Haifeng Xu --- mm/memcontrol.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 4b27e245a055..c73c5fb33f65 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -7421,8 +7421,7 @@ static int __init mem_cgroup_init(void) for_each_node(node) { struct mem_cgroup_tree_per_node *rtpn; - rtpn = kzalloc_node(sizeof(*rtpn), GFP_KERNEL, - node_online(node) ? node : NUMA_NO_NODE); + rtpn = kzalloc_node(sizeof(*rtpn), GFP_KERNEL, node); rtpn->rb_root = RB_ROOT; rtpn->rb_rightmost = NULL; -- 2.25.1