From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5AC0EB64DC for ; Wed, 14 Jun 2023 06:35:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EC536B0074; Wed, 14 Jun 2023 02:35:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19D286B0075; Wed, 14 Jun 2023 02:35:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0646A8E0002; Wed, 14 Jun 2023 02:35:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E8DDF6B0074 for ; Wed, 14 Jun 2023 02:35:24 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B4C311407C5 for ; Wed, 14 Jun 2023 06:35:24 +0000 (UTC) X-FDA: 80900391768.09.1C06247 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 07A4340005 for ; Wed, 14 Jun 2023 06:35:22 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b="l/fHGPaw"; spf=pass (imf27.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686724523; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vFZ9hO28bf8XxrNxtFYCoWmMVS6uyf64Shgrq0Va1nk=; b=CfT3gp6gr3vte2FiPsxL/5odCdRGKfUUo7/1XXtMwIGwKDDA1bj76UPthGVDBL9HZG5RfT PkT6vrNUEi7iNSAPGEP8SQEAUpK4tydVMqPPPQu0hvy4lCo382RMdziiLdh02ohtwoPaTX FG+wdphzyCoiUI2u4ViuwMEIpEaf1gw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b="l/fHGPaw"; spf=pass (imf27.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686724523; a=rsa-sha256; cv=none; b=2r7ujsG6uuFFO0kte9a92T2RX+JXQDQFyUqPfrvsnnf36znHYPqo+edjdJOjm5R+w48TB2 iWX5+WSYmsxukJs737hzqtfYEveBmnuNtV0qgISVA2kDbOmSkMGl7lwLbOMzvbmDvddN9s iryzsmWTse66ahFjXTjFDTRo8DbrFSw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2825E61F4D; Wed, 14 Jun 2023 06:35:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2430C433C0; Wed, 14 Jun 2023 06:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686724521; bh=lpzSb45cABD3n36CztUicAGwa3wNS9BkIywEDeDCmPQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l/fHGPawM+RXJJ5TPoaR3aei/cEaulQ4HY//74WtRqRi/hPCzg9xMmDx1Tn5Y1123 28drRNdXkjuKLUnszYy7jSunVw5kecpuC2QuNVl2/2RgooAEaiKDMOxTN4bimigtSv 0/iGHgqgaNfU9IhN9J6T+Q3HQu9ns+YVjfECLZKI= Date: Wed, 14 Jun 2023 08:35:18 +0200 From: Greg KH To: Wupeng Ma Cc: akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Wei Yang , "Michael S. Tsirkin" , Jason Wang , Pankaj Gupta , Michal Hocko , Oscar Salvador Subject: Re: [PATCH stable 5.10 1/1] mm/memory_hotplug: extend offline_and_remove_memory() to handle more than one memory block Message-ID: <2023061440-showing-happiest-937e@gregkh> References: <20230614061900.3296725-1-mawupeng1@huawei.com> <20230614061900.3296725-2-mawupeng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230614061900.3296725-2-mawupeng1@huawei.com> X-Rspamd-Queue-Id: 07A4340005 X-Rspam-User: X-Stat-Signature: nxqotomiecras8q986n6u9dxfymnrkjp X-Rspamd-Server: rspam01 X-HE-Tag: 1686724522-219143 X-HE-Meta: U2FsdGVkX18KjR4tp7ASOXrG5DXdsBIykV54tIIEtMmDnn0w1DSOpQW8C8Y1wbbVj1OtO45lc7piSKWmDtNTJFPBU6tGwDL1hOD4aABEMYqEHyYzgUrNO+qwWPWl+AKQJTCVlkl2XeUvMNtoCk7v2A43vRzBfecQCtbDsePyEF218MgBACoMXsI4arYKQA5V9P0fALYlzRm+gR+Z/dLEm4hdcxFuMqhDbi05Kg9MsufQHJjPCD6lr729ZnObN6rcvnMfBv6fzFJluWe07cHspL1KrfLQRBD3YQ0e8b4Dra2Kl+ptUdHwDRzNIXzYyAvLgTpSfatskVhoU3skmjHBJSnttfz5myW/9txkSfYpl41vOZZOs/vzWIcJCbk4FY9bj3xZ1r/RLm+VDhIx2qnnHRJ1lcuriS41uVADX0/FHMBjyRxeOydjaYCMQWOH2KWWtLv/+k+jdBV1dqxGAJ+/7SzpMcGzAejH4IVosfBtBB4cwv2UNGI5dLFUQuc9boIwzCidyVCRuav0kTL1wEo05VeAf67zlV96qEQWnICzQRhpt30bM7NOevx+pglYHvEvdqqiO86ilekdGWYg7WbgrdHZk56LLNHqeg0Qqi0lKP5r2o652jM3KEifYUwpKZ9rFi4sfO7pZewuvqII/7j0EAE/+rJmghOxto3NxmtDAaqmYM5H6aDMV+HNY+4cV+I99hsumKJTqmZpkXgpo4ate6VUVyHDYlxQjq1b/Tp9TVHsOd9ZMJMHDVFKyb/rJSa3kyGnoD6sRwx+xClMGvDszqkDpGnKqvnUpnNtzTgozod+M2/YCozkRdA+//RqzZhnNelgCBQgsyI4TqyejI39DNHHcktal9znkyOxJwbmUim5b2Sn2ZLgHs26KghNsKiKq3wkfFP70Jq33eJeGdYkBGh3qdO4XnSj0Wncr8iU2k/jH+fGzK9NGlFTvnQySV2mG7+kpgJ586gZTJRBLlo dm3kFBVO I0lYczuMexWzxxZj7NRJdq4ujc9cM0g4mgpOdcCj+NdTj6O/Au5XwpebiTJ0i/zVqTunT1uuQ5/LUpdG9cHf2mab41LD80HEnMBEcsL6XbUAwlJe34R7J22bg5mBiBKFAIB50F/Cj2bFCJ0oq9Xhwbv9Q0pGa34Dk8+h2q+JX0bHpIQND4XWEGIunIJXqljYZW8t0I9cLPoYKBZc6UqOj33i7eJIEaL5mpNVThdVdFdev7rvdM4HfeQk2ttYhLnZ6chIhB9Go5HEfgx904dvfR6/TsIpJt9hXZgkqEkgsJzbRqrM0Egie+ltRqmRL6UkCn2nI6/qzcY81iVsXqOoqV0zygAHjscnZCWst88hMdG8Pn04V+D3wAhBmSmEIThn+9S3iPxGbLYfae25W0pdqy5Ta7WaYNiPwy7p+4idJorRdIbviH3TjjiszTFLnV+83lbrGWfqd86wAkrRKj//kLQpixePcU+wguD+UhXvzSvimwT4wjYlnXltugYS62gri8n7W8cbR5R5dQQgmjc1Am+pzN0kcI6bA2cXk71GMEoFO0SQ0BIut6WlpXCzYRubfkYeVg4kAof025sRgKScjwesL72Hku/K70jzR9cc/9sgdZAI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 14, 2023 at 02:19:00PM +0800, Wupeng Ma wrote: > From: David Hildenbrand > > virtio-mem soon wants to use offline_and_remove_memory() memory that > exceeds a single Linux memory block (memory_block_size_bytes()). Let's > remove that restriction. > > Let's remember the old state and try to restore that if anything goes > wrong. While re-onlining can, in general, fail, it's highly unlikely to > happen (usually only when a notifier fails to allocate memory, and these > are rather rare). > > This will be used by virtio-mem to offline+remove memory ranges that are > bigger than a single memory block - for example, with a device block > size of 1 GiB (e.g., gigantic pages in the hypervisor) and a Linux memory > block size of 128MB. > > While we could compress the state into 2 bit, using 8 bit is much > easier. > > This handling is similar, but different to acpi_scan_try_to_offline(): > > a) We don't try to offline twice. I am not sure if this CONFIG_MEMCG > optimization is still relevant - it should only apply to ZONE_NORMAL > (where we have no guarantees). If relevant, we can always add it. > > b) acpi_scan_try_to_offline() simply onlines all memory in case > something goes wrong. It doesn't restore previous online type. Let's do > that, so we won't overwrite what e.g., user space configured. > > Reviewed-by: Wei Yang > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Pankaj Gupta > Cc: Michal Hocko > Cc: Oscar Salvador > Cc: Wei Yang > Cc: Andrew Morton > Signed-off-by: David Hildenbrand > Link: https://lore.kernel.org/r/20201112133815.13332-28-david@redhat.com > Signed-off-by: Michael S. Tsirkin > Acked-by: Andrew Morton > --- > mm/memory_hotplug.c | 105 +++++++++++++++++++++++++++++++++++++------- > 1 file changed, 89 insertions(+), 16 deletions(-) As you forwarded this patch on, you too need to sign-off on it. Also, what is the git id of the commit in Linus's tree? thanks, greg k-h