* [linux-next:master 7890/9793] kernel/rcu/rcuscale.c:301:20: error: use of undeclared identifier 'get_rcu_tasks_gp_kthread'; did you mean 'get_rcu_tasks_trace_gp_kthread'?
@ 2023-06-14 11:39 kernel test robot
2023-06-15 16:46 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2023-06-14 11:39 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: llvm, oe-kbuild-all, Linux Memory Management List
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: b16049b21162bb649cdd8519642a35972b7910fe
commit: df8fa2f1fc4c20cd300855a11b31ba5565f45ac6 [7890/9793] rcuscale: Measure RCU Tasks Trace grace-period kthread CPU time
config: arm-randconfig-r046-20230614 (https://download.01.org/0day-ci/archive/20230614/202306141920.TTvpsXwJ-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=df8fa2f1fc4c20cd300855a11b31ba5565f45ac6
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout df8fa2f1fc4c20cd300855a11b31ba5565f45ac6
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=arm olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash kernel/
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306141920.TTvpsXwJ-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
>> kernel/rcu/rcuscale.c:301:20: error: use of undeclared identifier 'get_rcu_tasks_gp_kthread'; did you mean 'get_rcu_tasks_trace_gp_kthread'?
301 | .rso_gp_kthread = get_rcu_tasks_gp_kthread,
| ^~~~~~~~~~~~~~~~~~~~~~~~
| get_rcu_tasks_trace_gp_kthread
include/linux/rcupdate_trace.h:90:21: note: 'get_rcu_tasks_trace_gp_kthread' declared here
90 | struct task_struct *get_rcu_tasks_trace_gp_kthread(void);
| ^
1 error generated.
--
In file included from kernel/rcu/update.c:649:
>> kernel/rcu/tasks.h:1113:21: warning: no previous prototype for function 'get_rcu_tasks_gp_kthread' [-Wmissing-prototypes]
1113 | struct task_struct *get_rcu_tasks_gp_kthread(void)
| ^
kernel/rcu/tasks.h:1113:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
1113 | struct task_struct *get_rcu_tasks_gp_kthread(void)
| ^
| static
1 warning generated.
vim +301 kernel/rcu/rcuscale.c
289
290 static struct rcu_scale_ops tasks_ops = {
291 .ptype = RCU_TASKS_FLAVOR,
292 .init = rcu_sync_scale_init,
293 .readlock = tasks_scale_read_lock,
294 .readunlock = tasks_scale_read_unlock,
295 .get_gp_seq = rcu_no_completed,
296 .gp_diff = rcu_seq_diff,
297 .async = call_rcu_tasks,
298 .gp_barrier = rcu_barrier_tasks,
299 .sync = synchronize_rcu_tasks,
300 .exp_sync = synchronize_rcu_tasks,
> 301 .rso_gp_kthread = get_rcu_tasks_gp_kthread,
302 .name = "tasks"
303 };
304
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [linux-next:master 7890/9793] kernel/rcu/rcuscale.c:301:20: error: use of undeclared identifier 'get_rcu_tasks_gp_kthread'; did you mean 'get_rcu_tasks_trace_gp_kthread'?
2023-06-14 11:39 [linux-next:master 7890/9793] kernel/rcu/rcuscale.c:301:20: error: use of undeclared identifier 'get_rcu_tasks_gp_kthread'; did you mean 'get_rcu_tasks_trace_gp_kthread'? kernel test robot
@ 2023-06-15 16:46 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2023-06-15 16:46 UTC (permalink / raw)
To: kernel test robot; +Cc: llvm, oe-kbuild-all, Linux Memory Management List
On Wed, Jun 14, 2023 at 07:39:01PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: b16049b21162bb649cdd8519642a35972b7910fe
> commit: df8fa2f1fc4c20cd300855a11b31ba5565f45ac6 [7890/9793] rcuscale: Measure RCU Tasks Trace grace-period kthread CPU time
> config: arm-randconfig-r046-20230614 (https://download.01.org/0day-ci/archive/20230614/202306141920.TTvpsXwJ-lkp@intel.com/config)
> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
> reproduce (this is a W=1 build):
> mkdir -p ~/bin
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm cross compiling tool for clang build
> # apt-get install binutils-arm-linux-gnueabi
> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=df8fa2f1fc4c20cd300855a11b31ba5565f45ac6
> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> git fetch --no-tags linux-next master
> git checkout df8fa2f1fc4c20cd300855a11b31ba5565f45ac6
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=arm olddefconfig
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash kernel/
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202306141920.TTvpsXwJ-lkp@intel.com/
>
> All error/warnings (new ones prefixed by >>):
>
> >> kernel/rcu/rcuscale.c:301:20: error: use of undeclared identifier 'get_rcu_tasks_gp_kthread'; did you mean 'get_rcu_tasks_trace_gp_kthread'?
> 301 | .rso_gp_kthread = get_rcu_tasks_gp_kthread,
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> | get_rcu_tasks_trace_gp_kthread
> include/linux/rcupdate_trace.h:90:21: note: 'get_rcu_tasks_trace_gp_kthread' declared here
> 90 | struct task_struct *get_rcu_tasks_trace_gp_kthread(void);
> | ^
> 1 error generated.
> --
> In file included from kernel/rcu/update.c:649:
> >> kernel/rcu/tasks.h:1113:21: warning: no previous prototype for function 'get_rcu_tasks_gp_kthread' [-Wmissing-prototypes]
> 1113 | struct task_struct *get_rcu_tasks_gp_kthread(void)
> | ^
> kernel/rcu/tasks.h:1113:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> 1113 | struct task_struct *get_rcu_tasks_gp_kthread(void)
> | ^
> | static
> 1 warning generated.
This should be fixed by these two commits in -rcu's "dev" branch:
df8fa2f1fc4c ("rcuscale: Measure RCU Tasks Trace grace-period kthread CPU time")
(Which replaced the commit tested.)
a88fd06db226 ("rcuscale: fix building with RCU_TINY")
Please let me know if there are still problems after these commits are
in place.
Thanx, Paul
> vim +301 kernel/rcu/rcuscale.c
>
> 289
> 290 static struct rcu_scale_ops tasks_ops = {
> 291 .ptype = RCU_TASKS_FLAVOR,
> 292 .init = rcu_sync_scale_init,
> 293 .readlock = tasks_scale_read_lock,
> 294 .readunlock = tasks_scale_read_unlock,
> 295 .get_gp_seq = rcu_no_completed,
> 296 .gp_diff = rcu_seq_diff,
> 297 .async = call_rcu_tasks,
> 298 .gp_barrier = rcu_barrier_tasks,
> 299 .sync = synchronize_rcu_tasks,
> 300 .exp_sync = synchronize_rcu_tasks,
> > 301 .rso_gp_kthread = get_rcu_tasks_gp_kthread,
> 302 .name = "tasks"
> 303 };
> 304
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-15 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-14 11:39 [linux-next:master 7890/9793] kernel/rcu/rcuscale.c:301:20: error: use of undeclared identifier 'get_rcu_tasks_gp_kthread'; did you mean 'get_rcu_tasks_trace_gp_kthread'? kernel test robot
2023-06-15 16:46 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox