From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79889EB64D9 for ; Wed, 14 Jun 2023 22:58:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8E1B6B0072; Wed, 14 Jun 2023 18:58:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3F6F8E0002; Wed, 14 Jun 2023 18:58:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 906438E0001; Wed, 14 Jun 2023 18:58:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8246E6B0072 for ; Wed, 14 Jun 2023 18:58:44 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 35EF11C87B2 for ; Wed, 14 Jun 2023 22:58:44 +0000 (UTC) X-FDA: 80902869768.24.DA3DF54 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf16.hostedemail.com (Postfix) with ESMTP id 46E17180003 for ; Wed, 14 Jun 2023 22:58:42 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="ANMU/U0y"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf16.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686783522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mZoi1bNKOhXBExhJOXQO6XVV9KpmpLb4lBwItpjnHWY=; b=3KC5ujWdYTKSguaj2NSx1SKA/aZZPCDaW6pg8v3HD6SWae/7KUpC3NtuRbNo9ztmiFrB/0 XIXR+D4R8dkcxfDnv3ZHwP1ra1ZDDo0HTr908CCL7zgwSycKugdCiepsdtrxEwOVkxwGSz gXN73qyrldrxE8llPVEExUCcEH6lehg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="ANMU/U0y"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf16.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686783522; a=rsa-sha256; cv=none; b=ShbY6qgkQyu2USznLTvu1udntG0TyRCADl5btIJV8tXn6/wKg4tmZ+8VMCjiHVxAdeRxua 0O4ftvgbvVhiSAomQbMxBVtt7WxQCbLhjDPVzrYWo9XyuA/4G4ETgTZp9IwqWScerfiK4B IQaOJuTTVcanCzFEmbERl967A6JKCno= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1b512309c86so1462185ad.1 for ; Wed, 14 Jun 2023 15:58:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1686783521; x=1689375521; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=mZoi1bNKOhXBExhJOXQO6XVV9KpmpLb4lBwItpjnHWY=; b=ANMU/U0yEYhD1KjeGLSBIAtuTuo/Ml3KgnPppr37JJzBNonje37HRd/JpahvqLr5vH 9D7jtvTs7u+LxcJvBSAm1jymib1LzrDm9LMawLSpOYpj3SVvphpR9CXs4F+eVfUFE+d2 y104M8h5KpRSP+tYhybTo78cxZ3LsFezLvjbE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686783521; x=1689375521; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mZoi1bNKOhXBExhJOXQO6XVV9KpmpLb4lBwItpjnHWY=; b=DTHW7RAuVcL4bmo7I7SKmGSsCFFrLSsx58oHcp+yzv/h0JYuuktWAPARvOHTisI6g2 VJQmuW/3wmWBZHHoifflfB7jZRtmHqux+h337h8RVQmhpuimcjtKwSZF7CK7HvH2SfrT hHiDDKhhjkJDd52/AgS/pFT1rIRTO6V65L+lJ6PM+3oTDVRy22DWSFyilYSzEFKpVvFa YJQxZ3YImJbbQYoYEiU2/qaIAoLTrGghvPCqtnVXgiJ31X/9DjHcPbQgXC9f8dycF6ss zByJux4USnpHvIMC1kMJ3SP8aJOdARP2HzBH2mZHLq+qz5V15v0z2wjrmo5ri1DDl7Ng NJxQ== X-Gm-Message-State: AC+VfDyjBt0xua57EFu25tBdTh06S/NCR6V6dze78iWlqTUyZAnIp4zv NrZA6hItSK4/NBgr2dyRk4cOkA== X-Google-Smtp-Source: ACHHUZ6wohFkQ9WR3wFAYVoYMKv3LJuhQaDuFM/LHXBWC+CjOXeEnsyLOw57F8R/Z2i+9M28S8mV4Q== X-Received: by 2002:a17:902:c951:b0:1a2:a904:c42e with SMTP id i17-20020a170902c95100b001a2a904c42emr4759122pla.24.1686783520999; Wed, 14 Jun 2023 15:58:40 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id bg1-20020a1709028e8100b001b3a21fbb4fsm8910888plb.12.2023.06.14.15.58.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 15:58:40 -0700 (PDT) Date: Wed, 14 Jun 2023 15:58:39 -0700 From: Kees Cook To: Nick Desaulniers Cc: kernel test robot , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , "Gustavo A. R. Silva" Subject: Re: [linux-next:master 3357/8413] drivers/scsi/FlashPoint.c:1712:12: warning: stack frame size (1056) exceeds limit (1024) in 'FlashPoint_HandleInterrupt' Message-ID: <202306141527.95B9960@keescook> References: <202306100035.VTusNhm4-lkp@intel.com> <202306131418.35B5D649DC@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 46E17180003 X-Stat-Signature: ff7xtfywd5mseqbs6f3sakea1qpdqp7a X-Rspam-User: X-HE-Tag: 1686783522-846726 X-HE-Meta: U2FsdGVkX1+3olyaEkQ5znA04+qpM/MnacpZQLtjS9H79daaYwNH5k/CZsjunEyy6CH1iddSqfFfi7Vn+K+968pqOSQwjmMdjPbWYrXmosm/1LEc2QI3EFd0nHyZllkO1gIS6XKFTYnCD9EpWuWPRuMZ4ux5CllLZkF9342zoe2UUJnfh1rf9TuOFvIF/FKNssmkPJaYzZX4EYjZAzB9cevS2ur+WQS3F8KPvTZ9F2K1nd1h7c/OIBUNEBbi69wGyyuW8djQbGnr5DSxcT8X52zPnumVsy9ha+0aTGvWVlM3IC2b2VJJjlucQ3RmeKLLK63iyPlFskR/Xalyp2TC0wH6v4cvztAVoG4EVpLgFITgkk7jU/pU/SqdNSt/hy9chPewjnRTOa6cRBlrBoyQU1FZGjuP5s4viItsc/LGtzc2Quf1XVlxpxrJQg8KGW2J8Z3OanGSLUykF/Z21lQ3MjL/fSiGX1fqgLv9bTYNOyza9foMY6Bl3xDiI8AESub7v2IzqWSscANqmkc2teYaavQNkgKx4M2c1kl6NKoVj9yY8MZuxycNjbrnrNQiUm7x77fcNmGWUmdltE/m7BZr5FttHG1blwffegP75IyHXgW0r+dZ75E/oXLc7ngdASM2XriXi8cdFoAMkxf3zKrk0LASTe02hUWdUirKHAtg8uFCnLr7RpoWy6kWIAlLvd0Q4vY1qtul9qmc/N16L5D6Rg9ryfM4uTO3+BHAFirbIupk5KhhAp3ic5/cEX+kAWE9TTqx6X4KTlpf2fD3G0Nt3UpakEbzRFszGp5CuC6bCBN79qj+0qmVFnUNc5Y9dNBNMcvT44Pvdj6RvtCAAX4rdhmALNOh4+V1wL1j4OntdfspnOoExispUe03IvgxrS45ayIqfc3ALGmhq5WLQGRfMPlFSmKR/E4UjW6qHKYEMDEnjCgXaQfnr0RnsO8oQQBDQf2bmoGToIao6nHzfCI tTMPOp4y /VkjtQBhHm5OXH1t9d7EQPMJsuL//3f9hIOdARGVuox0x9P7uLiYAC9nGy9hhzAoaGySOdY9qplx1RflIWxghyZ43H2Yt7wVYt7VJrgRZ0oWyBMbdGonxMdj+MJzGngS/Ax1lByPKcni7KkSyY4tjLqLe9SaU1LanDXNSDMMbDwfSt5In/bqfxOFBexvLQZ611Ck0eWrLFbfh/RQ1ggC7EGn5R9D4wcVI+ce/xlaA0LYqsCKWbh/gzKyiMnA/i1V7CF7unw0bTgM6WuIPugM4IXetwsW1AYD7UAFlhHYkNDS5U+liqOzKQ+5gA/kTGIyIoMeQJ0LY8ZkAkcBxqrOCNwhUeSzhB9QvJTrjEah0a4FADf8EDfRBhOjbR64PSCegMsfaeDjVB8tSGw43Z8cYfrnZb0o1qCW4HiabJsjDbuBaSCsaR/YzhEQ6/UD+DUUevmdmlj08CnZHW940L2eNiVfBX7HaV+8oCoQ4LAgLeDawhJ77omsyI4yJxWtqgJbKPfIIiMgSNTSDHu2MHb3dmzyjNRL1MHXxxOTk9lviLedrGLFwiaKiZ5Ut2t1tQtrlBcFb6R9aMfNFfUo38xWbZ2qU86IZjiSXJghJ7LsSMpTcxv5N4n7t32ljKA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 14, 2023 at 04:27:46PM -0400, Nick Desaulniers wrote: > On Tue, Jun 13, 2023 at 5:22 PM Kees Cook wrote: > > > > On Sat, Jun 10, 2023 at 12:58:23AM +0800, kernel test robot wrote: > > > First bad commit (maybe != root cause): > > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > > head: 53ab6975c12d1ad86c599a8927e8c698b144d669 > > > commit: df8fc4e934c12b906d08050d7779f292b9c5c6b5 [3357/8413] kbuild: Enable -fstrict-flex-arrays=3 > > > config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20230610/202306100035.VTusNhm4-lkp@intel.com/config) > > ^ I just checked this config. CONFIG_KASAN=y is not set, so this is > not a case of > https://github.com/ClangBuiltLinux/linux/issues/39 > > UBSAN is though (maybe a red herring) as well as GCOV and TSAN/KCSAN. > > Disabling GCOV did not change the stack usage from allmodconfig. > > Disable KCSAN dropped it down from 2272 to 2160. > > Disabling UBSAN produced no warnings, and changed the inlining > behavior such that FlashPoint_HandleInterrupt only uses 656B rather > than 2272 via allmodconfig. > > Seems specific to: > ``` > CONFIG_UBSAN=y > CONFIG_CC_HAS_UBSAN_ARRAY_BOUNDS=y > CONFIG_UBSAN_BOUNDS=y > CONFIG_UBSAN_ARRAY_BOUNDS=y > # CONFIG_UBSAN_SHIFT is not set > # CONFIG_UBSAN_UNREACHABLE is not set > # CONFIG_UBSAN_BOOL is not set > # CONFIG_UBSAN_ENUM is not set > CONFIG_UBSAN_SANITIZE_ALL=y > ``` > but adding these on top of powernv_defconfig I couldn't reproduce. So > perhaps we can do a config bisection between allmodconfig and > powernv_defconfig to see what combination of configs in allmodconfig > is causing this to blow up. I think you're missing: CONFIG_SCSI_BUSLOGIC=y CONFIG_SCSI_FLASHPOINT=y Or the function doesn't get built. I'm using powernv_defconfig plus your UBSAN configs and the 2 above: make -j128 O=clang-ppc LLVM=1 ARCH=powerpc \ KCFLAGS=-Rpass-analysis=stack-frame-layout \ drivers/scsi/BusLogic.o And I see the huge stack usage. Having -fstrict-flex-arrays=3's seems to contribute about 200B: Enabled: Offset: [SP-2032], Type: Spill, Align: 8, Size: 8 Disabled: Offset: [SP-1808], Type: Spill, Align: 8, Size: 8 Even just a quick check of structs, I see several that gain UBSAN_BOUNDS coverage as a result (i.e. that have trailing arrays): struct sccb_mgr_tar_info struct nvram_info struct sccb_card So everything is working "as intended" from that perspective. Is this just the result of inlining? Some of the called functions are short, but FPT_sres() is not and has comical indentation. If everything got inlined into FlashPoint_HandleInterrupt() and all the array indexes get instrumented, maybe that's it? Though I'd expect stack slot reuse for array index instrumentation... so maybe it's similar to what is mentioned in: https://github.com/ClangBuiltLinux/linux/issues/39#issuecomment-1273688761 -Kees -- Kees Cook