From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26119EB64D8 for ; Wed, 14 Jun 2023 15:24:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9ED78E0001; Wed, 14 Jun 2023 11:24:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4EBA6B007B; Wed, 14 Jun 2023 11:24:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 916768E0001; Wed, 14 Jun 2023 11:24:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 821A66B0078 for ; Wed, 14 Jun 2023 11:24:14 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 24B7E1A0721 for ; Wed, 14 Jun 2023 15:24:14 +0000 (UTC) X-FDA: 80901724428.04.AC7D991 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 4941E40015 for ; Wed, 14 Jun 2023 15:24:11 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F2VfAIa6; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686756252; a=rsa-sha256; cv=none; b=CWC9uPhI2hcqbRx6pcf9pEbtiq5ATj9oF5oXTTbahJ19GiTlDZwp6f1MI9AYZ8L4GMhNrg cuawbaMsGjA2aK5vFvPeamY9xqJzmAAvwHqh/LTgzLl31rDaPhFMVlwCx0qTcqy3oewHlv PIvy9EEGaPvLbFFO/kATr/OO6cSKYm8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F2VfAIa6; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686756252; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7yuOG5mQyO9Fb2DeKzg9Ltur2MWPLhNYG/QQN4Q8M6s=; b=BPCYTZOn3WEJMX6X/4rzkhwG/bvf3gYpmRvpmBUxxikWaqVvFW3hZeFcofg3jFteADPCSp dCmri9uz2HHLBITEehrwyP4LiTI/8f1TNpD1AoxqBLcOcXo7UekFXvbGz+92+6XGvt9/Zx /LFUs9uuO04ZWgMBj6jphq276GTCDkU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6D872643A9; Wed, 14 Jun 2023 15:24:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EFE1C433C0; Wed, 14 Jun 2023 15:24:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686756250; bh=DYUjdElx66wwW56gbS6Oam3+Ri1YVeFJgUO5WJxkfRA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F2VfAIa6x+BTq6Vf7GKpNIQ4VRxhW1RinP9K8UayobTe9Tk8E5+Sq7cmwZZRn0d1y 26CB8picqZJFxo5+mLk+dJnultBctEPc1n6TEIPPARJJzXHv+f/Pgy45b2HV/isl3Y gb/2jcktaHSMftse5jDK8hl+l0HD7oQErPJyL7pw0t1TXRYQmrQl+fKIONYs1PTSvS z8NvkUUtJo2edNsOz3fzHHy16sEmRifJKVrKC5RW3D9o58C7GKLfTiOHZj9zfeqH0l Z6HqMiy17H4r/WPjR88En22k7c9F1SxwlZ7LkQb5J7xPFN1zqBm3yUfunH4M/rparU rulVeBuEQZAuA== Date: Wed, 14 Jun 2023 18:23:33 +0300 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH v4 34/34] mm: Remove pgtable_{pmd, pte}_page_{ctor, dtor}() wrappers Message-ID: <20230614152333.GG52412@kernel.org> References: <20230612210423.18611-1-vishal.moola@gmail.com> <20230612210423.18611-35-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230612210423.18611-35-vishal.moola@gmail.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4941E40015 X-Stat-Signature: trzckkzns5sn5qu171qosctbc4myut5t X-Rspam-User: X-HE-Tag: 1686756251-498348 X-HE-Meta: U2FsdGVkX19lg5OM7pSu5p+unsz+KxX5mxjiLioyk5eBOVi2d+DMR5Hs6j+At7sMHEgNmnJzD/eGOiH35cGgPQuHm/ZlJBm9EDunmjoCQMHjJiNgMuoFMgh4a1HLTCF39meIovBZw0NyAlUtl3rNtqLoU2aTu3K+geA7mltX6ze7x2qtHjKRUXwXTAD6yBzBQdqBnu/gR0Gg2nLQkmzVCAJT+x8Vf2139rQdXMkszUtyHhjvjfpgdYTkn5FbYvL2eD3LKGWs6DukV2JVZ0y/iCky+SSqm6RxCXPBzgpqIJJ8+Aiwz7rdbCS12m711YrNua2L5sR1GZVupSr2+K7wUpc+x4G9ScPzS5xD8EMmY8YTiNKefC3dlWGyJj20T9nOU8bUTWnb6UJMBAWbBTnr6kf0RIAdOdJNG8Xhf8Q+HVCeV36GoKatGWoByr77nHXDCEXVE1dOcVHaCZtpvBGocf8E9H4LaP4ALDTflMxM0ISxQP9NEKsNPtuZRswFBiBCjpaF2lbg/LZtMjdAWEEyp+HhbcmRoMAxPmIePo7mqGykERRQ6PeJ/KZsM3zrbcPv0VUn1TutQ/sSyRViL6xWymZpjgN0mee9iRufyOzR30fIJu5hfdqf1bQEDLWdBUJSFbWk2rrW1vd865ipZxN7wfag6P9Sqf+ybU/JKslBqfMGEf2VOlTw+BtG0Ey+TOvkyjlnb01s1tDYeJQRnI7tPbAOddNP9DyB3RPs9ztxI62ffJ1QPQRCTADZJvmE/Bnm91QaC6dq4QojzVCL6i/QAyzboieQgACgZ1+z/92CnYUEVsXWImFPmjpNMEeyy6gVfWVDpJA49uW8M3ToS81ogoCZqZWsPyJfZcF/UZYLVNEdJ4bVuXJNMc07FQpWfptHik8dT+gC/Lh9mEpQlzproqdClEX/ewoaXNJrGQl/ORNgo5WzttB1dAYRqdHlV1fG7xh4N/Lg4bDKzuYqTgM yzIL6F2m K84YQTpY/mjy3GzXqmnsjn/Tuw9vRNMGeBcddmTYSwkQXuCwP3CZsqDZ7VHKUZeieBswS0tbmuTHuG84vMFySSsKVo3KNKQU8t8R1e8GtOjuUK3FnuDPNBdv0OMap8SrpyTSKN2itby1eUE/E6AKC/6HYfYyqCnPtSMcpj0EfXyOBhiQzrktfya8Fh10WamPAyIktRRHimROc4E3coABNbTegeZtmkY+SM0Li742gWdXXuJJ9kx9Qf0iNzvc3tNiXnI9wF4QFsVcZnafMzEJD/kvjn5rSpMjy4FbyRx3ZB2WMPdqwoYMThbcgFNJOpoXZ7Za15F/pJTpz3yNMrMHL80BWlPuwJj6qbRxKs7SNBQFOs3P8T8yLolbUI+iI7RQqJom6FmXAi8PdEXerDWgqg6TG9LWVt+xYS90JXYJ/gg+QFMvX0fjikrhBhqNrqRgEbhq6k9ocFpwEjt4D+3QMCpJ4wu9Dev8pMuST7y3g4bMdLio= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 02:04:23PM -0700, Vishal Moola (Oracle) wrote: > These functions are no longer necessary. Remove them and cleanup > Documentation referencing them. > > Signed-off-by: Vishal Moola (Oracle) I've found one stale reference in riscv: $ git grep -n pgtable_pmd_page_ctor arch/riscv/mm/init.c:440: BUG_ON(!vaddr || !pgtable_pmd_page_ctor(virt_to_page(vaddr))); Otherwise Acked-by: Mike Rapoport (IBM) > --- > Documentation/mm/split_page_table_lock.rst | 12 +++++------ > .../zh_CN/mm/split_page_table_lock.rst | 14 ++++++------- > include/linux/mm.h | 20 ------------------- > 3 files changed, 13 insertions(+), 33 deletions(-) > > diff --git a/Documentation/mm/split_page_table_lock.rst b/Documentation/mm/split_page_table_lock.rst > index 50ee0dfc95be..4bffec728340 100644 > --- a/Documentation/mm/split_page_table_lock.rst > +++ b/Documentation/mm/split_page_table_lock.rst > @@ -53,7 +53,7 @@ Support of split page table lock by an architecture > =================================================== > > There's no need in special enabling of PTE split page table lock: everything > -required is done by pgtable_pte_page_ctor() and pgtable_pte_page_dtor(), which > +required is done by pagetable_pte_ctor() and pagetable_pte_dtor(), which > must be called on PTE table allocation / freeing. > > Make sure the architecture doesn't use slab allocator for page table > @@ -63,8 +63,8 @@ This field shares storage with page->ptl. > PMD split lock only makes sense if you have more than two page table > levels. > > -PMD split lock enabling requires pgtable_pmd_page_ctor() call on PMD table > -allocation and pgtable_pmd_page_dtor() on freeing. > +PMD split lock enabling requires pagetable_pmd_ctor() call on PMD table > +allocation and pagetable_pmd_dtor() on freeing. > > Allocation usually happens in pmd_alloc_one(), freeing in pmd_free() and > pmd_free_tlb(), but make sure you cover all PMD table allocation / freeing > @@ -72,7 +72,7 @@ paths: i.e X86_PAE preallocate few PMDs on pgd_alloc(). > > With everything in place you can set CONFIG_ARCH_ENABLE_SPLIT_PMD_PTLOCK. > > -NOTE: pgtable_pte_page_ctor() and pgtable_pmd_page_ctor() can fail -- it must > +NOTE: pagetable_pte_ctor() and pagetable_pmd_ctor() can fail -- it must > be handled properly. > > page->ptl > @@ -92,7 +92,7 @@ trick: > split lock with enabled DEBUG_SPINLOCK or DEBUG_LOCK_ALLOC, but costs > one more cache line for indirect access; > > -The spinlock_t allocated in pgtable_pte_page_ctor() for PTE table and in > -pgtable_pmd_page_ctor() for PMD table. > +The spinlock_t allocated in pagetable_pte_ctor() for PTE table and in > +pagetable_pmd_ctor() for PMD table. > > Please, never access page->ptl directly -- use appropriate helper. > diff --git a/Documentation/translations/zh_CN/mm/split_page_table_lock.rst b/Documentation/translations/zh_CN/mm/split_page_table_lock.rst > index 4fb7aa666037..a2c288670a24 100644 > --- a/Documentation/translations/zh_CN/mm/split_page_table_lock.rst > +++ b/Documentation/translations/zh_CN/mm/split_page_table_lock.rst > @@ -56,16 +56,16 @@ Hugetlb特定的辅助函数: > 架构对分页表锁的支持 > ==================== > > -没有必要特别启用PTE分页表锁：所有需要的东西都由pgtable_pte_page_ctor() > -和pgtable_pte_page_dtor()完成，它们必须在PTE表分配/释放时被调用。 > +没有必要特别启用PTE分页表锁：所有需要的东西都由pagetable_pte_ctor() > +和pagetable_pte_dtor()完成，它们必须在PTE表分配/释放时被调用。 > > 确保架构不使用slab分配器来分配页表：slab使用page->slab_cache来分配其页 > 面。这个区域与page->ptl共享存储。 > > PMD分页锁只有在你有两个以上的页表级别时才有意义。 > > -启用PMD分页锁需要在PMD表分配时调用pgtable_pmd_page_ctor()，在释放时调 > -用pgtable_pmd_page_dtor()。 > +启用PMD分页锁需要在PMD表分配时调用pagetable_pmd_ctor()，在释放时调 > +用pagetable_pmd_dtor()。 > > 分配通常发生在pmd_alloc_one()中，释放发生在pmd_free()和pmd_free_tlb() > 中，但要确保覆盖所有的PMD表分配/释放路径：即X86_PAE在pgd_alloc()中预先 > @@ -73,7 +73,7 @@ PMD分页锁只有在你有两个以上的页表级别时才有意义。 > > 一切就绪后，你可以设置CONFIG_ARCH_ENABLE_SPLIT_PMD_PTLOCK。 > > -注意：pgtable_pte_page_ctor()和pgtable_pmd_page_ctor()可能失败--必 > +注意：pagetable_pte_ctor()和pagetable_pmd_ctor()可能失败--必 > 须正确处理。 > > page->ptl > @@ -90,7 +90,7 @@ page->ptl用于访问分割页表锁，其中'page'是包含该表的页面struc > 的指针并动态分配它。这允许在启用DEBUG_SPINLOCK或DEBUG_LOCK_ALLOC的 > 情况下使用分页锁，但由于间接访问而多花了一个缓存行。 > > -PTE表的spinlock_t分配在pgtable_pte_page_ctor()中，PMD表的spinlock_t > -分配在pgtable_pmd_page_ctor()中。 > +PTE表的spinlock_t分配在pagetable_pte_ctor()中，PMD表的spinlock_t > +分配在pagetable_pmd_ctor()中。 > > 请不要直接访问page->ptl - -使用适当的辅助函数。 > diff --git a/include/linux/mm.h b/include/linux/mm.h > index dc211c43610b..6d83483cf186 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2897,11 +2897,6 @@ static inline bool pagetable_pte_ctor(struct ptdesc *ptdesc) > return true; > } > > -static inline bool pgtable_pte_page_ctor(struct page *page) > -{ > - return pagetable_pte_ctor(page_ptdesc(page)); > -} > - > static inline void pagetable_pte_dtor(struct ptdesc *ptdesc) > { > struct folio *folio = ptdesc_folio(ptdesc); > @@ -2911,11 +2906,6 @@ static inline void pagetable_pte_dtor(struct ptdesc *ptdesc) > lruvec_stat_sub_folio(folio, NR_PAGETABLE); > } > > -static inline void pgtable_pte_page_dtor(struct page *page) > -{ > - pagetable_pte_dtor(page_ptdesc(page)); > -} > - > #define pte_offset_map_lock(mm, pmd, address, ptlp) \ > ({ \ > spinlock_t *__ptl = pte_lockptr(mm, pmd); \ > @@ -3006,11 +2996,6 @@ static inline bool pagetable_pmd_ctor(struct ptdesc *ptdesc) > return true; > } > > -static inline bool pgtable_pmd_page_ctor(struct page *page) > -{ > - return pagetable_pmd_ctor(page_ptdesc(page)); > -} > - > static inline void pagetable_pmd_dtor(struct ptdesc *ptdesc) > { > struct folio *folio = ptdesc_folio(ptdesc); > @@ -3020,11 +3005,6 @@ static inline void pagetable_pmd_dtor(struct ptdesc *ptdesc) > lruvec_stat_sub_folio(folio, NR_PAGETABLE); > } > > -static inline void pgtable_pmd_page_dtor(struct page *page) > -{ > - pagetable_pmd_dtor(page_ptdesc(page)); > -} > - > /* > * No scalability reason to split PUD locks yet, but follow the same pattern > * as the PMD locks to make it easier if we decide to. The VM should not be > -- > 2.40.1 > > -- Sincerely yours, Mike.