From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83942EB64DC for ; Wed, 14 Jun 2023 15:19:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12A256B0074; Wed, 14 Jun 2023 11:19:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DBA46B0075; Wed, 14 Jun 2023 11:19:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0C8E8E0001; Wed, 14 Jun 2023 11:19:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DFC3F6B0074 for ; Wed, 14 Jun 2023 11:19:31 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B2DAD1A0710 for ; Wed, 14 Jun 2023 15:19:31 +0000 (UTC) X-FDA: 80901712542.15.D10A21A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 33FD0C000E for ; Wed, 14 Jun 2023 15:19:27 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mukQSaSz; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686755968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gtYhd2SuCELveboPO5ugKbr09GQugYOa6yA+PPIXMqM=; b=n7WWCV2XdoCFQGXiPyzKgUJmRoCZv5jgd1ProWEHUZ1ra6j2zT3FlM1BVIrbB5ZQS9D2fO wKiAB4f3K0aQa6NmT1r850HdEMkcGx1ZTE9ehKaWm6rsFhnE0/TAjWFljgYl0JDN6f4Vqx 2fi3m85wtNOf7EAN9Na2twMBPhzYS70= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mukQSaSz; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686755968; a=rsa-sha256; cv=none; b=uq97SfsNogafN83indeVwkeDuo5tEnNS7ehZy9Wl9C1tO4nykZzHnqeSU3KaL+vxie39Dg ppsPHAAES0HEKvHZuXvBzDaXh0xiIpbvunlNBQJSghaXDJn4QQCABtCkeJgyW4PXwyNBM7 i6QVXedgTCuxbdozdommrCiDElVweF4= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1176663EB4; Wed, 14 Jun 2023 15:19:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5818AC433C8; Wed, 14 Jun 2023 15:19:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686755966; bh=c6X3BgGu/EnO13cv7axj+v9K19tCICftWYw//M95Fnc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mukQSaSzdQR3OwjUS8vlwj1DHxIFmnMmoNoVkKPQxFhB5yNNsmSGfOiEGD8e6JtXN VZrzNf4q5GRrRBOrFQak3/eBTJY3kdciGuz9dfIz0ogQBeAxF+PTcvQ/gdSnr6B6Ya C9HPAVz2+QHGDvMOZCaBKr/tY2qJeGKCeVCDx4TNXrt2yXr+HZedFR/l+9aCOtZIfW p20G2U+/kfUbEadTA1MzcZsMIBLzRi+uWub7RgdqmiPZpQJB5MtxjDgSgPYQUK2ycp Y3HwjPWpr3Oy82TQpASrv+jsR0EnwOAILsyUfuVeolmVBSHpN9tcvEMjDpzLifkGiY BbULUmkygaTkA== Date: Wed, 14 Jun 2023 18:18:48 +0300 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , Palmer Dabbelt Subject: Re: [PATCH v4 29/34] riscv: Convert alloc_{pmd, pte}_late() to use ptdescs Message-ID: <20230614151848.GB52412@kernel.org> References: <20230612210423.18611-1-vishal.moola@gmail.com> <20230612210423.18611-30-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612210423.18611-30-vishal.moola@gmail.com> X-Rspamd-Queue-Id: 33FD0C000E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: q11j3ywo6ct6fkae4rascf3dp8kfushn X-HE-Tag: 1686755967-846920 X-HE-Meta: U2FsdGVkX19AtaLK++odsdJL5oAxjglGzTFZ/BizvKMw7aD5XoqI8MEH3oJSzoJGKL/UgNelJ4IJ1NXL93EcRQqI7g7L1hwYHQZfd2CpWza7U3ge09JQepVaC6TUh5RGCbCs4+SFw2OHjV/7+GLZVzqSkPxFItd0QMCDQbXKFtbztxd5rSdMA7XksXRwm8QsUpnIp4UIFhxdS6aQi/DPN2cHaB1lhxhoLS26Rd+72vzz8R65ykx9LX24Lxc74ScojBd4iiYTCOwHrnOZ+IfZhZHlPAiwOdx69deUTPE/k10NvILO59Zix4jicVQVihPNWMH/rzjB3V7LY04M9JK74vGsgiKCpgA0qR267GODmxI2o35IMtCtF35oopj/6lLSDzV8BhLI2zO6gaX17/+D7165oueY0Py2ZYL/+e3XdXeUxlgagQ6iHpqlBwJOuKt96ywDrr+6ebS8kEDWSPqAtwDICE4sntDkyOsjKXTjReazC6CteuR3Lo16wFyBC4bLteXkV30Elo+wLkT53zLJ08g2wzZI/14K/YaPdZpgDa9br0nHQhpSvSaHAhBnVbKPFVRN2FZN7ku/S/n03wEABJzWFCMB/yTn1jKG5Xb+HSx6v1fZ9ZBBM0IY6fp913vXOSTI9brArXoh9UPAhFgClRaphiqzg40idSEuQF1zBJvL0ekWsbSST+Hja/1RF5kPcBi62vbpa/fTqBVpE/2c85+czKG4Gn+bJXUQVTRQQXM2jF+4IrDqa8yzfqRiAGHnU2ck1Qt7T9ynXJ+VItH70BO83Obb/bFj4kEl3eXxnuxhnvvitiKBTjhNeFBhLooVB3TNO541drZhfz+QXTDP5RnbnSycGJmd00MPLhR8PiKGScoM39nCJhBaBslKxX5S8JJGfCKsxav8rq9NyDUXDSJ6gVer9HiCHJczBo0hMxgY5NExGvAps4RWc0RLVe2PHW052KgwDeHQMsuWdhB AhotttjL 8TQIQYB+LniN8CmEjhTEv4I8dyAj4XOFwvKbOCNdW+emxpNEj1/TKkt+lolG16A1KTr4LCfNRnkorAXeQCV14pE046qNcu+vDi6FMzAdZxajw1EabbuDomZL6GkqyAEYDAgzfGCXzT6MLK1a3kfLPnF+/ycliJ1V1ljMY9Ln/is5e+pF9cVtBAiMEUTKca88QT+CqIDtfHi/NEF1WvJkL9jUVPtsvpIECGCwqaLF50l5w/NFJccOcm9y6xCBeaMot+2uIb48d+aowi9fkSdxoETDsKdNlai6xM1SLZV45fQ8oXzhMdFua2KFQRu32vS72+blaEZQ7BN1oOdjpRtLEf9VH1Fi8pYH5u8DOh+fzAEUGSMcLWN8Qm7hvHXc4JbD/ppwFuqLdGr+2CwmJSE6Dpf3j1wRWKuHdFfEUFd8Rv7WmJnP9VXy5dH26YKxapOAOpCdBkBBsNeP8VLC7w1otnf9AO7nf0us2PTxo+oZD1D7lAEr1NbTSrWp8INSqUl1geezYgvVBBwKh2ol7b7OL5x7zY23TUWwYsFlL1t9jQFoN8U0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 02:04:18PM -0700, Vishal Moola (Oracle) wrote: > As part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents, convert various page table functions to use ptdescs. > > Some of the functions use the *get*page*() helper functions. Convert > these to use pagetable_alloc() and ptdesc_address() instead to help > standardize page tables further. > > Signed-off-by: Vishal Moola (Oracle) > Acked-by: Palmer Dabbelt Acked-by: Mike Rapoport (IBM) > --- > arch/riscv/include/asm/pgalloc.h | 8 ++++---- > arch/riscv/mm/init.c | 16 ++++++---------- > 2 files changed, 10 insertions(+), 14 deletions(-) > > diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h > index 59dc12b5b7e8..d169a4f41a2e 100644 > --- a/arch/riscv/include/asm/pgalloc.h > +++ b/arch/riscv/include/asm/pgalloc.h > @@ -153,10 +153,10 @@ static inline pgd_t *pgd_alloc(struct mm_struct *mm) > > #endif /* __PAGETABLE_PMD_FOLDED */ > > -#define __pte_free_tlb(tlb, pte, buf) \ > -do { \ > - pgtable_pte_page_dtor(pte); \ > - tlb_remove_page((tlb), pte); \ > +#define __pte_free_tlb(tlb, pte, buf) \ > +do { \ > + pagetable_pte_dtor(page_ptdesc(pte)); \ > + tlb_remove_page_ptdesc((tlb), page_ptdesc(pte));\ > } while (0) > #endif /* CONFIG_MMU */ > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index 3d689ffb2072..6bfeec80bf4e 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -354,12 +354,10 @@ static inline phys_addr_t __init alloc_pte_fixmap(uintptr_t va) > > static phys_addr_t __init alloc_pte_late(uintptr_t va) > { > - unsigned long vaddr; > - > - vaddr = __get_free_page(GFP_KERNEL); > - BUG_ON(!vaddr || !pgtable_pte_page_ctor(virt_to_page((void *)vaddr))); > + struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL, 0); > > - return __pa(vaddr); > + BUG_ON(!ptdesc || !pagetable_pte_ctor(ptdesc)); > + return __pa((pte_t *)ptdesc_address(ptdesc)); > } > > static void __init create_pte_mapping(pte_t *ptep, > @@ -437,12 +435,10 @@ static phys_addr_t __init alloc_pmd_fixmap(uintptr_t va) > > static phys_addr_t __init alloc_pmd_late(uintptr_t va) > { > - unsigned long vaddr; > - > - vaddr = __get_free_page(GFP_KERNEL); > - BUG_ON(!vaddr || !pgtable_pmd_page_ctor(virt_to_page((void *)vaddr))); > + struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL, 0); > > - return __pa(vaddr); > + BUG_ON(!ptdesc || !pagetable_pmd_ctor(ptdesc)); > + return __pa((pmd_t *)ptdesc_address(ptdesc)); > } > > static void __init create_pmd_mapping(pmd_t *pmdp, > -- > 2.40.1 > > -- Sincerely yours, Mike.