From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 759C7EB64D8 for ; Wed, 14 Jun 2023 14:54:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2FDE6B0074; Wed, 14 Jun 2023 10:54:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE0136B0075; Wed, 14 Jun 2023 10:54:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACFB06B0078; Wed, 14 Jun 2023 10:54:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9FA946B0074 for ; Wed, 14 Jun 2023 10:54:09 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5E73616066C for ; Wed, 14 Jun 2023 14:54:09 +0000 (UTC) X-FDA: 80901648618.02.6F2F229 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 93348C0003 for ; Wed, 14 Jun 2023 14:54:07 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jZwYpBVV; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686754447; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mNLsoI9ViB+k90A00Axqcgt6cVaRJ8BmypffLi5Gvjc=; b=1Bf40zUMgCIIIZ/cjDYp5wnqyxM/DezXYamqnwDWiUmfseS2xAIKJVHH8ddTH5eYrWy/2E wKkkwPPbalLdfbKVQd0hhaU4OBP9W6eKbu2sTqF9qNtgd1YTJiYALkFIiGnkTnoLuEeiR9 x780sLxmfEgdmD0Uf3U5J5VnhqMif58= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jZwYpBVV; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686754447; a=rsa-sha256; cv=none; b=oEkndRQORigITsYTEgcyo7zYs48cNribHgPXh46TKE7IHvNSWP3gZ0wOhLGEiGBrew5Dl9 SvuTK+a8dHA6V4j20y/nIxf6061Ts+e9jvTQgxLx/4d9Z8Z0JHWqPAJq66bHuB6jCvryft 4OURJr5IXW7Zv3Fch1JVJ9cDrcr9qfM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7B66B64337; Wed, 14 Jun 2023 14:54:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2F20C433C0; Wed, 14 Jun 2023 14:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686754446; bh=aUxoRMWQndKzGf4Pu7KWMeOI/WoSZl9BaSxpwilOg7U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jZwYpBVV3Znjt/2r1/XmhShCVNutgqeq3trQicfEgjJSgiA24WGgfoHn4JPicd8He rS8NLkit65oXPztWCIk1plc/L0WWZ1stJCGO0xc9wMl4POqoTrOZPublJSijHPF4oz YlEcjE5Kwe8W73hiYvKQSbG68Y5Kyn6lFrlJJDjGKeMTC6UZAwh79rs3bU7nluQGBU tiS60ivJdA1OXEq/xKwuvgxelAM+i8GtKwUxe5gT00CZzdwQsaCSrG5/5u9c1vIGyV elULRRCAhePhL/Al9xGEtorsHTDGauC6YCgaYOxRHSZ2eYhHw9pEXNQZFB7ZzH7n03 HSw2Jfv0l97fA== Date: Wed, 14 Jun 2023 17:53:28 +0300 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH v4 18/34] mm: Remove page table members from struct page Message-ID: <20230614145328.GQ52412@kernel.org> References: <20230612210423.18611-1-vishal.moola@gmail.com> <20230612210423.18611-19-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612210423.18611-19-vishal.moola@gmail.com> X-Rspamd-Queue-Id: 93348C0003 X-Rspam-User: X-Stat-Signature: asoa3u3zi6hysduum31ayiarytrruqrk X-Rspamd-Server: rspam01 X-HE-Tag: 1686754447-491903 X-HE-Meta: U2FsdGVkX19HuPCaNVjOrQh4sD6MxL0u0+zi2vdcloPJV2Q8O2wZsGXr4coaCVMSD2n9shM03w7DnLL71lyd/7dJU2QKe659T9kGkFcRAHESuO0EZuQZV6FxdSIgoc5/GypisZSfTON40IyAlLLbzRPvhLw7xcEoD/8K+yM25q9TjnKtOYK5cAD5ysU+f4VtNttNgvJZJdXnr3wdYW7JRRChqsyCM/RufSRzC4iG995pGGwPEzJVnUJJ96W/H9iOUbc6YhLlFi0WPgxzDI9emgaWe4lHDhAL3Fn75vM8RAY+3vV529Gv/Rg6f7+stgAoP0Y+lNo0WwQecB4pjc6lBoaKsWg0LKmfsfdx3ioSWeKg15wXPW8G/lqzx1E4qz9pOTXlnsoLiSMEFRTkubf2AK8WK2mcXoESTowWMEdQHqSu0wXQ7TMqfrAmXvKDuyV9meWEVKiZLYt3hQRzTtOS5z+nGKyM9gX2ic8haXlmsVs9FAiRnNikPymaUFW69nC7ZqYkgZfVz0trZnbr0hWQ2cVPoiucS1pVO78yYdnjdwb0rcC/pHVlP4QwQOaabd6mP3P8+rA8vyR1Fy4r6Bcqy44RysDfs87uyyGNq1+HAAyIgHngBTYyP6v+q8OMARaCHxYF2hxyLIjkae8nT+v1gDo/tFlORuG0dOm/f/l0TVYfcC0wwUOgKZt/GkBo7sUSX/s9LwfnPLfYHSrxoA1u5TxSLywpG+2VsVK2I28BlxTH4YAuc/sEakSUCju16FjwipstBaqzevEMCBTyIMrYBSIctqYDQk/WMg9nb2yWNrE6nhVRSv+DNYu07N4uueHWmZD2QOti1+CPEntD5WB6JXXAqVPu7nNXGKL/zNOkweIQ0FDZjr6ahCaYU5qAveIWxz2g6N9MjOrW+P9EdMyfRz8aKOoDqt0sAn3UJ924F81RZFzvbUxyIjwPtP4nl8Ckxp+DQ10xRW7l9M+i3wt xxmBRffo J9iZbIVtCjL0x9o90SoDiCdvcvfvP29ZTkBL+L8c76GUbAUGGzmU1MpxEC/GGSt5U9Impxz3+rwiPM148BVb1tSdnZBG3beFHzhw5D4ufHRPhXUxzYD880DaRBqRApmziQBo0k6YtHkIeova55Tb98M0B4AjgIvhfXU/TxuuacPgQ5Ty3pGkTmSyX1KI7G3vScEti/5EQBtlLXHUoPHdaxqETsbRcqV6/zsvORQcQF/kizz0ipk1I4SuG2JucdTYbDx9UuH8/HHYUR27eo0wtmVTOOj7AF2ZgTdDM4fL8b9HH6s0D0PqaxAIs746EB7q8q9GqQzCX9fY5/rUS+MyqnCTotq0M32p6hYUgpiZLC/KBrg/05YN9Ihs/vfbIzxg4L5Azf7gVSlvpjTdvNXvmmEBbvQiErZQYHjagzZ6Rkya4twmEBEoXmvkPhLoTioYJ6QSC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 02:04:07PM -0700, Vishal Moola (Oracle) wrote: > The page table members are now split out into their own ptdesc struct. > Remove them from struct page. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > include/linux/mm_types.h | 14 -------------- > include/linux/pgtable.h | 3 --- > 2 files changed, 17 deletions(-) > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 6161fe1ae5b8..31ffa1be21d0 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -141,20 +141,6 @@ struct page { > struct { /* Tail pages of compound page */ > unsigned long compound_head; /* Bit zero is set */ > }; > - struct { /* Page table pages */ > - unsigned long _pt_pad_1; /* compound_head */ > - pgtable_t pmd_huge_pte; /* protected by page->ptl */ > - unsigned long _pt_s390_gaddr; /* mapping */ > - union { > - struct mm_struct *pt_mm; /* x86 pgds only */ > - atomic_t pt_frag_refcount; /* powerpc */ > - }; > -#if ALLOC_SPLIT_PTLOCKS > - spinlock_t *ptl; > -#else > - spinlock_t ptl; > -#endif > - }; > struct { /* ZONE_DEVICE pages */ > /** @pgmap: Points to the hosting device page map. */ > struct dev_pagemap *pgmap; > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index c405f74d3875..33cc19d752b3 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -1019,10 +1019,7 @@ struct ptdesc { > TABLE_MATCH(flags, __page_flags); > TABLE_MATCH(compound_head, pt_list); > TABLE_MATCH(compound_head, _pt_pad_1); > -TABLE_MATCH(pmd_huge_pte, pmd_huge_pte); > TABLE_MATCH(mapping, _pt_s390_gaddr); > -TABLE_MATCH(pt_mm, pt_mm); > -TABLE_MATCH(ptl, ptl); > #undef TABLE_MATCH > static_assert(sizeof(struct ptdesc) <= sizeof(struct page)); > > -- > 2.40.1 > > -- Sincerely yours, Mike.