From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC8B6EB64D9 for ; Wed, 14 Jun 2023 14:11:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 318D56B0071; Wed, 14 Jun 2023 10:11:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C80A6B0074; Wed, 14 Jun 2023 10:11:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 191056B0078; Wed, 14 Jun 2023 10:11:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0A88A6B0071 for ; Wed, 14 Jun 2023 10:11:31 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C9FCF160663 for ; Wed, 14 Jun 2023 14:11:30 +0000 (UTC) X-FDA: 80901541140.11.89E4FDF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 8F52740009 for ; Wed, 14 Jun 2023 14:11:28 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZhJtlj5I; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686751888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u7zKYWziWq0aAQRsC57ngChbSLVXmFYD1cgN3Tn+87w=; b=ZA0yXF0Lr/YRxAp2JJERE5dt/E4AEns+fYvFUAr/LZRtGWClBviiBfgGp4X6XZPBqXPNh8 IGreczt4RzTp/3kiB2HzPUf7XpKVrrdAHsFQLjzst/sm/1jXofYPyCDLE/L43lalXSHrNq LMl7owoa9qhBGyma2H27Htw1hCcITNA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZhJtlj5I; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686751888; a=rsa-sha256; cv=none; b=nZfhD4m2/3bMOyA/3izksWjlhJVuLeJvABXSlv0XcN5CxJoo/Nhpv7OWOoozQFtIxcf5XB to9IiYcWXTGDrSfIlTarL8hFPvfpRnyQ41qq1QjFdfZy1m3o2/8j9fAFYW7Wbu3VuDcugy JDWj9j74WI1xO58NWPHP5bFAd4L0bmo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6CFA860E9E; Wed, 14 Jun 2023 14:11:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10F7AC433C0; Wed, 14 Jun 2023 14:11:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686751886; bh=nq3f91/c6VdnG05wknAO7CzsIzeIwd55LMS9xhs7vLc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZhJtlj5I8piICZIev7qvB69N2MRkFrUNmM4AY9KOSxdltgl+qcVmK0w/AhUDKOYUE C0naLvwDyTJX3vMjNC8e9+i7bgqJP3nnR+cfRN/EKtI25YOH2TSwU36LZazWsweF02 YGMNzwODmUGT8dkPREzGod/+rUbK65tLM4QfOSq3fgVX2NpImfyc5X1iBcneHw7wgS aWE67OFlHHdjdwxPMfJUf27XkhoC98XnYJ++XQkAMrKDt/blZeMPDlGxeoaoTED8QE EqDj0B92olx0FPba9u2ztMQCZcN18316sOzneqJzKqI8FGzRdybM2tuA29sFD9tYUy 7yV6zVzN7CwRA== Date: Wed, 14 Jun 2023 17:10:49 +0300 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH v4 13/34] mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor} Message-ID: <20230614141049.GL52412@kernel.org> References: <20230612210423.18611-1-vishal.moola@gmail.com> <20230612210423.18611-14-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612210423.18611-14-vishal.moola@gmail.com> X-Rspam-User: X-Stat-Signature: 98piqad46ui8k6zqea85axwcn3b83siz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8F52740009 X-HE-Tag: 1686751888-593269 X-HE-Meta: U2FsdGVkX18SVkLkiBWoAXsrPjgIvJdY27JTqumSiSu5m57SBAgu3n+fKK2KJTTbLf+AKDNU1kSoXEDhJG5G1OFlqHv/CzNMGSXA43uyQhFt5xqM2LuxZF/wjZTVk4jB8cT3pKM44ZthLVrbVbFDuHC+ERb0/n6rooqtVt1+E2GAtHAh04ziIb2VSv5jOrCs6jApivBAjJUoFhnHI4/aIcxzWhHkGlL0dWtJNgGDEP+KXGlBtw0JuTbeWllk3UQnW7Pe5i1v4ZwzBh+z2shqOPcz14v/rOIGiSYkZhfynz6JEFBnmmDtANMWDa5+SbOYKXwhvQ8Rmtnb9BHznmxvTX1F8axI2EddXHk7KdnOcQ34gA8QjgEh5iS/Z+8/uxFvzjS4JXrSOGxLFNBgC58n4thee4bkncRbiLJ1KKlErEzE+MYEHnhjXLMsBKDUQ8XB0L1ucITVP3NsGAjN3Zfl6e9Mk3Di4Xa2lE8ZibOwohhuCXE/jl7F5dhaLszrpKJFecSJXXtFWDBrGZ4OzJ5ezW7kLPssxrLrIwSAnBp9WhatBr1sBI4+NjZtxt3rPDGnOZAuGtf/exNcc3oDJynFF+I1JGGxHVG0eXzPD7tMUbsjBFSKUNs+wUi3ADBe6nnYLIMyBN9Iivu4xvjYx+O6Gyx5a6cpWX9T6P9/EENamlvvPzNyqzEc2P4U6w2S4n6V1M7V0kxsN4SLofC2pALw8LQjk4IJWmOOoQbLO0HsdoO+uyP5gXOHEdYhuTyo9dlnditFfYZaDyX5KtwWWKd3E0d/kB0SYRHKubpMF+ghRJY2repUw/oG5EnFNRYVRIcpADlwPghug63Yi2zVVm5IOszBhUQxiDG8vwZ1h4yS9P6JYrNz+btpiLY11/M0lOLPmFcPO7Fr665W9KMEuc58/N7+t4DWhDOm3dKepbD+I4HWAy4IH0l27d3PoRwNks+bcwfFhkvVLar30MhwLUp bpUZXFue YaIWLndCHiRrZ5CQit5S1OMZua5XQH02R+1zDye4OfwBITyK7hrMkjZ46p1sBvsbdXnk0e0hkd+66fbdLzGtEG4kfpHfEEsN0q4l88S4A0o6GBp58PXi2L5cZnXWs4JjKR5eS0r0nFrAmJ3adHf6gFxGh/dQ7LU3TsvmM0fd5sKVJUqAxTvweb7r00KBuH76lNwYHkn0x79pezCBFmkHi4AnpQf1EZXAYV6FGSKIZ7OcY42Xo8sY5XdxyyfuF0utiQh2HAv8T4v2t19rPal+iC0H8/1fgZdX4FLKUiag6oroyOifdcE9J+3C9e9EJQznmHp0T/5uh1e8QefW9tocEp5bruGGZKvFhVRX9Dz0PiEY4/ki1HzRoOrnTooqbdGrseQezFhB4Hz5YDNqH8KOThq5Kbp9Z/XeWHlQlhQbrVcHDhUctUHpAqS+YpQyFd/JsziZMlp8cfhmljiZ66pDjhRHYHHGv35cLWo8sawJtwoEtbxc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 02:04:02PM -0700, Vishal Moola (Oracle) wrote: > Creates pagetable_pte_ctor(), pagetable_pmd_ctor(), pagetable_pte_dtor(), > and pagetable_pmd_dtor() and make the original pgtable > constructor/destructors wrappers. Nit: either "creates ... makes" or "create ... make" I like the second form more. > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > include/linux/mm.h | 56 ++++++++++++++++++++++++++++++++++------------ > 1 file changed, 42 insertions(+), 14 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index a1af7983e1bd..dc211c43610b 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2886,20 +2886,34 @@ static inline bool ptlock_init(struct ptdesc *ptdesc) { return true; } > static inline void ptlock_free(struct ptdesc *ptdesc) {} > #endif /* USE_SPLIT_PTE_PTLOCKS */ > > -static inline bool pgtable_pte_page_ctor(struct page *page) > +static inline bool pagetable_pte_ctor(struct ptdesc *ptdesc) > { > - if (!ptlock_init(page_ptdesc(page))) > + struct folio *folio = ptdesc_folio(ptdesc); > + > + if (!ptlock_init(ptdesc)) > return false; > - __SetPageTable(page); > - inc_lruvec_page_state(page, NR_PAGETABLE); > + __folio_set_table(folio); This comment is more to patch 1 ("mm: Add PAGE_TYPE_OP folio functions") It would be better to have _pgtable here, as "table" does not necessary mean page table. With PageType SetPageTable was fine, but with folio I think it should be more explicit. I'd add a third parameter to PAGE_TYPE_OPS for that. > + lruvec_stat_add_folio(folio, NR_PAGETABLE); > return true; > } > > +static inline bool pgtable_pte_page_ctor(struct page *page) > +{ > + return pagetable_pte_ctor(page_ptdesc(page)); > +} > + > +static inline void pagetable_pte_dtor(struct ptdesc *ptdesc) > +{ > + struct folio *folio = ptdesc_folio(ptdesc); > + > + ptlock_free(ptdesc); > + __folio_clear_table(folio); > + lruvec_stat_sub_folio(folio, NR_PAGETABLE); > +} > + > static inline void pgtable_pte_page_dtor(struct page *page) > { > - ptlock_free(page_ptdesc(page)); > - __ClearPageTable(page); > - dec_lruvec_page_state(page, NR_PAGETABLE); > + pagetable_pte_dtor(page_ptdesc(page)); > } > > #define pte_offset_map_lock(mm, pmd, address, ptlp) \ > @@ -2981,20 +2995,34 @@ static inline spinlock_t *pmd_lock(struct mm_struct *mm, pmd_t *pmd) > return ptl; > } > > -static inline bool pgtable_pmd_page_ctor(struct page *page) > +static inline bool pagetable_pmd_ctor(struct ptdesc *ptdesc) > { > - if (!pmd_ptlock_init(page_ptdesc(page))) > + struct folio *folio = ptdesc_folio(ptdesc); > + > + if (!pmd_ptlock_init(ptdesc)) > return false; > - __SetPageTable(page); > - inc_lruvec_page_state(page, NR_PAGETABLE); > + __folio_set_table(folio); > + lruvec_stat_add_folio(folio, NR_PAGETABLE); > return true; > } > > +static inline bool pgtable_pmd_page_ctor(struct page *page) > +{ > + return pagetable_pmd_ctor(page_ptdesc(page)); > +} > + > +static inline void pagetable_pmd_dtor(struct ptdesc *ptdesc) > +{ > + struct folio *folio = ptdesc_folio(ptdesc); > + > + pmd_ptlock_free(ptdesc); > + __folio_clear_table(folio); > + lruvec_stat_sub_folio(folio, NR_PAGETABLE); > +} > + > static inline void pgtable_pmd_page_dtor(struct page *page) > { > - pmd_ptlock_free(page_ptdesc(page)); > - __ClearPageTable(page); > - dec_lruvec_page_state(page, NR_PAGETABLE); > + pagetable_pmd_dtor(page_ptdesc(page)); > } > > /* > -- > 2.40.1 > > -- Sincerely yours, Mike.