From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DF75EB64D8 for ; Wed, 14 Jun 2023 14:00:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABD7F6B0071; Wed, 14 Jun 2023 10:00:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A46256B0074; Wed, 14 Jun 2023 10:00:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C0F18E0001; Wed, 14 Jun 2023 10:00:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7D73E6B0071 for ; Wed, 14 Jun 2023 10:00:56 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C4158AFE33 for ; Wed, 14 Jun 2023 14:00:55 +0000 (UTC) X-FDA: 80901514470.06.A6E30FC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 2E7FB4007F for ; Wed, 14 Jun 2023 14:00:26 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PDvLwogG; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686751227; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q1z+GH/hGwF8M2TkyRYUdLsDDroG+ZzP2tNZ82fLaNM=; b=LtXNZKA+AzoywwO/dz39WeZMQaUGAqlISMdXuIzD285l0rTrxoanvj+6c5lzVZj7dEtFwU nT5s566yv9fKrQKNlICEVeRQxM3M6n9vuXkdFMvOgOk6WJ7wym2CkLm4j/TOkUpXv91GI8 Yp9JVPK7NVAqyyOa+3U6qdk7Iep+Iy0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PDvLwogG; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686751227; a=rsa-sha256; cv=none; b=jDG4BALOWPeOKo/UtqayPjl1rrvyg2poUnhNZaDOodwWLrXUgl7XFGYhFM5MOy64lMHO43 Mhpha5IPSKmVk6+TfQ6cFtq6CY2vJ5lPRaqFZStXeZdHLoSOOEbGxHdchEk6ETKoHk6HRd lTyIFmvXdr5XqN/TO9J7Apb5EQGGRRo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E28C463F79; Wed, 14 Jun 2023 14:00:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67061C433C8; Wed, 14 Jun 2023 14:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686751225; bh=uKraQGeV6CHflKMTQULlWthGg679fqUnVunPDgo/6HY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PDvLwogGgBD7itA4KpDmMOz5f6z6VH2iaHunkUOmJGb2CV9/5MwRPKrP111EYXtEb UEqH+CWzIgF1Rc6XrQFIv/yMpYEmEBGoEuDURlPd52I/fGmF+q5wVqQlIl9KpU5+Uk bgdwaGWMrQOsCsKhPDLR53apMHeHe+9FdmAd1a7miKQKkWiXMpItAY3NijXk99Jluh Pxd9FqKP+sLyI/lOsBPezf8JoB5Fqp5Gg8oE7VA+UHq8nk2Bo7G2Cvf5IS4Aq32CvE s4FZBegGotMSVk+KfyEvDwvHHiHE5HW4dc9hJuLo8yp+W1/X4mVZFqgnWQ8kmzqF33 SBYFIqusV7nCA== Date: Wed, 14 Jun 2023 16:59:47 +0300 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH v4 12/34] mm: Convert ptlock_free() to use ptdescs Message-ID: <20230614135947.GK52412@kernel.org> References: <20230612210423.18611-1-vishal.moola@gmail.com> <20230612210423.18611-13-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612210423.18611-13-vishal.moola@gmail.com> X-Rspam-User: X-Stat-Signature: nogshu1shzd594kp91jey6stj9cdthgc X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2E7FB4007F X-HE-Tag: 1686751226-991790 X-HE-Meta: U2FsdGVkX1/iqw7PsBuZGAeD/yNP7XCPenlPjkc9nIsZxtT0vmipCHe2llTTr+awPOApUuNxCCSQGTtygZFfj9unOpPhI1VHKMvR30IDf82GriR2Dj8fHpU5d79/IGWE1XcxCzZRnNQwZ9UqUzcnlIT4l/93VaLq3XFe5uJr53oxfC/ngnsse1cnH0E41ygAITcTL7LUxDjZp6/M9ZwjrGA4DV7sVjVre9lsQ9sby711rlOU1En9M5vKxFzE1oV5/uwVqRug/u1a1UeI4VpB0oEyKRX4yjQHMM8EGi0TRUdW+uqrRufGkxBbWC7AUF/mLZZYMfZh6mOygJ6EvjgZ9q/E0wLb/4jZIguQhk6HlManVv0OVjA5GwETaZ2k/DoK5VftpS9jyrwNFDuP+AhcE8lcGlnZ8IEH7xPQZNUY3k4WBkyLx2IOk5RHPAKw4nTsLTcFMizAYhxgXJAjluoblevmGxI72PF9C/KNuzWXMreo3duo2mW3ZhzO61bm+M94CESAxUXLNTaUILW2uclV+4HIini3G61gsF/abZFflxctvyc87X9NvzlFzY1jUh4GbOxc9vUkj8FiYIR2ACVTCO0A88Bi6MZWRibz6FkqkTsesZvAebYsDbaqhdqcBO49RzemnDYNuR5LVcG39Yh1J2m54b1DY+rEROJivaKg4BksTkTIT5aSkF5d6uiHNb07nf2Z9ZKO15aAHrioOWObsrBJWxGx71Uo+n8UuNN7y5pN3MjrWZkl4MNHHkggsZitiBiqRYUuO/ATNtdWa8ZbwbCjOXJKOwKIv4Rli1AEsNfbKsj6KDfdlhgMnea8/Lq6K02Slz7iSSq+eY0Rs1EoGX+08gRnVTq1jWTatz8exB5guarKeWab5zsSmYxE6NHdNZv9MkLqGBzxVEFq5gijBuft3PXNpYITMy+mu+r59uZJoTzYfx9aBPrBE1/1cagsJLli/n51v0zj82JGMSs YfmRC2KW RsIs5T7CnS6zsTNvhkcRbWpWc6TPbA2AES1qouSs0IXgZ2ynt3OBUMX/SuLQA/q7d3anyWlrMqBe4zWXOdVfB3N/dxBXBoC/HDMqMyLxbTD61wF5FAe0oy+AgNf+49IDG468ABeFYcx6kU85EEZJsGDKzOvF3K83GcwRJLxuF1NWgufW1a7zvVQ4UcAgdV64XCWVJcOP6aJDDUDaBTQOwCCd8APvixeS58C+VcMqwic41OfRU1kI3camx4ueRGzkxPL5UKu2t+0jbVFLB6zmKPrSkAQ4kmyKng2QB7NJWolF/Z/0lis8sWeRoOBK5ryZYfz09/YSZD2tG/FK0ltnBc0qOsJrah3IkzNj1MtdoQxcx8cbD/5rEEOC+krtj9A2SKpKKc8+V+R1OOIQCFFabrsMZ32uRgW2ksfzDm98kwQlDrnsgyVRZLtsgnHfVGCtU8DuyevkCUfej2HsXYOr5DMFAdwB+kpbexoTk1+viKIftmv8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 02:04:01PM -0700, Vishal Moola (Oracle) wrote: > This removes some direct accesses to struct page, working towards > splitting out struct ptdesc from struct page. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > include/linux/mm.h | 10 +++++----- > mm/memory.c | 4 ++-- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 3b54bb4c9753..a1af7983e1bd 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2826,7 +2826,7 @@ static inline void pagetable_clear(void *x) > #if ALLOC_SPLIT_PTLOCKS > void __init ptlock_cache_init(void); > bool ptlock_alloc(struct ptdesc *ptdesc); > -extern void ptlock_free(struct page *page); > +void ptlock_free(struct ptdesc *ptdesc); > > static inline spinlock_t *ptlock_ptr(struct ptdesc *ptdesc) > { > @@ -2842,7 +2842,7 @@ static inline bool ptlock_alloc(struct ptdesc *ptdesc) > return true; > } > > -static inline void ptlock_free(struct page *page) > +static inline void ptlock_free(struct ptdesc *ptdesc) > { > } > > @@ -2883,7 +2883,7 @@ static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) > } > static inline void ptlock_cache_init(void) {} > static inline bool ptlock_init(struct ptdesc *ptdesc) { return true; } > -static inline void ptlock_free(struct page *page) {} > +static inline void ptlock_free(struct ptdesc *ptdesc) {} > #endif /* USE_SPLIT_PTE_PTLOCKS */ > > static inline bool pgtable_pte_page_ctor(struct page *page) > @@ -2897,7 +2897,7 @@ static inline bool pgtable_pte_page_ctor(struct page *page) > > static inline void pgtable_pte_page_dtor(struct page *page) > { > - ptlock_free(page); > + ptlock_free(page_ptdesc(page)); > __ClearPageTable(page); > dec_lruvec_page_state(page, NR_PAGETABLE); > } > @@ -2955,7 +2955,7 @@ static inline void pmd_ptlock_free(struct ptdesc *ptdesc) > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > VM_BUG_ON_PAGE(ptdesc->pmd_huge_pte, ptdesc_page(ptdesc)); > #endif > - ptlock_free(ptdesc_page(ptdesc)); > + ptlock_free(ptdesc); > } > > #define pmd_huge_pte(mm, pmd) (pmd_ptdesc(pmd)->pmd_huge_pte) > diff --git a/mm/memory.c b/mm/memory.c > index ba9579117686..d4d2ea5cf0fd 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -5945,8 +5945,8 @@ bool ptlock_alloc(struct ptdesc *ptdesc) > return true; > } > > -void ptlock_free(struct page *page) > +void ptlock_free(struct ptdesc *ptdesc) > { > - kmem_cache_free(page_ptl_cachep, page->ptl); > + kmem_cache_free(page_ptl_cachep, ptdesc->ptl); > } > #endif > -- > 2.40.1 > > -- Sincerely yours, Mike.