From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 552EBEB64D8 for ; Wed, 14 Jun 2023 13:59:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E188D6B0071; Wed, 14 Jun 2023 09:59:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA2398E0001; Wed, 14 Jun 2023 09:59:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C422E6B0078; Wed, 14 Jun 2023 09:59:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B4A406B0071 for ; Wed, 14 Jun 2023 09:59:51 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8A298C0680 for ; Wed, 14 Jun 2023 13:59:51 +0000 (UTC) X-FDA: 80901511782.11.F795896 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id BA1E8120012 for ; Wed, 14 Jun 2023 13:59:49 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rB5cuxD7; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686751189; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rvn6GyCJmJQhtvnqPw0W/soNxGagCGUaitL1eaYiy7Y=; b=7ASILC5ZNae/Fgwez44BhIfvcKOIsDTPAEfsl7Kk7yEGPvTupp2VzON1/Zd++HB/+ZhDN+ YRgx15V89IDAGDpCuWHxNHaAMHnwkBA/5kYGPmXHV8/zxvvtbLj3qnvWqi9VO6Bx6kWG9f vllhH/ASzJ2zGd7YEDxenNt6O3yw6m0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rB5cuxD7; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686751189; a=rsa-sha256; cv=none; b=lUkcwi/bxl7vN035dhrMp6moGuPi/HDMARnP+xUfYeJ2sswi6LRz6Kdg05oxewslbNyd9h vSXl2OOm5rknbgtjMtbHTu89D0tCd0Wh6vXuSwnNqahRX32/9H+r1MsyC1jrtofNCNjCEt X/6XlvMzUlXE/JsMrE8Ptw87NC+5f7o= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D676263914; Wed, 14 Jun 2023 13:59:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75DD0C433C8; Wed, 14 Jun 2023 13:59:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686751188; bh=bczNeLQKsA4Jn/cyv5Zpe2oQqQ9DoTlx1RmcfxuzAiw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rB5cuxD7f+pVV/2kNGOgyZm/CMnI+FrUzScbpb3WvoAusSUJT4mgiOW93EX9McJH2 FhTySbUNTBv9MPhFHuVa5nuJ1XZTkWt5yRSSUAhZSNmRhZbJ31odisGjIKfu1++lsZ CH2YOx06YFt56y6ifO55IZUoGHHh/jigUaNtJtYKTg86qZrpU96rQcXjsvJGzQn/kn YLwGgJim4snk8fpaILSaD4wUTac4kDSaDw7wbBi0N7ZYhBsLDqm0a86c4hplOXMBZK gjGoFTFEI0ysZIaZZuOB0qrBTQ+cGwB5XLuAStdydY6oCdalsx3dIZVfFXIzN0yL0V 8u2LU4VeWNaSQ== Date: Wed, 14 Jun 2023 16:59:11 +0300 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH v4 11/34] mm: Convert pmd_ptlock_free() to use ptdescs Message-ID: <20230614135911.GJ52412@kernel.org> References: <20230612210423.18611-1-vishal.moola@gmail.com> <20230612210423.18611-12-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612210423.18611-12-vishal.moola@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BA1E8120012 X-Stat-Signature: yftmkn19fo69iojnw5jcomgoto4c9jmf X-HE-Tag: 1686751189-975573 X-HE-Meta: U2FsdGVkX18pUTx+YOAzCYCFDB31kYqk0WJTz1JzlkhAwN10hVCo7AMj+ii6C7R4ZCuIBOgNhxQEeFk5NOrUL2WGm1rSEB+HfoN7lgDIguY60wSLa4vx2M8VMjJlNATTFtneu6cs6UScYUl2p2tyPuOz6x2PisKPqcbDcz7pUzjosbaYtXVnzyyMhDHYiBWJtW0VZ0UGYBff5kKAxJ63bpccgIq3cgmO/nIVk3O9NSuf78q8tq3yYDnu4EsFBoXJ847YjisjGHJQdIYHtZuBR14UFaZdihmncu1iUFkFdy/GU+TVT0b5Y7yMEVEvjwwmrUtP8mUP6FtoxW7HtkJ1LJTWY55vriY06jvq0oz6Z6DjqZhVc+mZMCeZB1KegIcr3TZ20DKIjHWNqe8stGpFORLcHbgRa0SIfFlXE/kw3b0xC6UU9WJ1tiDlapN/6pvvE+7/MeqLeYAOLNj4SprLVQx2/HFhFLFrapANaTYwWZmoK25r7zCyDnbyd5OTO1SKC2u/HuX57Dx1vV/Efi2G9VZRnW7vQduumgAgtfZ1eP60VXCglWyPl7KK7zlpxiM6Jv8gW1zzvCN+GB8MsU2d3EsGin6zWmmbSz0W4lTAMfm6XRHmgki8fty659gF2KT/lSrEVN69dUND44UIzIMRMvOqox5MRs9/iqsF9xLq7/yEGZTaRuDFCvQDtbSMpJIT65qtTxAB4BTFe21PbuDMfU7uRwfglJVKY/ja2Pd6Ncc4jSdiAvxc66B2CMEIXN3l2UcQcfpPQ+LDEMTEAwNNf28TDE4pAf04SXN1cW7hCpGoA2ja0/7quPnH2EUCJbt5i1REeTVIKiGv2GwwPyQUy8oE3sjqabRPB3472ouVF+uC1sh7TERnKPp5/vGamsxue4cjU6rUQXBl7v7B8ZVpUe4L4OLWryIIp/V1gCO5cUt0EG6SOApEP6qK/IoTbtivCDgvCdb3WA+jLPMTJ7K /xgwUwJi E5svak/Ktj0IrLSlNMuuyGxgMHR6JCpey//40pvnlWzNsz4cRwvoQxRUEPH7E4WRIp341AEOw3XVk1BfkwLvM0HZ8Izwoz9KdyB8iMcZ1qK+9JHX0IeBu/sAUSJsWhBQ308dSjFPuMmG8ZFl3r8PpFLpytPywbKxtCL6RSPfaq2nUdGNK3fbr5FNut2Vw8CqYswyMu2PXoE2W/g4SudPw/31a6T/8Sfd521mg0sl83Tk70na0Y32uQpsq5pip45PE+8ZPZDNN/tGpvZlss2LVCjD6/T8OWrLedSPNzA8uSKgH9vH9jMDlORfH8tIARFkjL/gdMFKIW0brJJHCihHhu5FBUGD/XfMO54o+BEBMxUs8BUYtsRbjcPRr410WPTwUyU2p/BDRlwnkdrGdvle/m+gafmERP9k2c80W+4grKDN/iExVkRMSBOwIm+streuIW8/9Su/1jCrP0yEidQLPQn1JEp+pD3t9/ouCrixHfeFOTlE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 02:04:00PM -0700, Vishal Moola (Oracle) wrote: > This removes some direct accesses to struct page, working towards > splitting out struct ptdesc from struct page. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > include/linux/mm.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index f48e626d9c98..3b54bb4c9753 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2950,12 +2950,12 @@ static inline bool pmd_ptlock_init(struct ptdesc *ptdesc) > return ptlock_init(ptdesc); > } > > -static inline void pmd_ptlock_free(struct page *page) > +static inline void pmd_ptlock_free(struct ptdesc *ptdesc) > { > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > - VM_BUG_ON_PAGE(page->pmd_huge_pte, page); > + VM_BUG_ON_PAGE(ptdesc->pmd_huge_pte, ptdesc_page(ptdesc)); > #endif > - ptlock_free(page); > + ptlock_free(ptdesc_page(ptdesc)); > } > > #define pmd_huge_pte(mm, pmd) (pmd_ptdesc(pmd)->pmd_huge_pte) > @@ -2968,7 +2968,7 @@ static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) > } > > static inline bool pmd_ptlock_init(struct ptdesc *ptdesc) { return true; } > -static inline void pmd_ptlock_free(struct page *page) {} > +static inline void pmd_ptlock_free(struct ptdesc *ptdesc) {} > > #define pmd_huge_pte(mm, pmd) ((mm)->pmd_huge_pte) > > @@ -2992,7 +2992,7 @@ static inline bool pgtable_pmd_page_ctor(struct page *page) > > static inline void pgtable_pmd_page_dtor(struct page *page) > { > - pmd_ptlock_free(page); > + pmd_ptlock_free(page_ptdesc(page)); > __ClearPageTable(page); > dec_lruvec_page_state(page, NR_PAGETABLE); > } > -- > 2.40.1 > > -- Sincerely yours, Mike.