From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACF18EB64DB for ; Wed, 14 Jun 2023 13:58:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B9056B0074; Wed, 14 Jun 2023 09:58:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3692D8E0003; Wed, 14 Jun 2023 09:58:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2574E8E0002; Wed, 14 Jun 2023 09:58:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 198E66B0074 for ; Wed, 14 Jun 2023 09:58:33 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id ACFD016064C for ; Wed, 14 Jun 2023 13:58:32 +0000 (UTC) X-FDA: 80901508464.11.3E27F46 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id DBB98C0013 for ; Wed, 14 Jun 2023 13:58:30 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lSDu5H7K; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686751111; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2TU2U1Li5JOFHjTHO5/wUPcfBstgrRbciTjslZZFv24=; b=JokOHRb6KVWYmRKE/JD3/ptRvgqyFr61/tXuOWAtLdFIiIIWOr1pw9LmPLSf1ceapJNGXB cuuljV1E5ZQP79EiBQD5MHZe/DaUk6T3Qi3bkCFhcK+gf8j64pdryi2Ow1t6owi/EnFn08 LFtFVjqTMT4Hr13Ek6ADJxiIVXwiuRs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lSDu5H7K; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686751111; a=rsa-sha256; cv=none; b=nd/dk6p5r75YoHZeFvgi/oE4lytwFdWen6OHyjnrqiVQ/86qo+bKTn+IglnndWXA5lFifr TVuWoI2l/af0U0YCFlKCx9vbCenPKDneccO4jOT1/Fzraij0f/6Ce/mmFLo37UxrutouOR 7Tb85+lzKtkxYfuNVjVKRrsXqcOwVqM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C25E463EA8; Wed, 14 Jun 2023 13:58:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0141C433C8; Wed, 14 Jun 2023 13:58:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686751109; bh=zODqmBJZryq+bXrqw2+dO7/Egr05l6EFGh7EoAR+f5Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lSDu5H7KOZKMWJOQe/RZf66XvE8x+eCZ2Ytzhs66p+GHx+ddxnclpSnPyGBBVOC05 kntWJ9TrG8h428EjebftgV+rAv2YXAhTb0cmqdcy2uTjvuT0Ga5hGuS9drSzCT7vEe lZBUTVYDwjRpPWR0zfBUHmtTwZ2dHpcIOTvlm3uWIc27APHLBBUO1V3IJqvs3/W4hf V4LiUm2GDpkcLNAf56LDxlLuEAL6oO/16Aw5vUDA8I/ZMKz2QG0XPQLr9Bk8rgf5Zl R9Y5FHwwoN9JyP4cz6UUoLxJJznNWVeOmwWxNxC0W9lJyus9Kc2Q39K0WgkNq1Cbbd +hjJK6ETZawtw== Date: Wed, 14 Jun 2023 16:57:51 +0300 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH v4 10/34] mm: Convert ptlock_init() to use ptdescs Message-ID: <20230614135751.GI52412@kernel.org> References: <20230612210423.18611-1-vishal.moola@gmail.com> <20230612210423.18611-11-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612210423.18611-11-vishal.moola@gmail.com> X-Rspam-User: X-Stat-Signature: 496wikb741smaztr9wwyc5pxwcs6bxn9 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DBB98C0013 X-HE-Tag: 1686751110-248906 X-HE-Meta: U2FsdGVkX18o+mNQ+dT45Pig2LfZZ5ePdyApqUHE1Q0/dimOVFlQLBhxM0vOr3lDhPtXQPwSlCX15cAT+Z/3AgYXTL1oqvCM1ZaMRFg4yaQ0v17UxxX3lyRDPgRfPOLV6sfDMW3zoxTWhX9KhZzgnIupD4fQcwni7vfVyb9qCp4hmsq2CEO7A0FT/q7qkqJI5BWiWlYRxY3gK4BS6mHXd9y5UipWfk/CXYMBZJ6IEz5Gl0rP8auw81Ie060Z/KM0UAOXtql4QQUjKrx3hPRGvbkzC31h5HVfKdcVqWvZyH4NDPw+3oXjD6lnBr9SeS1cj5EPywtQQ/G7466q7So3KgYzk3hEHtiQE/ea5oXmBbPHV0dIaenTVG98m3uE/TpgcSUC9w3FkROQZ4sHUY3NziOgQQ1XggEsc1yeHuoHpeZkR+gAL5i5pLUe40H/SNkw+WqQj923Ni5WbVloXWyf4fMN7mdLxc0pRfIgWkvTpSsJ5D5j/peiXb4kUzrE4SpKvcBRwa4+vZ2QtlAS7/f2fYVtcxBXD0PCaoO1PMQxJms3iWKUJIkfbIInppWAtMKwXUeijHsSLpzWNJv9AoqyJp+ztQQJ6Mosfok5ifTa4TxMdEv4BiQD2MjkVHQJ61R+TD+OMkk+vxISXkiYXn8V10aq/wTz4zI5+stUEdcGeCMDqN1gDJ1ryTt4kLrlALq956re7O/MfDgkNa6nxEVLCZrwYui3zVp5p/DN3tpUxud7qBqOnbLiEvokedoSBv+TLylv1DgpWm1wWM0sczrMHs9hFkl3snnOw3xEXLveb7tyMmrjWrcn/6ctQxvKXAYAVCIUgIuIVVQs+4pKT2FAgxuaFdk+uxFshDW5h9nTsqJMAA1XDXTBNwrAVPaYueqiiDt0ej1Xu0HH7j6Wb/Imdil4odu3YN0TfYY2Nq0Dl6Gc7rTnMaAAxRab9mm8EHMWDuMnw/oDguECbyLJgWF FYirmWUN syL0zSOYS+UhR21Q43um/WOhnOmlrR54YI+bXD6MbBF/7VXtXYs/PZYYOUsMivSHT6CvVqehMr1ubxGpcNiqz57HBtK6cLwrs25XHEYyqSpnwwM18e+veaqC2WwepS/RchJBuazFc81b+Q6iqoi26wTPDjuGna04qEZO9CsWmmluw/VVjr94Hl8IXjzPyuJ6xg2gtBNnmcqngOY68ogswhmtnSX22yUHE2MrjoVqYKwAWQ+uxWbW7123D1wQtTnbrMu8NAaG6s5Bq8VLNtK9BgLGZ1gTFrVWL79awqB7PX5zeeJ30li/ITdSUDtwAU0kV3L1QgbtbaMM50qV+B02ZnbRk60nHukvXQ5UPCmvhsPkrQvGR2mtxjh4boQ4NQGZJXP6vmE2n+uzCm7Y0Xs5LXg7243U7VGqok6EvB3V6GdpazII07Av1i1YeCs8x91rTO1etKzg4OOaCqj5ElMxIAbzVjjCl4kBB+3QW2kPGs1ZNegw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 02:03:59PM -0700, Vishal Moola (Oracle) wrote: > This removes some direct accesses to struct page, working towards > splitting out struct ptdesc from struct page. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > include/linux/mm.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index daecf1db6cf1..f48e626d9c98 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2857,7 +2857,7 @@ static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) > return ptlock_ptr(page_ptdesc(pmd_page(*pmd))); > } > > -static inline bool ptlock_init(struct page *page) > +static inline bool ptlock_init(struct ptdesc *ptdesc) > { > /* > * prep_new_page() initialize page->private (and therefore page->ptl) > @@ -2866,10 +2866,10 @@ static inline bool ptlock_init(struct page *page) > * It can happen if arch try to use slab for page table allocation: > * slab code uses page->slab_cache, which share storage with page->ptl. > */ > - VM_BUG_ON_PAGE(*(unsigned long *)&page->ptl, page); > - if (!ptlock_alloc(page_ptdesc(page))) > + VM_BUG_ON_PAGE(*(unsigned long *)&ptdesc->ptl, ptdesc_page(ptdesc)); > + if (!ptlock_alloc(ptdesc)) > return false; > - spin_lock_init(ptlock_ptr(page_ptdesc(page))); > + spin_lock_init(ptlock_ptr(ptdesc)); > return true; > } > > @@ -2882,13 +2882,13 @@ static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) > return &mm->page_table_lock; > } > static inline void ptlock_cache_init(void) {} > -static inline bool ptlock_init(struct page *page) { return true; } > +static inline bool ptlock_init(struct ptdesc *ptdesc) { return true; } > static inline void ptlock_free(struct page *page) {} > #endif /* USE_SPLIT_PTE_PTLOCKS */ > > static inline bool pgtable_pte_page_ctor(struct page *page) > { > - if (!ptlock_init(page)) > + if (!ptlock_init(page_ptdesc(page))) > return false; > __SetPageTable(page); > inc_lruvec_page_state(page, NR_PAGETABLE); > @@ -2947,7 +2947,7 @@ static inline bool pmd_ptlock_init(struct ptdesc *ptdesc) > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > ptdesc->pmd_huge_pte = NULL; > #endif > - return ptlock_init(ptdesc_page(ptdesc)); > + return ptlock_init(ptdesc); > } > > static inline void pmd_ptlock_free(struct page *page) > -- > 2.40.1 > > -- Sincerely yours, Mike.