From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99994C001B3 for ; Wed, 14 Jun 2023 13:53:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D0818E0002; Wed, 14 Jun 2023 09:53:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2817C6B007E; Wed, 14 Jun 2023 09:53:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 170088E0002; Wed, 14 Jun 2023 09:53:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 094E66B007B for ; Wed, 14 Jun 2023 09:53:18 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C8585A033E for ; Wed, 14 Jun 2023 13:53:17 +0000 (UTC) X-FDA: 80901495234.09.5DF6FF7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 1B7341A000E for ; Wed, 14 Jun 2023 13:53:14 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TGto5Dvi; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686750795; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gwMZJlpdGzxDy4JDU6mbpXg4kDb0oG//pvjsL+BGl8Q=; b=RZwONSQXO/IKv9Qgb4ztmZAt0lOpwpb6D4vcL2VmXAqjguXggQky5IDS18BeHMQXA/W5H3 F9A0XueDJtB6g7PMESRQfcreBvc+4FfA3C/9MtalT8lAivvp4AT1/NgRHTS5R2muu1vUhX 2LCWSo/b7sRujqCrOz+e9Of7GOGLs9k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686750795; a=rsa-sha256; cv=none; b=GqERnoZKTcPcmHcpXe33YcyEganC+pHT+5R5k7BcYndihbqQn3Uc1L++4yupFSgb+832en sJPypylJYFF8fULo7jZ7XTV+TzRX0jseSc4YKc79nsknR43UKMYuxph8JbaIHMw4LxtmfX dCpS/0kTB/0ip+9woHTCaDM+I6fgN2w= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TGto5Dvi; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3128961F1E; Wed, 14 Jun 2023 13:53:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36061C433C9; Wed, 14 Jun 2023 13:53:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686750793; bh=i+dWwopS2R2pjDCoeERaU9nBu0jCYzS/lwxwHCWXb4I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TGto5Dvi/HN8fU/LSHI/Xe9mWSqjuoMuAggxIeDsDpSdGjOz+OD5Q61dYnwlfUI2u 12eC8JWZkY3dBTcv69CxtYmzohm/TspcjrDl3Zxm+eVFHQ1BuvWvblYU6lS5nHTdB4 4jgzdRwk6I0iRkcg+lC5rT6e/+Zoj8O4Z4XMzKkrAI3Xrl//xHCT0oSrSqy8qzE0DR HFjNZU76vrLc90NskBD5ZmADqSbItjU5wL2oiacXptUySDzj5MWQp2048o6t9bgjHk 3J9d7i2fEQepFckTIKlCANmHRPvvJQeN1+/+mCtl5JH8j+CkcnEmQVaXh28mzw5CiW A7drC/yoaT/Vw== Date: Wed, 14 Jun 2023 16:52:36 +0300 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH v4 09/34] mm: Convert pmd_ptlock_init() to use ptdescs Message-ID: <20230614135236.GH52412@kernel.org> References: <20230612210423.18611-1-vishal.moola@gmail.com> <20230612210423.18611-10-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612210423.18611-10-vishal.moola@gmail.com> X-Rspamd-Queue-Id: 1B7341A000E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 9gi1x3brzhac5hhi73brgqtosqdazpn1 X-HE-Tag: 1686750794-661596 X-HE-Meta: U2FsdGVkX1+oUDiP9Gs1hJlTc5g1T3W5bYh0wzO52zBMG54qoL7EuTYLukFboZ8tcSsiG0rF4AMGrD5K+h+0iix3wHtgt9nIsb6wN+jKeMq3Ho/vAAp9ImtL30IrQD1IPmhtA3iUzQloliKkb9kNLU33NkF/ttiI+KPJm+kqKmLvKq8Z8juOYuLiLo/WtlDEymM1nWBoDQiFygGrgBBmGALlBBSqytpHvP05Urly2ppe2s4pchVT3yyGn86Zs0MPHHYGjzvEoQFsnmoe51b0MVgq8cv4Oy7LesEDBFgGFT6ODLX28Y/QzSkXz2xRg4RGebdqi7OTKkTZVbvVOJ8Q4YtyDQqjGWLB72CMtG39YDHq25L+I/uhOrV+2EPS8Bboe9osmJ3/NGS83WAIjDkjYxP1w0vfMv6/GTJuvKJJt+Knl+ABpnnilsKLkLbWXGlmuYlKfTyE+fZtOsPEmmsDVDUz6BfEQiR1zkkk61vnLHbrAbxvApbh/bTZZNX1GXMqaRFUPX8Y74BCNSfS+oxwTY0BJbtCKri5HIVKNfWs4kjzUKDrWLNXmD0bB7wUMUtM+poAz/tdatOjc3DIiaFWHkXXdWZiBAyND7REaH1i0CWYjkeaNVBUp8X7rHHKG748AZ+X5CHTcz7Fd6CzOiGp3jW4WZuc8WM6CP5Pr+/M+DPMqfVj1bjUHYzuZt0ejv6+ht+gNXRHH0XIXqswXdVe7S5AQ3gyNQTveCG1FGs1uYQew5fTQXykxKQsBZl1Y+mLIh6CIPTWVILWZA7/gBBE4hWxMVKW9gUYzzXuDFxvv2Zf56czcyf4HM3AcFCZBNZ6wEr9DMqHzIHqtRA0q7butBS0mZfy0iWr/ym17gwgK5qnuhPNe3MUMie1Qesr2kIt1jGT/KIPdw6A9IY0zZ7KNOyt8oxMYTo7EmKr68HKeHMcTie/kIgXgR6SN7InOEsI66qdfZr2n6Ld3GJC6t+ VtfgoXUY 9Gfh958oi1PDkPOygOT5FrG9B36ktJCMu14aSbR4iBOKEOEP7uTdrtMcVtenRJ5ozEDf2HixcXrvNQ6jiY2+mC+D9F5S2tCMKW0in7xhZpQeYkuiViMjR625tg8db4XA8yaYKbuXoC5mnKntIOA2vsTrNaQ3vs91iOjza8JIMyEZpWWPB15DeM3fIrhcmNkBp6yJXCmuqiBJXqnxZeNTQkzSUmJYoBNDywLIkBm4jLqNMwBWyRS4T7rru+Fhc9Rpr+qOfDvo2dVxkBsnZUiCGVnfKW7yCXAzON0X0j3dvxi/3TEZj5MzJcadYMj+eJTob2sMFg+55BHQusaNfDW2CVkTRJcCnJft6j8v+KlDFU/93GhSKPZN0lQNhQhvR83o1iM01zu4mWCedVMXKVRX0sP/i/TaAzfBMMYgSD96xkMgVefyHDkbHCda4ZY2+yeXjEShIvD2fKlTWIPFrSiJjFd1Lron+duXYsfdBAFZ706JVMqU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 02:03:58PM -0700, Vishal Moola (Oracle) wrote: > This removes some direct accesses to struct page, working towards > splitting out struct ptdesc from struct page. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > include/linux/mm.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index bb934d51390f..daecf1db6cf1 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2942,12 +2942,12 @@ static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) > return ptlock_ptr(pmd_ptdesc(pmd)); > } > > -static inline bool pmd_ptlock_init(struct page *page) > +static inline bool pmd_ptlock_init(struct ptdesc *ptdesc) > { > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > - page->pmd_huge_pte = NULL; > + ptdesc->pmd_huge_pte = NULL; > #endif > - return ptlock_init(page); > + return ptlock_init(ptdesc_page(ptdesc)); > } > > static inline void pmd_ptlock_free(struct page *page) > @@ -2967,7 +2967,7 @@ static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) > return &mm->page_table_lock; > } > > -static inline bool pmd_ptlock_init(struct page *page) { return true; } > +static inline bool pmd_ptlock_init(struct ptdesc *ptdesc) { return true; } > static inline void pmd_ptlock_free(struct page *page) {} > > #define pmd_huge_pte(mm, pmd) ((mm)->pmd_huge_pte) > @@ -2983,7 +2983,7 @@ static inline spinlock_t *pmd_lock(struct mm_struct *mm, pmd_t *pmd) > > static inline bool pgtable_pmd_page_ctor(struct page *page) > { > - if (!pmd_ptlock_init(page)) > + if (!pmd_ptlock_init(page_ptdesc(page))) > return false; > __SetPageTable(page); > inc_lruvec_page_state(page, NR_PAGETABLE); > -- > 2.40.1 > > -- Sincerely yours, Mike.