From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A557EB64D8 for ; Wed, 14 Jun 2023 13:52:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E69976B0080; Wed, 14 Jun 2023 09:52:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E19B68E0006; Wed, 14 Jun 2023 09:52:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE2558E0005; Wed, 14 Jun 2023 09:52:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BBC226B0080 for ; Wed, 14 Jun 2023 09:52:46 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9CC55120689 for ; Wed, 14 Jun 2023 13:52:46 +0000 (UTC) X-FDA: 80901493932.09.5E74DD4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id E84C0180013 for ; Wed, 14 Jun 2023 13:52:44 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WTLFY5L6; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686750765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SdwAs+x7VArfbSgwgU4x4+UjZFlaFtujYlJ1NrU0UCE=; b=hzT4kLM5gN9U2zxuf3DGPyC6LPVenoWKEjnynZlHvrf0JA9kxu7AmqVZv3gcucvIR0yp5P eM4aLR+WwLl/MeAxrkfqRVusaxG0e+B2pr1ZPOfnuJsccwiZuW7Pa4ND5qIIoEyttLWAFy Ydow2lawgl/JWyuNyk0QbV6o7QnhuGk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WTLFY5L6; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686750765; a=rsa-sha256; cv=none; b=lqkf6JcsYUYPVUHOOhAbTvcKKsG7EBFO+DYRH3+quFUK4cMgrDUAsU9RKGlbZrhOhAkFs5 JRY6bs3KlccUgz6/Z5M+h4O9GctUUZMQ2qgR0e7fHnbMo/CY6um85cSGj+/ocPYvHRdFCM M+1Pn/qTbh58rNizFW5UiHu7vX0oa7Y= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0070864287; Wed, 14 Jun 2023 13:52:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA10DC433C0; Wed, 14 Jun 2023 13:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686750763; bh=Jr1CjE7x6zZhqlD+PrxSeOCGxWprISw499VNjITcty4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WTLFY5L6mnlqfGDyFTiH9jqq2FKHmRtqRnjsTj1RSarSSy3AxLfMgUgjr8wGlmHBW ZIyTwYSaSC1laCUlNWdYFX2P0Vpo5Cygx+gCIcavFIbmFA7gdFkAZSMhEGMMgWmRbu 2PIwOB+Zm2qIyVb3o5W9j04IHSX7uWkmLNNjNW4pTo0Uj3+m7MBHT7TUhTgbQveuQG 8Y13PY2/OBFLWcieHZ12iDoM6RLDamAU84EbiDa/rEeH2lt3RpONvk9+fHWXJncK7b 7pIkWK95aM9sq+JHpbXwyxHzzP/N7RDgJmdalD7vC2ycKfkQ6ox4Zo04K9yfj/x21h HrE7P9YKzVHGQ== Date: Wed, 14 Jun 2023 16:52:05 +0300 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH v4 08/34] mm: Convert ptlock_ptr() to use ptdescs Message-ID: <20230614135205.GG52412@kernel.org> References: <20230612210423.18611-1-vishal.moola@gmail.com> <20230612210423.18611-9-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612210423.18611-9-vishal.moola@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E84C0180013 X-Stat-Signature: u8khkxb391aq1nrjab1m8d6u3t1wyy53 X-HE-Tag: 1686750764-326508 X-HE-Meta: U2FsdGVkX1+0GWIdxm7Ta0DQmR2RTtBpNhKr5urFwKUIlyT7Vh0Mk1WJGxK98C8jpCtkDzQZgGs1YpuNxPSGATx55M587r5o8Az3X4pteP/kugPXytHh4ngfvHOGOgaHzaXhHWLwXqtEjLP8xaLpUvFDrwGsX5oXPhN/KNbrDY0hXpJgFL/lIDBt4g0Xr34uzOU93ZhRUCxj9ifRtCX+XRg8ffz0UDy/Ln46BphudusfbbuguLbRDyfG3tKVCU3qBa8/fVeeSenfZVx3HhNBj/fW/JRj/7FQFpBYBpqJltB5VmuSno79AJP7QDc6PaFqTAnVssBPqNNJNKLYAYP95uwwnjkTQAZAiitTIHljHjopgO6S4eetvSKS5G2+onWNIVUL40KbBnrQCI+nRdfG/zOdOvW0CdXdEM+k4rfCZU3LA+21WpY3b5+HZVwvMtRqmmKtP5IihxPwfG0RlJ+95hEJNbZ/CxCbIt2wxLXu5Y60F/Xt4l5nns/vv4lSXm85KgKbQK1zSM061KmmbE+kzWoOvUhvoejWF17ZV+x8i89RgUfCSxuq26WgsEyupgDClrBkXo2mli/Yyu945oOWScuMsl9U4XN5+pxiOmHSc4sISeHVku1etchaeOUuZTgqGAu525oxgpwZtz8A9h/PryRhjw2QhA6Oacnv6LTUqKtof16XmfYEMgoTjZIjSLIH4JquQcEC3pm9iYv9lpQCrhR7KKg66vljLNfuLJC4tcWQfef25ma9JzOZy6k+mGA2gJQTCBzMEcFR3SdlSQ/F7JHYk9ZQKpAPNvOQfReCMfQ14JP4uBlXv9BiiLd1O47NbTxdGKA6/fxOxPM8dNSHl35to9cFX6icalGnOe78+FI8jnK16F3pS2Lzb1IXhFRhyDE8sf2W/yj4XVAHvC1mG+meXNfjzHq6teqxQh3zcEcVPfV9n/DK/HwwIYY2T+2z8v525eTa+oRvcKRKPD6 mrEfckgl Ols1J1ZDStQ/WaTLl+gHnEBkW6SrQfwX12ZSHEnhWFU+8YmIDNnRPZxZf99GeS0upnrg3lxpiRVQRFsPeYj2Pb4+NN45bY94XYVs/OERqmwvUXZ8FUHDaa+gSB2c2mHVvFObmjtvIkIW6PPhryhm+Wt9N45wZFsT4O4Bn2NTUxXnDl3IFP7lsn56CH6c3ahbFUb+w08HriCMSS8xdhS6cD5/hS2+s7KSL5LoSm9e3MOOmhTJFif0ofRke0v6zgZxKKrFeXIdX0VJPz9UpdFlUmzW3TMDoOf/Hdzj+wGL0G7c0TGt+gY2zlLe6X98Ik3NVGPvJB09mbc9jPyf86LR6/nt2sFra0kg5++PUCDytozurSuXESVhDTG6NKIg3SnP4ZDDvw+e7FRHVCxnS5LFSgrPIT3CgOPQJPyEBeixhgiHUK5mSdN7m3PuohD8Y0/LA9hxhKw6SwujxrvCs65GwUgSyUYd2wnexTqzLvIHcl/7sA2o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 02:03:57PM -0700, Vishal Moola (Oracle) wrote: > This removes some direct accesses to struct page, working towards > splitting out struct ptdesc from struct page. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > arch/x86/xen/mmu_pv.c | 2 +- > include/linux/mm.h | 14 +++++++------- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c > index b3b8d289b9ab..f469862e3ef4 100644 > --- a/arch/x86/xen/mmu_pv.c > +++ b/arch/x86/xen/mmu_pv.c > @@ -651,7 +651,7 @@ static spinlock_t *xen_pte_lock(struct page *page, struct mm_struct *mm) > spinlock_t *ptl = NULL; > > #if USE_SPLIT_PTE_PTLOCKS > - ptl = ptlock_ptr(page); > + ptl = ptlock_ptr(page_ptdesc(page)); > spin_lock_nest_lock(ptl, &mm->page_table_lock); > #endif > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index e6f1be2a405e..bb934d51390f 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2828,9 +2828,9 @@ void __init ptlock_cache_init(void); > bool ptlock_alloc(struct ptdesc *ptdesc); > extern void ptlock_free(struct page *page); > > -static inline spinlock_t *ptlock_ptr(struct page *page) > +static inline spinlock_t *ptlock_ptr(struct ptdesc *ptdesc) > { > - return page->ptl; > + return ptdesc->ptl; > } > #else /* ALLOC_SPLIT_PTLOCKS */ > static inline void ptlock_cache_init(void) > @@ -2846,15 +2846,15 @@ static inline void ptlock_free(struct page *page) > { > } > > -static inline spinlock_t *ptlock_ptr(struct page *page) > +static inline spinlock_t *ptlock_ptr(struct ptdesc *ptdesc) > { > - return &page->ptl; > + return &ptdesc->ptl; > } > #endif /* ALLOC_SPLIT_PTLOCKS */ > > static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) > { > - return ptlock_ptr(pmd_page(*pmd)); > + return ptlock_ptr(page_ptdesc(pmd_page(*pmd))); > } > > static inline bool ptlock_init(struct page *page) > @@ -2869,7 +2869,7 @@ static inline bool ptlock_init(struct page *page) > VM_BUG_ON_PAGE(*(unsigned long *)&page->ptl, page); > if (!ptlock_alloc(page_ptdesc(page))) > return false; > - spin_lock_init(ptlock_ptr(page)); > + spin_lock_init(ptlock_ptr(page_ptdesc(page))); > return true; > } > > @@ -2939,7 +2939,7 @@ static inline struct ptdesc *pmd_ptdesc(pmd_t *pmd) > > static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) > { > - return ptlock_ptr(ptdesc_page(pmd_ptdesc(pmd))); > + return ptlock_ptr(pmd_ptdesc(pmd)); > } > > static inline bool pmd_ptlock_init(struct page *page) > -- > 2.40.1 > > -- Sincerely yours, Mike.