From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3F24EB64D8 for ; Wed, 14 Jun 2023 20:13:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E28326B0074; Wed, 14 Jun 2023 16:13:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD8356B0075; Wed, 14 Jun 2023 16:13:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC7108E0001; Wed, 14 Jun 2023 16:13:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B93C76B0074 for ; Wed, 14 Jun 2023 16:13:10 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 936DEAFD8D for ; Wed, 14 Jun 2023 20:13:10 +0000 (UTC) X-FDA: 80902452540.24.C68E3EB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id CCDF520026 for ; Wed, 14 Jun 2023 20:13:08 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NQCNj+8w; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686773588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bHnC6LrdFYrLmHEm0y+H19UJ4mnKr64q0kjMQAM4r6g=; b=rnZZfne7LXpwPeiHiDQIbl7sSSdEaTiW8LLoijkk2RJ/YE06OzxFrZ6WiClTijMZu7OE2R XHywwjmlftRyFOIOtF1Bq063d9Mj1RsCvsVzRLvjxcmbkX0BKWqGFWTYO9ODqkcYk/M6nV ew4HxUec336IgRYOiXU0zTl/RoCAtOs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686773588; a=rsa-sha256; cv=none; b=hNhSU20AsHW3tji6HC7lJ968e/qDYQn+hs9KyjGCh7Gzg4Bi5KH5HsfDihWrLh6iJZl5Xj 8VWMcrTlLy5Nm2ijgBJYdGp42/Nm1mShyrr2zoH8bEyd8t01bApq9ew2b7xyujgDPzvEEt ynAZJ6VFBrrLfauovsO7NYzZbiQtydw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NQCNj+8w; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9C6E46256A; Wed, 14 Jun 2023 20:13:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7E77C433C0; Wed, 14 Jun 2023 20:13:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1686773587; bh=xsZ+CWCKRyyxoauUAGpvrlkFZGcwS9pzZy45t1pr7+Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NQCNj+8wWyzL0VK5qxblXRl20YSA07UqvKcqVNcKqqGwEGQTdOVB7X/LkVH2Dzzgl 8QkGo05FE09NFsLynbICBo68HGw/G/jsmkFkJklcKpBW0vhALzvo8y+EKmi7w4lY2P kIfyXcQUtTuHEyIjwH3FgVOp67OudcY4y6sG9l+o= Date: Wed, 14 Jun 2023 13:13:05 -0700 From: Andrew Morton To: "Vishal Moola (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH v2 2/5] mmzone: Introduce folio_migratetype() Message-Id: <20230614131305.2939f29e4372c94a8c6a56a8@linux-foundation.org> In-Reply-To: <20230614021312.34085-3-vishal.moola@gmail.com> References: <20230614021312.34085-1-vishal.moola@gmail.com> <20230614021312.34085-3-vishal.moola@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CCDF520026 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 3rb1hhtn7hb7ow9qrkmhorsrm8nnhhd4 X-HE-Tag: 1686773588-338691 X-HE-Meta: U2FsdGVkX18o8JjzTxAkVPX1ffffctJVrPbA0ux1ZiS7uFujrDzAXkX6/ENNuBdzgY+0ZR/NlpBl7jaVHZUudtG0nnsDlJcg3oGZsdbP+HvPF/wUf3UyVxrfh6XZAWfJfvVg7MaL+sKh5S8sE0G9t0WRkPN0R5j671z5vZW7xyNXBgotRUAUS7Hbe4uTMcEowCaxLTmOlqSauHfzP87w1F4r8ePLqmyBS/FIhWdlw2bhKc6JTdy99zCsdNv5Up+Z9rjhMsv5AcInore/9rRpCbItdbAV2pFCg/+1Nw8bJ1Pq3xeB4pZ04AHAHbILFx0c6LiDk3LUvnheu50ILWG4o53SSanN6PTURHTEy1f+nMEEHNeQIa+aQu2adi1UzVFuB9k/GizC4Dtz2OfbcPg3zKRtfJEEv+yp42pQj9rpnzW8iHJZowRjczp4KACTZyJiYxCd5EnerYiQv5A2xBnAKmweGqqmJrV+AN4rN0DRO1mpdPs3k9KcLEnyI7d3C/lYKedm52p4rF7b1ASnIFeibvVOQMz9SGTDLQ6U6e1AjUh9rYg4sJoEHNPW8szm+8FteCEs3XnzTGEFYHDSEOoJ62BRexU6ju6AkuluZSMrSKXa2mmZzlwTJ8RZ7OY/3ocpJLJmqQ4ZJkIrXC1m61sQ1D/wGyQQYYv+BkUAhplk7QDn7M24ChOxkt8vnxY9XRRnw7ZAnHphzqasBeW94e81taw0y90JV2phsyUB0q38Nlrr+atjLsSB3HAQbseMzg43vUdHfu1t9C6hToHFQ/6tuCVsWeyJgGUd+A3ETwfxKo5fp3cBQRfOqaMe85ATcNzd5f8lLEy2OcC255l35uHy9cVIWVb4/fVYXn2gjC+E/V+72PIqjK78hioDjFkLo88E2p84Vb/n/gKJw9hylw1dFuvKYe9HWAPcMZeORArSR1cvx8uQ41EM0JcFBA71I0PgOYvhpmdQWFjHTQtib1y 2tX8bsVU rm3M+gaHcryJwC+CRzgBaqjLyYlxKejznFCHpfgbtY/oagQVWeBAjGrNV6wJtdtadHgMuFrsirSpbVPv5IWw2+hiJrP2kmCnRecNW910N1z8oVcL8jk0yH1vXOefk6a2/IFcLC3hidwVg5rpzgXL0Yxg7E8Mq2alS/Fsr1tKhnkwFaxRJci0psIzr2wIrI80s8G97fjZo5OmNgEFG/EbZXM0cwGNSLzgr3JV/0iqCXKONQvokHb6jdRJLdC5w6Wr04hqkeb+OXPkDsmDkoZYAXjIoI6mEEYOJKYn5HOmutyWQUkHGSw0+jho9GU5P5NMsQu+dbfuCkR/975ibtmnNRpsM9WooYP/f1Co2ubJmH3FbCt90FAiirV6JjvWC0i3c8pepF7YSERS89ocEBhFV0zegg7wGmTJ8GHJ8T7e4LcA3J4Ki3aw8Af8jyLo3BbLkXgssd6v7Ok7u0qvYMm9M3CC1cRf/7oudPK9fTRCGa5iOXxJmZFLUVB4GvJPLTHUqyILMHx6Qu2IDgZg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 13 Jun 2023 19:13:09 -0700 "Vishal Moola (Oracle)" wrote: > Introduce folio_migratetype() as a folio equivalent for > get_pageblock_migratetype(). This function intends to return the > migratetype the folio is located in, hence the name choice. > > ... > > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -105,6 +105,9 @@ extern int page_group_by_mobility_disabled; > #define get_pageblock_migratetype(page) \ > get_pfnblock_flags_mask(page, page_to_pfn(page), MIGRATETYPE_MASK) > > +#define folio_migratetype(folio) \ > + get_pfnblock_flags_mask(&folio->page, folio_pfn(folio), \ > + MIGRATETYPE_MASK) Theoretically this is risky because it evaluates its argument more than once. Although folio_migratetype(folio++) seems an unlikely thing to do. An inlined C function is always preferable. My quick attempt at that reveals that the header files are All Messed Up As Usual.