From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C797AEB64D8 for ; Wed, 14 Jun 2023 13:04:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52CF68E0005; Wed, 14 Jun 2023 09:04:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B5C28E0002; Wed, 14 Jun 2023 09:04:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37D218E0005; Wed, 14 Jun 2023 09:04:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 24D478E0002 for ; Wed, 14 Jun 2023 09:04:32 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4508140633 for ; Wed, 14 Jun 2023 13:04:31 +0000 (UTC) X-FDA: 80901372342.24.E7345F7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 3CADF400D9 for ; Wed, 14 Jun 2023 13:02:46 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ij1kaX2f; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686747766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VJEQ8NyPFsOdlPd5FZZmi3O3EHJ5hxhEolur395DdP4=; b=LfpDn4Ms/YjmeN3wjkWMdVsPXvUPggr6cfzBq1YP555Q2Q9tmeB1axHgm83+8+zBm5gccK UVEd99HnB9LIjU9W608rjpDJ/PPIYCZe9a5BMKWXQhyIY6gHJ8MqM4mJVm4r7a283dG+g2 BnPuYxpDCDkEwgMgzRl4Mk5dUBXt5a8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686747766; a=rsa-sha256; cv=none; b=SVi5PYtOOIT/Zu3hnHbSwsJt+DKxBE6gug+cpfMssiw8xTEH5sztTLv7fWoBXfosyPp61z Quj07xjs+Dxah7ujnPZWNnixespNFD/urXsPoj+YEHT7DivSExn4piTj851qHiJhAdPz1J 8l6K19PTxEfw8Qrm+a5fcW3IRF8fZ+I= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ij1kaX2f; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4E2AB639FF; Wed, 14 Jun 2023 13:02:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8321C433CB; Wed, 14 Jun 2023 13:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686747764; bh=Z0S2d/Eru6a8jIIub+wJj2QGnnAEIe7xODp5r4XEjY4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ij1kaX2f2DmI7HK85FkEb/euMvHbhk1Yl6Bfkym5Y/V3n55SCcwdtHPiMl/Uaznfq /JPBcReV4N5cCfLGrjl0lmP3t1/xIRQ0sNu8SuNRKfJvFTG3ehEI7XrnyZzzj/mq5Z LIzsfSZJkFEA+VFk5od8SUJmz7a2MZahKi7y83tUViVFyHKqtoU7QmKJKuQUMruG+3 ZBcXEtH/BdXI8p8nle54zxP2rJXEAQvrH6UElVJeso6ar3qrgbKRU7tK7ulw5ExB7M 3MJes9iMWx7TD3tX2qF3/3jOSJV75iRXzB8fjYUsip9RPr0GERlktBmW7yBKguUpKQ +EDy1u2Ox8vrA== Date: Wed, 14 Jun 2023 16:02:07 +0300 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH v4 01/34] mm: Add PAGE_TYPE_OP folio functions Message-ID: <20230614130207.GZ52412@kernel.org> References: <20230612210423.18611-1-vishal.moola@gmail.com> <20230612210423.18611-2-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612210423.18611-2-vishal.moola@gmail.com> X-Stat-Signature: yxub6dk6munr3gxe4o5zo3ydyfghsdi9 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3CADF400D9 X-Rspam-User: X-HE-Tag: 1686747766-728723 X-HE-Meta: U2FsdGVkX18K00k5K9V6onM0UAU7CGnD1nBBw5Fr3XvDYkCCOIUboT5zU8098GapYOj+BlUcPlaIDStvlIpchy84F7Yafl41za5c/U9bYjsHC4/Ffild/ot7O6ygTboY6IihJrqG1M5uFeqxjzUjeiqNlGM2FMaiSZjQ2AjdQtcsKOQXY/i2nY/7V9e0AEk9HRy1FghjuY+i5f+HewZygjNsvvLw6+N1LBzJFhzWkRgEm0tIcyj9TrOp2CUj5Dz1a/FVbfd99+6FZeT5pnSwDsTKCScsz4opjzyHOuZQjnDYKwrjKearxe0ScQXUJfAe62kStsmv4+rYppF5QxAMFR4cVgVRyEXKmVhK0HpszEHRxBfcIl+2NmfA3RFDyTtsw0ezpAnRGglvUkE8bm2XfmZwNfnT//UQjWJnR3vQTbwFigZM6YDEFN+HPfVXA/PgfULR24AfjLX3m5PwuYJbg5DQJ9MozO6B+jMLLvOfOD93yeS3bxRDXcKR6AcR5iwF67MOZwDdiiumYs4gnkUhows1/FsUhbvHIe5MKf+eOUQBYQyV9A9DSyDp3QXGjFeA2vfCbnBIweGkknR9yU5ng8Oy1rtul+M4rgSc33nU7FeWmX4lfevrtO+E1iMDUs9bFudmWqPhMIUjKPERfOO62FVf9NR3R/RdXBAi8M6yNwjs5pcFXAYh/ZcX5YHdR70tD6cInY3p5kFUpsJJ/fkaGPun3WITBAeh3vROKdczzF7edHSlqYcHWSB2Os76NVe/ThWYiAkCT1AqcsctSvdJfS4HdSm0L0gvH7AHV2V6uetNVEkQBZXTSB3kMyy4qnEW1vA8UzyQfI9IFxju/Oe02Tgn93s+yhEF8tGXoIVwJKbRCJ9XrRWVRuvL+DiiCEbzJdEGnVU737nNzZgn0bQpqqZThaL+AKHsmyzN4ROud/1JBxK+ROvaW+pu5MZ2Qll0xGXhhkCHNSCAR3FJvQD ZPgZUimE 00TmWsYhkVZIcUb4ASJUQ1YH/j5Btl4x7QqkObuJgGrAaNro3xq7/ovHgL3NLm20YhR385ASfAVy4uSfTHPqe5nSBtdO+o4Lqc4DrDk8dCAFEq0K40XbeZBdg43F/d1qWVvCCOqn4N1RkGJVOunvEPBaoCsx1D6F4ptz/vSb7EDIdkGQP5p2e2uTJ9//vZuAfr7V7yWoQj7gb/GxJasiegmhigHJR5R4EWsPJy0AIEx9gQrc4iCI1e4tFc5J7wD77aMUMpXn+xXTsMpdEDcxzB0t1rRdwa8Xph91K14RdTqslStAtsr76Vuic+CRc6zuDZJIolrUywSwsdL0smMobQZ+zYaf9MWGjySphpJPRBh5Ycdq86DEIY7ihzixpPnW8p6g5//OkDt3ox+k5g/3Qoqn5MGP0D3dzwczbktxJDBwcO7NyjJN5gp6cJuc1sQcOc0bLZZ7YHbyLZLAahLIKl9GaWqWcS4EblQaB4JuOjJlJyoc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 02:03:50PM -0700, Vishal Moola (Oracle) wrote: > No folio equivalents for page type operations have been defined, so > define them for later folio conversions. > > Also changes the Page##uname macros to take in const struct page* since > we only read the memory here. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > include/linux/page-flags.h | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 92a2063a0a23..e99a616b9bcd 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -908,6 +908,8 @@ static inline bool is_page_hwpoison(struct page *page) > > #define PageType(page, flag) \ > ((page->page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE) > +#define folio_test_type(folio, flag) \ > + ((folio->page.page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE) > > static inline int page_type_has_type(unsigned int page_type) > { > @@ -920,20 +922,34 @@ static inline int page_has_type(struct page *page) > } > > #define PAGE_TYPE_OPS(uname, lname) \ > -static __always_inline int Page##uname(struct page *page) \ > +static __always_inline int Page##uname(const struct page *page) \ > { \ > return PageType(page, PG_##lname); \ > } \ > +static __always_inline int folio_test_##lname(const struct folio *folio)\ > +{ \ > + return folio_test_type(folio, PG_##lname); \ > +} \ > static __always_inline void __SetPage##uname(struct page *page) \ > { \ > VM_BUG_ON_PAGE(!PageType(page, 0), page); \ > page->page_type &= ~PG_##lname; \ > } \ > +static __always_inline void __folio_set_##lname(struct folio *folio) \ > +{ \ > + VM_BUG_ON_FOLIO(!folio_test_type(folio, 0), folio); \ > + folio->page.page_type &= ~PG_##lname; \ > +} \ > static __always_inline void __ClearPage##uname(struct page *page) \ > { \ > VM_BUG_ON_PAGE(!Page##uname(page), page); \ > page->page_type |= PG_##lname; \ > -} > +} \ > +static __always_inline void __folio_clear_##lname(struct folio *folio) \ > +{ \ > + VM_BUG_ON_FOLIO(!folio_test_##lname(folio), folio); \ > + folio->page.page_type |= PG_##lname; \ > +} \ > > /* > * PageBuddy() indicates that the page is free and in the buddy system > -- > 2.40.1 > > -- Sincerely yours, Mike.