From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A832CEB64DB for ; Wed, 14 Jun 2023 11:47:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E97166B0074; Wed, 14 Jun 2023 07:47:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E205D6B0075; Wed, 14 Jun 2023 07:47:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC0766B0078; Wed, 14 Jun 2023 07:47:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B8D1B6B0074 for ; Wed, 14 Jun 2023 07:47:04 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 79847A0934 for ; Wed, 14 Jun 2023 11:47:04 +0000 (UTC) X-FDA: 80901177168.04.1F75D93 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id D7D91C0022 for ; Wed, 14 Jun 2023 11:47:01 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CphnQVIG; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686743221; a=rsa-sha256; cv=none; b=fGkeyMR2vRnG8CMZw1D+VHy2wdu5TzToHT7zNgadsyjMkV9/Z5MsdZmQR/ZOYoKwAQUMVV ikojoQki0s2jNGNUYlRx7jtrzOS9yBN6GbR4kf5LXV3lDTP02Se4am3pL3cr1sFllDW9sL Yq/YHqjVuz/n7azQWL7Hu1cLLU5fz8Q= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CphnQVIG; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686743221; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KAZFTh9uvAJjj62+EADa43wxlIDZ+1fMMO49wkAFkmU=; b=L3gQTBHg7q8gHLHzGeZ9/DyVXoJ3P4Q7u7v1KjypvemoCqgg7DIu7/4Y04g5xo7q7FR0UM WttUanacf5uZObIdpUcnTZyEq4m9yq7AR5x1C3Ad+U2obiMZOf9eowgwpgRu0nwt97i9Xj ACn0SixXPN7Iy//qnjMriTPXaJh40M4= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DA58E60EA2; Wed, 14 Jun 2023 11:47:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C5BAC433C0; Wed, 14 Jun 2023 11:46:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686743220; bh=hUgVO/GCrrBC8yyi34t2DrgRbyXURmTA1orcAkAe0pA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CphnQVIG1x8bMDw09c1e9AWm29ATdgRMUlx3PSedKkyJy0ap3QEs4UV+c07hXSFeO 0jPIssvrXAQehQdPfmilN6fdB4VSupZzo/I7vCFkRPHKQbalUvoYU1dRARwQ3JxviA JZvOdzFkKBLPHa+UuEo7Qw1vPjozqA2b5c8GvnDuHOe4xkOMe0HFEWnk0cFZyFt0lz 8yHHvRvUDWLjYYgOnIdw/lqs4PshJeIOJY3HIJeDUIwW1u8Ry5EzhPHIplJTzlbGdk g0fIh7WdFMSet/FUInjApJGDJGRJU3rlUNwRL9ceqE/Rq5wAplLeHDEKZGwYTsXEXw pGtlvS18y+Nmw== Date: Wed, 14 Jun 2023 14:46:27 +0300 From: Mike Rapoport To: Peng Zhang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com Subject: Re: [PATCH] memblock: use the helper macro for_each_zone Message-ID: <20230614114627.GW52412@kernel.org> References: <20230612125102.1674568-1-zhangpeng362@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612125102.1674568-1-zhangpeng362@huawei.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D7D91C0022 X-Stat-Signature: 4p3185yzcagno6xwkekwmohxe5bdfwwe X-Rspam-User: X-HE-Tag: 1686743221-867394 X-HE-Meta: U2FsdGVkX1+whrUD/acOjdqfWqnqHWJ7O+QYgZ2XHpLLG6X7XINqLXFsObJNOSpffnvcF7LQcClJmzbBNwZJQ/nOZriNbDRLHFiQFpAlk9yfE8n+EnIUpmCOgx4zL/FTV9B6JuLK/uGBxdJJSM62H20ajI384J3p3L8Ufdti2x6sZjGPu9ZkP3a9XguK4RUuehk30fErdbWBrhKcYKR49Uf2vQOSsv9z7BFLR6TyfgR6XQnFb0e0d2/4+xm0I4utuVvutUpkZkCi75SKd94LgCS57w0He8D6kbafftWgn8hdGNfGkg94lgU29DSxo/y8D0Pwy23RxvytQwmVeH/QWKlozbzhJHnUEi8pqFYzAes2mBV2qSXR8W5k7tOxEaShKAZMTJqugvfUpIFqudOnd22073vuTa/nhBIX3/Upp1bUi3KPgF2ltxn7w2R1A86kHEpoRHiUCtVsdvbkF6dpwzhQY+pPUs7J1c8vZAzTiMlE7AN54qWyPRY+tObOTYU7JJpcTuxPj0fSwGnxDlb3MboN4iDBy9hwyrFSWSPVw0iyGn9GcZnU4fdnK5b6S8d7HeFH9D7KHbN/Sgx/Xp+o3chkJUh/HgSZVkSQvBdaJh04YOTY+pMvzSHAtK27ng6X5OYLakuiUsJ5k5VtxRxCyTkrV6iY0inZDUTbQMFz01YvIUpRSGY6BPMZsAk03gaAL6DAzmo6Z6HnpF20ITyNw6MNI5CD6OqA26F3nhrFYtxwZaAcmeeXFVGHLVTxBdR6UU19sGb/4spkB9h3K2WaDMe+/68NIOyPDHT10JOJMONQUOXUp3WRi3X33IMg8yXb8Leo1nyFTTFOEbkeJsUXTLj0l8UkMxpotsx+JNuATok0g4N1PxpVq1ATybUZaOCbEB5p8y65mhVlBps9gAJTL7pJ4HzydOraK1rfBaByLBAen5a6KFc8/EwWVpEGiag/9NjOhKcQ6qMfke+hx3P /xfdYZhH fL1Ooll5IFHKHoJZkk8RkazKzqkcz8tlSYDajoS/UsTBCpjR6Sv0mdCcn+vTOOwdrSW03ZEwyv+1YcwTE4AywormX4ZrC6IqYVWu+6N/eAQdSXNHBw7k7ShtU4szY3MlZ6VxeVT8Pup5eKmJtPH5IrUV97EzgIZOXhPJ3IWZm6uzFGfgMBr0duMTwz/eVRMhc08wMUUJqx3n89zt2XH0aQG1GJsOZseMjKZ/bNfaPld+olW6L+lyIIvnUn591OMytxIAqmj1W3UDDEc1jgDwPtqLBwQT7x3lNKnlWKNsrfwD+KHTLphzqTENgxf3Hn8ofhW8fRtf8Q+Hy4kNXgTluRd870Og9Y4NLP36SFPrNCx41Sik= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 08:51:02PM +0800, Peng Zhang wrote: > From: ZhangPeng > > Let's use the helper macro for_each_zone to iterate over all memory > zones and reset the node managed pages. After that, we can remove the > unused function reset_node_managed_pages. Are you sure it's safe to use for_each_zone() in all users of reset_all_zones_managed_pages()? > Signed-off-by: ZhangPeng > --- > mm/memblock.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index da4264528e1e..af552604c3fb 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2122,23 +2122,15 @@ static unsigned long __init free_low_memory_core_early(void) > > static int reset_managed_pages_done __initdata; > > -static void __init reset_node_managed_pages(pg_data_t *pgdat) > -{ > - struct zone *z; > - > - for (z = pgdat->node_zones; z < pgdat->node_zones + MAX_NR_ZONES; z++) > - atomic_long_set(&z->managed_pages, 0); > -} > - > void __init reset_all_zones_managed_pages(void) > { > - struct pglist_data *pgdat; > + struct zone *z; > > if (reset_managed_pages_done) > return; > > - for_each_online_pgdat(pgdat) > - reset_node_managed_pages(pgdat); > + for_each_zone(z) > + atomic_long_set(&z->managed_pages, 0); > > reset_managed_pages_done = 1; > } > -- > 2.25.1 > -- Sincerely yours, Mike.