From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE83EB64D8 for ; Wed, 14 Jun 2023 18:09:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6CFB6B0074; Wed, 14 Jun 2023 14:09:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1CE96B0075; Wed, 14 Jun 2023 14:09:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE4636B0078; Wed, 14 Jun 2023 14:09:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AC4856B0074 for ; Wed, 14 Jun 2023 14:09:27 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 70E501C83B7 for ; Wed, 14 Jun 2023 18:09:27 +0000 (UTC) X-FDA: 80902140774.24.349EB7F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id A157780006 for ; Wed, 14 Jun 2023 18:09:25 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Kiva6gK7; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686766165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cx3ww42b/GUADmPxgecUruglRuTodYTFhWxxp7Qxcss=; b=xOZsqnMHlXSo6zSh1wGGCJim0PPM7Wg4wFPcyT5/Q/k3R1TvZTMaiUoYaUcz7JqAgg7gqN AHnqXlnCzEC8ub8zGcyOMpbJi3u6mpdvzMluE1k6x4OPy2LUq2rsXbP1YOqgZOFwrfkEC8 vhvZcnTL2OQHRKblIkjNhfS/KGD3+Ic= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Kiva6gK7; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686766165; a=rsa-sha256; cv=none; b=k65l2vpNjEshqtiVYqP6heAvua+vKAxdvYk5q7xGdCSs/350QjA6jZdtJNGd8haFbG8Nn7 O1ss0WFxZm8/WLg1ABMu4EZSw4swLEDj1cqIQsBJ31bkBsNp0/L+d1W/YztpBFnCRfLej3 RoIBIs4q2oG/hiK0AUW6L+5QGujHLpE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A715264591; Wed, 14 Jun 2023 18:09:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF487C433C8; Wed, 14 Jun 2023 18:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1686766164; bh=+nxesi73rHt30BcL4CzJywspddkR9ibaByigPS/fPBc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Kiva6gK7MHUYL0CxOWup6G0c1iUNZxcgNyRtbLccepIEW9XIsERqtTwtmhufzdk8D tL1fJjZqqtgVCYCr03ofsn/4dYBh7I9kARA8qLfI8/SNX311/bI06DIe663INP1v6J fdqtvJ7J/3R8p6TS5f/0JQkeEl68nnuADOkb8EaM= Date: Wed, 14 Jun 2023 11:09:23 -0700 From: Andrew Morton To: hexingwei001@208suo.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: page_io: Prefer 'unsigned int' to bare use of 'unsigned' Message-Id: <20230614110923.b5ac015ac6e9a2d97f3b40c3@linux-foundation.org> In-Reply-To: <1e132a6416d673e285af610ff185fa5f@208suo.com> References: <20230614071804.13110-1-panzhiai@cdjrlc.com> <1e132a6416d673e285af610ff185fa5f@208suo.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A157780006 X-Rspam-User: X-Stat-Signature: i5zrazi8izsrfgsa8539y55qw8ckewbz X-Rspamd-Server: rspam01 X-HE-Tag: 1686766165-218763 X-HE-Meta: U2FsdGVkX19wL5oBAKFY3HmHejWZEGwqnPw6fPhk+tVkTQLa/s3VBOPmwJ5fPAr0tuM9r9aS00A6bYxaLhYxU8k2xnxcvt2pyMXSE6tIgTVLbO3uOhATlV3DEMjBKc99E+8FEfxBY1ztwfOgdbcd0Xs4l06U/fHhIO1ooTv8ig2Lay0wfc8GgiHkeE30liVBvShnmTwFe/iYT6ghSS4yiWOZjTMPk8nIj9lRwDkezt4zK5r/s9+6Ql+4Qdd0r3MIuxFurpiz2BSm6Oi5iAMRh9XTtG3JU/gbalRNDs3wJHUCCCFFO34AzfWzbJOPbjj7OvrCpgmoQwSEhMOs7rWagbEFkNphyO4xhYnnEZadlTehwlNn+u42ccKA3rraADeftUZTdmj+2r2r5xsNHm+M5Mozglzuj6IbHgMROjnrJmrRlmyZugAEpA5gqvGZ3Km28WDPelYOxBABi33E4pgLcqIyqyMpzDmTyMdbUwBJOJMqwVFzwYpDx2wec7klMRif22llaZ3GBPSGXKoBRaNp/a7EVl8vmKtv1k5jK6eWudGPKrJfMO2jQOyKxxU09xLl+1ySc5jp5QpZzDBGhoKJ3Dmy5L2a7oROBGadWDlOiQFeaxM4xpUtqk/Twb3yckAKM8gAhlNR5LsWmB4kEjEqVrdOEVl6dVHsrm4+CQ7t08Hqh8D8GoGNe6nqR1MSJooI1J/OX0RZRK0uBk5Ron4QVOpqFjQLFg4i9cMAISy/zH5E7v/QeyBu2uD6mbuvXY9hz+3rOYA8oMUfH/YGOZq8golkDmgkgkX1A/rt37ZV+PMr5KTINdgnHJVrQdUVQIGmprKORNjCC3iC4GzsgX6Ske+yiofMb1Od5QimLE9hTFMAEYT7Qj7xiulPeUgGgvva6fO89cq4gbbzCYQUHFafU9lAVcCXz+kRY82osF2Cs08aJfMEMLWtyBej+ybukO/TU9iW6cW+f624lbmn8zD HjmYF+lS pxGOa4//xpp9T01RTxFj748YH9+r9Zn/ehekAGWEAZFIzWFiJBs29fcV0yhjFDJ/Fb1zJZWHh4DFQEcDcpMfUxuu1HujxPWt9w5LNp0ZH1cNUkU7pBlTuv5hvWBQP7I7+At5he+mFBFpyGJL1H+e/RNicxwHg/6i7cQ1TXppirhLBX7A28ZEyskDaWEshE5zqI/Os/BPUT++DOp5DPaxEbJtonLqnXvn8M9xPKZhAb8uGCt+Vnz67U37tcjmPH1Uyq6NtxDjnL17G9vbqhGwM/ogTw8GwOCYPcAXEP0tilfd5b4tBEcxKkDj0mv0FisttQbBBFb954le8W4J1yViwccvnka9AAGQ4JY0bTN+NNx38qvt5xfpl4SZoTBeabvqOLQ9jzCsAPsNRwvJfoAEg4GlHu3ndik4wYoKHEPF7c+ZpvxzUJGAA/AFptQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 14 Jun 2023 15:23:44 +0800 hexingwei001@208suo.com wrote: > Fix the following checkpatch warning: > > mm/page_io.c:87: WARNING: Prefer 'unsigned int' to bare use of > 'unsigned'. > mm/page_io.c:89: WARNING: Prefer 'unsigned int' to bare use of > 'unsigned'. > mm/page_io.c:109: WARNING: Prefer 'unsigned int' to bare use of > 'unsigned'. I'm counting 55 of these in mm/*.c. If we're going to do this then it wouild be better to do all at once, plus the header files. I don't believe that is worth the churn.