From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4281EB64D9 for ; Wed, 14 Jun 2023 11:08:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E9C06B0074; Wed, 14 Jun 2023 07:08:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0727D6B0075; Wed, 14 Jun 2023 07:08:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E07106B0078; Wed, 14 Jun 2023 07:08:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CC7E96B0074 for ; Wed, 14 Jun 2023 07:08:55 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 79490807CE for ; Wed, 14 Jun 2023 11:08:55 +0000 (UTC) X-FDA: 80901081030.06.30D79E7 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf18.hostedemail.com (Postfix) with ESMTP id 09F6B1C0013 for ; Wed, 14 Jun 2023 11:08:51 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IBrdOcL4; spf=none (imf18.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686740932; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZgA4IBbJY2LfhRCTHq7uBY4trb5CXVwwo/E5KZVNFDg=; b=pcorMnBV5u8BvBhPReIYp/5J3gvflaNN2UdTylInvHQT8NC79m0Bu+XLAS2RtSCje/AcSP RO91O7hFHiCNfmLK1Hm28YyK/U2jhVWhfUHqVTrfHENZ7idgXeeXdiJtP10lL32Q6Kx8eA i9dsBZuNXhxCF8voWtDorfPQakDoSb4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686740932; a=rsa-sha256; cv=none; b=SMZMhydu+6ANWNhFdLKzx4W2WH+Pf/2fHDKcyEhkTeXAEddog8b64NN+6zfD1Kd5a7VSgb mynjIC2cAwW0C+276Xb1cm6qvHJqVYy8JMzw2so84HXT7MWQjxFVIYAAig6ADmIqxBql5O eOl8ijtkOz/9FM6+rYRCgjvAdaYoK6s= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IBrdOcL4; spf=none (imf18.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686740932; x=1718276932; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Mm79erLzfDU1g9VPH5nKFTr67LEN6rYuyJAuFo/ZDXU=; b=IBrdOcL4pQlGQL8hnvmFbSoSR1bhh6H5nqtvq2vF39k0yZOm7NMUzeVn 6mJsJeRG+OS7vKpKtMxsK8waQmOTrFfzLst7DiqLJ9du1VInsf2umzMYk kRApQkcX3zIuMREAG3SOTpulRFmcx0z8cnellb1fl4dDQUGc1YlV9jaWL ycVXTUQhy3e6Nm5JSAF+qz++REFl6wMcAJ3F73YEpXA8028fDgpfr/kAx 9JOZKuJLSNBdp5xq1RdvYVw2PJO+QjJxLXUQf0+pX9sJfsGLTgvkwWjmk bRe8YM4UsZpbGiCBsJOj4VDmpxnlbFX0oyFkvuloD+hdkuLuBZg6HTcxo Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="386993013" X-IronPort-AV: E=Sophos;i="6.00,242,1681196400"; d="scan'208";a="386993013" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2023 04:08:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="741798491" X-IronPort-AV: E=Sophos;i="6.00,242,1681196400"; d="scan'208";a="741798491" Received: from wlwpo-8.amr.corp.intel.com (HELO box.shutemov.name) ([10.251.211.89]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2023 04:08:38 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id 7AC2910A069; Wed, 14 Jun 2023 14:08:21 +0300 (+03) Date: Wed, 14 Jun 2023 14:08:21 +0300 From: "kirill.shutemov@linux.intel.com" To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "Luck, Tony" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "Yamahata, Isaku" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "Shahar, Sagi" , "peterz@infradead.org" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" Subject: Re: [PATCH v11 18/20] x86: Handle TDX erratum to reset TDX private memory during kexec() and reboot Message-ID: <20230614110821.pf35kxd4vcwjjpb5@box> References: <5aa7506d4fedbf625e3fe8ceeb88af3be1ce97ea.1685887183.git.kai.huang@intel.com> <20230614100245.3vehux365zou3ze6@box> <84dcc5ff896f487c95dc1602b627abef8d48432f.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84dcc5ff896f487c95dc1602b627abef8d48432f.camel@intel.com> X-Rspamd-Queue-Id: 09F6B1C0013 X-Rspam-User: X-Stat-Signature: uagap5ud6g4r9gncbozh5ipzawu1t4no X-Rspamd-Server: rspam03 X-HE-Tag: 1686740931-564437 X-HE-Meta: U2FsdGVkX18GTPxYmnZEsC5ioeAZBAkfEAePHDmUDx1aImgndb6t/4urDW1lEDnXKgKu82YXctySYKwPH7h67+E8Nt59N6drevsbSQrsroHVS/PUFpJXbdAwJ11xb+QahybbCltMt3OQvMwIb5qwqwKF94VIRVGG1axGju/MDxbpEf5S9tGVJtIp3tn1VdfTlRsgJubux5xt+QxYPak8e5/nvkDd0Kq6SLpnQBd8RIu28gltU42WOYvpPaNFug30AYx6Ht4v02Nz3NOxu2M1zHlqiEfu+HwdoU+oSCa96SZ2avxIKvkfmA/tFbt13KqluoJ9ydFOOa6wvng/6nV5Q4mGLk0fAYps1O/3naHgC5Fm1oGsyttBREJqSLLluANKVY9Wn6B+h+sPx9MJd1ZRznmVQX9iUrGSaMYrtQPNHwJmm/IThEGyFskTAe5324w0EflQz1yEDH6tqH+Emp+hFCRFg99nZrf3VkJjWW0DxDFLUP7cmX98xr1RQ3aOPWeFOIwsK9br06pxxAlem4ynKI9q72BoCQZ+oK/d026goVCp3ZqkF46m9HyrBgDGvt/CrDcnaSk8GwbHbUhiz0eX9tO8t9gi6jdxOxIKr3oEDxkNHpiqfLhY8yUfEJWX9CK/PSiCGGjXWZ52uI03pK24vnN0q5sRBvbd7/DrzHM/9jzopPyfO3Zs2xrP2rlAh7jksePSyhlO4o4wcdHOZgrAiQlLvWtiLHgXfeWC/e3I60gylHkW8H2dhmhZ4GZzAvsHN4oTc1I/orj6um8xM8iXPoAooskGOBoq9Dk0+3iTC+1w8yc/WBcmGKXD/9/ACnFbx9FnbZSoRwz4n6W7IFbCTjySpqE7zRmdY27VGcO+hVQUgDY5X0dpkebMHOCpg4V4wj7IqAnu1BY+SScOIQu26BKhKFN+XPcyFYNFIF+rKgEAet8GGXggcYiPRcUcffUkk2OrPoPp9NjnrG/Ud1T XyDDVW+u Mp9/Q9CDqeV4M+WVDih7JWqudzg/pDo0J7XfXQ9LzKF6cEWfHtMY6MYE6rT7rl2pr31nYu2RJpHjYvjS/VmTZywlmeTbjM/+S99fx0sxAGUH/OdEOWCA4AYR2Rm6XCa64wPP9NUIuvHiSAI6c4wHfbRwcj7NvdKfI+RAoygRooJJ2gsw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 14, 2023 at 10:58:13AM +0000, Huang, Kai wrote: > > And the platform has to > > handle erratum in BIOS to reset memory status on reboot anyway. > > So "handle erratum in BIOS" I think you mean "warm reset" doesn't reset TDX > private pages, and the BIOS needs to disable "warm reset". > > IIUC this means the kernel needs to depend on specific BIOS setting to work > normally, and IIUC the kernel even cannot be aware of this setting? > > Should the kernel just reset all TDX private pages when erratum is present > during reboot so the kernel doesn't depend on BIOS? Kernel cannot really function if we don't trust BIOS to do its job. Kernel depends on BIOS services anyway. We cannot try to handle everything in kernel just in case BIOS drops the ball. -- Kiryl Shutsemau / Kirill A. Shutemov