From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52960EB64DA for ; Wed, 14 Jun 2023 10:03:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 917FA6B0074; Wed, 14 Jun 2023 06:03:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C8F86B0075; Wed, 14 Jun 2023 06:03:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78FD36B0078; Wed, 14 Jun 2023 06:03:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 650556B0074 for ; Wed, 14 Jun 2023 06:03:32 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 30DBAC0910 for ; Wed, 14 Jun 2023 10:03:32 +0000 (UTC) X-FDA: 80900916264.12.EED8017 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf06.hostedemail.com (Postfix) with ESMTP id 7373D18000D for ; Wed, 14 Jun 2023 10:03:28 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CQiwN7ye; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf06.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686737010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uJafqMneOL0UnUQwA7BRfl3HyQByc9Jr8YCEcJd4YCQ=; b=3OBHKNAD0awN4fBTW6CycQi2szJq3pKF7Sc2deakueNs8FYLNaeliq8q5y6s8DFrhuDSYY YAnHascxT+PcZV/vgJ5kezIYtGQFPyz9nV2fOXOKa13sH+J7SR+k2JVCawPEWEghqULDdX B/LHTDO5rj2ZfQM1kR9UTYvdTiCACpQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CQiwN7ye; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf06.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686737010; a=rsa-sha256; cv=none; b=FGt6XDKtmKQGkcl2XCp240Vpz4heeoSOK530S4UKsdRduhtjVcQaDjkftztcRZ0MjNwFih k34reSECSDc0AMj2W68GDxWfDnsID5zbw4CIXIpVJxbLoV4gaVuEjK/+EenC/53dwdV+Uh SbhKU/EtnbawSyCwNnmARcWwJjF/gAI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686737008; x=1718273008; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=dN70DPRIIm8Vru/aWZ0BgD3rW447BgWLjBzsIad6I7E=; b=CQiwN7ye5ys8qLTP6Lpyjsl8ASqnxvphUb2YFRdWwgPD5oND9Y2EJFtt bTUDkuxRfoV5QUbSIV1nODQGAqZouDov2vs0PVs4/FLCNt2rA/35+7DFi 3R+kEa0WZQIGbV2Yj7TVGD7DMdyNwv2cEKU4WlfyXlXveF5UvxBfqOMpi nN0JafizkZFZPgrblSYm/YbQg/8kxgbOZu5abjlX4PP2rFiDGMM/96vy7 wd70QzVcblxhXHo1Jnzb1qN6eEMW5rsawmYYXATcmhYsHiwo8OUQscUTK +/VOtErUoHU5fG46JQk9aHTcYNVAwbULWIeK4d62Wz0i1YiNhRMFtaa9b A==; X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="422174743" X-IronPort-AV: E=Sophos;i="6.00,242,1681196400"; d="scan'208";a="422174743" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2023 03:03:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="662346663" X-IronPort-AV: E=Sophos;i="6.00,242,1681196400"; d="scan'208";a="662346663" Received: from wlwpo-8.amr.corp.intel.com (HELO box.shutemov.name) ([10.251.211.89]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2023 03:03:06 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id A3D2710A069; Wed, 14 Jun 2023 13:02:45 +0300 (+03) Date: Wed, 14 Jun 2023 13:02:45 +0300 From: "kirill.shutemov@linux.intel.com" To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "tglx@linutronix.de" , "Luck, Tony" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" Subject: Re: [PATCH v11 18/20] x86: Handle TDX erratum to reset TDX private memory during kexec() and reboot Message-ID: <20230614100245.3vehux365zou3ze6@box> References: <5aa7506d4fedbf625e3fe8ceeb88af3be1ce97ea.1685887183.git.kai.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 7373D18000D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: jn8sz1maspp9pozte69eseich6i36bdp X-HE-Tag: 1686737008-519752 X-HE-Meta: U2FsdGVkX1/OOE1EzAzN4msFo0nngfvf4I36Cx/nAIiA30lkz3p7Sq9iPKDZH2lOlfCBIcx319yM9gz5ugSegPDjtmIy2ZqM3BIHn2hj000lYi8S3BZTHZ587l6+EGGx9kVaRQYhmTtyjcVwKhpfM+8yK+yNt8WTdOsGziWOuApCe6iSus6BVuyQbOG++OgLTctj/xBGPUfTi/5FxtcpJMfWO+XD+sl6iiOjE0Inz1EbGrUhXce7JMEl8j60rfPJQjM05fl0AeJk+trZdUJdbRtaoE6fIoRBwjxuVFoljHbYPTfJSVNR96gjzzT/2NuFQdzWtP03nfHypS359PckFeaSmIYqkiYkdTduJMjtpWbUNiAQ4yM9y5fDGjlq+pGe7CfdXXtx7iJyC1d5hiXgLf8ysoQvcjFQ/DRufyPJSlIwZEng+tysqoJUVVDBsQQEljGrtk+g/5ELAnv8zeCNUerSBEi+GssyYuQEi8oTlyWbt9wuAOfH58NgCBk6IF9HvcbPSTD66J77+pw2EW/J7e8g+KiWdCnFMXIimokxTA0xWLLi5YvQ+0DKcwGA5k/x4Of5GYB/UP4oRg7QSdncUVRcqBS6mTHWkIVeRJhnOZTkULJaSdxQEmh86isbVD/526P3Oj3f2yKJytlNJiqM+WvGhPdpjfAnan/IXLpha1nAy1NTctAKSOHOlUfVeDRpgGeHm+ffA+R2tTcZx/X3bsCR9s7BIQohLg6Pv+OprZ/vikg96/SYoAPANyJjBxH3GhY0D8eW3n4h0lE4KdMsKyx3kORRNU7mbu3JdgHd7Dl8hfFb98wvRC/zQgNsHXgGzqHD/9bmNAWlJaGzvhDcpg/KF64b9/m8Z/lCQG2yB/PuGjRVybsoTwSstRGk+fH583ZVShrztkmGIB9F4wEYsQRNpIvrR7keKqDNSKs8/HCYhO6ez6hrvjGMb7AipLhdhR/JaYgmqGr4i/w4Z77 tqRFKFlI HjV94hwChU0vqUWNRP/oriJjTEdsrcvBGHlNQLr9PAE6CVNPWScrwlzWFElrYuuenFeQ6LHmFOqlMJ0NT9J/ewkQSoIlw29Ugy91l9jmJvgpt+FyyeBdDfujlJQiSrTTt6Mdd2jcs9hzqA9f6pGgTjFtgmk4F0sPc3xpJb/sindOsCBY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 14, 2023 at 09:33:45AM +0000, Huang, Kai wrote: > On Mon, 2023-06-05 at 02:27 +1200, Kai Huang wrote: > > --- a/arch/x86/kernel/reboot.c > > +++ b/arch/x86/kernel/reboot.c > > @@ -720,6 +720,7 @@ void native_machine_shutdown(void) > >   > >  #ifdef CONFIG_X86_64 > >   x86_platform.iommu_shutdown(); > > + x86_platform.memory_shutdown(); > >  #endif > >  } > > Hi Kirill/Dave, > > I missed that this solution doesn't reset TDX private for emergency restart or > when reboot_force is set, because machine_shutdown() isn't called for them. > > Is it acceptable? Or should we handle them too? Force reboot is not used in kexec path, right? And the platform has to handle erratum in BIOS to reset memory status on reboot anyway. I think we should be fine. But it worth mentioning it in the commit message. -- Kiryl Shutsemau / Kirill A. Shutemov