linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Wupeng Ma <mawupeng1@huawei.com>
To: <akpm@linux-foundation.org>, <david@redhat.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	<mawupeng1@huawei.com>, <stable@vger.kernel.org>
Subject: [PATCH stable 5.10 0/1] Fix memleak during hotremove memory
Date: Wed, 14 Jun 2023 14:18:59 +0800	[thread overview]
Message-ID: <20230614061900.3296725-1-mawupeng1@huawei.com> (raw)

From: Ma Wupeng <mawupeng1@huawei.com>

Hi maintainers:

Our test find a memleak in init_memory_block, it is clear that mem is never
been released due to wrong refcount. Commit 08b3acd7a68f ("mm/memory_hotplug:
Introduce offline_and_remove_memory()") failed to dec refcount after
find_memory_block which fail to dec refcount to zero in remove memory
causing the leak.

Commit 8dc4bb58a146 ("mm/memory_hotplug: extend offline_and_remove_memory()
to handle more than one memory block") introduce walk_memory_blocks to
replace find_memory_block which dec refcount by calling put_device after
find_memory_block_by_id. In the way, the memleak is fixed.

Here is the simplified calltrace:

  kmem_cache_alloc_trace+0x664/0xed0
  init_memory_block+0x8c/0x170
  create_memory_block_devices+0xa4/0x150
  add_memory_resource+0x188/0x530
  __add_memory+0x78/0x104
  add_memory+0x6c/0xb0

David Hildenbrand (1):
  mm/memory_hotplug: extend offline_and_remove_memory() to handle more
    than one memory block

 mm/memory_hotplug.c | 105 +++++++++++++++++++++++++++++++++++++-------
 1 file changed, 89 insertions(+), 16 deletions(-)

-- 
2.25.1



             reply	other threads:[~2023-06-14  6:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14  6:18 Wupeng Ma [this message]
2023-06-14  6:19 ` [PATCH stable 5.10 1/1] mm/memory_hotplug: extend offline_and_remove_memory() to handle more than one memory block Wupeng Ma
2023-06-14  6:35   ` Greg KH
2023-06-14  6:45     ` mawupeng
2023-06-19  6:20       ` Greg KH
2023-06-19  6:54         ` mawupeng
2023-06-19  6:51       ` [PATCH stable 5.10] " Wupeng Ma
2023-06-19  7:16         ` Greg KH
2023-06-19  7:22           ` mawupeng
2023-06-19  7:41             ` David Hildenbrand
2023-06-19  7:53               ` mawupeng
2023-06-19  8:04                 ` Greg KH
2023-06-19  7:48             ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230614061900.3296725-1-mawupeng1@huawei.com \
    --to=mawupeng1@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox