From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D525EB64DB for ; Wed, 14 Jun 2023 02:14:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B50F98E0002; Tue, 13 Jun 2023 22:14:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADA0E900002; Tue, 13 Jun 2023 22:14:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B7178E0007; Tue, 13 Jun 2023 22:14:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 79A8A8E0002 for ; Tue, 13 Jun 2023 22:14:31 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5074D1A06C1 for ; Wed, 14 Jun 2023 02:14:31 +0000 (UTC) X-FDA: 80899734342.27.34549C2 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by imf15.hostedemail.com (Postfix) with ESMTP id 8425BA0003 for ; Wed, 14 Jun 2023 02:14:29 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=O48zV0HJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686708869; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Oezw1x9OR5I9OrjQTv8pl4ceJsvnhhH8ZZxaxblQe1s=; b=jAqfqr0J2CDttlbahWFgWkJSYXYmLn8eWhIuiqFyxF20WeqDmKsm8lxDrGxRqLONeb6+jB Tq6wYHMqm3nTtRiaQbRnLAwkxDg4e3EZmWPjCy7/HiHwjObkgLs1+V6L4zPVuAEhrhtV8m gITzij2tMNdNCAebF0IMkVDTAnYjLpQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=O48zV0HJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686708869; a=rsa-sha256; cv=none; b=d1vKULB9OZI0FgaHUVKAbFR2mtkLlj3P+iggDLpuoEH3qWRlxoVqESy0OmXv9Yc3bsysmJ hrmPtpB5/p7f9jXxeJmb7p4yQTJtI6RAoDFR9Mgn4NxIWNy+qR7ZcAvZ60OMvSNm6Nmixt YLU+2yfj8lw+ypwYDk58dPxnqJqWyEc= Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-56d0776f668so2205657b3.3 for ; Tue, 13 Jun 2023 19:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686708868; x=1689300868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Oezw1x9OR5I9OrjQTv8pl4ceJsvnhhH8ZZxaxblQe1s=; b=O48zV0HJ8AnO6I45UUKI48I+tD/Vv23woacs9hKnlQUxpefbJbhzQLqPr5GRevY5g9 QPj5DwIyXOvszZCwPQHWvb8S2Nec48dlPm76GAa7K/NYG3zynZ9iCijubGWPdTnPPLT0 PNLSWXCh2boJweoP/O9U5JQj5ruvgnbTzpj5Co9lQHUdNgysNtGP9IcmCL13jGSnCTaN /r/5Gw13CrEJV0ZyM4DKdT6pAAe9yjoHrmua6tqXJZJ22cz/oxKC8YCvWk0BzhIevIVA qeMFjIYfkShTzuvIClUtOGRftTo40VJp9tIsll7NcDaok7XIcijeg4IZ0QOGEojV9+h0 TJxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686708868; x=1689300868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Oezw1x9OR5I9OrjQTv8pl4ceJsvnhhH8ZZxaxblQe1s=; b=V88RQXvXUdNdu+yv+8y5qLKdKXxUVF445pSV6doVYTVQAW6WI75qkpFgJFYZagX0Vi p6QNrr6E9/VcAyOR0zEPctmn9xo52zUnllKWkpzcjfxtvmF3fh+lblZ90cdfV5r7Whuu M9PVHqfroJ0TDccGxEQJIh2clV+bkxvufX9fjHlee9twwDYkMdORn9WRkEaESj08dbyu u1LXn1wRZdZuE4Aee84dFTHp2DqZDbq5INUsB+k+s1Tz/S4i0tuD+cFXsfV12AS3Nv9Y mUqJbls4oh4FiSidBmAPAMAeS0sW7yBNarDU9nhsEvCofaPiJZH7SwUsIpBDiQWOOLFT Uh6A== X-Gm-Message-State: AC+VfDxqO6+YRuZrQH0b78k2FmeV3oJUUZG8wl3jEf3SCehUmBQ+q4MW gInHp/CV+7BmP3pXLlbI1Zo= X-Google-Smtp-Source: ACHHUZ4U+/TjEKVuJNFVPqHGiuvcd9miGd5mgokN6FTvX/wE87apwS8HCpWNLHMIde0JYtJVPLwbsg== X-Received: by 2002:a0d:e6cc:0:b0:56d:3b1a:8641 with SMTP id p195-20020a0de6cc000000b0056d3b1a8641mr516908ywe.23.1686708868335; Tue, 13 Jun 2023 19:14:28 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::e]) by smtp.googlemail.com with ESMTPSA id p3-20020a817403000000b0056d30f1b508sm1463931ywc.107.2023.06.13.19.14.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 19:14:28 -0700 (PDT) From: "Vishal Moola (Oracle)" To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Vishal Moola (Oracle)" , Matthew Wilcox Subject: [PATCH v2 5/5] mm: Remove is_longterm_pinnable_page() and Reimplement folio_is_longterm_pinnable() Date: Tue, 13 Jun 2023 19:13:12 -0700 Message-Id: <20230614021312.34085-6-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230614021312.34085-1-vishal.moola@gmail.com> References: <20230614021312.34085-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8425BA0003 X-Stat-Signature: ziecs6o83m4rn69zc43xi8x4nbp17rq8 X-HE-Tag: 1686708869-204326 X-HE-Meta: U2FsdGVkX18CS4FeD1TqtE7k1CWamW9aM69mTA7LZLQzszBTqGrVt/fKyookAruByilhg0/O7gPWKBUCiUHPwo8w/Jghhu4aKLWvVIyl/zlORbDaqXd4YkVrI/cR8Q4DjmLyqXRJAF0zVMcsN96eWtaEGyOz8DhExY7KoXOzCe3zzbu5VVp2u/py+3RQOGMYtVhI9Qr9SMipI3kgC11qrVDd+Pyfcro1SrSBEw7zsSmqkiHh84thBENvQsXmaBT+fR25RB3B40ijGkS0jCBbk9CMmZrBR3skVeUd5xaqYB5dxUKDiFrN9JJQ+v6dJJ1mH/JVUfdxhFzxNaWz1KNLK+gCF4UWkacytw8deCvo0qBSNGTI9RrL5hmjP6e+WLmbDDXP3urdCkVjbNwlUBAfqHFihownk8eb90hAcmtUaqBwtb2Clq8bDY+UAYIQo3KzTxSiBp/AyALE1BGi2W+0VvlZc8mkxC6V7UqqPT0uXCpUn+8dElmI2A1vhonsKRPnN2y+gXrtW510pIGals47iLWRwjKZCJDw8DjbGCFZV0IPlDmNhpI5MVJePhDC/56xeXBmtJcEUztN0LEB6wqYDWHTVkkx5l+4cFeqjsHHGbL55T+1HzyqGUc5j1OKO5wGiLF/Cnd0Ru8oAHeXreieWUTkxTMYQYvbEMxXlvBa68pHW/0esNPeGTht59hEbYn46AUrOMnpRF+2Al/YzDrmHVI5ikGJpJ993kUt4byKWAjl0mZceTKpVA2H3egVN/6cK1daeT+tzXfByx/QL88WYbY9MkK2eN6hpas/pcMw9Ac/Tgnvt39WZNL/1x/8I+sO151T/U3CDPGuimo1zSy7F0TFdDlGRA4TIpp4aYfIdzHcjrZw6jQ0KL5oKsPVKjZrOjaTs5E2hwHl9xe6vFJWZGIxHiLz7Q8WlPLVkhoqW0Q7KjHbe9dilgYaRPT5rmoUuNCasXBnXxkDhImrcI3 FLGhaXUQ vWx0PEX0rBJKQSOFRwvL8oWKK0Rp/HNodcKXm+OOCnuGvF2ZXHBb6tYlnDvKDRTpM2YrZMGEtOLXQmSNB6inLIlLoUP116CfjSINlOMn57kFH1LqECIrgO9iylSkqugSv2KRE3vAgfQHR8HPNfuZLbeYCjUm3moQp3VFw62g/UE9tS4QhaIoddu9OwW13m0ZVE4rw7tDwHsDcoJvgEXSJmUNDB86K9lvXivHoL/YoGWbvHwtpnmbV0ejuPtbsv340aerkQ2vKEVxpcpyEEzQzt8kr7Y3MeqOaWSlpKPe8ZmBjahPNFrlvhWcssgTaUZg8LfcQYtIpMYazTViVP/wTIKAwyQTyta6Mq57z+pyzoTpm24BW7efujaUfRUVLvWunvNpG5P42vW9G8lT/R915CAl8nKBqG3pyYtoEztJZOAGKodTPITvyI/cOZpbSe76SWqNblqGtodCbdydF0bzIHwKkg/vO+tvsAkyubgrsUsu5XXkg92itacTS2aFjbA7jb2zwtdLawZXVnCizs9/jMm0PGeNyoAfDMm/205lvJ5pfVrUvTSDTHr9EfTmFMNYmJsyZppTFzrgSZ3JiUx1O6MBVQevKRtLj3xN7ZN7AXHZMa9FaVslgSCNYJL/YKV6bwy8o X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: folio_is_longterm_pinnable() already exists as a wrapper function. Now that the whole implementation of is_longterm_pinnable_page() can be implemented using folios, folio_is_longterm_pinnable() can be made its own standalone function - and we can remove is_longterm_pinnable_page(). Signed-off-by: Vishal Moola (Oracle) Reviewed-by: Matthew Wilcox (Oracle) --- include/linux/mm.h | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 27ce77080c79..e2d35e272e07 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1910,39 +1910,35 @@ static inline bool page_needs_cow_for_dma(struct vm_area_struct *vma, return page_maybe_dma_pinned(page); } -/* MIGRATE_CMA and ZONE_MOVABLE do not allow pin pages */ +/* MIGRATE_CMA and ZONE_MOVABLE do not allow pin folios */ #ifdef CONFIG_MIGRATION -static inline bool is_longterm_pinnable_page(struct page *page) +static inline bool folio_is_longterm_pinnable(struct folio *folio) { #ifdef CONFIG_CMA - int mt = get_pageblock_migratetype(page); + int mt = folio_migratetype(folio); if (mt == MIGRATE_CMA || mt == MIGRATE_ISOLATE) return false; #endif /* The zero page may always be pinned */ - if (is_zero_pfn(page_to_pfn(page))) + if (is_zero_pfn(folio_pfn(folio))) return true; /* Coherent device memory must always allow eviction. */ - if (is_device_coherent_page(page)) + if (folio_is_device_coherent(folio)) return false; - /* Otherwise, non-movable zone pages can be pinned. */ - return !is_zone_movable_page(page); + /* Otherwise, non-movable zone folios can be pinned. */ + return !folio_is_zone_movable(folio); + } #else -static inline bool is_longterm_pinnable_page(struct page *page) +static inline bool folio_is_longterm_pinnable(struct folio *folio) { return true; } #endif -static inline bool folio_is_longterm_pinnable(struct folio *folio) -{ - return is_longterm_pinnable_page(&folio->page); -} - static inline void set_page_zone(struct page *page, enum zone_type zone) { page->flags &= ~(ZONES_MASK << ZONES_PGSHIFT); -- 2.40.1