From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Peng Zhang <zhangpeng.00@bytedance.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
Subject: Re: [PATCH v2 0/3] Optimize the fast path of mas_store()
Date: Tue, 13 Jun 2023 13:23:52 -0400 [thread overview]
Message-ID: <20230613172352.u4oj5ydoloztvdqk@revolver> (raw)
In-Reply-To: <20230609120347.63936-1-zhangpeng.00@bytedance.com>
* Peng Zhang <zhangpeng.00@bytedance.com> [230609 08:04]:
> Add fast paths for mas_wr_append() and mas_wr_slot_store() respectively.
> The newly added fast path of mas_wr_append() is used in fork() and how
> much it benefits fork() depends on how many VMAs are duplicated.
>
> Changes since v1:
> - Revise comment and commit log. [3/3]
> - Add test for mas_wr_modify() fast path. [1/3]
Thanks for adding the tests. I'm just trying to figure out how to best
address testing this in RCU mode. And by testing it I mean add tests in
RCU that does this and detect the failure by modifying your code, then
change it back and have it pass the test by falling back to node store.
This would need to change tools/testing/radix-tree/maple.c to update the
testing there.
>
> v1: https://lore.kernel.org/lkml/20230602075353.5917-1-zhangpeng.00@bytedance.com/
>
> Peng Zhang (3):
> maple_tree: add test for mas_wr_modify() fast path
> maple_tree: optimize mas_wr_append(), also improve duplicating VMAs
> maple_tree: add a fast path case in mas_wr_slot_store()
>
> lib/maple_tree.c | 69 ++++++++++++++++++++++++++++---------------
> lib/test_maple_tree.c | 65 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 111 insertions(+), 23 deletions(-)
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2023-06-13 17:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 12:03 Peng Zhang
2023-06-09 12:03 ` [PATCH v2 1/3] maple_tree: add test for mas_wr_modify() fast path Peng Zhang
2023-06-09 12:03 ` [PATCH v2 2/3] maple_tree: optimize mas_wr_append(), also improve duplicating VMAs Peng Zhang
2023-06-09 12:03 ` [PATCH v2 3/3] maple_tree: add a fast path case in mas_wr_slot_store() Peng Zhang
2023-06-13 17:23 ` Liam R. Howlett [this message]
2023-06-14 11:10 ` [PATCH v2 0/3] Optimize the fast path of mas_store() Peng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613172352.u4oj5ydoloztvdqk@revolver \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=zhangpeng.00@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox