From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C29CBEB64D7 for ; Tue, 13 Jun 2023 21:22:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41E968E0003; Tue, 13 Jun 2023 17:22:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CE5F8E0002; Tue, 13 Jun 2023 17:22:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26F5B8E0003; Tue, 13 Jun 2023 17:22:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 12A6D8E0002 for ; Tue, 13 Jun 2023 17:22:32 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CE8FB160610 for ; Tue, 13 Jun 2023 21:22:31 +0000 (UTC) X-FDA: 80898998502.30.88C6660 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf04.hostedemail.com (Postfix) with ESMTP id E41FD40018 for ; Tue, 13 Jun 2023 21:22:28 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Ktgo8zSr; spf=pass (imf04.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.177 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686691349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wWRudrPnHjVGc5oCn6M809kCQsjvZKoLo1qzFLP37Us=; b=y7fq0TunzlGxyXaokFE80RW9K2lHHp/5fwofVMXpSAL9V2zztZi0Wy2nAv2igzCf9hxxnS 9EgdXR6q+cW8QpSHLCCvUYtl8CjABbS4DogKf6z5K40a+5Tvb0ULRp4RUuDse0sCNOr7X1 L2u9s9Z1TfnpI5XeSa4JcPZ6Xu1s7ps= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686691349; a=rsa-sha256; cv=none; b=EeVBNqKWA2hwznycFTyFkGGa3YgUI/XrL4O7oO2v2/5fF9T/JObOc/fXDETTG18LsGq6+n R7qJFDVgiZyrRKa+j1EifKQ4cmcvzkRj0vVFVwFzNiKmYgQ+pa0VnRjQqjBKxXd5+pMWpn wloDqHf+KFuuzIsap9wINbjQOhiPYpk= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Ktgo8zSr; spf=pass (imf04.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.177 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-652d1d3e040so4599880b3a.1 for ; Tue, 13 Jun 2023 14:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1686691348; x=1689283348; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wWRudrPnHjVGc5oCn6M809kCQsjvZKoLo1qzFLP37Us=; b=Ktgo8zSr8EXXB2UzZLgdhE6zaCRIeHoRMwBb1uUA1A9M3CTZ+2BYMnYKR2PzOHPNwa YWDiUp1WSeHQkJDCpGcgRLHm9/AGUtAYL1oeHSQmkxlym0jpb8Pr2lf6FjB/QY+fD9Bz oU9HOHcqvQec/HPDkxKJvpmw5IMRk3QcXazpw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686691348; x=1689283348; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wWRudrPnHjVGc5oCn6M809kCQsjvZKoLo1qzFLP37Us=; b=G7487bbCenWK68hr5wsHjOHWkMrYWP/nvhWPpQTxXbm1dXWmN+nL8+LLokgnYMyaDj 8XopwPlQgfDCqt1CaMBgIkV5j+ewoMC8YRHnh74uMMeEHrPvWU/SluuUDH6Peq8ZYE/8 q6rnCc+7FBReC/Hr7ucuHSNYcKuoEeIpXmajqJQcPE/zZiFyE5pRMcgkc0Ne+z71xNso zreH4l4SUqJB2wGu+xNwPP3yEdazUffwhLupi3evYaECNHzfXKRheYPpMgVxxNSSL7JA eQ4BLxXyu1rIwQS0XKKqlbtHblDIC6tPyrh4Ufz7w6Ml9vIVZT3cH3eECosKinfq+Qeg RwHQ== X-Gm-Message-State: AC+VfDxGuAtDCDYnjQeUiD5j0+tPz+EU42Qdy2wSWyvnQc86T/gAGhXG Kp8kknpbUvOxOJrum9uKvL3EmQ== X-Google-Smtp-Source: ACHHUZ7Hnj2dBGCbwSlRjBAKHsJQ2zREIGLpMzHssRYQlX+brI0ocqWinP2aG4ynfZVSI0C/+C81Cw== X-Received: by 2002:a05:6a00:14d0:b0:64c:c5f9:1533 with SMTP id w16-20020a056a0014d000b0064cc5f91533mr16110132pfu.33.1686691347806; Tue, 13 Jun 2023 14:22:27 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id u5-20020aa78385000000b0064d4d11b8bfsm8986934pfm.59.2023.06.13.14.22.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 14:22:27 -0700 (PDT) Date: Tue, 13 Jun 2023 14:22:26 -0700 From: Kees Cook To: kernel test robot Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , "Gustavo A. R. Silva" Subject: Re: [linux-next:master 3357/8413] drivers/scsi/FlashPoint.c:1712:12: warning: stack frame size (1056) exceeds limit (1024) in 'FlashPoint_HandleInterrupt' Message-ID: <202306131418.35B5D649DC@keescook> References: <202306100035.VTusNhm4-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202306100035.VTusNhm4-lkp@intel.com> X-Rspamd-Queue-Id: E41FD40018 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ja3n96d7iykbfksubbhk877ewuddi1ci X-HE-Tag: 1686691348-372150 X-HE-Meta: U2FsdGVkX19AuQv7h4sffwjlCgqlP3Okq4o8wLZb8ataDwG5hCgMxnwxePBdKQOOlO/qanycTu8Mx13EeCkq+u0dxJChyJcIyHzst8eNw2syIZLciT5OgcvxX9xWX4enTv1w6/pGRFyel2M0QZU8k7lDREAAQqnddCStwZfApBIKmLjvbXAVJN+1eQDtfZz73l2rDz0G315tsleViLmH028ejau7pzQotPGUKd5U9JE2HtxgozSvTg3tYppeR1N+epKxZSHSe6WFHHKqISh/E5kpjDs0VGm3CU4lMKzFbxTaEsSuf084iswIEK/UZUXcVo2YtdmGxZUR1dPS58h1ogA8rlFlTSyb6HKrAIdyBO7akHOPkCdyOLxWN4aTVDzNVKr2BrlIN7e++OBSyz+4LizM8o+IznNO1chWb4kYoogUID+4oGO5jmR/sj1zQxH5o3XSXX2obfglJki+XHGArQ/mO1nBp+J7Be+7wynz2mb55theCKAgdR6dt3AqmNscMmtyS0t+NWA5JhpJYzbO+QZAMeXc9+L8/4SjVe+TBK7TrmvfgGyVceHgaHGgasdDrN6zmz7sPhShadOlQoTd0LiR9xqrjfc2po/LGR+U98xHtMtBRyEHHp/XYvaMitlYPDZM4wZgIjgrpN7uz9Py9cBJRGoD/HddNeBtHqCpd96k0M82tw/fWQwxuPDJP9eGsAxTfQsSb9wDVc7POkmzB6qmvYtyQBnYP4xeVSaDZ0/LuomOCtEV4uHRcZOZQ7xkx8PlMQNNHBVjvcgUEuZ5IjIIh6dF9zud5AipFbbWeKm3dJ+CqR8z/Wx9yfE5/pO17u44IflftyLL0IQyls5Ligc6j1IWm/37IpQ1D+3OGx6IHp8OtafofpPdZkpv1oZraAk9LdpYQXIbz4x3+0qoy/REFiwTrreLdf5abp0STrXLVyalTWeKTZpX9rS37ZX03jbE/Cn4wevWPlRxQdo 2xQs9d9X H1bvUtYuBGGysPyqMgB7nHNVzDPJrmOOccTqqMjlYyHFWYMAoC65LWxP3vBnhSkSQ49Dc9Tr3NZGhjdFKulh649OmjTAPawNX0ukMcKuYuKqP+7XrIfxyItyCJzoYCjoa5HNqhDIIHiq9gMbTxxbCJ3j8jhmTN5JZlQPNOmRTGMoMBx6OzA6hB0n2E77maUkG7BZpMQcyeXgD/LNNotpIsumj1FuX7HsjWt/dsunBsnMzPclnq5A84cE0dJ+7876t49H/t+mkU/rW2q0OJ4Yuw7V6OEs7YV/mELNbllLiUH7YieUjh2EJ6InwbmSwhQuUcOwYmBgrBbxhx/dcE41O2I2J8yUlGtWXBbN32VHoLSn2Sx6USDpQfHJDLGQf/9J80oFF3hI08HLBIBXvWeUlnDrfwyIPQ65ivYcqFFjIdWPnjfRz9LlBJUxqV7n3WhoOkyO9LW9kR5C1gXAJ2BmWJSfMZ5CkCjEHOUAkbHDOHwsLYRunq79MrolEber7zIv58p4r/T3npsYT1NWotIQgZ4MGI8/04TOee32rmcKKqE1RYo3rTEPw0NcvMMANgkj2A74ryEprzDKHvOr1i8oCj35woglrHRS1xyjFHPPqyVDGxZJnnP0fMapuVg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003214, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 10, 2023 at 12:58:23AM +0800, kernel test robot wrote: > First bad commit (maybe != root cause): > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 53ab6975c12d1ad86c599a8927e8c698b144d669 > commit: df8fc4e934c12b906d08050d7779f292b9c5c6b5 [3357/8413] kbuild: Enable -fstrict-flex-arrays=3 > config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20230610/202306100035.VTusNhm4-lkp@intel.com/config) > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) > reproduce (this is a W=1 build): > mkdir -p ~/bin > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install powerpc cross compiling tool for clang build > # apt-get install binutils-powerpc-linux-gnu > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=df8fc4e934c12b906d08050d7779f292b9c5c6b5 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout df8fc4e934c12b906d08050d7779f292b9c5c6b5 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=powerpc olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/ > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202306100035.VTusNhm4-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > In file included from drivers/scsi/BusLogic.c:51: > >> drivers/scsi/FlashPoint.c:1712:12: warning: stack frame size (1056) exceeds limit (1024) in 'FlashPoint_HandleInterrupt' [-Wframe-larger-than] > 1712 | static int FlashPoint_HandleInterrupt(void *pcard) > | ^ > 1 warning generated. I wasn't able to generate the warning with my Clang, but it sure is close! Building with KCFLAGS=-Rpass-analysis=stack-frame-layout I see: In file included from ../drivers/scsi/BusLogic.c:51: ../drivers/scsi/FlashPoint.c:1713:1: remark: Function: FlashPoint_HandleInterrupt Offset: [SP-4], Type: Protector, Align: 4, Size: 4 Offset: [SP-8], Type: Spill, Align: 8, Size: 4 Offset: [SP-12], Type: Spill, Align: 4, Size: 4 Offset: [SP-16], Type: Spill, Align: 16, Size: 4 Offset: [SP-20], Type: Spill, Align: 4, Size: 4 Offset: [SP-24], Type: Spill, Align: 8, Size: 4 Offset: [SP-28], Type: Spill, Align: 4, Size: 4 Offset: [SP-32], Type: Spill, Align: 16, Size: 4 Offset: [SP-36], Type: Spill, Align: 4, Size: 4 Offset: [SP-40], Type: Spill, Align: 8, Size: 4 Offset: [SP-44], Type: Spill, Align: 4, Size: 4 Offset: [SP-48], Type: Spill, Align: 16, Size: 4 Offset: [SP-52], Type: Spill, Align: 4, Size: 4 Offset: [SP-56], Type: Spill, Align: 8, Size: 4 Offset: [SP-60], Type: Spill, Align: 4, Size: 4 Offset: [SP-64], Type: Spill, Align: 16, Size: 4 Offset: [SP-68], Type: Spill, Align: 4, Size: 4 Offset: [SP-72], Type: Spill, Align: 8, Size: 4 Offset: [SP-76], Type: Variable, Align: 4, Size: 4 Offset: [SP-80], Type: Spill, Align: 4, Size: 4 Offset: [SP-84], Type: Spill, Align: 4, Size: 4 ...[4 byte spills]... Offset: [SP-1012], Type: Variable, Align: 4, Size: 4 Offset: [SP-1016], Type: Variable, Align: 4, Size: 4 [-Rpass-analysis=stack-frame-layout] So something is very weird in FlashPoint_HandleInterrupt -- it has a single while loop with an internal if/else if/.../else chain. So I don't see why it would need such extensive spills... This seems like a missed optimization in Clang, maybe? -- Kees Cook