From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E44EAC88CB9 for ; Tue, 13 Jun 2023 10:19:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B64E8E0002; Tue, 13 Jun 2023 06:19:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 366736B007E; Tue, 13 Jun 2023 06:19:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22E5E8E0002; Tue, 13 Jun 2023 06:19:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 12A576B007B for ; Tue, 13 Jun 2023 06:19:13 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E4FAC1A046C for ; Tue, 13 Jun 2023 10:19:12 +0000 (UTC) X-FDA: 80897326944.06.1D22CCB Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf04.hostedemail.com (Postfix) with ESMTP id A403C40020 for ; Tue, 13 Jun 2023 10:19:09 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Q1Hjnwp3; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf04.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686651550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f13/Z50cOLWv87IeaJprTAVuaS95gM9WY09vW3KFL2E=; b=fSXmr+78hPXu60KoKYHI2XYSRcE84UPlmquWDw2e1TziaJWhQ/bbA9he6ubIis+HTS4LpA jzQ+BOsjO3ZUs+lgO//EMXGndnyUI+o8Kavci9XMz4hpuwbw5qaFu+xxGYfyWGF2j3Isw5 kXC7j4JBanzn8p1Gx2y9q4u3Ysu8IX4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Q1Hjnwp3; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf04.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686651550; a=rsa-sha256; cv=none; b=xiPmImrYzdyFVsssdUXuelLMPUswBZrWHyzLuOvj3WmQGKcgrN18T8VSIkwR3oykG9Aaje m9S00Cxtm/g8UhjO9ai/hBXEHTh9tDdNmQF6pV8lH2EXbpMkEdDOHNgPWc0GEj1T0/z5N9 hPsS6qi8Z+vgmztM3y5q7Yj/5x9J+OM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686651549; x=1718187549; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=PQ9SSE+dMfofmg/Jm7X/ua46UeTu5f5xwyyaNzG+ZSc=; b=Q1Hjnwp381/ZJhZGaFDrGwj/50RjT9cqk1RMmb6762fXYexuLwzF8OOJ /eBy6aJnddFu5IVw5kfGKRsOsypT4TzaJMiS3Ci3zp9TuTPBWAr35klfn Yzp5thNIDeGLXgWQybYZu/B1ZU7I4M3J2e5Q2HQPkDSaXDPn/SuyF6/Ut dDUFDeEoFNANyBpl4oZkrs5DYRo4CtafBj9GXZm/9dtiL+KX8wHFaKXH9 PlAaAdEGSb9DBNvppjkiuHv7muosRfKkgw81zFd38LZjKmfK4Baci/Gkw 1RgLGhSpZ4eBrsY5UPoBwWdjmq5K7bX2PcZrm9LeUvBf+kB2WDaMoZ7Te A==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="360769961" X-IronPort-AV: E=Sophos;i="6.00,239,1681196400"; d="scan'208";a="360769961" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2023 03:19:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="1041703071" X-IronPort-AV: E=Sophos;i="6.00,239,1681196400"; d="scan'208";a="1041703071" Received: from attilavx-mobl2.ger.corp.intel.com (HELO box.shutemov.name) ([10.252.62.33]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2023 03:19:02 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id B7E8D10BB6B; Tue, 13 Jun 2023 13:18:59 +0300 (+03) Date: Tue, 13 Jun 2023 13:18:59 +0300 From: "kirill.shutemov@linux.intel.com" To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "Yamahata, Isaku" , "linux-mm@kvack.org" , "Luck, Tony" , "Shahar, Sagi" , "peterz@infradead.org" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" Subject: Re: [PATCH v11 11/20] x86/virt/tdx: Fill out TDMRs to cover all TDX memory regions Message-ID: <20230613101859.lwqlwa4t72sthvwk@box.shutemov.name> References: <927ec9871721d2a50f1aba7d1cf7c3be50e4f49b.1685887183.git.kai.huang@intel.com> <0600959d-9e10-fb1f-b3a9-862a51b9d8e1@intel.com> <201af662-f700-9145-c113-563e378074ad@intel.com> <89c99e7360dc2acfe5fb56c2bbb40e074e1f94d5.camel@intel.com> <20230612143355.sur7zc7byu7omxal@box.shutemov.name> <3e188621d97af794f03072e5261dcc9f589900aa.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3e188621d97af794f03072e5261dcc9f589900aa.camel@intel.com> X-Rspam-User: X-Stat-Signature: ah1wpia4m97e7qa5bb1pjoejg3mpu75m X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A403C40020 X-HE-Tag: 1686651549-442900 X-HE-Meta: U2FsdGVkX1/3UWOsTpuZG//j/FbVm0DUoHwuG6yY0zZohtLURNxC0n6RQbU1mHpb1HvjkXCCg2wtfuRan6jDGsdzPi5ZlR3Do3QpbMzU0ox7lKM1BEPkFXDcUPZ3RdUHyZ73WcFrnbrywU0CY7O6/HBOFQuwT3souANyQwQUSH6Af7GhluY/fyXnVDLoDpaeEWvxksNMkcEwb0En4/5csccIiEYVzM31ZysLLhBptxE5pITKXiGUYVi7Iuy31aKfPRcNgbCmDtVCevrv83qENiXqndVgEN95+IVWeFNwc6/4vMiUe1uzOOMrngNW++QvhnHF9EIaNWy7o6qwDGHYaOewScOb6GsJ6y0ffXHwEnsU6NfZa2PDg5K9M2/kV7kyFsaHbKZ9MfaG35/xN5pDeDAtjIS5zXrW2YSh3R8MGJO6loHa8sfNCz9ogaMmtFJtin4NaAGOXevLL5QOnfD0EDxubvJoavEGi7ZEJFJ+itMDS+SS07JjE+ffhHKIXyE2KZdXuGN8do+M0u53CYJCnzQ1NrnR5obHc4lboHJY2lySV94krjxmua+b8AXQQHCKsCmQYr51TQKKVER2SHijIVOiV/uXtXatEd4LLj/hAQGlHOZotI4F3B+YFLQIoUQVsq1kEf9v6utXtG/EASj+u+vR70WpwzDcWg8qadJ3Wg8tI6Euddp2p3EqmhjMFuqQhnRKQNfd19GxYybgoxBgZ5GbIL9ESEsnzBN2dCX99wwNmefi7FlzrsfIuImfg5lKJiBm/OWx8/LcLRuGmBNJEwgVPp8SEImmO5FcVuSsEzsb+7T2KDLPkKdoTKuXrBjzf/ElfkC+jKpJN79Sh3kyl3TilVwmeee68lTgLszVBte2fJtwuUJuGQ5hNCn6lfWnBg6hzBBwh+g5it+h0Ky842KYWvJJSHTdx3Yj6ktJKgFX4j5QLEKoimhINX48+M35C6GxIwDMlnjLzZ0Jz4d yT+NBLKo YJ+BkvUSsjMVGmnZzc2p0P3BVemQq0zicLdM7xY4mIijbH9vvxvJykT115EuhMyOOXKctJNiECDzLIm5OVEJ+6yKcZupN4NDlw36Kj3/dxTBOyM+IJx6a2KHWRYVcEDfR6rExc3puFQIVv0iBDc0EOQWRlRidTUqalEU4hIy5CSa1d9Z8f1nfNO662w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 10:10:39PM +0000, Huang, Kai wrote: > On Mon, 2023-06-12 at 17:33 +0300, kirill.shutemov@linux.intel.com wrote: > > On Mon, Jun 12, 2023 at 02:33:58AM +0000, Huang, Kai wrote: > > > > > > > > > > > Maybe not even a pr_warn(), but something that's a bit ominous and has a > > > > chance of getting users to act. > > > > > > Sorry I am not sure how to do. Could you give some suggestion? > > > > Maybe something like this would do? > > > > I'm struggle with the warning message. Any suggestion is welcome. > > I guess it would be helpful to print out the actual consumed TDMRs? > > pr_warn("consumed TDMRs reaching limit: %d used (out of %d)\n", > tdmr_idx, tdmr_list->max_tdmrs); It is off-by-one. It supposed to be tdmr_idx + 1. -- Kiryl Shutsemau / Kirill A. Shutemov