From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96438C88CB2 for ; Mon, 12 Jun 2023 16:04:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10B138E0003; Mon, 12 Jun 2023 12:04:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BC028E0002; Mon, 12 Jun 2023 12:04:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC4F98E0003; Mon, 12 Jun 2023 12:04:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DF9488E0002 for ; Mon, 12 Jun 2023 12:04:12 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9D749402AF for ; Mon, 12 Jun 2023 16:04:12 +0000 (UTC) X-FDA: 80894567544.03.CD2878B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 182DD8017B for ; Mon, 12 Jun 2023 16:02:41 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=epqC8+rm; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686585762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KTdM5oJB8FnG27FfWhVdtLSlax0njnZ6kYgEihvhzR0=; b=5cGcF+iSrgRU1gIQqCApPUsDOvcpbjS2xstZwnTsufb5Vm+z9LA3DNaiMyv2zQ0xGJExrj Tao9J9Bs1fWefbu4/OophTCZMw39pkpjIadsz4laUNGNTu/XV/vlgW/+iRn2R9GOVdiWCr Ev47SilXqPw9woH4FN6j3IR+HlzuQDQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=epqC8+rm; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686585762; a=rsa-sha256; cv=none; b=GUKWNNCkLiq+65DDbr8gx8P99sAujxBEv5YXsztbcVO8lowQgigI9A8NR/dw8X/tp3tBGw /PrulfK9LFfUcK8yYvhE17+ga3DO4PAcCjGeTlfEi0sHdaNBiMbogjTvuUZV6Nr5g3Q7KX DIpRQkHfVadpq6C+OSH6J6PpARe0MzY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EA2296144D; Mon, 12 Jun 2023 16:02:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3ADE1C433D2; Mon, 12 Jun 2023 16:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686585760; bh=Cw8/v58Xwe9nL7yTk1IkL4cO65ODqpxDl2gTcvbhl3s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=epqC8+rmPDl+BzBaPqK8iPO5GY2MfOWKrl9+fdaLf2x9qOH4UJnmnHT7N140y6g3L Vq1Wdf/Nc3kYloaEu/NdI/4N7ZpHmGMTFcEchMqJDX+a7usWKgZNg9X097J1IglqZG V0sMpHL/tY7r3M1XGzo5yDodJJEFIJr2DSjiwCN76R2WGDcNxTG9MB6+OGph59BGhI zzXsCR/Sq6eJtqXu7v2qAC9m2XUOdpx5CA4ugsdN5cTHf+mUKkcctvIfEP4rhl29hU 4tuIloBLb2UgEOSVC60yxOuGH3E7/Gn5bopZq/OJqk+wTK25LqIncxPClX/YEyYrVl maL8Z7Z+IBPoA== Date: Mon, 12 Jun 2023 09:02:37 -0700 From: Nathan Chancellor To: Baoquan He Cc: Mike Rapoport , kernel test robot , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@lst.de, willy@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, deller@gmx.de, Brian Cain , linux-hexagon@vger.kernel.org Subject: Re: [PATCH v6 02/19] hexagon: mm: Convert to GENERIC_IOREMAP Message-ID: <20230612160237.GA199007@dev-arch.thelio-3990X> References: <20230609075528.9390-3-bhe@redhat.com> <202306091859.NhlW2nny-lkp@intel.com> <20230611054019.GL52412@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 182DD8017B X-Stat-Signature: 6ez3rsezer9f9mwzxbfmj6fggoopygfm X-Rspam-User: X-HE-Tag: 1686585761-119152 X-HE-Meta: U2FsdGVkX1+dbAoUepxJMqNOQQOsglyo/ACw8iC4GWeLFSftO3fboIJaOpP5+zFNXLiOVbzeCkuoYhdaTxa072BoQAfgDyLELxuea2BhtGkW3QnvV0qn9QURG4D9K7jvzWg1eR7iz7G772U8579cGcgnWgJchZWzDkRAzD+xnYU6io8Ssaz5iAdDTefcKiGabYzzA7f35Jwfv4qb8SrQvGiRgRDr8Kl2hZMqzSZ/jvYCdaeKWoArOFi6JGhsRB3CnqqmOhTZ0GquRdaw6dSZ9Mkg7h1q9CpifA4Z9Zl2eSlj2wZUBfVtFDcdTP0Q+mRbWv4eZHGJQvY3YYkLSVu+jETrkLzgi3OWilFjDq/fBOmnxTSf1dfnrUrP4kHJ4+vjV+bFv8e33/PHlCHKLeXxfMpFgdpPDOHnKLgDQERze8k1ic2g65DBep86PnBacKJy3sSEEMNSgcCsJ5fXfOQF7pzjsVh9S7BfwgRp4HpPOjQhIWKWSm4agNRK0S0E2pK6V9qzZ4HL1eQ+QVWI1GaLmBJJrjyFQxLvEmrCsVSUQNsLq5CDT7Ki40RN1hDlD9gO0tNq76nk4vMwP+Yj59q4ZWGKjLHho29Mh7+6sRwEcP2wtPizl99CPzfAA+mH9fVRmWtXNee3VbZpXznOiCkA18zIYcCYjFkexD+vrQWSIQrFDmKaXR/7ytfEdHMdV/JcrQfYrgXsbq2s+vFqvULVsnw+MvwNsYdQukXqGI+kQBQc7spRp459oufBsvPJ78oPUuC1rLIPfA3RFBp0hiI4311J27EpmsZa/qkkXTilKlFJdZoaG7qAVh7CRw+0IGbvcKxeczWDY8w66b2WtAAAs8JYemoSfV1qWFkswT3Kd+ygEWhswVvUQ6Gx6szesmedCKaF7UuW80D7+JpW1QQafjWDJk+ZZrwh+AfwHhoO1jtWiX7W5qFzeYOH/m3ljZop/Pf2oHpLHpxZ+4mRMqm yPOQAbhj KihWim/j+rH3TqQbR7txH0ahKkqxXHpAFcsy2m4reUAiKPHN9xQ0J+HDUJwXkrYB6jjFjGeqeoks/6TwU0eroUmnb/MVgV8OCE+51zO1KxGq9/xU1V4GwtgggL8ussy5vV7ou3NXs9RpWGcVqyPb8puYcsN/CDYDgv5YNFSG47NlOhM05y+FM5JJT89xbFs+JOoZVpH34hlIVpgeDPlk60+fZ3Z4GdhNYI9kiT+NCKMdSmFEKvP1xwWzBBY+RaVdpDRIIc54Tvk8HdzspQd6PNU5dAe5Y7iiqdTT/F/LwYhNIXDE0ZsY4PX8b/lzPqc/15uyuZk6BxxV8WJq9GRUJY8RmyJ89duGwObRBbjmpwuiXHZzBmNeSP0OP70m9dfbC3C4oxT0iXvMqVYc/usHvLsJzGTMkAvXIlKr2NmyGF+ohIHWz7t9a63j20/hIcg/9tJB3/e8qAwG0qJf5S0iqws2VwskhlETlIfghgfnlJiqivDpeIhnHXqi7AMrmkieT+OYGJUOhw+PiRw3o2IdU4dXT9NeUqH3KUd6U+cqxEKy0WoYGdQB76w2Xv/hv8oiaQDEbo3yW36pC1F7N87ac0TgyWQoZSyyMukKZqfkKPHIcQZ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 11, 2023 at 03:57:32PM +0800, Baoquan He wrote: > On 06/11/23 at 08:40am, Mike Rapoport wrote: > > Hi Baoquan, > > > > On Sat, Jun 10, 2023 at 04:26:21PM +0800, Baoquan He wrote: > > > On 06/09/23 at 07:09pm, kernel test robot wrote: > > > > Hi Baoquan, > > > > > > > > kernel test robot noticed the following build errors: > > > > > > > > [auto build test ERROR on akpm-mm/mm-everything] > > > > > > > > url: https://github.com/intel-lab-lkp/linux/commits/Baoquan-He/asm-generic-iomap-h-remove-ARCH_HAS_IOREMAP_xx-macros/20230609-160014 > > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > > > > patch link: https://lore.kernel.org/r/20230609075528.9390-3-bhe%40redhat.com > > > > patch subject: [PATCH v6 02/19] hexagon: mm: Convert to GENERIC_IOREMAP > > > > config: hexagon-randconfig-r041-20230608 (https://download.01.org/0day-ci/archive/20230609/202306091859.NhlW2nny-lkp@intel.com/config) > > > > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) > > > > reproduce (this is a W=1 build): > > > > mkdir -p ~/bin > > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > > chmod +x ~/bin/make.cross > > > > git remote add akpm-mm https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git > > > > git fetch akpm-mm mm-everything > > > > git checkout akpm-mm/mm-everything > > > > b4 shazam https://lore.kernel.org/r/20230609075528.9390-3-bhe@redhat.com > > > > # save the config file > > > > mkdir build_dir && cp config build_dir/.config > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=hexagon olddefconfig > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=hexagon prepare > > > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > > > the same patch/commit), kindly add following tags > > > > | Reported-by: kernel test robot > > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202306091859.NhlW2nny-lkp@intel.com/ > > > > > > Thanks for reporting. I reproduced them on my local machine. Below patch > > > can fix them. And by the way, I also saw the clone3 warning, and have to > > > made change in scripts/checksyscalls.sh to mute it, wondering how you > > > handle it in your testing. > > > > I think the warning kbuild reported is rather this one: > > > > >> include/asm-generic/io.h:1078:6: error: conflicting types for 'iounmap' > > 1078 | void iounmap(volatile void __iomem *addr); > > | ^ > > This one is reported as error. The old iounmap() declaration has a const, > while the standard one doesn't have. So I just remove the old one to use > the standard one. > > Another one is warning about PCI_IOBASE. Because inb/w/l and outb/w/l is > redefined in asm-generic/io.h, and it uses PCI_IOBASE which is defniend > as NULL in asm-generic/io.h if ARCH doesn't have its own PCI_IOBASE > definition. Then the warning is triggered. So I define macro to override > the standard inb/w/l and outb/w/l. > > #ifndef PCI_IOBASE > #define PCI_IOBASE ((void __iomem *)0) > #endif I believe that this series [1] by Niklas Schnelle should take care of the PCI_IOBASE warnings (which are not Hexagon specific), so there is no need to worry about them when they show up in build reports. [1]: https://lore.kernel.org/20230522105049.1467313-1-schnelle@linux.ibm.com/ Cheers, Nathan > > > stdin>:1520:2: warning: syscall clone3 not implemented [-W#warnings] > > > 1520 | #warning syscall clone3 not implemented > > > | ^ > > > 1 warning generated. > > > > > > ------ > > > diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh > > > index 1e5d2eeb726d..3a369b78edb7 100755 > > > --- a/scripts/checksyscalls.sh > > > +++ b/scripts/checksyscalls.sh > > > @@ -148,6 +148,7 @@ cat << EOF > > > #define __IGNORE_nanosleep > > > #define __IGNORE_io_getevents > > > #define __IGNORE_recvmmsg > > > +#define __IGNORE_clone3 > > > #endif > > > > > > > > > From 6a86f4360a61a2b7b4d71172e5c03be554367553 Mon Sep 17 00:00:00 2001 > > > From: root > > > Date: Fri, 9 Jun 2023 21:21:36 -0400 > > > Subject: [PATCH] hexagon: mm: fix warning in asm/io.h > > > Content-type: text/plain > > > > > > Remove the old iounmap() declaration which is not consistent with the > > > standard one in asm-generic/io.h, let's use the standard one. > > > > > > And also add macro definition of inb/w/l and outb/w/l to override > > > the definition of them in asm-generic/io.h. > > > > > > Reported-by: kernel test robot > > > Signed-off-by: Baoquan He > > > --- > > > arch/hexagon/include/asm/io.h | 8 ++++++-- > > > scripts/checksyscalls.sh | 1 + > > > 2 files changed, 7 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h > > > index dcd9cbbf5934..efe9cb00ebf8 100644 > > > --- a/arch/hexagon/include/asm/io.h > > > +++ b/arch/hexagon/include/asm/io.h > > > @@ -27,8 +27,6 @@ > > > extern int remap_area_pages(unsigned long start, unsigned long phys_addr, > > > unsigned long end, unsigned long flags); > > > > > > -extern void iounmap(const volatile void __iomem *addr); > > > - > > > /* Defined in lib/io.c, needed for smc91x driver. */ > > > extern void __raw_readsw(const void __iomem *addr, void *data, int wordlen); > > > extern void __raw_writesw(void __iomem *addr, const void *data, int wordlen); > > > @@ -207,16 +205,19 @@ static inline void memset_io(volatile void __iomem *addr, int value, > > > * > > > * Operates on "I/O bus I/O space" > > > */ > > > +#define inb inb > > > static inline u8 inb(unsigned long port) > > > { > > > return readb(_IO_BASE + (port & IO_SPACE_LIMIT)); > > > } > > > > > > +#define inw inw > > > static inline u16 inw(unsigned long port) > > > { > > > return readw(_IO_BASE + (port & IO_SPACE_LIMIT)); > > > } > > > > > > +#define inl inl > > > static inline u32 inl(unsigned long port) > > > { > > > return readl(_IO_BASE + (port & IO_SPACE_LIMIT)); > > > @@ -227,16 +228,19 @@ static inline u32 inl(unsigned long port) > > > * @data: data to write to > > > * @addr: address in I/O space > > > */ > > > +#define outb outb > > > static inline void outb(u8 data, unsigned long port) > > > { > > > writeb(data, _IO_BASE + (port & IO_SPACE_LIMIT)); > > > } > > > > > > +#define outw outw > > > static inline void outw(u16 data, unsigned long port) > > > { > > > writew(data, _IO_BASE + (port & IO_SPACE_LIMIT)); > > > } > > > > > > +#define outl outl > > > static inline void outl(u32 data, unsigned long port) > > > { > > > writel(data, _IO_BASE + (port & IO_SPACE_LIMIT)); > > > > > > > -- > > Sincerely yours, > > Mike. > > > >