From: Andrew Morton <akpm@linux-foundation.org>
To: David Hildenbrand <david@redhat.com>
Cc: Zhaoyang Huang <huangzhaoyang@gmail.com>,
"zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
Matthew Wilcox <willy@infradead.org>,
Suren Baghdasaryan <surenb@google.com>,
Minchan Kim <minchan@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
ke.wang@unisoc.com
Subject: Re: [PATCHv5] mm: skip CMA pages when they are not available
Date: Mon, 12 Jun 2023 13:56:42 -0700 [thread overview]
Message-ID: <20230612135642.24cef34a2925cdde257c1a50@linux-foundation.org> (raw)
In-Reply-To: <b72118b0-47dc-86c4-15fb-fb5ea72bcf30@redhat.com>
On Mon, 12 Jun 2023 12:01:20 +0200 David Hildenbrand <david@redhat.com> wrote:
> ...
>
> >>
> >> If it's a performance improvement, it would be good to show that it is
> >> an actual improvement worth the churn ...
> > Sorry for the confusion. As for the OOM issue, the previous
> > commit(https://lkml.kernel.org/r/1683782550-25799-1-git-send-email-zhaoyang.huang@unisoc.com)
> > helps to decrease the fail rate from 12/20 to 2/20, which it turn to
> > be 0 when applying this patch.
>
> Thanks! Can we make that clearer in the patch description? I'm
> struggling a bit my self to find the right words.
>
> Something like
>
> "This change further decreases the chance for wrong OOMs in the presence
> of a lot of CMA memory."
>
Great, I added that.
>
> In any case
>
> Acked-by: David Hildenbrand <david@redhat.com>
>
And I'll move this patch into mm-stable.
next prev parent reply other threads:[~2023-06-12 20:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 2:51 zhaoyang.huang
2023-06-09 22:35 ` Andrew Morton
2023-06-10 1:51 ` Matthew Wilcox
2023-06-12 9:29 ` David Hildenbrand
2023-06-12 9:35 ` Zhaoyang Huang
2023-06-12 10:01 ` David Hildenbrand
2023-06-12 20:56 ` Andrew Morton [this message]
2024-08-13 9:49 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612135642.24cef34a2925cdde257c1a50@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=huangzhaoyang@gmail.com \
--cc=ke.wang@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=surenb@google.com \
--cc=willy@infradead.org \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox