From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCDE2C77B7A for ; Sun, 11 Jun 2023 05:45:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 103616B0072; Sun, 11 Jun 2023 01:45:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B2C36B0074; Sun, 11 Jun 2023 01:45:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE2E68E0002; Sun, 11 Jun 2023 01:45:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DE6606B0072 for ; Sun, 11 Jun 2023 01:45:31 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 75128120391 for ; Sun, 11 Jun 2023 05:45:31 +0000 (UTC) X-FDA: 80889379662.14.B833BFD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id BBB974000F for ; Sun, 11 Jun 2023 05:45:29 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NFzJ2Oto; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686462329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YnuGzKA105s0r3wHWBoABrFsIukbfeHd/DebovYi46Y=; b=EDHs29f59MsWRjAOG8mMMV6bKm+ymq68QW+/IoJRn5Arb6Q5QiD+E+iEFgLVkq+AzEX/V5 aZmzaHPrnsPZKOofbm5ARXy6fUOWEOh3N6MDCrt++elvi35QVXiTDA+ZuErHMhrKsW3sl7 xOLmSrVtR8rXE5MiHLJdyCPEi2CUIno= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686462329; a=rsa-sha256; cv=none; b=pmlTsI1+JJF3s7BsMT1jOX+fPvERUqo54HZruZfv+YtRVYBQsMELRg55KzrxeQjgsxqm4K BYc1XtgjX451/R6W9s/bTYVOo/yrtN16TSPkSTeMTnQI9qpOC4ztaQdoDaFmwfrFxcJzhH OFF9cOUwgftjKJtkXjrY/fshW+Vm0o4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NFzJ2Oto; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C1A0860C55; Sun, 11 Jun 2023 05:45:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F9AAC433EF; Sun, 11 Jun 2023 05:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686462328; bh=n0udy2xioTBgU05GRm67QikACKmHKTs0zVskv1Tl+18=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NFzJ2OtogPgQZUttN3MDnq4YUxBIU2YS/cmf/gLqWnMQVbpBTU7MKblX3z3KRRHut g8PD/rX4lO29jMW/3MiHLOxhNnf7kmk6dBydY4lf7iF367Eqz98tMFeBXPRMJHfxAo sUvxXdleTneeyJf81JS2iJgbcFSLtH43VF1r3R+1zYG74BSs6iBtqNEEdL4/NSMoNQ VdL4CNkGv3wHeavm80Ow3pEFYN/e5ZJrBJ/UcrOepsKFZjbQWG/5/rh/dVKQee3HU8 98tCwzbacxieoTaiaahjbuMqd2xSZ7xxXxszPV+OoPtwOqQSm9uAdH1fbu0cxw5ItW 8Pr3BN2K0cePw== Date: Sun, 11 Jun 2023 08:44:55 +0300 From: Mike Rapoport To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@lst.de, willy@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@ACULAB.COM, shorne@gmail.com, deller@gmx.de, Jonas Bonn , Stefan Kristiansson , openrisc@lists.librecores.org Subject: Re: [PATCH v6 03/19] openrisc: mm: remove unneeded early ioremap code Message-ID: <20230611054455.GM52412@kernel.org> References: <20230609075528.9390-1-bhe@redhat.com> <20230609075528.9390-4-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230609075528.9390-4-bhe@redhat.com> X-Stat-Signature: ecyndwq9kywuzjxntyqyemsi4us7uxxt X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BBB974000F X-Rspam-User: X-HE-Tag: 1686462329-642053 X-HE-Meta: U2FsdGVkX1/GlCwwyhCm6/EvMt9iGK+4A2uEM/2SspXtWGksJaYSQbJ0Ie59NhTGhENg0HB1gp9ZF9v/TdS3UDa/m7/bVotNtZd6OoqFxGVJJ2oisK8vw0GQ4mTXlAk2wI7HtaGRjuki92j1mJOpznNUulKAX60atK9pcdENE3mdbNKUGHwOgceKYLdlspnn5/PUxlAOSvy+1W6VWCCUBONrmX3XjvSMScLvOhTW6k5dnMbfKix4dhksXL4dxIuEvsiqgbLlYDJin/nNxcpGWVAom6h68SpKSrfRyXpNny3DbaxH123Iw71G5dTXl1bWUsLLGkjziknlInmsa1wBBKuwysBrXuzY6yypYDpA4P5MBUwIsoF3xMz1gU3nkcVpq+PR5X15rVGzhzOtNZhxGtPxYDSFR7X1lDQmoxm1dR0zFvyrxqc5ttpuku4vOy5YpgT3utjKrsHvSIQoOFvLbybJCO1VRki44119U+qrN3HDdwGSwk1hLnKkWTNlzzUNJINasxfDTbj+htkSK8DfR2Gq/BuKUCGbTkVt/MAE+VsCrUVupHquXnYP/ZvApqW7mv4v4PbNMxhqQaM0jECrYWMP//EbJTWlA7wrSRPr7QIXahOqLMvfnAvB5MIhrvu4EiyysA3uEV0Hpulh9y5R6bGuMkpfTTMgewQ9HOgZVsv/ElQWT+6kbYljd61/w2AUrPi2GAuP+hjHheVx1oZe2WICGZ8/siUqZzs7C/xr3AaJ3C6UvsWUoqogKkCdZNL4/xRWW+5EwVnfxcGFY3rCjBZrv442ckpOge7SffCbPWDatNUADqn+E/Oy47vOK1zW0Y+FPC0/pQ/BUHYkHko2tFM2wBvb0Kp2fTdSepSQpekO+1VWUE+xNPMvZuJBzwRSff2vN2FFmnWpO0ZF3tZHDDRPQQH+QUDxeq9dUn8u413qsV9QPFybvRaMxHnQY0Ry7ZZ0g4FZsfHEOPuVVRz N+lkUkqo Q3ySkP20ltdgzT4M6k5wZmnTK/JckaBIeFADXEEAQUw+hYgaOkGRq2Mj5ScbY/nW11KVjFNE3kXaIdIEYCOVhGbgKnbu6yPM0AtDL8Il+onea2wgwi8EZQVb/AQyqrgcd6laCuIUm+LTYFp3aiIcvpGtAiiucShYWxGMaxMMIblYUendESRke3qKBhJktDGYUxr0Fwj7auH/jELYBrwmAk4Gc8GxHhMMx079FQDVlCANjjJXs/38sUr2GJof3hznMwSXGgpU6pKbGHHJeWUVLyItjgi5KTcn9V9PQq8lFzrCYg1PDqx9aIrky2i4hq7tLYmhHgz7LBenjzW9R8btjHbfp2/xl2/ecAKsDYpFSo2YYEaOdMlzyiGXFUis9lu9hEiAZx+zcrhQL4LYMpc9BZj6O84DtJACEnNJnOAOehAsBjFO1EO2/n/NXe5IXnFcYjaENqZZmcuEzE0Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 09, 2023 at 03:55:12PM +0800, Baoquan He wrote: > Under arch/openrisc, there isn't any place where ioremap() is called. > It means that there isn't early ioremap handling needed in openrisc, > So the early ioremap handling code in ioremap() of > arch/openrisc/mm/ioremap.c is unnecessary and can be removed. > > And also remove the special handling in iounmap() since no page > is got from fixmap pool along with early ioremap code removing > in ioremap(). > > Link: https://lore.kernel.org/linux-mm/YwxfxKrTUtAuejKQ@oscomms1/ > Signed-off-by: Baoquan He > Acked-by: Stafford Horne > Cc: Jonas Bonn > Cc: Stefan Kristiansson > Cc: Stafford Horne > Cc: openrisc@lists.librecores.org Reviewed-by: Mike Rapoport (IBM) > --- > v5->v6: > Remove the special handling in iounmap() because no page is got from > fixmap pool along with early ioremap code removing in ioremap() - Mike. > > arch/openrisc/mm/ioremap.c | 43 +++++--------------------------------- > 1 file changed, 5 insertions(+), 38 deletions(-) > > diff --git a/arch/openrisc/mm/ioremap.c b/arch/openrisc/mm/ioremap.c > index 8ec0dafecf25..cdbcc7e73684 100644 > --- a/arch/openrisc/mm/ioremap.c > +++ b/arch/openrisc/mm/ioremap.c > @@ -22,8 +22,6 @@ > > extern int mem_init_done; > > -static unsigned int fixmaps_used __initdata; > - > /* > * Remap an arbitrary physical address space into the kernel virtual > * address space. Needed when the kernel wants to access high addresses > @@ -52,24 +50,14 @@ void __iomem *__ref ioremap(phys_addr_t addr, unsigned long size) > p = addr & PAGE_MASK; > size = PAGE_ALIGN(last_addr + 1) - p; > > - if (likely(mem_init_done)) { > - area = get_vm_area(size, VM_IOREMAP); > - if (!area) > - return NULL; > - v = (unsigned long)area->addr; > - } else { > - if ((fixmaps_used + (size >> PAGE_SHIFT)) > FIX_N_IOREMAPS) > - return NULL; > - v = fix_to_virt(FIX_IOREMAP_BEGIN + fixmaps_used); > - fixmaps_used += (size >> PAGE_SHIFT); > - } > + area = get_vm_area(size, VM_IOREMAP); > + if (!area) > + return NULL; > + v = (unsigned long)area->addr; > > if (ioremap_page_range(v, v + size, p, > __pgprot(pgprot_val(PAGE_KERNEL) | _PAGE_CI))) { > - if (likely(mem_init_done)) > - vfree(area->addr); > - else > - fixmaps_used -= (size >> PAGE_SHIFT); > + vfree(area->addr); > return NULL; > } > > @@ -79,27 +67,6 @@ EXPORT_SYMBOL(ioremap); > > void iounmap(volatile void __iomem *addr) > { > - /* If the page is from the fixmap pool then we just clear out > - * the fixmap mapping. > - */ > - if (unlikely((unsigned long)addr > FIXADDR_START)) { > - /* This is a bit broken... we don't really know > - * how big the area is so it's difficult to know > - * how many fixed pages to invalidate... > - * just flush tlb and hope for the best... > - * consider this a FIXME > - * > - * Really we should be clearing out one or more page > - * table entries for these virtual addresses so that > - * future references cause a page fault... for now, we > - * rely on two things: > - * i) this code never gets called on known boards > - * ii) invalid accesses to the freed areas aren't made > - */ > - flush_tlb_all(); > - return; > - } > - > return vfree((void *)(PAGE_MASK & (unsigned long)addr)); > } > EXPORT_SYMBOL(iounmap); > -- > 2.34.1 > -- Sincerely yours, Mike.