From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9828C7EE2E for ; Sat, 10 Jun 2023 22:08:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B49D76B0072; Sat, 10 Jun 2023 18:08:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF9436B0074; Sat, 10 Jun 2023 18:08:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E84A8E0002; Sat, 10 Jun 2023 18:08:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8F9926B0072 for ; Sat, 10 Jun 2023 18:08:15 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4BACC140354 for ; Sat, 10 Jun 2023 22:08:15 +0000 (UTC) X-FDA: 80888227350.29.8558749 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 8CE7AC0025 for ; Sat, 10 Jun 2023 22:08:12 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=kxN1UvBn; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686434892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vsMzMS6Nwd5syKJ5RlDBrxmikTqikPJE9kXrAEn6XlI=; b=kCpQ+3uQt3HTOjvfbHYh9KgpuYK0lTd2xuDdfpuUped2wbw/eREIJ/3hziqB2d6CSVfxTQ 6JPZoAHOYNurJ5DI3hgVjJKRg2giBaGejEwC8BCyF/GwbINW65pK+PW+fdF25ldo1ZuEjV dxGYS+d0MOxI2UqPcPKjc65FsfDMjNA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=kxN1UvBn; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686434892; a=rsa-sha256; cv=none; b=5Tx81nGB7Gd2AXyLuXlG3Y359xjrGurLzyNVIveP6jEbx+HlOV7muoS2O+kZ1w8w73NGb0 nUbQGVY5kFDEBoHpbnkBsnITspze1wwTkIJJnHzAAVFTifZgu+7plxIDy1y2lWFZKsdIt3 BRUCTZtelvT/49YxrP+Od7hw+zMyBmM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3CC9960DF0; Sat, 10 Jun 2023 22:08:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B9C1C433D2; Sat, 10 Jun 2023 22:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1686434890; bh=MCsFvVy435UaO9a2k6Ch4D0TT3bNe+I9J5W8nx6Qeb8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kxN1UvBnTCZQG40Rtk8MCWrbWMEX/vfsaNnkp7tb4aTwwvgq/moKjS4R3oQ4+v0u9 L+46ZjVNWlrmWdkhMRJRzFFutZkW6pETOoy9rHjRDxoUBkdxzkcLOwG7bRrC3iSlpN dR2fI0Wa6dWu/Wd2hWBsZMwfvGWemLvsZwZTfRTE= Date: Sat, 10 Jun 2023 15:08:09 -0700 From: Andrew Morton To: Lorenzo Stoakes Cc: David Laight , Lu Hongfei , Uladzislau Rezki , Christoph Hellwig , "open list:VMALLOC" , open list , "opensource.kernel@vivo.com" Subject: Re: [PATCH] mm/vmalloc: Replace the ternary conditional operator with min() Message-Id: <20230610150809.babdc5a7919258f066c8637e@linux-foundation.org> In-Reply-To: References: <20230609061309.42453-1-luhongfei@vivo.com> <832d7c69-ffd5-4764-8ffe-3a02bef0efb0@lucifer.local> <3fc87d60-4e81-4f49-95f0-0503ad5cdf35@lucifer.local> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8CE7AC0025 X-Rspam-User: X-Stat-Signature: sh9ojrayi6zjqn9gxa43xgmknz6cozzn X-Rspamd-Server: rspam01 X-HE-Tag: 1686434892-876278 X-HE-Meta: U2FsdGVkX188O4P0TOys4LpvQA+T7PXsRbc6ADqql3ti8CifR23ywWxqxHyquF7lCQO2dbeNi+Qn/pCKJqvu5Zp0ywX7lRcm0srObmbvjzIDMsYd1nyj/OlZbmZIKxLsXYLpFY10M33ALAfqbR0bX5AI95xV7OTc2lY9A5tXCohQ3QQuwbBRHElmGvaNWfXadW51J4JD0tk+OubnUXUgqdX1qetbGvZRl9S5IXksbWCTrl8X1ZRxeH5+5Cmb3FRtZdcxmpXEgU2a0UWhgEo/uZ4s8oa/LvPdPBu7PRqvGTLZHGuGBGJC4CiEQ4rqHYoms2IJ7d1iNXXlj1CPx+aKMEY7Qs53lQe4tzgnyQEHQbms0nCDO5o77nBhjvmmDR1DG0URx8Sjj2Twg/+n9+JjUHvqAs0ak9jqYKBBlUIYdxkt0axO/awxYe4E3f/SWMms6TptJB4Voz6d7MlBqABY79ZiKtzZKDSxcGJ1iodRiU1q5Bx7WYKffLMymc2pRkBwgY2ZOhxqR341T2B9MGTGacVC5h80Ts87q9fBeLnGKqC7TyC2VbgvfnQvOIUmbq0kiSaXPi8ZX2UvPZKcoHirsC3y8StpFkx57xQ7d3hDFOvQfTY6S//jJ7p/ZujD0PPpmV9/LEbWQk8O8tRG9B4mt9rgHNy3+3SoPbtt4+0pvSQ3925nOBkn3VhkJP8F/L5QiiXb4nC9HUkrCRB10CfmxLQDG/VZPMlbVPetwAHfIelgKz5bAmvpFYxGrGKERc0/ptBJF6fhzSeMEuQtQ5ECIBntrCIWRp6h3ag6WjtdmdK2S5/dohqUA/DmjvdsKRuegdfY/Pxv1YJjGkt22o5bC+8zQ3Lc3bLjFpmBKPY1B2sTKsN/fCW75mNEg/VU4R0EfX5EIJdJWTHFd/Iyf7E8jhhua5vwFn86kegMK24kNzUjpva2nuZ4j8ub1FfGaoADosAmlZlx0Z5yz9lYSTW UoHopjjO ExNGekr1J547C8p9ZdAvcyXiilI2O99hUSU6P20zXsQ8JwoHXCwyUpxGcQ4/Zc9hjg9PPfIB/zyxFZZ558t1/5U5gNcFli167HDsnBBEZQ+DOmwKV9cCI+8zvu/tqjM7eV9PCeICNDWJUri/ca7E3mPKyUdG2a3EX137lDtttzn5GOV0p34Oh3Tmb14rKTcu5ZTDVvVAv+kIcprbZh5wmbAezk50xzuFQw947PqfP/fJum8HC6whEBH+R8KBB6sbmeZBnU7WP4tUPjD+OFKdi8m1SFCi8r1W+a954XXtLWYITZwQDmFcVw7t7uOkcMbYROPWMiLgSBvPMESLqzITFqwWFTkOhb2CeS+cBsMnm0ZJLaYkRKjwwYdVERNbI6TdStaT8QPNYW9sf8RQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 10 Jun 2023 22:06:35 +0100 Lorenzo Stoakes wrote: > > > OK, as per the pedantic test bot, you'll need to change this to:- > > > > > > num = min_t(size_t, remains, PAGE_SIZE); PAGE_SIZE is a nuisance. It _usually_ creates the need for a cast: hp2:/usr/src/linux-6.4-rc4> grep -r "min(.*PAGE_SIZE" . | wc -l 117 hp2:/usr/src/linux-6.4-rc4> grep -r "min_t(.*PAGE_SIZE" . | wc -l 279 Perhaps it should always have been size_t. I suppose we could do #define PAGE_SIZE_T (size_t)PAGE_SIZE And use that where needed. Mainly because I like the name ;)