From: Andrew Morton <akpm@linux-foundation.org>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: David Laight <David.Laight@aculab.com>,
Lu Hongfei <luhongfei@vivo.com>,
Uladzislau Rezki <urezki@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
"open list:VMALLOC" <linux-mm@kvack.org>,
open list <linux-kernel@vger.kernel.org>,
"opensource.kernel@vivo.com" <opensource.kernel@vivo.com>
Subject: Re: [PATCH] mm/vmalloc: Replace the ternary conditional operator with min()
Date: Sat, 10 Jun 2023 15:08:09 -0700 [thread overview]
Message-ID: <20230610150809.babdc5a7919258f066c8637e@linux-foundation.org> (raw)
In-Reply-To: <ba45584f-41a2-4d06-8443-e7e64375b07f@lucifer.local>
On Sat, 10 Jun 2023 22:06:35 +0100 Lorenzo Stoakes <lstoakes@gmail.com> wrote:
> > > OK, as per the pedantic test bot, you'll need to change this to:-
> > >
> > > num = min_t(size_t, remains, PAGE_SIZE);
PAGE_SIZE is a nuisance. It _usually_ creates the need for a
cast:
hp2:/usr/src/linux-6.4-rc4> grep -r "min(.*PAGE_SIZE" . | wc -l
117
hp2:/usr/src/linux-6.4-rc4> grep -r "min_t(.*PAGE_SIZE" . | wc -l
279
Perhaps it should always have been size_t.
I suppose we could do
#define PAGE_SIZE_T (size_t)PAGE_SIZE
And use that where needed. Mainly because I like the name ;)
next prev parent reply other threads:[~2023-06-10 22:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 6:13 Lu Hongfei
2023-06-09 7:09 ` Lorenzo Stoakes
2023-06-09 8:48 ` Lorenzo Stoakes
2023-06-10 20:09 ` David Laight
2023-06-10 21:06 ` Lorenzo Stoakes
2023-06-10 22:08 ` Andrew Morton [this message]
2023-06-10 22:23 ` Lorenzo Stoakes
2023-06-10 22:29 ` David Laight
2023-06-10 22:18 ` David Laight
2023-06-10 22:35 ` Lorenzo Stoakes
2023-06-09 8:28 ` kernel test robot
2023-06-09 9:12 ` kernel test robot
2023-06-09 9:35 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230610150809.babdc5a7919258f066c8637e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=David.Laight@aculab.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=luhongfei@vivo.com \
--cc=opensource.kernel@vivo.com \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox