* [PATCH] memory tier: remove unneeded !IS_ENABLED(CONFIG_MIGRATION) check
@ 2023-06-10 3:41 Miaohe Lin
2023-06-12 9:15 ` David Hildenbrand
2023-06-12 21:57 ` Yang Shi
0 siblings, 2 replies; 3+ messages in thread
From: Miaohe Lin @ 2023-06-10 3:41 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, linmiaohe
establish_demotion_targets() is defined while CONFIG_MIGRATION is
enabled. There's no need to check it again.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/memory-tiers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
index dd04f0ce5277..a516e303e304 100644
--- a/mm/memory-tiers.c
+++ b/mm/memory-tiers.c
@@ -366,7 +366,7 @@ static void establish_demotion_targets(void)
lockdep_assert_held_once(&memory_tier_lock);
- if (!node_demotion || !IS_ENABLED(CONFIG_MIGRATION))
+ if (!node_demotion)
return;
disable_all_demotion_targets();
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] memory tier: remove unneeded !IS_ENABLED(CONFIG_MIGRATION) check
2023-06-10 3:41 [PATCH] memory tier: remove unneeded !IS_ENABLED(CONFIG_MIGRATION) check Miaohe Lin
@ 2023-06-12 9:15 ` David Hildenbrand
2023-06-12 21:57 ` Yang Shi
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2023-06-12 9:15 UTC (permalink / raw)
To: Miaohe Lin, akpm; +Cc: linux-mm, linux-kernel
On 10.06.23 05:41, Miaohe Lin wrote:
> establish_demotion_targets() is defined while CONFIG_MIGRATION is
> enabled. There's no need to check it again.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/memory-tiers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
> index dd04f0ce5277..a516e303e304 100644
> --- a/mm/memory-tiers.c
> +++ b/mm/memory-tiers.c
> @@ -366,7 +366,7 @@ static void establish_demotion_targets(void)
>
> lockdep_assert_held_once(&memory_tier_lock);
>
> - if (!node_demotion || !IS_ENABLED(CONFIG_MIGRATION))
> + if (!node_demotion)
> return;
>
> disable_all_demotion_targets();
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] memory tier: remove unneeded !IS_ENABLED(CONFIG_MIGRATION) check
2023-06-10 3:41 [PATCH] memory tier: remove unneeded !IS_ENABLED(CONFIG_MIGRATION) check Miaohe Lin
2023-06-12 9:15 ` David Hildenbrand
@ 2023-06-12 21:57 ` Yang Shi
1 sibling, 0 replies; 3+ messages in thread
From: Yang Shi @ 2023-06-12 21:57 UTC (permalink / raw)
To: Miaohe Lin; +Cc: akpm, linux-mm, linux-kernel
On Fri, Jun 9, 2023 at 8:41 PM Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> establish_demotion_targets() is defined while CONFIG_MIGRATION is
> enabled. There's no need to check it again.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Yang Shi <shy828301@gmail.com>
> ---
> mm/memory-tiers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
> index dd04f0ce5277..a516e303e304 100644
> --- a/mm/memory-tiers.c
> +++ b/mm/memory-tiers.c
> @@ -366,7 +366,7 @@ static void establish_demotion_targets(void)
>
> lockdep_assert_held_once(&memory_tier_lock);
>
> - if (!node_demotion || !IS_ENABLED(CONFIG_MIGRATION))
> + if (!node_demotion)
> return;
>
> disable_all_demotion_targets();
> --
> 2.27.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-12 21:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-10 3:41 [PATCH] memory tier: remove unneeded !IS_ENABLED(CONFIG_MIGRATION) check Miaohe Lin
2023-06-12 9:15 ` David Hildenbrand
2023-06-12 21:57 ` Yang Shi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox