From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47C29C7EE25 for ; Fri, 9 Jun 2023 19:16:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C499F6B0072; Fri, 9 Jun 2023 15:16:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF6966B0074; Fri, 9 Jun 2023 15:16:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A98028E0002; Fri, 9 Jun 2023 15:16:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 96BD46B0072 for ; Fri, 9 Jun 2023 15:16:28 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6D6171A0333 for ; Fri, 9 Jun 2023 19:16:28 +0000 (UTC) X-FDA: 80884165656.05.21535D6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id C1E4F40003 for ; Fri, 9 Jun 2023 19:16:26 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KF5au+Wf; spf=pass (imf01.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686338186; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wbr/1VDMLSumfwO/3/F8p72Z2ikSsrXCMvXPqgs42SA=; b=fJgLX42hwVR/to/I4sEOpTqI+BgAXI/qwuc2oHdTZk3yBamIstTrKvRWVIOPQuqf79e7Vo 2ScpQczOQC46ok7fM2GJEHc26hABJDyO88kIvmzGv9EvXw/jN1TPAMlcKzEJYEPI6dl2bu eLGdfA2SDJl3i/NbFdp2sQFI3w+Yayc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686338186; a=rsa-sha256; cv=none; b=zPjrSv4Pao/QnzIFWtmizY9jI6qqwn9Cm5ow3v4BqYpgRRkCVJ3k1nGCJneQ17HUGdJisS WnRXyeT3+PPev3z9QQdrdG34Zhkq9haOL0qVgr8GbjUz3PrGWnPmcnt8m+GAxE833+A+3E EU0FRAfkGghapjYVHbYxTR01NDSozAo= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KF5au+Wf; spf=pass (imf01.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AF5E065B43; Fri, 9 Jun 2023 19:16:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60A48C4339C; Fri, 9 Jun 2023 19:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686338185; bh=tJjWk6hGIUwDfmPq3y89WUdeFFNwy2a0cWqN5OR7kJ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KF5au+WfV0NuB0ror1osdkBAbZLKNTlIzfO7xdF9/kwLYpsNE6bOUjL7l4mW218XN Zswfyuk+qs/TjZiP60VijNjhYEQb3fvxWDeXRcmfeTizhr1nMK7uc4kGXMeveApGzU DaTl9qgAo/giDkLqZFy3Kwoh0oLKcXvsOGe9H6wBVmdyAvgdDeHEqTwJ1DoKUB3omv EfD04rIlueqhUKXR5cJFhOxX3v44n2ltyE02VWNXRKLAbQryQA5ntHT5YM1gN6JypB bVNXhWX34B7ujj5CH/cxteXyMcsiZ18cGgH8ZBt46a3Sw1/kY/GgPhkn5fv+mZ3Lxp fhCegvfX8DQJQ== From: SeongJae Park To: SeongJae Park Cc: akpm@linux-foundation.org, Anders Roxell , shuah@kernel.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Naresh Kamboju Subject: Re: [PATCHv2] selftests: damon: add config file Date: Fri, 9 Jun 2023 19:16:22 +0000 Message-Id: <20230609191622.80289-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230412165806.80672-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C1E4F40003 X-Rspam-User: X-Stat-Signature: 5xsjwxck45aonsgkd8bixygccmpphw57 X-Rspamd-Server: rspam03 X-HE-Tag: 1686338186-618883 X-HE-Meta: U2FsdGVkX18DSaZAqlvNvPbEQpH/W3/89/UPjAAaqwnQeRN4gqKgGpEBY8lWCB5hXwTeHszzHuKWvVrAs3TnuV3FpH5xauxcrlMWXd4orfnePToXtMsAINbiXMvLdw7UVg5H8bdnIrJK74SHeFel7Qrg/nHA2XGwm58b11YKdmscy2wnjsBiI5iXPF4CR2oBrbim6PJYL+DuGRUx//wOJQsC/fdfptkmGjoYFYvdMWwfWJKIBXyxxSVdfjMtgKrXzV8YrLDTA2hUj5eWvahRnhakaTsB1IEMv6s8WwW6u5MLYC/4YckTg6f2OmYZPBcANkhmAT51ChIjv29V9VU0dnL5HkvEaYpwyu+pFPd0sUJ+s3oQejI2XL97v9EJAxaQWfMgmJC7vgR1xYXK50TX7n7Gfgzo0CPx9JPo6ZCHhXfR0+lVgtMAHmmkpkBYk/13sz4f0bUrK7yZ3u7VmMb6y/C0dXhkeaSNKM82DqJa39d+zgUp3Nww6ISvNLcqMHqwkhD+5Y4b7rggELKIaq9aEYrU/wzW6+ErwJ+nFMKUKHx6zeW926HlGeiYtKhaDMDvmnnkNOp48MuyU3TpavKT2f4w6rLJFDwGVOo4rCurnO4zJu8vVNCOuw7/dA8EAOGlnGIwRIh693bo+2aIuoHzxh5JhQ3QpR0Pcheq5UwNaOlplpR3i0RXbL44rlqScDweJHSl3UnKd9rn1HDZHOjh4+EPhNA2w2eW1Y29kQNJhLjsjh2Fqh5JChj3aK2c05qYRTmq9Z/OBDfS7gBfkWe1818+G2lLpylIAvOHJr64I82M4xWKJnBKbLdG4fCJ5H2OtTcWe1TQ3xCqJIBnKTAseyq+z+7kF7tWuWuEfMXT69YNFj+qgm2WKX8ZF8jOEjYJeatO8DplqYxycA4Lr9nnqh2MqWEhj3mN09GRxozQ+0RQz3gAw3d4NiLvo9JbNxbw+CpHZ6sifhb8AMRmy5t R/o8mZOZ q8EbbDDgyHNMaX8NCZs+oz5+no3vanGc9eN9jVjEA2QQO4qzy/GZYysS1Gg3JWGZf4i8cNBznEv7NsUqcdCgDQZU6c7ZSuhODKxeUZqZQTjHq3rOlJICN1avSyJW/PNoT5YeIVHD8OJMXwWd3/rI4R6ih7x9/8NzPlzLKIKYtki3578t90n7ZicUBQtAHlc3uyZhvltB05TGzT3wNZ4IGdJA542keGMe5mBvS38roEdSuqXTZEGxwfvA3vs1y267FW0KLcaOKnFkMjNF68xsKNSUd9e28o6g2g9XafP8vjukoBePCuJ4XctFAhvHLFPAQkF50Oeu4kQEd4W19PoWHSIOzUk8WZwBg944fzB+hCD6MKdzs1kkgO7y/cNap9JiLjhc3KJ1X0Qe4lSUa3hxovxicuw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 12 Apr 2023 16:58:06 +0000 SeongJae Park wrote: > Hi Anders, > > On Wed, 12 Apr 2023 11:28:54 +0200 Anders Roxell wrote: > > > Building and running the subsuite 'damon' of kselftest, shows the > > following issues: > > selftests: damon: debugfs_attrs.sh > > /sys/kernel/debug/damon not found > > > > By creating a config file enabling DAMON fragments in the > > selftests/damon/ directory the tests pass. > > > > Fixes: b348eb7abd09 ("mm/damon: add user space selftests") > > Reported-by: Naresh Kamboju > > checkpatch.pl is warning as below: > > WARNING: Reported-by: should be immediately followed by Link: with a URL to the report > #20: > Reported-by: Naresh Kamboju > Signed-off-by: Anders Roxell > > The reason for the warning can be found from commit d7f1d71e5ef6 ("checkpatch: > warn when Reported-by: is not followed by Link:")'s commit message. Do you > have a link to put here? I guess the report was made inside Linaro, so might > have no publicly available link. Maybe better to add some notes or some funny > tag like "Link: N/A # no publicly-available link of the report" for convincing > the tool, but I don't think this should be a blocker for this patch. > > > Signed-off-by: Anders Roxell > > Reviewed-by: SeongJae Park Shuah, may I ask your opinion on this patch? I'm also cc-ing Andrew, as he may also interested in picking this patch. Thanks, SJ > > > Thanks, > SJ > > > --- > > tools/testing/selftests/damon/config | 7 +++++++ > > 1 file changed, 7 insertions(+) > > create mode 100644 tools/testing/selftests/damon/config > > > > diff --git a/tools/testing/selftests/damon/config b/tools/testing/selftests/damon/config > > new file mode 100644 > > index 000000000000..0daf38974eb0 > > --- /dev/null > > +++ b/tools/testing/selftests/damon/config > > @@ -0,0 +1,7 @@ > > +CONFIG_DAMON=y > > +CONFIG_DAMON_SYSFS=y > > +CONFIG_DAMON_DBGFS=y > > +CONFIG_DAMON_PADDR=y > > +CONFIG_DAMON_VADDR=y > > +CONFIG_DAMON_RECLAIM=y > > +CONFIG_DAMON_LRU_SORT=y > > -- > > 2.39.2 >