From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAF4BC7EE25 for ; Fri, 9 Jun 2023 09:36:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09CDA8E0003; Fri, 9 Jun 2023 05:36:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04C258E0001; Fri, 9 Jun 2023 05:36:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E083E8E0003; Fri, 9 Jun 2023 05:36:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CD5F58E0001 for ; Fri, 9 Jun 2023 05:36:08 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A5859A01A7 for ; Fri, 9 Jun 2023 09:36:08 +0000 (UTC) X-FDA: 80882703216.23.958B1D3 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf21.hostedemail.com (Postfix) with ESMTP id 406611C0018 for ; Fri, 9 Jun 2023 09:36:06 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=g3TW4bbe; spf=pass (imf21.hostedemail.com: domain of lkp@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686303366; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=foLON+9XaZ8XVd1R/2Fxu9lu/Modcqdacnj4FMQuCZ0=; b=URmyf9ICXWwyWcqZrALf8D1/aOzZCle2Fg74kmkG30KigASQ8sNtTG5Qkar/nXkd7qaL3D 6Gb2m5T0MmZ/Jguem9atL/a+iNwTsyD/K+r0GA9AUSQ2HROS6MZckAeAcC6GiuT8ZAxkgF ff58SvW3F25mBJnYlxvOjqNY7KeWDQ8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686303366; a=rsa-sha256; cv=none; b=WKDYxGEZ5jUeATMqW7jq+SBhKw2eqUHl7VmgLYRaeXC5sB+5fZIF6yL1ynJ0CELXWL+S2+ fl5os8gACp3tEs2eHmwvUmYx+7wJEJFUlVKSHrfYZjDEB9PODkfoMAzrXbwh1UE6x9RMY0 9618/qt/9oyXOQ0UzOcOtcD1HfiqhOg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=g3TW4bbe; spf=pass (imf21.hostedemail.com: domain of lkp@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686303366; x=1717839366; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=c2G/ZBWJ+bChfZroJsrTfZdBnqBEt1G0Os4orLnXNfg=; b=g3TW4bbe3px4rnthOGJl8+xbHPbQ/8Rm13IA+wqT93wu9JmSev6rkBFQ Njs5kJ/wvhFj8tgO+8Yr41Q8enudftejj+pAOR3sclV2osBx9Oz3w1i+X yoU6Yq8Zr2gYY3RQgmVeYYqk7XVaG6RFQiteknAP5MOuFBkJxm2ZvWTJR KHCL8P3Glxvr/z6g/iqJbDx/mmVYQGfqTPQszYRSGyKhhVD+a44lYsEMu MbX3HAI0zrV9tHH7mwBZ8r2u+obLnZ8ocNoZo/ylbgvfJNrKVVMdHEl3d yzbCiJ0SKWn8q60qEwbPBNfoL28ZwmwXwlGcApuA/aHd9ZoP9xZIkPPMn g==; X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="337919075" X-IronPort-AV: E=Sophos;i="6.00,228,1681196400"; d="scan'208";a="337919075" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2023 02:36:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="854687095" X-IronPort-AV: E=Sophos;i="6.00,228,1681196400"; d="scan'208";a="854687095" Received: from lkp-server01.sh.intel.com (HELO 15ab08e44a81) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 09 Jun 2023 02:36:02 -0700 Received: from kbuild by 15ab08e44a81 with local (Exim 4.96) (envelope-from ) id 1q7YXJ-0008tq-1w; Fri, 09 Jun 2023 09:36:01 +0000 Date: Fri, 9 Jun 2023 17:35:29 +0800 From: kernel test robot To: Lu Hongfei , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , open list Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , opensource.kernel@vivo.com, luhongfei@vivo.com Subject: Re: [PATCH] mm/vmalloc: Replace the ternary conditional operator with min() Message-ID: <202306091701.KHIG4Osf-lkp@intel.com> References: <20230609061309.42453-1-luhongfei@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230609061309.42453-1-luhongfei@vivo.com> X-Rspamd-Queue-Id: 406611C0018 X-Rspam-User: X-Stat-Signature: 3k4i4bg9u9cjkqs13urtw5mscqzquz69 X-Rspamd-Server: rspam03 X-HE-Tag: 1686303366-637101 X-HE-Meta: U2FsdGVkX1/tm1clFaAs5FdMHNvUoXHkPCCeYPxnj6VEh7r3njA9SiBCgW23sRd39HIiEBQPzqIbyj1AUc9XfpYBiugTWfTG7SGcMVEE5KprWpViibNBjWnS/NEdFaHdSkUQSzAV87sYaDcaaQm9aumNd+1RjsQO1PxO1aI3mGQi+A6syAmPmQVYUsPE1yG9EcoygW0CG7v6bxdIipgkXFZW/SgoXQ8ytRRubKzX9aQY1UF/LRCc7AGYMiZ2C3CQK+GP8mMLZI8Bl6c9D32LD6mdkq210RpriTAJwOHh283k0Q2eO9BuLpZobTyzq/DQXgbdThUiPeGU9c+VDZFKIqEmUxqNLIJNFKNvj6FObFfG5A+EzSbij1qzXDCMDlmwB/XKKA73BFJzp+qSYFO5vJ3nNgAQCjB8uqOpR2cyl/VqhnCKanvgO7vwGmgdyhATIcYi/0OUuJgeTaFFPa0XTH+Es+5rGvZjhG6hl5g5vHwiBGIPNB0kF/yOCHguC++Q3k8w0yD2frM2o857UDmrZ6OFZV+36H1PYoCfq9DTXjPnyLRe6zjDvzRPf0Oc0LGBFLLt6K6snilgYu1/2hAkbdZfmwdTJXvjjUTPVgW4s6ShSOnIKLixZffzVbNX0SnNEyG8iXXWgQEoR0FWBqSkMSQ8mqvXkea4nVktoMIjWXAd6ODZCI1EakAVF9OAr1mq5SZ/IQdUKpTCsKq5Ysj6D025jkKFV48RSICnS0OFB1YFtAl5orgoo29swNUHHHDF1jVDUFB/X7OXhUsX2BWvpzA3VZaZbZFOuIwZXTcjhsYsmscqgh3aVK8v+RjSi0tfag3GHFhvm6WWTTNi+I1IpA3HlW/CBdyQZ99SSOy126rxoUB+RSxf6WH1SANWXxHai4e7jiepfTjB9xJsLIB4GbHAmxK7Ls53CAwtA83rzb1XXpqLWd5EPZbPBr/8+NWibHTJg51D0oQadCn30AG YT23D6Td /sJbaD/eYiT0kk3xly6sSNrJno9FG2hegzxl+xxA89G/QhZws4Ty02ybml88rBb7lHDmNRIx31ZRk8y/Hu+FnY5edMZ/9tMBMhF2MWqIZfSNNO46WbMzjl84Kz8VOUby8qU9Gi+8pvdEEkwQCHmTfioNLj058G/1eW1eCl5cNKIFqEPCmA+DhjFAh2WQtRYw5ftZYQ9waol5tzzC6sGKccDxKss1PwUdDNW9RId874O5HQP72eDXJwH8Y9pt+JBkl46AW0lARuk6D8FCLvm0PCjPdwUucACYliGUiFrmvKL5m6lfFNjtcZyBHmvolBr7rZERnqNeqOXoThEBr+O5AMC7YWKgqQShRa9FVNGk2n4ZTYkfo1DjYObRGEYixqQUOqWmFdWxTnOBVGsRvgjrYLSXJBvQYFd9RiHSXrMaGqayfE9E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Lu, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Lu-Hongfei/mm-vmalloc-Replace-the-ternary-conditional-operator-with-min/20230609-141417 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230609061309.42453-1-luhongfei%40vivo.com patch subject: [PATCH] mm/vmalloc: Replace the ternary conditional operator with min() config: i386-randconfig-i011-20230608 (https://download.01.org/0day-ci/archive/20230609/202306091701.KHIG4Osf-lkp@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git remote add akpm-mm https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git git fetch akpm-mm mm-everything git checkout akpm-mm/mm-everything b4 shazam https://lore.kernel.org/r/20230609061309.42453-1-luhongfei@vivo.com # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=i386 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202306091701.KHIG4Osf-lkp@intel.com/ All warnings (new ones prefixed by >>): >> mm/vmalloc.c:3574:9: warning: comparison of distinct pointer types ('typeof (remains) *' (aka 'unsigned int *') and 'typeof (((1UL) << 12)) *' (aka 'unsigned long *')) [-Wcompare-distinct-pointer-types] num = min(remains, PAGE_SIZE); ^~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:67:19: note: expanded from macro 'min' #define min(x, y) __careful_cmp(x, y, <) ^~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:36:24: note: expanded from macro '__careful_cmp' __builtin_choose_expr(__safe_cmp(x, y), \ ^~~~~~~~~~~~~~~~ include/linux/minmax.h:26:4: note: expanded from macro '__safe_cmp' (__typecheck(x, y) && __no_side_effects(x, y)) ^~~~~~~~~~~~~~~~~ include/linux/minmax.h:20:28: note: expanded from macro '__typecheck' (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~ 1 warning generated. vim +3574 mm/vmalloc.c 3561 3562 /* 3563 * Atomically zero bytes in the iterator. 3564 * 3565 * Returns the number of zeroed bytes. 3566 */ 3567 static size_t zero_iter(struct iov_iter *iter, size_t count) 3568 { 3569 size_t remains = count; 3570 3571 while (remains > 0) { 3572 size_t num, copied; 3573 > 3574 num = min(remains, PAGE_SIZE); 3575 copied = copy_page_to_iter_nofault(ZERO_PAGE(0), 0, num, iter); 3576 remains -= copied; 3577 3578 if (copied < num) 3579 break; 3580 } 3581 3582 return count - remains; 3583 } 3584 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki