From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1478CC7EE25 for ; Fri, 9 Jun 2023 16:13:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E23D6B0072; Fri, 9 Jun 2023 12:13:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86B566B0074; Fri, 9 Jun 2023 12:13:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70D598E0002; Fri, 9 Jun 2023 12:13:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5E3D46B0072 for ; Fri, 9 Jun 2023 12:13:48 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2D3F9A01BC for ; Fri, 9 Jun 2023 16:13:48 +0000 (UTC) X-FDA: 80883705336.07.DD5A2EF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 5783D2001F for ; Fri, 9 Jun 2023 16:13:46 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Sg7lp6e/"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686327226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eWs6BV3xv1gKElShu2O5kqw5/VxozgUn579H4YHsbGM=; b=cE9QVBzs7vId27sq9N4LD2XmxqY6VkbnL/ZJNlmaR6wsE3sUdiqnE2BSwx1E1ZVukFwllY RwlQhsgVrnkebWpiViNK8d2uIxpbhrwON/Z7mgFBfxJp7TJlu+xzEjX3fYCqx8MtCVnJEi DiS7igSlfTmGwUArB6S2x8J+/w9C7IE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Sg7lp6e/"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686327226; a=rsa-sha256; cv=none; b=0JgjVIsmIT1L59bVjnX5n5MmXMN/t5JhZ2Subm6HAM2URqzimhE+35XBi/zklz2eVGpDHF OLtyryfooru2lvU808NE7fdRacu7yz6B9f+iOZWjs4AC0iUsRzu1j3AUdxSu05Ly6QASwu WHzE+2M4bptTs7H7mKGqGzANItYgRTw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 34341659A8; Fri, 9 Jun 2023 16:13:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D35ECC433EF; Fri, 9 Jun 2023 16:13:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686327224; bh=LhBOPmVWiuPUJIE5GrF/M4tdGkC4quufp7Koq2ZDGQI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Sg7lp6e/IiNPD5JZOY2U2ZfOH3jGxOK/5t1Fco/wfXnTnzJRbdGtIaN0kki2GKVag mYdVFhj91b2lEL9xr/NI8Bk6b7G2j3Pf3YjeSG1KkxytgyJmBCT/DuHNT4HuC38IN3 VJ5dIKqZ7IxAXqy63dTCTzwljHXhuej2nJiZhhRmYFJN9k/QpQmZFGlws6i9fBXBBD LPXYdoTJGCxa25JIKc/sZuGaTNssbzn8FPFJeMVWDCPJBU9OLKRBR+RmTTmk91BcVv ICp+DoN7JCyd9LxGtesYVwQxhUDvnN0uNv/3h1CJmaglmet4taUfTfA8b/jNAAT0tj Eo1HhC5I2OExg== Date: Fri, 9 Jun 2023 09:13:40 -0700 From: Nathan Chancellor To: Konrad Dybcio Cc: Peter Zijlstra , corbet@lwn.net, will@kernel.org, boqun.feng@gmail.com, mark.rutland@arm.com, catalin.marinas@arm.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, Arnd Bergmann , Herbert Xu , davem@davemloft.net, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Andrew Morton , vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-crypto@vger.kernel.org, sfr@canb.auug.org.au, mpe@ellerman.id.au, James.Bottomley@hansenpartnership.com, deller@gmx.de, linux-parisc@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v2 5/12] percpu: Add {raw,this}_cpu_try_cmpxchg() Message-ID: <20230609161340.GA4019185@dev-arch.thelio-3990X> References: <20230531132323.587480729@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5783D2001F X-Stat-Signature: 9dx91db8oww8ksdrkzmkp4uzu1gt69x9 X-Rspam-User: X-HE-Tag: 1686327226-26901 X-HE-Meta: U2FsdGVkX1/whL7P3Nmpx9TFSbxQyb2wTk5chlhO9afDHSy3EHESZMrFdFwRJ85cRcIlg6fw76DMa6F/qZSZnHMGaKbL3BlPcMa8vcLR8b6hiCyfoJS+8MwdnfynfheodVFEHyICX3P6od1w5t7vejBTCpxJMkPEtGl2+IO4As81clwgK6TYP30WI1iybLxFIZkNh6J8JgkHPPQhoWwMo+Xlm2QMRQtoDGgGhL7JfZ2J/YqWRy6A0jWqlkRsLUkm71li3eR88eCdxLayNuVc77wVtDnWBxApjsrLdsjlL88oLhbR23ix1uGl99rTomCjZbwSNWO1XL7kCGcF6YKptWeXpvWkGuAPQ97r+A4ADk1MC1cFJCE0LJHDEAIlNwjTlv6XJ9yb1Q1L69P/srMLomyJvFHzosZGvYc707cl8C0i3Im+1lB4kp2wRNQdlhFGNEtQI9Tih2b0cwkE2ezucWF3wGzTOjM885yGys/H2tXLw8+h0KWqNZv2b6CkFgnyInCOUxnHf8+5fa1MHuZj8d/vYBEGP3PpYWi35pvfnZLNEi7//FfFjPac5NE09aC+AO8Bkw/KlIQWpL4Vp4HbzTZKiBt7CGUcGG8CM4UGTPSK34gHjAuXN6Bv1cgfKnlNasA/MQ9UU0tbYjM1zEs01LGBrQ7haLxLdoFSDtD1/suVexnO3V9KYvcl+REOD2UH4lpiLAP6IvfMUgvL4ErIyH02SJYo4HJs7GBJ7b6Kb9mp4r/J2mEc8FS+eB4Go5/RbmBiIRyGxOtf/Jdpmjm6eN09QweZVPEsK9PuPjQnt9XumJwQLbGfBshPgyfXdV8s3jnfRzPlwH2caMPWEMGNcauGnOvKNwXX9xQt3P3NBB0TZOrY8OwEIvh+K9NZIaqVDeE7IoC/T1M8MbTHu2eOvj1WwSpG5/C1VLu11inHhOnE62dZn6dnLrZZzlUCXX87Zfzokn/AH2PCLptSEIq KIcj6dGo 4kEhlLqzK/F9pE/UurmixZAHz6p3bwj25r+7J417/p4FN82ACEBn+T0+1ftMkIpWmLHXDSa5sYXPJcbFVNkY+MFMMp0G5ortRliA1qtFXhxgetg96GpYRiQ7PN5Bhzp55U3TiPvxLZ1JVQLmJI7hG0G3w+RNAERp+EOPmM9WBwIJCBZec/Don49Q7C+YlKIllHe//lOm//34aig/dG2IA/C4lUug9qCV/hRpKPfJbFRYb5I/eWU532/c2kF1eh0p5mvJWU88PGHAwFlWtggnnEFD4y9DaSt4/XJqbgt1lTdJtp74naJXzKEHxwdHoH1dzbVa/ATG5Rpi6KA6KjcwaqCay2Gfei+ZvHhLIvk4ojXnazw7S9GFLqa7h3uGQgA6ItbhSMA4MoGZr82wJDHwY/SllajkA4s+hJTN0FylaoVtNYuiVkdkAClm7YkipeeNzM6Fz1csjC2Ngz4KDfTv0Dr+iRlxZmTMUZm7l6w1L5BdFs5wpl9Ltg+xoTfXBXgcGTSEeh0GwGVRTSCu7y8aoEtvFag== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Konrad, On Fri, Jun 09, 2023 at 06:10:38PM +0200, Konrad Dybcio wrote: > > > On 31.05.2023 15:08, Peter Zijlstra wrote: > > Add the try_cmpxchg() form to the per-cpu ops. > > > > Signed-off-by: Peter Zijlstra (Intel) > > --- > +CC Nathan, llvm list > > Hi all, this patch seems to break booting on Qualcomm ARM64 platforms > when compiled with clang (GCC works fine) for some reason..: > > next-20230605 - works > next-20230606 - doesn't > > grev -m 1 dc4e51fd9846 on next-20230606 - works again > b4 shazam -P 1-4 - still works > b4 shazam -P 5 - breaks > > Confirmed on at least Qualcomm QCM2290, SM8250. > > Checking the serial console, it hits a BUG_ON: > > [ 0.000000] ------------[ cut here ]------------ > [ 0.000000] kernel BUG at mm/vmalloc.c:1638! > [ 0.000000] Internal error: Oops - BUG: 00000000f2000800 [#1] SMP > [ 0.000000] Modules linked in: > [ 0.000000] CPU: 0 PID: 0 Comm: swapper/0 Not tainted [snip] > [ 0.000000] Hardware name: Qualcomm Technologies, Inc. Robotics RB1 (DT) > [ 0.000000] pstate: 000000c5 (nzcv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > [ 0.000000] pc : alloc_vmap_area+0xafc/0xb08 > [ 0.000000] lr : alloc_vmap_area+0x9e4/0xb08 > [ 0.000000] sp : ffffa50137f53c20 > [ 0.000000] x29: ffffa50137f53c60 x28: ffffa50137f30c18 x27: 0000000000000000 > [ 0.000000] x26: 0000000000007fff x25: ffff800080000000 x24: 000000000000cfff > [ 0.000000] x23: ffffffffffff8000 x22: ffffa50137fef970 x21: fffffbfff0000000 > [ 0.000000] x20: ffff022982003208 x19: ffff0229820031f8 x18: ffffa50137f64f70 > [ 0.000000] x17: ffffa50137fef980 x16: ffffa501375e6d08 x15: 0000000000000001 > [ 0.000000] x14: ffffa5013831e1a0 x13: ffffa50137f30c18 x12: 0000000000402dc2 > [ 0.000000] x11: 0000000000000000 x10: ffff022982003018 x9 : ffffa5013831e188 > [ 0.000000] x8 : ffffcb55ff003228 x7 : 0000000000000000 x6 : 0000000000000048 > [ 0.000000] x5 : 0000000000000000 x4 : ffffa50137f53bd0 x3 : ffffa50136490000 > [ 0.000000] x2 : 0000000000000001 x1 : ffffa5013831e190 x0 : ffff022982003208 > [ 0.000000] Call trace: > [ 0.000000] alloc_vmap_area+0xafc/0xb08 > [ 0.000000] __get_vm_area_node+0x108/0x1e8 > [ 0.000000] __vmalloc_node_range+0x1fc/0x728 > [ 0.000000] __vmalloc_node+0x5c/0x70 > [ 0.000000] init_IRQ+0x90/0x11c > [ 0.000000] start_kernel+0x1ac/0x3bc > [ 0.000000] __primary_switched+0xc4/0xcc > [ 0.000000] Code: f000e300 91062000 943bd9ba 17ffff8f (d4210000) > [ 0.000000] ---[ end trace 0000000000000000 ]--- > [ 0.000000] Kernel panic - not syncing: Attempted to kill the idle task! > > Compiled with clang 15.0.7 from Arch repos, with > make ARCH=arm64 LLVM=1 Thanks a lot for testing with LLVM, submitting this report, and doing a bisect. I sent a patch to fix this a couple of days ago and Peter pushed it to -tip today, so it should be in the next -next release: https://git.kernel.org/tip/093d9b240a1fa261ff8aeb7c7cc484dedacfda53 Cheers, Nathan