From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDFC0C7EE2E for ; Fri, 9 Jun 2023 08:12:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D5A28E0005; Fri, 9 Jun 2023 04:12:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6861C8E0003; Fri, 9 Jun 2023 04:12:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54EA88E0005; Fri, 9 Jun 2023 04:12:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 457D98E0003 for ; Fri, 9 Jun 2023 04:12:04 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1E9F440183 for ; Fri, 9 Jun 2023 08:12:03 +0000 (UTC) X-FDA: 80882491326.20.3472115 Received: from bee.tesarici.cz (bee.tesarici.cz [77.93.223.253]) by imf29.hostedemail.com (Postfix) with ESMTP id CC585120015 for ; Fri, 9 Jun 2023 08:12:00 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=tesarici.cz header.s=mail header.b=11LODvHI; spf=pass (imf29.hostedemail.com: domain of petr@tesarici.cz designates 77.93.223.253 as permitted sender) smtp.mailfrom=petr@tesarici.cz; dmarc=pass (policy=none) header.from=tesarici.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686298321; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ejkzhnFWXMXbS14iPK8cfSpBf5EsY3zs6OJeDkoa6cM=; b=BS2sBcRyksTSFlUUtgdcWIXHgmhXP3VwMjxvwDU1bJFBvYpJhEpg9k7vZuogRByrj/lwwG iY0UwV2obo14Hzh+Nu6QnNb/Z+u3ZB1BH+tCuXshwoii5x6iLLbVfhnqhuI+FsQvSJisfM ON0ioeTNm0c5bHCrO9aPu7x8W7O9vSs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686298321; a=rsa-sha256; cv=none; b=1b9gu9vvjL9+bcewMOJHI2ufJY1GZbQxSFWE94ov3Oj/j0LnVael3jKWts2xaueaJ+F/vX PV3EAKoJ4PL9IwYGwbFocbHWqnoGsHPxXiDQBfVHPPKr1J2P2RAycq4HzB+UvyfiE95ewE pXhdL1NUDAma3naVt0FBsNGJxhpTjjE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=tesarici.cz header.s=mail header.b=11LODvHI; spf=pass (imf29.hostedemail.com: domain of petr@tesarici.cz designates 77.93.223.253 as permitted sender) smtp.mailfrom=petr@tesarici.cz; dmarc=pass (policy=none) header.from=tesarici.cz Received: from meshulam.tesarici.cz (dynamic-2a00-1028-83b8-1e7a-4427-cc85-6706-c595.ipv6.o2.cz [IPv6:2a00:1028:83b8:1e7a:4427:cc85:6706:c595]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bee.tesarici.cz (Postfix) with ESMTPSA id C7DBB16965A; Fri, 9 Jun 2023 10:11:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tesarici.cz; s=mail; t=1686298317; bh=hZfrcwcxHoyRa5wqyYqCGUTJUrze6YAm/fimj/PnGkc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=11LODvHIZXX438UC905uhWdeYSYnSaBwWC1C3JeTEWrwMES7jzmGLA2yl6TLdyajR 1uEkwLsW3k6HHY7h8c4eUk7sJ69NGbp5vNT3Vl6N3ahZ0ms7VgpsaBGi2yci/o5N/8 LU3Tdh0TSdTic8Txb4Sdoq9uDFtUZ5d2x5XuQ6wBEaI21pKfONYDaoNZv2o7MlPDnr wHmx26NHQi18vxwwSis5VYN7bY1i20LdObSRRRNfab/BdF/hog0dOow5AgRPf71k/z rghGRLVjvTYvbn7Hh2BiyktIJFqH6DmX/Vvr5Sr9jbsNHc8WDug322OQXVv+m3nYc6 A3i4lL2SouHqw== Date: Fri, 9 Jun 2023 10:11:56 +0200 From: Petr =?UTF-8?B?VGVzYcWZw61r?= To: Isaac Manjarres Cc: Ard Biesheuvel , Catalin Marinas , Linus Torvalds , Christoph Hellwig , Robin Murphy , Arnd Bergmann , Greg Kroah-Hartman , Will Deacon , Marc Zyngier , Andrew Morton , Herbert Xu , Saravana Kannan , Alasdair Kergon , Daniel Vetter , Joerg Roedel , Mark Brown , Mike Snitzer , "Rafael J. Wysocki" , Jonathan Cameron , linux-mm@kvack.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, FUJITA Tomonori , Konrad Rzeszutek Wilk Subject: Re: [PATCH v6 00/17] mm, dma, arm64: Reduce ARCH_KMALLOC_MINALIGN to 8 Message-ID: <20230609101156.6f17e3c6@meshulam.tesarici.cz> In-Reply-To: References: <20230531154836.1366225-1-catalin.marinas@arm.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CC585120015 X-Rspam-User: X-Stat-Signature: pk1o8zfjztmzbqksu3361d9aoyn37f46 X-Rspamd-Server: rspam03 X-HE-Tag: 1686298320-864608 X-HE-Meta: U2FsdGVkX1+/AvaCl5oU55iaxzOpjou7FLqm+ZYXOvVvc2df+jqpelcEgFYS/wjqEAtTQVSbzaJ+AQwrwijPOad9ZNz9kWMn2wODgH7Ju6AhWhzyR5WAbYLoxOfVxy2O8cCYzVKwnqmlTgCEzMTVUo9cd08q9Na0khry0SoSXFL2LHk68WJrSU0gZtD4lfvswaULTNcW9cbyhhBRa0j2SvPUbkmbODwXU3h+bindZYvkwSDt1h0/yII1tNViYfXoxEWYMVGvH+bsOlt/5hIs5eplBvDlSo2K/rgPrxfB6Mw3ztGpI88R3tiLi5+YZ17r7Xsl74lBfERHh0Zp5Jvei9TVNSCk9OotF+PAhbKwA7Z69KDZS1XJ3BR5pDtIgha/g2PKdbfpmaywbdZFWodCVSiqfwbyYqzqFbcs6Qoci/TNC/TcsfcpSnZl6OpCyBsKpRsdQ9bLoQXnW0E+nP5HUcPP8tsL10VSi3DEImZ495AfHDsIb2w6jjSeQtdGqyrs/ZjlrCimAB2FchdgKrUIxXtXkgoIQ4/MsiXVx3CS3AeZZzR/NWMKdSxPvgoZ+9omgXHUBk2Y8QN38iLsSWMwTAJ1QuJtlhe2e4cWN35Y6kSxT9zoYokACAT/nBMlmdsKDAndvtHpT1WXE5sxAr9rS0iKzXn8ydkNNJQ/M32UdoXW+4WvnaHiks6zcuFA8bJ2Lu++bhdDV+z3oFH7ErV1LvqOhrfJYt8JANda+Crr7cCmBiCeWhk5Y38aDYgYodrb2imcXiJnzG29MYAzELCvtZygiQJGunQuavfhSIZN0FY1b3xKlADfOF/iq7boZzYyHiQLa2BoHmXoiVNJVv4jLQVDX9CwEUN2l6pcjowVWxH1bOuVYO5HlsacOICowL1fsYk39AHBk71HTgFZRcD446Gdts4LRXtjnI953WXaGDygPvojsiyVFst9bnUwZlgPK8U4ThyvTOKWExg8/3s avGmhwMv 8RbvociXV5dvNE6JXl6n14MdO7pp5XzpCYCx/4BXUe+DzIA7gFSSJ4Tv5gPeluurAPATrTK/1ZCI6YLYat3hca5k62Col41N9AMrHxkrxIX46bsRixqUjF158IZ2qs/Kjnv+jb/7yXyT+SGH1XxpqN+nCp46JH6BBMs5I83mhYgk0G0qXDGabt2LNNW5+Xadex20rKCZFEMJxDESk6otubd1fLaUEaANjstBm5gaYixqtFpApeRHvSpXL0BtA6ynIe9cra0NPsnop3JlynawUpVI/7uHGoTWzx8bA+hHc2doJHRuqGugL+xn/gSrj+gAXF1+WbkvItEUNnHE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 8 Jun 2023 14:29:45 -0700 Isaac Manjarres wrote: >[...] > P.S. I noticed that the trace_swiotlb_bounced() tracepoint may not be > invoked even though bouncing occurs. For example, in the dma-iommu path, > swiotlb_tbl_map_single() is called when bouncing, instead of > swiotlb_map(), which is what ends up calling trace_swiotlb_bounced(). > > Would it make sense to move the call to trace_swiotlb_bounced() to > swiotlb_tbl_map_single() since that function is always invoked? Definitely, if you ask me. I believe the change was merely forgotten in commit eb605a5754d0 ("swiotlb: add swiotlb_tbl_map_single library function"). Let me take the author into Cc. Plus Konrad, who built further on that commit, may also have an opinion. Petr T