linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Lu Hongfei <luhongfei@vivo.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Uladzislau Rezki <urezki@gmail.com>,
	Christoph Hellwig <hch@infradead.org>,
	Lorenzo Stoakes <lstoakes@gmail.com>,
	linux-mm@kvack.org (open list:VMALLOC),
	linux-kernel@vger.kernel.org (open list)
Cc: opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH] mm/vmalloc: Replace the ternary conditional operator with min()
Date: Fri,  9 Jun 2023 14:13:09 +0800	[thread overview]
Message-ID: <20230609061309.42453-1-luhongfei@vivo.com> (raw)

It would be better to replace the traditional ternary conditional
operator with min() in zero_iter

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 mm/vmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 29077d61ff81..42df032e6c27
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -3571,7 +3571,7 @@ static size_t zero_iter(struct iov_iter *iter, size_t count)
 	while (remains > 0) {
 		size_t num, copied;
 
-		num = remains < PAGE_SIZE ? remains : PAGE_SIZE;
+		num = min(remains, PAGE_SIZE);
 		copied = copy_page_to_iter_nofault(ZERO_PAGE(0), 0, num, iter);
 		remains -= copied;
 
-- 
2.39.0



             reply	other threads:[~2023-06-09  6:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09  6:13 Lu Hongfei [this message]
2023-06-09  7:09 ` Lorenzo Stoakes
2023-06-09  8:48   ` Lorenzo Stoakes
2023-06-10 20:09     ` David Laight
2023-06-10 21:06       ` Lorenzo Stoakes
2023-06-10 22:08         ` Andrew Morton
2023-06-10 22:23           ` Lorenzo Stoakes
2023-06-10 22:29           ` David Laight
2023-06-10 22:18         ` David Laight
2023-06-10 22:35           ` Lorenzo Stoakes
2023-06-09  8:28 ` kernel test robot
2023-06-09  9:12 ` kernel test robot
2023-06-09  9:35 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230609061309.42453-1-luhongfei@vivo.com \
    --to=luhongfei@vivo.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lstoakes@gmail.com \
    --cc=opensource.kernel@vivo.com \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox