From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A80AC7EE29 for ; Fri, 9 Jun 2023 01:33:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C6828E0002; Thu, 8 Jun 2023 21:33:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 177A68E0001; Thu, 8 Jun 2023 21:33:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03F1F8E0002; Thu, 8 Jun 2023 21:33:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EB0998E0001 for ; Thu, 8 Jun 2023 21:33:51 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C9A00803B1 for ; Fri, 9 Jun 2023 01:33:51 +0000 (UTC) X-FDA: 80881487862.02.44ADD3A Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by imf29.hostedemail.com (Postfix) with ESMTP id 0C696120010 for ; Fri, 9 Jun 2023 01:33:49 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=mzyv1nhS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.167.174 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686274430; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=054mTRUxEPdtrb7ivXoRErsU3vYGjbAVch0JPzI16Wk=; b=ljSh3u5k8LdxWy/hkfbKcJ6wPYcD5s/ttGSk2yUwdeuGdQy+nthqNejvluuxtMc0o74BQ1 FfSzmejo+FNoYOx+EMxYZ8+9LJNy9RHOfXTnB9U58zT8569EaYpXBOgYY/0W+RmAB1y5FD bbwe+JNMGJI6DQwv+EHyBhG09ea7XBg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=mzyv1nhS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.167.174 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686274430; a=rsa-sha256; cv=none; b=4adrcgzTj6wIai+IRCoa4gsOEOc6VVWMRglTMAkgoUQWVBJl0y/LJyOqHgIfwy+otOSvGW oT0hWPdxzenXjznOxYgr1gr0CwPR4hc2SMOky6cViMDS8UAXvzeWFnhY4k2w8l8ywl4wbg J0qaUx9H1OE6YPwvMM+r4nFVgqNMMS4= Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-39a3f26688bso225489b6e.2 for ; Thu, 08 Jun 2023 18:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686274429; x=1688866429; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=054mTRUxEPdtrb7ivXoRErsU3vYGjbAVch0JPzI16Wk=; b=mzyv1nhSqrQtWMqZ19Pfy7kurBOadwl8rtQunFwidyCXYv6u8yxOzuoszSWeRTY41P emftQ91W0R5azu4U5di8nXjR9q4wyR6lZwIL5ETJ2ZuFttgs2PCsN3Ta2Fr+behXZ/I0 zbAXi8+GTKq8MHROIs0qrna3vLTCLrUZiWavTasmVHKiiasrcB/jnyGCKYfDG8M6NJyv Et1hMRpKMB/RFn44WexRTr6foYRzN7tec51mgecJTQ6Fh6eF+IPnPvXc4sRiZPi15Cut yTYN8NiPej0aVRl/4IPFMbYKDTrE/Ao1jUks1TtguVr2uQhW5Ot3MIwZgua9aO8CL28T qW1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686274429; x=1688866429; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=054mTRUxEPdtrb7ivXoRErsU3vYGjbAVch0JPzI16Wk=; b=ZSMiY0xbhq2ShHN3Mg5ZbavM4K2CJNs6OlSvD8ErOBun/RlsO688Lg2Qqyj3rSrwaw rvUqcPmRoA7A344W8l2EOdCYCRw7aH7dj21j24oTEdeTHaz75U2u+CeCK8IqR9RUkzjK 4mjia6Dm2uzMxqr/UcfPZogb47YpHhftjvw4gJ9ymynhE6bgysieE9EdVvZ9pe3OuSnC PZQ28Sp7SjfU2O8AGRdpj5HPmZiOAg/P3eIP1cROAgbYRRpwJfhlMsyUAZdB/1RpCVQ9 J7RNuTqzee8Hgp26Hst9niB4ZKAfHkKH3UaQrOh2+O54CDpMG0P9l6qg3XjPcYyDZc06 KvFw== X-Gm-Message-State: AC+VfDzqEz8GA292CI3sCGvkQ+sf0sEkrEzaDSINWl/sd5M1ewg398q0 8lKItMOtSNWjygZ7g+z8cro= X-Google-Smtp-Source: ACHHUZ5HjoLrjpzTTjoUo+3fEZdjMy55PDi3hyeMLhgBjbcTJJ3AEeKwuelkaJ7qFQypVgd48ix28w== X-Received: by 2002:a05:6808:21a4:b0:398:36ac:44f1 with SMTP id be36-20020a05680821a400b0039836ac44f1mr269529oib.7.1686274428982; Thu, 08 Jun 2023 18:33:48 -0700 (PDT) Received: from localhost ([192.55.54.50]) by smtp.gmail.com with ESMTPSA id g16-20020a17090a7d1000b00259e553f59bsm2052031pjl.20.2023.06.08.18.33.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 18:33:48 -0700 (PDT) Date: Thu, 8 Jun 2023 18:33:46 -0700 From: Isaku Yamahata To: "kirill.shutemov@linux.intel.com" Cc: Isaku Yamahata , "Huang, Kai" , "kvm@vger.kernel.org" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "Luck, Tony" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" Subject: Re: [PATCH v11 08/20] x86/virt/tdx: Get information about TDX module and TDX-capable memory Message-ID: <20230609013346.GN2244082@ls.amr.corp.intel.com> References: <50386eddbb8046b0b222d385e56e8115ed566526.1685887183.git.kai.huang@intel.com> <20230608002725.xc25dantcwdxsuil@box.shutemov.name> <19ea7470e9d6fa698f9ad7caff3279873e530a0b.camel@intel.com> <20230608114128.vu75wlcojpyjak22@box.shutemov.name> <20230608232919.GM2244082@ls.amr.corp.intel.com> <20230608235441.olqpkrwzu2hplepa@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230608235441.olqpkrwzu2hplepa@box.shutemov.name> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0C696120010 X-Stat-Signature: qj8hsfcewd8teo6ya8bhm7dq99afni3s X-Rspam-User: X-HE-Tag: 1686274429-17057 X-HE-Meta: U2FsdGVkX18s3lL4eQcAUkGygv6kwzU9B+qG2xyXMvjFECd2pAGJ+s3Z4CFXKehSjPz4SrvP9ZHPyTwFD82T/2atot1e1lCDjSip1Tus0vgUrEQzg+lRLi4vSbLkn93QB4O/DGNyJOnlnNpgj0FILMpxESyBmRtpWiTClBpm/qWwZ+c1Fy7snk08043FBhRXpYr+NHaZXdnyV+TLocdGtkoN0boV4iIAwf2Aj157Bgax3OLe9+X7aKCG19WG2qYvO0rlPRePbjn3Dci5LUijO1nCRm6YdYiZbwgJa83dyMgnTOvf2wcbPnYIbRTjkVNCMr6RUtkz9cvn2/w0C3K6KhFDGzv8SW1+eFyKqhHg+N4cgm3SEAFw6MJQ2mff07Kx6yXSXPNhEAPdc3tIY3uZQ9mEQfDfColSne2M9cxDwjiaEKnK8ZxBrm0NacM3J6EuJGwHweliif6wz7HED71dpBaptMBd78VYXNd6CTPpeaBB/StJRsJbjN1yGVZ+N4KG92CavniEcTD8/G9w1yci/yCDlT+jFUuwu6x7EBxQaxkhSNbpzbE7T6xfOWopfl28X3OUDQT3dNXDhaXPxCB/s67HY4tGLRHdyZkxfMboW3gzy2tK5zBKOUQ/gtdGGlEu/ibQE70CEFN7bFZpcip4LDainJrYMLq4qgBObkALw7Zbj7K5j2V1o97TCdEUitnHBLYmbTtBD3oOEHuvUYVGZTC0oAAkK+b2koly7PmPpdlmjS6egApXks9iXetx0Xa6gGiQ6f27DSJ/IeqXCsxrpyqXchOcU7iZHUXGc847MH5AMa3UTDf5uRxcrpnL4kEaYPSgny06tFr6KUpCNL5Lmq1iy/WzR1tBlIqB1byviiPqHjh34gyWfdBThrTuYFwcD2xueJBc88m01svZf0mFL11UEU/9eYEgSdYIZD3p5e9me319mOuC2Z0fg99wMJW0dEL/h/+/GrVc1sNupc8 8oK3ITtC DxDjogrihVb0WFmhKxn8dvpjeMIYPoN6rsnE2qoa+PXVewo6u4pGwXh5i48m71q43mzL0f5meKQG9Y1t4HC+vniSCVrVR2Sg0rd9pBjqFSn8x7cw5DwcEv+gpsewWXDjoDiQ20FQY1dfJUVeDBnUl+J7pHcdVy9XikYYcRhfeufWEOe65+bZ7QVIGTDke8zCWhfDtYfJ74cjgP0O1HoITJegQqzoa0Z5dTKURydsg7UUQkr3qHQ9KkJGvkjD7gZ/vmKUHVUhcPwv8IPGvG2DIIuVpNc4JoXoZLnwGm6OAflsfUG4qTOt2v3YHidUfO4Qi5Z59NpuMJ+0VvaP4OqsjwsWuMSQgwXR58D+b6tIx3GVYqPHNufVZGieW1TNPHwZM21U1ctUhOJ3InLaltS7tIIXPywBUd/fogjP+rzrC27ta+huYkIvGIrtt37Y3zHJs9f/ZsjU4fGZqW/7NfdpQlg8Q3lEghXASgbXNCB+kcE3ar5asoE67G6CaOEpy0vChYbxVEtoo96pIuRXfrnjZkts9ivVTizuze5njVYH3AP2oe8OtQ5ycR9mYLHsvKNuxBkLP7U7ffqqEHnE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 09, 2023 at 02:54:41AM +0300, "kirill.shutemov@linux.intel.com" wrote: > On Thu, Jun 08, 2023 at 04:29:19PM -0700, Isaku Yamahata wrote: > > On Thu, Jun 08, 2023 at 02:41:28PM +0300, > > "kirill.shutemov@linux.intel.com" wrote: > > > > > On Thu, Jun 08, 2023 at 02:40:27AM +0000, Huang, Kai wrote: > > > > On Thu, 2023-06-08 at 03:27 +0300, kirill.shutemov@linux.intel.com wrote: > > > > > On Mon, Jun 05, 2023 at 02:27:21AM +1200, Kai Huang wrote: > > > > > > For now both 'tdsysinfo_struct' and CMRs are only used during the module > > > > > > initialization. But because they are both relatively big, declare them > > > > > > inside the module initialization function but as static variables. > > > > > > > > > > This justification does not make sense to me. static variables will not be > > > > > freed after function returned. They will still consume memory. > > > > > > > > > > I think you need to allocate/free memory dynamically, if they are too big > > > > > for stack. > > > > > > > > > > > > I do need to keep tdsysinfo_struct as it will be used by KVM too. > > > > > > Will you pass it down to KVM from this function? Will KVM use the struct > > > after the function returns? > > > > KVM needs tdsysinfo_struct to create guest TD. It doesn't require > > 1024-alignment. > > How KVM gets it from here? For now, TDX KVM patch series moves the tdsysinfo out of the function, and add a getter function of it. As long as KVM can access the info, it doesn't care how its memory is allocated. static or dynamic. -- Isaku Yamahata