From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2374CC7EE29 for ; Thu, 8 Jun 2023 23:54:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFF1B6B0072; Thu, 8 Jun 2023 19:54:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BAF168E0001; Thu, 8 Jun 2023 19:54:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A78E26B0075; Thu, 8 Jun 2023 19:54:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 952F96B0072 for ; Thu, 8 Jun 2023 19:54:53 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 390D01C7711 for ; Thu, 8 Jun 2023 23:54:53 +0000 (UTC) X-FDA: 80881238466.08.CA18F24 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf28.hostedemail.com (Postfix) with ESMTP id 0BBA2C0011 for ; Thu, 8 Jun 2023 23:54:50 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gEm84hnm; spf=none (imf28.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686268491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Eq8G+xZR1ImmdIpIT4s1NfB9cgbIBSLtt3M41S1Rnbc=; b=kt3fA0+Xt8tpLE8kN3+9XEu2kEtO3NBhdaTZT/YMIBCyG0Qc5S26SBAqpsBB+BRQvjMJ/E STtck8CxVXAI1g4dOCq1Tj+z4/fssbnrvKDbSh+9xGCx2zqg8k0Rj5D8eG2kz4DeK2MFjo 4d4PlCn+tDD/dybd2QysVRhKFB7hVjs= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gEm84hnm; spf=none (imf28.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686268491; a=rsa-sha256; cv=none; b=FmEIvB08UmAyHgIHOcO2ETiZyFzTo8YP8hICcSvhHAd9izp4M7NkTxZzxtkE6gR+K9p/l/ X8r6m/mDPPXrDPfsMCqjJPQthCiQfTEvPBZDJ7zEuUJ4yFCN9Jm7ATBP8JXYn3CnKlA76U sjvSiC0GRSVIsCImkEtAjS9Xc+e8/Lg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686268491; x=1717804491; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xZ1uRwDFiJo+JxOT813efewCSGKFi1vucjFu1ekbu3w=; b=gEm84hnme8KOAAZouO1kpuoFd5jZMQUvu9sFwjUDXW8RqgfHyXsBpKYa HGTW/XMf2nxfzlT6XqADUYwyhbSOxWPZpV3yA6l69kGspO8V06VqvqWlV JQF7oUVO/OyItbdLQkeJNlGJJAyROXduETLxGs9q3kmFFWi6wktErINwh Ex3XeFs+Ogfr28VQG0qn4wle3Dr4akQXb1ibKy0CBEHY8DZ9/HTlgMPYJ Ks+Kerpi3J+7MdRurL270hFmOGkcRMcJWT6UEjOR72ERhUlX0AuayMsOB HEvIrgzIJqdadp0Q67x8E7j8z1gJCZc4xm81kbcgKRpVWFHKylkSy8V88 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="421055482" X-IronPort-AV: E=Sophos;i="6.00,228,1681196400"; d="scan'208";a="421055482" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2023 16:54:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="775286493" X-IronPort-AV: E=Sophos;i="6.00,228,1681196400"; d="scan'208";a="775286493" Received: from fgorter-mobl.ger.corp.intel.com (HELO box.shutemov.name) ([10.252.59.89]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2023 16:54:43 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id 659D6104C0F; Fri, 9 Jun 2023 02:54:41 +0300 (+03) Date: Fri, 9 Jun 2023 02:54:41 +0300 From: "kirill.shutemov@linux.intel.com" To: Isaku Yamahata Cc: "Huang, Kai" , "kvm@vger.kernel.org" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "Luck, Tony" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" Subject: Re: [PATCH v11 08/20] x86/virt/tdx: Get information about TDX module and TDX-capable memory Message-ID: <20230608235441.olqpkrwzu2hplepa@box.shutemov.name> References: <50386eddbb8046b0b222d385e56e8115ed566526.1685887183.git.kai.huang@intel.com> <20230608002725.xc25dantcwdxsuil@box.shutemov.name> <19ea7470e9d6fa698f9ad7caff3279873e530a0b.camel@intel.com> <20230608114128.vu75wlcojpyjak22@box.shutemov.name> <20230608232919.GM2244082@ls.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230608232919.GM2244082@ls.amr.corp.intel.com> X-Rspamd-Queue-Id: 0BBA2C0011 X-Rspam-User: X-Stat-Signature: uzfuhqfeg9yeni3bjarm4n4dusw5wb7m X-Rspamd-Server: rspam01 X-HE-Tag: 1686268490-278106 X-HE-Meta: U2FsdGVkX1960VHqOWiMSZ6C31OvOZhM35Mzw7vsOUw8eglDwEDALhjRji1RTZM3uP+SRdUZBqyt3E3ZZrE+6JBSO4azPPEnUwnIwh/IxI4ksZCipzlR398PQiM6EW4yg9hwXRFIBW4okHHEHqPLM67l39uOpg+shRup+aY5L39ehn7MRpR0HzuBF4NK+r0+a5tthUNjFEpIUsepOXqk2ROnSTFTPJPlHp3cJB0pp9jc6/Tr2Ft1xWvf8zK8jMLJpbI5mhMVazrS+EVuU5r9BhgtSHvR/1TFt7Fm0frEuv5qrcT1DrH5jmh5wryt4C/1O+3Ys8YXHfo0eWBpUi+5iTFi88WVBXmer4SgwwzPhxVvb44tM0HU/kaoq3bR/sfeOKl0cus8qGM0e7hvFNF7Q5BpDMYt+Ypf84+1sCfzTUZtYoMKul2N/kUsQXDXYkRjr/F5oBtxOge+3EhY5qIa1VQ/roL787bWm56Rcdc40ZeXK6/Ksp0Yj4aTcjPCftIPa5dPmbOBS4+EoXpZ9Hu1ZnWZcgRoS4owrBVLvRd4RlLWDLb4pvDVlEeb011+pNAyCI0zisNg6G7nJqqGNXcZAQoSFVpEisWOlBkE/ma6mEV3xoz4XsX8I2ZtI8ArNC/Hxh9rO6ebNegYwAPYKe9q1UHdXCzIGCNhDyDP0Zw0I82Qd+mTX/oojlKpxCabMWf6ZOBRb1erwnw/FjoT4pxhQbV2D9l6CWsEA9jw4o6CPXX+8wVHQ/vZzgOv38TXpnKfcIPRnZrvgzOcS/9/KWOw4OjgnMl/5POgi9Y6vjbcIBXSYtp0IiZkFGlALCAPr7igoQfheSioIJ+vFwYyUfnAp68WL+gxbAseXfz3fOQYUy/OdBuqyDSb1VbWD9U0gKpzlJ9RuQ1+hWJZCC4yycPpMlR300onVG60wRNDB7zzTT7GNNC0Adwhjz5iesO9NzkmQJYbDjSAUSj2XvZ96wy b40vNdh2 naxUEKyhAPH5sKH4mOY5C5G+jPT7NTpu50grwhZKVFC//Ur5AMsP9sdj1mNNcDBp3tDz79+03W1grq+3aVQKDPrUkWTSxUqNnam/4BPOfmqeHrgEFjwP1/8YfyKlQk0WCPOqvM4yPkLicopasuBQ7YSgFkEkU/eJvAmy09raewElAV/E15Lg2u0nOmD5s0/3BxB53dZlnbVJm4RRn5zqlD5tWsZrDhTOefzLnhBiM8QQAX91q6nc0mVe5oBObisau88uZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 08, 2023 at 04:29:19PM -0700, Isaku Yamahata wrote: > On Thu, Jun 08, 2023 at 02:41:28PM +0300, > "kirill.shutemov@linux.intel.com" wrote: > > > On Thu, Jun 08, 2023 at 02:40:27AM +0000, Huang, Kai wrote: > > > On Thu, 2023-06-08 at 03:27 +0300, kirill.shutemov@linux.intel.com wrote: > > > > On Mon, Jun 05, 2023 at 02:27:21AM +1200, Kai Huang wrote: > > > > > For now both 'tdsysinfo_struct' and CMRs are only used during the module > > > > > initialization. But because they are both relatively big, declare them > > > > > inside the module initialization function but as static variables. > > > > > > > > This justification does not make sense to me. static variables will not be > > > > freed after function returned. They will still consume memory. > > > > > > > > I think you need to allocate/free memory dynamically, if they are too big > > > > for stack. > > > > > > > > > I do need to keep tdsysinfo_struct as it will be used by KVM too. > > > > Will you pass it down to KVM from this function? Will KVM use the struct > > after the function returns? > > KVM needs tdsysinfo_struct to create guest TD. It doesn't require > 1024-alignment. How KVM gets it from here? -- Kiryl Shutsemau / Kirill A. Shutemov